Re: [PATCH] media: rkvdec: silence ktest bot build warning

2021-01-07 Thread Boris Brezillon
; > vim +/of_rkvdec_match +967 drivers/staging/media/rkvdec/rkvdec.c > > > >966 > > > 967 static const struct of_device_id of_rkvdec_match[] = { > >968 { .compatible = "rockchip,rk3399-vdec" }, > >969

Re: [PATCH] mtd: rawnand: driver for Mediatek MT7621 SoC NAND flash controller

2019-11-10 Thread Boris Brezillon
On Sun, 10 Nov 2019 12:39:19 +0100 Boris Brezillon wrote: > On Thu, 7 Nov 2019 09:40:07 +0100 > Greg KH wrote: > > > On Thu, Nov 07, 2019 at 05:35:21PM +1000, g...@kernel.org wrote: > > > From: Greg Ungerer > > > > > > Add a driver to support

Re: [PATCH] mtd: rawnand: driver for Mediatek MT7621 SoC NAND flash controller

2019-11-10 Thread Boris Brezillon
On Thu, 7 Nov 2019 09:40:07 +0100 Greg KH wrote: > On Thu, Nov 07, 2019 at 05:35:21PM +1000, g...@kernel.org wrote: > > From: Greg Ungerer > > > > Add a driver to support the NAND flash controller of the MediaTek MT7621 > > System-on-Chip device. (This one is the MIPS based parts from Mediatek)

Re: [PATCH] mtd: rawnand: driver for Mediatek MT7621 SoC NAND flash controller

2019-11-10 Thread Boris Brezillon
+Richard and Miquel On Thu, 07 Nov 2019 09:20:53 + René van Dorst wrote: > Quoting g...@kernel.org: > > > From: Greg Ungerer > > > > Add a driver to support the NAND flash controller of the MediaTek MT7621 > > System-on-Chip device. (This one is the MIPS based parts from Mediatek). > > > >

Re: [PATCH 5/8] media: cedrus: Detect first slice of a frame

2019-08-29 Thread Boris Brezillon
On Thu, 29 Aug 2019 21:04:28 +0200 Jernej Škrabec wrote: > Dne ponedeljek, 26. avgust 2019 ob 20:28:31 CEST je Boris Brezillon > napisal(a): > > Hi Jernej, > > > > On Thu, 22 Aug 2019 21:44:57 +0200 > > > > Jernej Skrabec wrote: > > > When cod

Re: [PATCH 8/8] media: cedrus: Add support for V4L2_DEC_CMD_FLUSH

2019-08-26 Thread Boris Brezillon
On Thu, 22 Aug 2019 21:45:00 +0200 Jernej Skrabec wrote: > This command is useful for explicitly flushing last decoded frame. > > Signed-off-by: Jernej Skrabec Reviewed-by: Boris Brezillon > --- > .../staging/media/sunxi/cedrus/cedrus_video.c | 34 +++ >

Re: [PATCH 7/8] media: cedrus: Add support for holding capture buffer

2019-08-26 Thread Boris Brezillon
iver by exposing and implementing > V4L2_BUF_CAP_SUPPORTS_M2M_HOLD_CAPTURE_BUF capability. > > Signed-off-by: Jernej Skrabec Reviewed-by: Boris Brezillon > --- > drivers/staging/media/sunxi/cedrus/cedrus_dec.c | 9 + > drivers/staging/media/sunxi/cedrus/cedrus_hw.c| 8 +

Re: [PATCH 2/8] videodev2.h: add V4L2_DEC_CMD_FLUSH

2019-08-26 Thread Boris Brezillon
On Thu, 22 Aug 2019 21:44:54 +0200 Jernej Skrabec wrote: > From: Hans Verkuil > > Add this new V4L2_DEC_CMD_FLUSH decoder command and document it. > > Signed-off-by: Hans Verkuil > Signed-off-by: Jernej Skrabec Reviewed-by: Boris Brezillon > --- > Documentati

Re: [PATCH 5/8] media: cedrus: Detect first slice of a frame

2019-08-26 Thread Boris Brezillon
Hi Jernej, On Thu, 22 Aug 2019 21:44:57 +0200 Jernej Skrabec wrote: > When codec supports multiple slices in one frame, VPU has to know when > first slice of each frame is being processed, presumably to correctly > clear/set data in auxiliary buffers. > > Add first_slice field to cedrus_run str

Re: [PATCH] staging: media: hantro: Remove call to memset after dma_alloc_coherent

2019-07-25 Thread Boris Brezillon
ed-off-by: Hariprasad Kelam Reviewed-by: Boris Brezillon > --- > drivers/staging/media/hantro/hantro_vp8.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/media/hantro/hantro_vp8.c > b/drivers/staging/media/hantro/hantro_vp8.c > index 66c4533..36

[PATCH] staging: Remove the mt29f_spinand driver

2018-10-22 Thread Boris Brezillon
A new SPI NAND subsystem has been added in drivers/mtd/nand/spi/ and Micron's MT29F devices are now supported in drivers/mtd/nand/spi/micron.c. Remove the old driver. Signed-off-by: Boris Brezillon --- Hello, If anything is missing in drivers/mtd/nand/spi/micron.c to properly suppor

Re: [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch)

2018-09-17 Thread Boris Brezillon
On Sat, 15 Sep 2018 19:54:40 +0200 Miquel Raynal wrote: > Hi Boris, > > Boris Brezillon wrote on Fri, 7 Sep 2018 > 00:38:32 +0200: > > > Hello, > > > > This is the 2nd batch of API cleanup patches. This time we move > > deprecated hooks/fields to the

Re: [PATCH 19/19] mtd: rawnand: Move JEDEC code to nand_jedec.c

2018-09-07 Thread Boris Brezillon
On Fri, 7 Sep 2018 10:40:44 +0200 Ladislav Michl wrote: > Hi Boris, > > this patchseries is really amazing clean up. Thank you! I'm glad I'm not the only one to find it useful :-). > > On Fri, Sep 07, 2018 at 12:38:51AM +0200, Boris Brezillon wrote: > >

[PATCH 19/19] mtd: rawnand: Move JEDEC code to nand_jedec.c

2018-09-06 Thread Boris Brezillon
This moves ONFI related code to nand_onfi.c and ONFI related struct/macros to include/linux/mtd/onfi.h. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/Makefile | 1 + drivers/mtd/nand/raw/internals.h | 3 + drivers/mtd/nand/raw/nand_base.c | 98

[PATCH 14/19] mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.h

2018-09-06 Thread Boris Brezillon
platform_nand_xxx definitions are just used by the plat_nand driver. Let's move those definitions out of the core/driver-agnostic rawnand.h header. Signed-off-by: Boris Brezillon --- arch/arm/mach-ep93xx/snappercl15.c | 3 +- arch/arm/mach-ep93xx/ts72xx.c | 3 +- arch/arm

[PATCH 18/19] mtd: rawnand: Move ONFI code to nand_onfi.c

2018-09-06 Thread Boris Brezillon
This moves ONFI related code to nand_onfi.c and ONFI related struct/macros to include/linux/mtd/onfi.h. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/Makefile| 1 + drivers/mtd/nand/raw/internals.h | 7 + drivers/mtd/nand/raw/nand_base.c | 296

[PATCH 13/19] mtd: rawnand: Get rid of a few unused definitions

2018-09-06 Thread Boris Brezillon
Those definitions are not used, let's remove them. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/nand_timings.c | 14 -- include/linux/mtd/rawnand.h | 8 2 files changed, 22 deletions(-) diff --git a/drivers/mtd/nand/raw/nand_timings.c b/driver

[PATCH 03/19] mtd: rawnand: Deprecate ->{read, write}_{byte, buf}() hooks

2018-09-06 Thread Boris Brezillon
All those hooks have been replaced by ->exec_op(). Move them to the nand_legacy struct. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/ams-delta.c | 6 +-- drivers/mtd/nand/raw/atmel/nand-controller.c | 8 ++-- drivers/mtd/nand/raw/au1550nd.c |

[PATCH 09/19] mtd: rawnand: Deprecate ->chip_delay

2018-09-06 Thread Boris Brezillon
The wait timeouts and delays are directly extracted from the NAND timings and ->chip_delay is only used in legacy path, so let's move it to the nand_legacy struct to make it clear. Signed-off-by: Boris Brezillon --- Documentation/driver-api/mtdnand.rst | 2 +- drivers/mtd/

[PATCH 10/19] mtd: rawnand: Move function prototypes after struct declarations

2018-09-06 Thread Boris Brezillon
Move nand_scan[_with_ids]() and nand_wait_ready() at the end of the file where all function prototype lies. This will also allow us to get rid of the nand_flash_dev forward declaration. Signed-off-by: Boris Brezillon --- include/linux/mtd/rawnand.h | 24 1 file changed

[PATCH 05/19] mtd: rawnand: Deprecate ->dev_ready() and ->waitfunc()

2018-09-06 Thread Boris Brezillon
Those hooks have been replaced by ->exec_op(). Move them to the nand_legacy struct. Signed-off-by: Boris Brezillon --- Documentation/driver-api/mtdnand.rst | 4 +-- drivers/mtd/nand/raw/ams-delta.c | 4 +-- drivers/mtd/nand/raw/atmel/nand-controller.c |

[PATCH 07/19] mtd: rawnand: Deprecate ->erase()

2018-09-06 Thread Boris Brezillon
we should discourage people from overloading this method and encourage them to implement ->exec_op() instead. Move the ->erase() hook to the nand_legacy struct to make it clear. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/denali.c| 2 +- drivers/mtd/nand/raw/nand_b

[PATCH 15/19] mtd: rawnand: Inline onfi_get_async_timing_mode()

2018-09-06 Thread Boris Brezillon
onfi_get_async_timing_mode() is only used in one place inside nand_base.c. Let's inline the code and kill the helper. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/nand_base.c | 5 +++-- include/linux/mtd/rawnand.h | 9 - 2 files changed, 3 insertions(+), 11 dele

[PATCH 06/19] mtd: rawnand: Deprecate ->block_{bad,markbad}() hooks

2018-09-06 Thread Boris Brezillon
discourage people from overloading those methods and encourage them to fix their driver instead. Move the ->block_{bad,markbad}() hooks to the nand_legacy struct to make it clear. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/cafe_nand.c | 2 +- drivers/mtd/nand/

[PATCH 02/19] mtd: rawnand: Create a legacy struct and move ->IO_ADDR_{R, W} there

2018-09-06 Thread Boris Brezillon
umented as deprecated. We start with the ->IO_ADDR_{R,W] fields. Signed-off-by: Boris Brezillon --- Documentation/driver-api/mtdnand.rst | 24 arch/arm/mach-ep93xx/snappercl15.c | 5 +++-- arch/arm/mach-ep93xx/ts72xx.c| 6 +++--- arch/arm/mach-imx/mach-qong.

[PATCH 08/19] mtd: rawnand: Deprecate ->{set,get}_features() hooks

2018-09-06 Thread Boris Brezillon
Those hooks should be replaced by a proper ->exec_op() implementation. Move them to the nand_legacy struct to make it clear. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 4 +- drivers/mtd/nand/raw/cafe_nand.c | 4 +- drivers/mtd/n

[PATCH 04/19] mtd: rawnand: Deprecate ->cmd_ctrl() and ->cmdfunc()

2018-09-06 Thread Boris Brezillon
Those hooks have been replaced by ->exec_op(). Move them to the nand_legacy struct. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/ams-delta.c | 2 +- drivers/mtd/nand/raw/atmel/nand-controller.c | 4 +- drivers/mtd/nand/raw/au1550nd.c |

[PATCH 16/19] mtd: rawnand: Keep all internal stuff private

2018-09-06 Thread Boris Brezillon
are not supposed to be exposed. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/internals.h | 98 drivers/mtd/nand/raw/nand_amd.c | 2 +- drivers/mtd/nand/raw/nand_base.c | 21 drivers/mtd/nand/raw/nand_bbt.c | 3 +- drivers

[PATCH 12/19] mtd: rawnand: Get rid of the duplicate nand_chip forward declaration

2018-09-06 Thread Boris Brezillon
There's already a forward declaration of nand_chip at the beginning of the file. Get rid of this one. Signed-off-by: Boris Brezillon --- include/linux/mtd/rawnand.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h index 768415e

[PATCH 17/19] mtd: rawnand: Move legacy code to nand_legacy.c

2018-09-06 Thread Boris Brezillon
Allows us to move a few hundred lines of deprecated code out of the core file which is quite big. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/Makefile | 2 +- drivers/mtd/nand/raw/internals.h | 6 + drivers/mtd/nand/raw/nand_base.c | 618

[PATCH 11/19] mtd: rawnand: Get rid of nand_flash_dev forward declation

2018-09-06 Thread Boris Brezillon
nand_scan[with_ids]() have been moved at the end of the file. We can now get rid of of the nand_flash_dev forward declaration. Signed-off-by: Boris Brezillon --- include/linux/mtd/rawnand.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd

[PATCH 01/19] mtd: rawnand: Leave chip->IO_ADDR_{R, W} to NULL when unused

2018-09-06 Thread Boris Brezillon
There's no point in poisoning the ->IO_ADDR_{R,W}, a NULL pointer is just as good to detect unexpected ->IO_ADDR_{R,W} usage. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 3 --- drivers/mtd/nand/raw/socrates_nand.c | 4 2 files changed,

[PATCH 00/19] mtd: rawnand: API cleanup (2nd batch)

2018-09-06 Thread Boris Brezillon
API/core cleanup. Regards, Boris Boris Brezillon (19): mtd: rawnand: Leave chip->IO_ADDR_{R,W} to NULL when unused mtd: rawnand: Create a legacy struct and move ->IO_ADDR_{R,W} there mtd: rawnand: Deprecate ->{read,write}_{byte,buf}() hooks mtd: rawnand: Deprecate ->cmd_ctrl() a

[PATCH v2 17/23] mtd: rawnand: Pass a nand_chip object to chip->waitfunc()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->waitfunc() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/r

[PATCH v2 10/23] mtd: rawnand: Pass a nand_chip object to chip->read_xxx() hooks

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle all chip->read_xxx() hooks at once. Signed-off-by: Boris Brezillon --- drivers/mtd

[PATCH v2 09/23] mtd: rawnand: Pass a nand_chip object to ecc->write_xxx() hooks

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle all ecc->write_xxx() hooks at once. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/r

[PATCH v2 21/23] mtd: rawnand: Pass a nand_chip object to chip->setup_data_interface()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->setup_data_interface() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/n

[PATCH v2 20/23] mtd: rawnand: Pass a nand_chip object to chip->setup_read_retry()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->setup_read_retry() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/ra

[PATCH v2 19/23] mtd: rawnand: Pass a nand_chip object to chip->{get, set}_features()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->{get,set}_features() hooks. Signed-off-by: Boris Brezillon --- drivers

[PATCH v2 16/23] mtd: rawnand: Pass a nand_chip object to chip->cmdfunc()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->cmdfunc() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/r

[PATCH v2 23/23] mtd: rawnand: Pass a nand_chip object nand_erase_nand()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the nand_erase_nand() helper. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/nand_b

[PATCH v2 22/23] mtd: rawnand: Pass a nand_chip object to all nand_xxx_bbt() helpers

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the nand_xxx_bbt() helpers. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/nand_b

[PATCH v2 13/23] mtd: rawnand: Pass a nand_chip object to chip->block_xxx() hooks

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle all chip->block_xxx() hooks at once. Signed-off-by: Boris Brezillon --- drivers

[PATCH v2 18/23] mtd: rawnand: Pass a nand_chip object to chip->erase()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->erase() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/de

[PATCH v2 12/23] mtd: rawnand: Pass a nand_chip object to chip->select_chip()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->select_chip() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/r

[PATCH v2 06/23] mtd: rawnand: Pass a nand_chip object to ecc->calculate()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one. Now is ecc->calculate()'s turn. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/cs553x_nand.c | 4 ++-- drivers/mtd/nand/raw/davinc

[PATCH v2 07/23] mtd: rawnand: Pass a nand_chip object to ecc->correct()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one. Now is ecc->correct()'s turn. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/davinci_nand.c | 9 - drivers/mtd/nand/raw/diskon

[PATCH v2 14/23] mtd: rawnand: Pass a nand_chip object to chip->cmd_ctrl()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->cmd_ctrl() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/ra

[PATCH v2 08/23] mtd: rawnand: Pass a nand_chip object to ecc->read_xxx() hooks

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle all ecc->read_xxx() hooks at once. Signed-off-by: Boris Brezillon Acked-by: Stefan Agner

[PATCH v2 15/23] mtd: rawnand: Pass a nand_chip object to chip->dev_ready()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->dev_ready() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/ra

[PATCH v2 02/23] mtd: rawnand: Pass a nand_chip object to nand_scan()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers to take a nand_chip object instead of an mtd_info one. We start with nand_scan(). Signed-off-by: Boris Brezillon --- Changes in v2: - Fix commit message --- Documentation/driver-api/mtdnand.rst | 2 +- drivers/mtd

[PATCH v2 11/23] mtd: rawnand: Pass a nand_chip object to chip->write_xxx() hooks

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle all chip->write_xxx() hooks at once. Signed-off-by: Boris Brezillon --- drivers/mtd

[PATCH v2 05/23] mtd: rawnand: Pass a nand_chip object to ecc->hwctl()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one. Now is ecc->hwctl()'s turn. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/cs553x_nand.c | 3 +-- drivers/mtd/nand/raw/davinc

[PATCH v2 03/23] mtd: rawnand: Pass a nand_chip object to nand_release()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers to take a nand_chip object instead of an mtd_info one. Now is nand_release()'s turn. Signed-off-by: Boris Brezillon --- Documentation/driver-api/mtdnand.rst | 2 +- drivers/mtd/nand/raw/ams-delta.c | 2 +

[PATCH v2 01/23] mtd: rawnand: plat_nand: Pass a nand_chip object to all platform_nand_ctrl hooks

2018-09-06 Thread Boris Brezillon
of an mtd_info. We add temporary plat_nand_xxx() wrappers to the do the mtd -> chip conversion, but those will be dropped when patching nand_chip hooks to take a nand_chip object. Signed-off-by: Boris Brezillon Reviewed-by: Alexander Sverdlin Acked-by: Alexander Sverdlin Acked-by: Robert Jarzmi

[PATCH v2 04/23] mtd: rawnand: Pass a nand_chip object to nand_wait_ready()

2018-09-06 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers to take a nand_chip object instead of an mtd_info one. Now is nand_wait_ready()'s turn. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 2 +- drivers/mtd/nand/raw/c

[PATCH v2 00/23] mtd: rawnand: Stop passing mtd_info to drivers

2018-09-06 Thread Boris Brezillon
ux-0day/commits/nand/api-cleanup Boris Brezillon (23): mtd: rawnand: plat_nand: Pass a nand_chip object to all platform_nand_ctrl hooks mtd: rawnand: Pass a nand_chip object to nand_scan() mtd: rawnand: Pass a nand_chip object to nand_release() mtd: rawnand: Pass a nand_chip object to

Re: [PATCH 01/23] mtd: rawnand: plat_nand: Pass a nand_chip object to all platform_nand_ctrl hooks

2018-08-22 Thread Boris Brezillon
On Fri, 17 Aug 2018 18:09:00 +0200 Boris Brezillon wrote: > Let's make the raw NAND API consistent by patching all helpers and > hooks to take a nand_chip object instead of an mtd_info one or > remove the mtd_info object when both are passed. > > In order to do that, we firs

Re: [PATCH 08/23] mtd: rawnand: Pass a nand_chip object to ecc->read_xxx() hooks

2018-08-20 Thread Boris Brezillon
Hi Stefan, On Mon, 20 Aug 2018 09:57:47 +0200 Stefan Agner wrote: > On 19.08.2018 13:26, Boris Brezillon wrote: > > Hi Stefan, > > > > On Sat, 18 Aug 2018 10:30:13 +0200 > > Stefan Agner wrote: > > > >> > diff --git a/drivers/mtd/nand/r

Re: [PATCH 08/23] mtd: rawnand: Pass a nand_chip object to ecc->read_xxx() hooks

2018-08-19 Thread Boris Brezillon
Hi Stefan, On Sat, 18 Aug 2018 10:30:13 +0200 Stefan Agner wrote: > > diff --git a/drivers/mtd/nand/raw/tegra_nand.c > > b/drivers/mtd/nand/raw/tegra_nand.c > > index 5dcee20e2a8c..bcc3a2888c4f 100644 > > --- a/drivers/mtd/nand/raw/tegra_nand.c > > +++ b/drivers/mtd/nand/raw/tegra_nand.c > > @@

[PATCH 23/23] mtd: rawnand: Pass a nand_chip object nand_erase_nand()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the nand_erase_nand() helper. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/nand_b

[PATCH 11/23] mtd: rawnand: Pass a nand_chip object to chip->write_xxx() hooks

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle all chip->write_xxx() hooks at once. Signed-off-by: Boris Brezillon --- drivers/mtd

[PATCH 16/23] mtd: rawnand: Pass a nand_chip object to chip->cmdfunc()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->cmdfunc() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/r

[PATCH 09/23] mtd: rawnand: Pass a nand_chip object to ecc->write_xxx() hooks

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle all ecc->write_xxx() hooks at once. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/r

[PATCH 08/23] mtd: rawnand: Pass a nand_chip object to ecc->read_xxx() hooks

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle all ecc->read_xxx() hooks at once. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/r

[PATCH 14/23] mtd: rawnand: Pass a nand_chip object to chip->cmd_ctrl()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->cmd_ctrl() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/ra

[PATCH 10/23] mtd: rawnand: Pass a nand_chip object to chip->read_xxx() hooks

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle all chip->read_xxx() hooks at once. Signed-off-by: Boris Brezillon --- drivers/mtd

[PATCH 15/23] mtd: rawnand: Pass a nand_chip object to chip->dev_ready()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->dev_ready() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/ra

[PATCH 13/23] mtd: rawnand: Pass a nand_chip object to chip->block_xxx() hooks

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle all chip->block_xxx() hooks at once. Signed-off-by: Boris Brezillon --- drivers

[PATCH 17/23] mtd: rawnand: Pass a nand_chip object to chip->waitfunc()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->waitfunc() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/r

[PATCH 12/23] mtd: rawnand: Pass a nand_chip object to chip->select_chip()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->select_chip() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/r

[PATCH 01/23] mtd: rawnand: plat_nand: Pass a nand_chip object to all platform_nand_ctrl hooks

2018-08-17 Thread Boris Brezillon
of an mtd_info. We had temporary plat_nand_xxx() wrappers to the do the mtd -> chip conversion, but those will be dropped when doing the patching nand_chip hooks to take a nand_chip object. Signed-off-by: Boris Brezillon --- arch/arm/mach-ep93xx/snappercl15.c | 7 ++-- arch/arm/mach-ep93xx/

[PATCH 20/23] mtd: rawnand: Pass a nand_chip object to chip->setup_read_retry()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->setup_read_retry() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/ra

[PATCH 22/23] mtd: rawnand: Pass a nand_chip object to all nand_xxx_bbt() helpers

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the nand_xxx_bbt() helpers. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/nand_b

[PATCH 18/23] mtd: rawnand: Pass a nand_chip object to chip->erase()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->erase() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/de

[PATCH 06/23] mtd: rawnand: Pass a nand_chip object to ecc->calculate()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one. Now is ecc->calculate()'s turn. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/cs553x_nand.c | 4 ++-- drivers/mtd/nand/raw/davinc

[PATCH 19/23] mtd: rawnand: Pass a nand_chip object to chip->{get, set}_features()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->{get,set}_features() hooks. Signed-off-by: Boris Brezillon --- drivers

[PATCH 21/23] mtd: rawnand: Pass a nand_chip object to chip->setup_data_interface()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one or remove the mtd_info object when both are passed. Let's tackle the chip->setup_data_interface() hook. Signed-off-by: Boris Brezillon --- drivers/mtd/n

[PATCH 07/23] mtd: rawnand: Pass a nand_chip object to ecc->correct()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one. Now is ecc->correct()'s turn. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/davinci_nand.c | 9 - drivers/mtd/nand/raw/diskon

[PATCH 05/23] mtd: rawnand: Pass a nand_chip object to ecc->hwctl()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers and hooks to take a nand_chip object instead of an mtd_info one. Now is ecc->hwctl()'s turn. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/cs553x_nand.c | 3 +-- drivers/mtd/nand/raw/davinc

[PATCH 00/23] mtd: rawnand: Stop passing mtd_info to drivers

2018-08-17 Thread Boris Brezillon
riate). For those who want to see what's in the pipe, here is a branch [1] containing all the cleanups I plan to merge. Regards, Boris [1]https://github.com/bbrezillon/linux-0day/commits/nand/api-cleanup Boris Brezillon (23): mtd: rawnand: plat_nand: Pass a nand_chip obj

[PATCH 02/23] mtd: rawnand: Pass a nand_chip object to nand_scan() & co

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers to take a nand_chip object instead of an mtd_info one. We start with all variants of nand_scan(). Signed-off-by: Boris Brezillon --- Documentation/driver-api/mtdnand.rst | 2 +- drivers/mtd/nand/raw/ams-de

[PATCH 03/23] mtd: rawnand: Pass a nand_chip object to nand_release()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers to take a nand_chip object instead of an mtd_info one. Now is nand_release()'s turn. Signed-off-by: Boris Brezillon --- Documentation/driver-api/mtdnand.rst | 2 +- drivers/mtd/nand/raw/ams-delta.c | 2 +

[PATCH 04/23] mtd: rawnand: Pass a nand_chip object to nand_wait_ready()

2018-08-17 Thread Boris Brezillon
Let's make the raw NAND API consistent by patching all helpers to take a nand_chip object instead of an mtd_info one. Now is nand_wait_ready()'s turn. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 2 +- drivers/mtd/nand/raw/c

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

2018-08-06 Thread Boris Brezillon
On Mon, 6 Aug 2018 15:01:37 +0300 Dan Carpenter wrote: > On Mon, Aug 06, 2018 at 01:46:48PM +0200, Boris Brezillon wrote: > > Hi Dan, > > > > On Wed, 1 Aug 2018 15:05:51 +0300 > > Dan Carpenter wrote: > > > > > On Wed, Aug 01, 2018 at 11:24:19AM

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

2018-08-06 Thread Boris Brezillon
Hi Dan, On Wed, 1 Aug 2018 15:05:51 +0300 Dan Carpenter wrote: > On Wed, Aug 01, 2018 at 11:24:19AM +0800, Jheng-Jhong Wu wrote: > > For NAND flash chips with more than 1Gbit (e.g. MT29F2G) more than 16 bits > > are necessary to address the correct page. The driver sets the address for > > more

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

2018-07-31 Thread Boris Brezillon
Hi Jheng-Jhong, On Wed, 1 Aug 2018 11:24:19 +0800 Jheng-Jhong Wu wrote: > For NAND flash chips with more than 1Gbit (e.g. MT29F2G) more than 16 bits > are necessary to address the correct page. The driver sets the address for > more than 16 bits, but it uses 16-bit arguments and variables (thes

Re: [PATCH v3 14/20] mtd: Remove depends on HAS_DMA in case of platform dependency

2018-04-22 Thread Boris Brezillon
On Tue, 17 Apr 2018 19:49:14 +0200 Geert Uytterhoeven wrote: > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". > In most cases this other symbol is an architecture or platform specific > symbol, or PCI.

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-04 Thread Boris Brezillon
On Wed, 04 Apr 2018 21:49:26 +0200 Robert Jarzmik wrote: > Ulf Hansson writes: > > > On 2 April 2018 at 16:26, Robert Jarzmik wrote: > >> Hi, > >> > >> This serie is aimed at removing the dmaengine slave compat use, and > >> transfer > >> knowledge of the DMA requestors into architecture co

Re: [PATCH v2 14/21] mtd: Remove depends on HAS_DMA in case of platform dependency

2018-03-18 Thread Boris Brezillon
a/drivers/mtd/spi-nor/Kconfig > +++ b/drivers/mtd/spi-nor/Kconfig > @@ -71,7 +71,7 @@ config SPI_FSL_QUADSPI > config SPI_HISI_SFC > tristate "Hisilicon SPI-NOR Flash Controller(SFC)" > depends on ARCH_HISI || COMPILE_TEST > - depends on HAS_IOMEM &&a

Re: [PATCH 1/5] mtd: Initialize ->fail_addr early in mtd_erase()

2018-03-18 Thread Boris Brezillon
On Mon, 12 Feb 2018 22:03:07 +0100 Boris Brezillon wrote: > mtd_erase() can return an error before ->fail_addr is initialized to > MTD_FAIL_ADDR_UNKNOWN. Move this initialization at the very beginning > of the function. Applied the patchset after addressing Miquel's comments.

Re: [PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

2018-02-13 Thread Boris Brezillon
e->state = MTD_ERASE_DONE; > > - } > > - mtd_erase_callback(erase); > > + > > return rc; > > } > > > > diff --git a/drivers/mtd/devices/slram.c b/drivers/mtd/devices/slram.c > > index 0ec85f316d24..2f05e1801047 100644 > > --- a/drivers/mtd/devices/slram.c > > +++ b/drivers/mtd/devices/slram.c > > @@ -88,8 +88,6 @@ static int slram_erase(struct mtd_info *mtd, struct > > erase_info *instr) > > * I don't feel at all ashamed. This kind of thing is possible anyway > > * with flash, but unlikely. > > */ > > Same with this comment. Actually, I'm not sure I understand that comment, but I guess it's talking about races between read/write and erase paths, so nothing related to the changed I'm doing here. > > > - instr->state = MTD_ERASE_DONE; > > - mtd_erase_callback(instr); > > Space ? > > > return(0); > > } > > > > > > -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 4/5] mtd: Unconditionally update ->fail_addr and ->addr in part_erase()

2018-02-12 Thread Boris Brezillon
rase_info->callback() and are thus only taking the ->addr_fail and ->addr fields into account after part_erase() has returned. While we're at it, get rid of the erase_info->mtd field which was only needed to let mtd_erase_callback() get the partition device back. Signed-off-by: Boris B

[PATCH 0/5] mtd: Simplify erase handling

2018-02-12 Thread Boris Brezillon
sistent and allows us to get rid of a few hundred lines of code. Regards, Boris Boris Brezillon (5): mtd: Initialize ->fail_addr early in mtd_erase() mtd: Get rid of unused fields in struct erase_info mtd: Stop assuming mtd_erase() is asynchronous mtd: Unconditionally update ->fail_a

[PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

2018-02-12 Thread Boris Brezillon
>state field, all MTD_ERASE_XXX definitions and the mtd_erase_callback() function. Signed-off-by: Boris Brezillon --- drivers/mtd/chips/cfi_cmdset_0001.c | 16 ++-- drivers/mtd/chips/cfi_cmdset_0002.c | 26 +++--- drivers/mtd/chips/cfi_cmdset_0020.c

[PATCH 1/5] mtd: Initialize ->fail_addr early in mtd_erase()

2018-02-12 Thread Boris Brezillon
mtd_erase() can return an error before ->fail_addr is initialized to MTD_FAIL_ADDR_UNKNOWN. Move this initialization at the very beginning of the function. Signed-off-by: Boris Brezillon --- drivers/mtd/mtdcore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH 3/5] mtd: Stop assuming mtd_erase() is asynchronous

2018-02-12 Thread Boris Brezillon
None of the mtd->_erase() implementations work in an asynchronous manner, so let's simplify MTD users that call mtd_erase(). All they need to do is check the value returned by mtd_erase() and assume that != 0 means failure. Signed-off-by: Boris Brezillon --- drivers/mtd/devices/bcm47xx

[PATCH 2/5] mtd: Get rid of unused fields in struct erase_info

2018-02-12 Thread Boris Brezillon
Some fields are not used by MTD drivers, users or core code. Moreover, those fields are not documented, so get rid of them to avoid any confusion. Signed-off-by: Boris Brezillon --- include/linux/mtd/mtd.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/linux/mtd/mtd.h b/include

Re: [PATCH 5/5] mtd: nand: add ->exec_op() implementation

2017-12-01 Thread Boris Brezillon
On Thu, 30 Nov 2017 18:01:32 +0100 Miquel Raynal wrote: > EXPORT_SYMBOL_GPL(nand_write_data_op); > > /** > + * struct nand_op_parser_ctx - Context used by the parser > + * @instrs: array of all the instructions that must be addressed > + * @ninstrs: length of the @instrs array > + * @instr_id

Re: [PATCH 5/5] mtd: nand: add ->exec_op() implementation

2017-12-01 Thread Boris Brezillon
Hi Miquel, On Thu, 30 Nov 2017 23:25:38 +0100 Miquel RAYNAL wrote: > > > diff --git a/drivers/mtd/nand/nand_base.c > > > b/drivers/mtd/nand/nand_base.c index 52965a8aeb2c..46bf31aff909 > > > 100644 --- a/drivers/mtd/nand/nand_base.c > > > +++ b/drivers/mtd/nand/nand_base.c > > > @@ -689,6 +689,5

  1   2   3   4   5   6   >