Re: [PATCH] Staging: crystalhd: Mark local functions as static

2014-04-19 Thread bojan prtvar
On Sat, Apr 19, 2014 at 9:58 AM, bojan prtvar wrote: > On Sat, Apr 19, 2014 at 1:23 AM, Greg KH wrote: >> On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote: >>> This fixes the following sparse warnings: >>> drivers/staging/crystalhd/crystalhd_l

Re: [PATCH] Staging: crystalhd: Mark local functions as static

2014-04-19 Thread bojan prtvar
On Sat, Apr 19, 2014 at 1:23 AM, Greg KH wrote: > On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote: >> This fixes the following sparse warnings: >> drivers/staging/crystalhd/crystalhd_lnx.c:631:5: warning: symbol >> 'chd_dec_pci_suspend' was no

[PATCH] Staging: crystalhd: Mark local functions as static

2014-04-18 Thread Bojan Prtvar
Should it be static? drivers/staging/crystalhd/crystalhd_lnx.c:78:29: warning: symbol 'chd_dec_alloc_iodata' was not declared. Should it be static? drivers/staging/crystalhd/crystalhd_lnx.c:99:6: warning: symbol 'chd_dec_free_iodata' was not declared. Should it be static? S

[PATCH] staging: vme: Simplfy string usage in vme_user_probe()

2014-04-03 Thread Bojan Prtvar
We can avoid usage of sprintf() and magic-sized array with simple pointer assignment. Signed-off-by: Bojan Prtvar --- This parch should be applied on top of "staging: vme: Fix a small coding style issue in vme_user.c" Compile tested only. drivers/staging/vme/devices/vme_

Re: [PATCH] staging: vme: Fix a small coding style issue in vme_user.c

2014-04-03 Thread bojan prtvar
On Thu, Apr 3, 2014 at 5:14 PM, walter harms wrote: > beside style: > that sprint looks like as it could be replaced with a > name="bus/vme/m%%d" > > any takers ? > > re, > wh > Hi Walter, I guess you mean something like this? Please review carefully if I got right "%%d" intent. Now a basic q

[PATCH] staging: vme: Fix a small coding style issue in vme_user.c

2014-04-02 Thread Bojan Prtvar
The checkpatch.pl complains about missing blank line after declaration. This patch silence the warning. Signed-off-by: Bojan Prtvar --- This patch is for Eudyptula Challenge task 10 drivers/staging/vme/devices/vme_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vme

[PATCH] Staging: android: Remove extern from function prototypes in .h files

2013-09-02 Thread Bojan Prtvar
checkpatch.pl complains that extern prototypes should be avoided in .h files Signed-off-by: Bojan Prtvar --- drivers/staging/android/timed_output.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/timed_output.h b/drivers/staging/android

[PATCH v2] Staging: android: Mark local functions in binder.c as static

2013-09-01 Thread Bojan Prtvar
This fixes the following sparse warnings drivers/staging/android/binder.c:1703:5: warning: symbol 'binder_thread_write' was not declared. Should it be static? drivers/staging/android/binder.c:2058:6: warning: symbol 'binder_stat_br' was not declared. Should it be static?

[PATCH] Staging: android: Mark local functions in binder.c as static

2013-09-01 Thread Bojan Prtvar
This fixes the following sparse warnings drivers/staging/android/binder.c:1703:5: warning: symbol 'binder_thread_write' was not declared. Should it be static? drivers/staging/android/binder.c:2058:6: warning: symbol 'binder_stat_br' was not declared. Should it be static?

[PATCH] Staging: android: add __user annotation in binder.c

2013-09-01 Thread Bojan Prtvar
This fixes the following sparse error drivers/staging/android/binder.c:1795:36: error: incompatible types in comparison expression (different address spaces) Signed-off-by: Bojan Prtvar --- drivers/staging/android/binder.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git