Re: [PATCH 00/10] staging/irda/net: Adjustments for several function implementations

2017-10-12 Thread Bjørn Mork
Did you read drivers/staging/irda/TODO ? There is no need to answer that. You already have. Thanks a lot for your ever lasting invaluable contributions to /dev/null. Please continue. Bjørn ___ devel mailing list de...@linuxdriverproject.org http://d

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

2017-01-29 Thread Bjørn Mork
Greg KH writes: > Please take some time, and go read Documentation/SubmittingPatches. That's quickly done nowadays: bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches This file has moved to process/submitting-patches.rst I don't know why it was necessary to move t

Re: [PATCH 00/10] MA USB drivers cover letter

2014-11-04 Thread Bjørn Mork
[added linux-...@vger.kernel.org Cc] Stephanie Wallick writes: > Media Agnostic (MA) USB enables the USB protocol to be used over a wide > range of physical media. MA USB is a relatively new protocol and is > currently unsupported in the Linux kernel. This patch set adds the > following drivers

Re: [PATCH] staging: et131x: remove Module.symvers

2014-06-02 Thread Bjørn Mork
Mark Einon writes: > On Mon, Jun 02, 2014 at 10:26:42AM +0200, Bjørn Mork wrote: >> Removing a build generated file. >> >> Cc: Mark Einon >> Fixes: e0349d5bac22 ("staging: et131x: Remove unused rcv_pend_lock spinlock") >> Signed-off-by: Bjørn Mork >

[PATCH] staging: et131x: remove Module.symvers

2014-06-02 Thread Bjørn Mork
Removing a build generated file. Cc: Mark Einon Fixes: e0349d5bac22 ("staging: et131x: Remove unused rcv_pend_lock spinlock") Signed-off-by: Bjørn Mork --- drivers/staging/et131x/Module.symvers | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 drivers/stag

Re: [PATCH v2 net-next 0/9] set addr_assign_type when inheriting a dev_addr

2013-09-03 Thread Bjørn Mork
David Miller writes: > From: Bjørn Mork > Date: Fri, 30 Aug 2013 18:08:43 +0200 > >> Copying the dev_addr from a parent device is an operation >> common to a number of drivers. The addr_assign_type should >> be updated accordingly, either by reusing the value f

[PATCH v2 net-next 0/9] set addr_assign_type when inheriting a dev_addr

2013-08-30 Thread Bjørn Mork
Changes in v2: - assuming addr_len == ETH_ALEN to allow optimized memcpy - dropped the vt6656 patch due to addr_len being unset in that driver Bjørn Mork (9): net: etherdevice: add address inherit helper net: vlan: inherit addr_assign_type along with dev_addr net: dsa: inherit addr_assign_

[PATCH v2 net-next 9/9] staging: vt6655: inherit addr_assign_type along with dev_addr

2013-08-30 Thread Bjørn Mork
A device inheriting a random or set address should reflect this in its addr_assign_type. Cc: Forest Bond Signed-off-by: Bjørn Mork --- drivers/staging/vt6655/hostap.c |2 +- drivers/staging/vt6655/ioctl.c |2 +- drivers/staging/vt6655/wpactl.c |2 +- 3 files changed, 3 insertions

[PATCH v2 net-next 1/9] net: etherdevice: add address inherit helper

2013-08-30 Thread Bjørn Mork
Some etherdevices inherit their address from a parent or master device. The addr_assign_type should be updated along with the address in these cases. Adding a helper function to simplify this. Signed-off-by: Bjørn Mork --- include/linux/etherdevice.h | 15 +++ 1 file changed, 15

Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

2013-08-23 Thread Bjørn Mork
Dan Carpenter writes: > Ah... Here is the first patch which adds eth_hw_addr_inherit() > > http://patchwork.ozlabs.org/patch/269365/ > > I don't think we've actually set dst->addr_len yet at this point so > it doesn't do the memcpy(). This doesn't work. Ouch. Yes, I see. The net_device is all

Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

2013-08-23 Thread Bjørn Mork
Dan Carpenter writes: > On Fri, Aug 23, 2013 at 11:35:13AM +0200, Bjørn Mork wrote: >> Cc: Forest Bond >> Signed-off-by: Bjørn Mork >> --- > > The changlog is missing. Yes, right. Sorry about that. > Why does this patch help? It ensures that addr_assign_ty

[PATCH net-next 00/10] set addr_assign_type when inheriting a dev_addr

2013-08-23 Thread Bjørn Mork
patch set adds a helper copying both the dev_addr and the addr_assign_type, and use this helper in drivers which don't currently set the addr_assign_type. Using NET_ADDR_STOLEN might be more appropriate in some of these cases. Please let me know, and I'll update the patch accordingly.

[PATCH net-next 09/10] staging: vt6655: inherit addr_assign_type along with dev_addr

2013-08-23 Thread Bjørn Mork
Cc: Forest Bond Signed-off-by: Bjørn Mork --- drivers/staging/vt6655/hostap.c |2 +- drivers/staging/vt6655/ioctl.c |2 +- drivers/staging/vt6655/wpactl.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/hostap.c b/drivers/staging/vt6655

[PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

2013-08-23 Thread Bjørn Mork
Cc: Forest Bond Signed-off-by: Bjørn Mork --- drivers/staging/vt6656/hostap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/hostap.c b/drivers/staging/vt6656/hostap.c index c699a30..3ddef9d 100644 --- a/drivers/staging/vt6656/hostap.c +++ b