On 3/17/21 1:50 AM, Ricardo Ribalda wrote:
> Hi Bingbu
>
> Thanks for your review
>
> On Tue, Mar 16, 2021 at 12:29 PM Bingbu Cao
> wrote:
>>
>> Hi, Ricardo
>>
>> Thanks for your patch.
>> It looks fine for me, do you mind squash 2 patchsets
/* CSS expects some format on OUT queue */
> - if (i != IPU3_CSS_QUEUE_OUT &&
> - !imgu_pipe->nodes[inode].enabled)
> - fmts[i] = NULL;
> }
>
> if (!try) {
>
--
Best regards,
Bingbu Cao
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
fs_chroma, 0,
> sizeof(cfg->scaler_coeffs_chroma));
> - memset(&cfg->scaler_coeffs_luma, 0, sizeof(*cfg->scaler_coeffs_luma));
> + memset(&cfg->scaler_coeffs_luma, 0, sizeof(cfg->scaler_coeffs_luma));
> do {
> phase_step_correct
, 1, PCI_IRQ_MSI);
>
> - if (r) {
> + if (r < 0) {
> dev_err(&dev->dev, "failed to enable MSI (%d)\n", r);
> return r;
> }
>
--
Best regards,
Bingbu Cao
___
devel mailing li
On 01/28/2019 11:45 PM, Kai Heng Feng wrote:
Hi Kieran,
On Jan 28, 2019, at 4:48 PM, Kieran Bingham
wrote:
Hi Kai-Heng,
On 27/01/2019 05:56, Kai-Heng Feng wrote:
Hi,
We have a bug report [1] that the ipu3 doesn’t work.
Does ipu3 need special userspace to work?
Yes, it will need furthe
On 01/07/2019 07:00 PM, Sakari Ailus wrote:
Hi Bingbu,
On Mon, Jan 07, 2019 at 10:38:19AM +0800, Bingbu Cao wrote:
Hi, Haibing
Thanks for your patch, it looks fine for me.
Reviewed-by: Bingbu Cao
On 12/29/2018 10:45 AM, YueHaibing wrote:
css->pipes[pipe].bindex = binary;
I'
Hi, Haibing
Thanks for your patch, it looks fine for me.
Reviewed-by: Bingbu Cao
On 12/29/2018 10:45 AM, YueHaibing wrote:
css->pipes[pipe].bindex = binary;
___
devel mailing list
de...@linuxdriverproject.org
h
