Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

On 21/07/2014 17:16, Bjorn Helgaas wrote: > [+cc Jingoo] > > On Fri, Jul 18, 2014 at 12:50 PM, James Bottomley > > Anyway, it's PCI code ... let the PCI maintainer decide. However, if he > > does want this do it as one big bang patch via either the PCI or Trivial > > tree (latter because Jiří has

[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // @@ identifier i; declarer

Re: [PATCH 9/18] staging: rtl8723au: Use kmemdup instead of kmalloc + memcpy

On 26/05/2014 17:43, Jes Sorensen wrote: > Benoit Taine writes: > > This issue was reported by coccicheck using the semantic patch > > at scripts/coccinelle/api/memdup.cocci > > > > Signed-off-by: Benoit Taine > > --- > > Tested by compilation without err

[PATCH 0/18] Use kmemdup instead of kmalloc + memcpy

These patches enhance kernel style usage, and allows smaller code while preventing accidental code edits to produce overflows. The semantic patch at scripts/coccinelle/api/memdup.cocci was used to detect and edit this situation. ___ devel mailing list de

[PATCH 9/18] staging: rtl8723au: Use kmemdup instead of kmalloc + memcpy

This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/memdup.cocci Signed-off-by: Benoit Taine --- Tested by compilation without errors. drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c |3 +-- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 16

[PATCH] staging: rtl8723au: Use kmemdup() instead of memcpy() to duplicate memory

This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/memdup.cocci, and tested by compilation. Signed-off-by: Benoit Taine --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c |3 +-- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 17

[PATCH] staging: rts5208: Use pci_device_id rather than DEFINE_PCI_DEVICE_TABLE

This patch enhances kernel style usage for the rts5208 driver. We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. Signed-off-by: Benoit Taine --- drivers/staging/rts5208/rtsx.c |2 +- 1 file

[PATCH] staging/rtl8192u: Put EXPORT_SYMBOL just after the exported function

; @@ - EXPORT_SYMBOL(f); @@ identifier r.f; @@ f(...) { ... } + EXPORT_SYMBOL(f); // Signed-off-by: Benoit Taine --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c |3 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c| 52 +- drivers/staging/rtl8192u/ieee80211