[PATCH 1/1] staging: skein: Delete a useless white space line

From: Kroderia Delete a useless white space line according to the coding style. Signed-off-by: Ben Chan --- drivers/staging/skein/skein_generic.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c index 85bd7d0

Re: How to replace control code in gdm72xx?

On Wed, Jul 16, 2014 at 1:40 PM, Greg KH wrote: > > On Wed, Jul 16, 2014 at 09:24:28PM +0100, Michalis Pappas wrote: > > Hi, > > > > I'm currently working on bringing the gdm72xx WiMAX driver out of > > staging. The driver currently uses two control channels: > > > > 1. The SIOCDEVPRIVATE ioctl to

[PATCH] staging: gdm72xx: add help text to Kconfig

The descriptions are provided by GCT Semiconductor, Inc. Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/Kconfig | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig index dd8a391..5836503

Re: Anybody working on gdm72xx?

On Tue, Jul 1, 2014 at 9:22 AM, Michalis Pappas wrote: > > Hmm, I wasn't aware of the existence of the user-space library. From a > peek through the sources I notice some copyright disclaimers by GCT. How > do they distribute that library? Who is the maintainer? [Ben] The user-space library in Ch

Re: [PATCH] staging: gdm72xx: move T_CAPABILITY bit definitions to hci.h

On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas wrote: > Signed-off-by: Michalis Pappas > --- > drivers/staging/gdm72xx/gdm_wimax.c | 10 +++--- > drivers/staging/gdm72xx/hci.h | 6 ++ > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/gdm72xx/gdm_

[PATCH] staging: gdm72xx: clean up endianness conversions

annotations. Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_qos.c | 4 +-- drivers/staging/gdm72xx/gdm_sdio.c | 5 +-- drivers/staging/gdm72xx/gdm_usb.c | 12 +++ drivers/staging/gdm72xx/gdm_wimax.c | 64 +++-- drivers/staging/gdm72xx/gdm_wimax.h | 10

[PATCH v2] staging: gdm72xx: use consistent style for header guards

Signed-off-by: Ben Chan --- I forgot to add the Signed-off-by stanza in the original patch. drivers/staging/gdm72xx/gdm_qos.h | 6 +++--- drivers/staging/gdm72xx/gdm_sdio.h | 6 +++--- drivers/staging/gdm72xx/gdm_usb.h | 6 +++--- drivers/staging/gdm72xx/gdm_wimax.h | 6 +++--- drivers

[PATCH] staging: gdm72xx: use consistent style for header guards

--- drivers/staging/gdm72xx/gdm_qos.h | 6 +++--- drivers/staging/gdm72xx/gdm_sdio.h | 6 +++--- drivers/staging/gdm72xx/gdm_usb.h | 6 +++--- drivers/staging/gdm72xx/gdm_wimax.h | 6 +++--- drivers/staging/gdm72xx/hci.h | 6 +++--- drivers/staging/gdm72xx/netlink_k.h | 7 --- drive

Re: Anybody working on gdm72xx?

On Sat, Jun 28, 2014 at 2:49 AM, Michalis Pappas wrote: > > Hi Ben, > > would you be interested to work on this driver together? My reviewing > process is a bit slow as this is the first driver I'm going through and > I would like to understand how everything works in detail. I was > planning to s

Re: Anybody working on gdm72xx?

On Wed, Jun 25, 2014 at 5:11 AM, Michalis Pappas wrote: > > > Hi everyone, > > I've been working on a driver review for gdm72xx and I think there are some > more issues to be fixed except from stuff reported by checkpatch.pl. Here's > what I've come up with so far: > > First of all, during a pat

[PATCH 2/4] staging: gdm72xx: use bool instead of custom-defined BOOLEAN

Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_qos.c | 10 +- drivers/staging/gdm72xx/gdm_qos.h | 4 +--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c index df6f000..732f009 100644 --- a

[PATCH 1/4] staging: gdm72xx: return -EINVAL instead of BUG_ON for invalid data length

This patch changes gdm_usb_send() and gdm_sdio_send() to return -EINVAL instead of calling BUG_ON if an invalid data length is passed to the functions. Reported-by: Dan Carpenter Reported-by: Michalis Pappas Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_sdio.c | 3 ++- drivers

[PATCH 4/4] staging: gdm72xx: use lower case for variable names for consistency

Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_qos.c | 38 +++--- drivers/staging/gdm72xx/gdm_qos.h | 2 +- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c index

[PATCH 3/4] staging: gdm72xx: use int instead of u32 whenever makes sense

This patch addresses the following issues: - Use int instead of u32 whenever makes sense - Turn extract_qos_list() in gdm_qos.c, which previously always returned 0, into a void function. Reported-by: Dan Carpenter Reported-by: Michalis Pappas Signed-off-by: Ben Chan --- drivers/staging

[PATCH] staging: gdm72xx: check return value of sscanf

Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_wimax.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index e5e5115..3081fd4 100644 --- a/drivers/staging/gdm72xx/gdm_wimax.c +++ b

[PATCH staging-next] staging: gdm72xx: fix block comment style

lines WARNING: networking block comments put the trailing */ on a separate line Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_sdio.c | 7 ++- drivers/staging/gdm72xx/gdm_usb.c | 6 ++ drivers/staging/gdm72xx/gdm_wimax.c | 5 +++-- drivers/staging/gdm72xx/hci.h | 4 +-

[PATCH staging-next] staging: gdm72xx: remove blank lines after an open brace

This patch fixes the following checkpatch warning: CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/

Re: Anybody working on gdm72xx?

On Mon, Jun 23, 2014 at 2:33 PM, Kristina Martšenko wrote: > > Here is an example of another driver being moved out: > http://www.spinics.net/lists/linux-usb/msg100924.html > Thanks Kristina. checkpatch reports 1 errors and 17 warnings on the current driver. I guess I need to first submit patch