Re: [PATCH] Staging: ft1000 : ft1000-pcmcia: replace __attribute ((__packed__) with __packed macro per coding style guidelines in ft1000_dnld.c

2014-11-29 Thread Belisko Marek
Please use shorter summary phrase (which appear an subject) + split commit message to more line (not one long line). marek On Sat, Nov 29, 2014 at 3:49 AM, Geoff Darst wrote: > Replace two instances of __attribute ((__packed__) with __packed macro to > address the warning found by the checkpatc

Re: [PATCH] staging:drivers:staging:ft1000:ft1000_pcmcia:ft1000_hw.c:Added a blank line after declaration

2014-11-29 Thread Belisko Marek
Hi Anjana, please update subject to something like staging: ft1000: Marek On Sat, Nov 29, 2014 at 2:34 PM, Anjana Sasindran wrote: > This patch fix the checkpatch.pl warning > > WARNING: Missing a blank line after declaration > > Signed-off-by: Anjana Sasindran > --- > drivers/staging/f

Re: [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table.

2014-06-27 Thread Belisko Marek
PIng? Jonathan do you have any objections to this approach? Can you please pick it? Thx. On Tue, Feb 18, 2014 at 9:35 PM, Belisko Marek wrote: > Hi Jonathan, > > On Tue, Feb 18, 2014 at 11:40 AM, Jonathan Cameron wrote: >> On 14/02/14 14:25, Marek Belisko wrote: >>>

Re: [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table.

2014-02-18 Thread Belisko Marek
Hi Jonathan, On Tue, Feb 18, 2014 at 11:40 AM, Jonathan Cameron wrote: > On 14/02/14 14:25, Marek Belisko wrote: >> >> Signed-off-by: Marek Belisko > > I wonder how this got missed. However, for those data elements to be > useful, you will > need to read them somewhere in the driver I think