On Tue, 2020-03-24 at 20:35 +0300, Dan Carpenter wrote:
> On Tue, Mar 24, 2020 at 04:21:47PM +0100, Bastien Nocera wrote:
> > On Tue, 2020-03-24 at 16:20 +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Mar 24, 2020 at 11:36:00AM +0100, Bastien Nocera wrote:
> > > > M
On Tue, 2020-03-24 at 16:20 +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 24, 2020 at 11:36:00AM +0100, Bastien Nocera wrote:
> > Make it possible to disable the LED, as it can be pretty annoying
> > depending on where it's located.
> >
> > See also https://github
Make it possible to disable the LED, as it can be pretty annoying
depending on where it's located.
See also https://github.com/lwfinger/rtl8188eu/pull/304 for the
out-of-tree version.
Signed-off-by: Bastien Nocera
---
drivers/staging/rtl8188eu/core/rtw_led.c | 6 ++
drivers/st
On Tue, 2020-03-24 at 13:48 +0100, Greg Kroah-Hartman wrote:
>
> Huh? Why not fix this properly, as that's the only way this driver
> is
> ever going to be fixed up correctly and get out of staging at all.
Because, unfortunately, I have limited free time.
__
On Tue, 2020-03-24 at 13:32 +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 24, 2020 at 12:47:01PM +0100, Bastien Nocera wrote:
> > On Tue, 2020-03-24 at 12:38 +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Mar 24, 2020 at 11:36:00AM +0100, Bastien Nocera wrote:
> > > &g
On Tue, 2020-03-24 at 12:38 +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 24, 2020 at 11:36:00AM +0100, Bastien Nocera wrote:
> > Make it possible to disable the LED, as it can be pretty annoying
> > depending on where it's located.
> >
> > See also https://github
it Kukreti
Looks good, thanks.
Reviewed-by: Bastien Nocera
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote:
> Hi,
>
> On 28-06-18 09:43, Michael Straube wrote:
> > Hi,
> >
> > I stumbled upon the following if else construct in
> > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618
> >
> > if (pwrpriv->bInternalAutoSuspend)
> > {
>
On Mon, 2018-04-30 at 15:19 +0100, Colin King wrote:
> + P2P_STATE_RECV_INVITE_REQ_DISMATCH =
> 17,/* receiving the P2P Inviation request and mismatch
> with the profile. */
Might as well fix the "inviation" as well, no? :)
Thanks
___
On Wed, 2018-02-07 at 00:57 +0900, Kangmin Park wrote:
> From: pr0gr4m
This needs a commit message. I don't understand what the code is trying
to do.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/lis
On Fri, 2017-05-05 at 16:10 -0600, Justin Vreeland wrote:
>
> Sorry about blank email.
>
> I'm not 100% happy with it either. Larry Finger suggested to fix the
> overly long lines so I tried to find a decent way to shorten them. I
> think the best way would be to change the function names or p
*/
This does line up when applied, right? If so:
Reviewed-by: Bastien Nocera
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote:
> Ensure checkpatch compliance
>
> > Signed-off-by: Justin Vreeland
> ---
> v2:
> - Added commit message
> - Fixed overly long lines
>
> drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 18 --
> drivers/staging/rtl87
ntical.
>
> Justin Vreeland (7):
> staging: rtl8723bs: Fix initialization of static variables
> staging: rtl8723bs: Wrap multi-line macros in do-while loop
You can add:
Reviewed-by: Bastien Nocera
for those 2.
Cheers
___
devel mai
On Thu, 2017-04-27 at 18:09 -0600, Justin Vreeland wrote:
> Justin Vreeland (7):
>
> staging: rtl8723bs: Fix pointer style
> staging: rtl8723bs: Fix spacing around '<'
> staging: rtl8723bs: Do not use assignment in if condition
You can add:
Reviewed-By: Bast
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote:
> Smatch lists the following:
>
> CHECK drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:470
> rtw_cfg80211_ibss_indicate_connect() error: we previously assumed
> 'scanned' could be null
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote:
> Fixing this requires changing the indentatikon of a long for loop.
Typo here.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote:
> + if (cam_id >= 0 && cam_id < 32)
Isn't there a constant we could use instead of hard-coding this?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/
>
> Signed-off-by: Larry Finger
Feel free to add:
Reviewed-by: Bastien Nocera
for all the patches I didn't directly comment on.
Cheers
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote:
> } else {
> - for (pstat->aid = 1; pstat->aid <= NUM_STA; pstat->aid++)
> + for (pstat->aid = 1; pstat->aid < NUM_STA; pstat->aid++)
> if (pstapriv->sta_aid[pstat->aid - 1] == NULL)
>
Signed-off-by: Bastien Nocera
---
drivers/staging/unisys/virthba/virthba.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/virthba/virthba.c
b/drivers/staging/unisys/virthba/virthba.c
index d7a629b..03672d8 100644
--- a/drivers/staging/unisys/virthba
21 matches
Mail list logo
