Remove the unnecessary socket buffer null check in hostif_data_request.
There is already an appropriate null check in the calling function:
(ks_wlan_net.c) ks_wlan_start_xmit
Signed-off-by: Aymen Qader
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2
Remove an extra space in ddk750_mode.c to fix indentation
Signed-off-by: Aymen Qader
---
drivers/staging/sm750fb/ddk750_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c
b/drivers/staging/sm750fb/ddk750_mode.c
index 7e22d093b091
Use the ENOMEM constant instead of -1 for kzalloc failure checks in
rtl_halmac.c
Signed-off-by: Aymen Qader
---
drivers/staging/rtlwifi/halmac/rtl_halmac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtlwifi/halmac/rtl_halmac.c
b/drivers/staging
ks_wlan_start_xmit |
> hostif_data_request | PARAM_VALUE | 1 | skb | s64min-(-1),1-s64max
>
> regards,
> dan carpenter
>
Again, thanks very much! That's really cool, Smatch looks like a great
tool, I wish I found it before!
On Fri, Sep 28, 2018 at 11:22:39AM +0300, Dan
Skip unnecessary request field checks when the information element
pointer is null.
Signed-off-by: Aymen Qader
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers
Skip unnecessary request field checks when the information element
pointer is null.
Signed-off-by: Aymen Qader
---
v2: combine pointer check and length check & change commit message to be
more appropriate
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 6 +++---
1 file changed, 3 insert
On Thu, Sep 27, 2018 at 03:52:53PM -0500, Larry Finger wrote:
> On 9/27/18 12:04 PM, Aymen Qader wrote:
> > Avoid null pointer arithmetic in rtw_mlme_ext.c by skipping other field
> > checks if the information element pointer is null.
> >
> > Signed-off-by: Aymen Q
return.
On Thu, Sep 27, 2018 at 04:16:13PM +0100, Aymen Qader wrote:
> Add a null pointer check for the socket buffer in ks_hostif.c to avoid a
> possible null pointer deference, and remove a later now-redundant null
> pointer check.
>
> Signed-off-by: Aymen Qader
> ---
> v2:
Avoid null pointer arithmetic in rtw_mlme_ext.c by skipping other field
checks if the information element pointer is null.
Signed-off-by: Aymen Qader
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging
Add a null pointer check for the socket buffer in ks_hostif.c to avoid a
possible null pointer deference, and remove a later now-redundant null
pointer check.
Signed-off-by: Aymen Qader
---
v2: Remove redundant pointer check
v3: Style fix
drivers/staging/ks7010/ks_hostif.c | 6 +-
1 file
Add a null pointer check for the socket buffer in ks_hostif.c to avoid a
possible null pointer deference, and remove a later now-redundant null
pointer check.
Signed-off-by: Aymen Qader
---
v2: Remove redundant pointer check
drivers/staging/ks7010/ks_hostif.c | 6 +-
1 file changed, 5
Add a null pointer check for the socket buffer in ks_hostif.c to avoid a
possible null pointer deference.
Signed-off-by: Aymen Qader
---
drivers/staging/ks7010/ks_hostif.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010
Remove the TODO item to remove manual cache flushing from bulk_receive.
This was previously done in this commit:
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
flush operations")
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/bcm2835-camer
Update the bcm2835-camera driver to remove a TODO and an unused header
include. These were made unnecessary in
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
flush operations")
Aymen Qader (2):
staging: bcm2835-camera: Update TODO
staging: bcm2835-camera: Rem
Remove the TODO item to remove manual cache flushing from bulk_receive.
This was previously done in this commit:
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
flush operations")
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/bcm2835-camer
Update the bcm2835-camera driver to remove a TODO and an unused header
include. These were made unnecessary in
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
flush operations")
Aymen Qader (2):
staging: bcm2835-camera: Update TODO
staging: bcm2835-camera: Rem
Remove the asm/cacheflush.h header include from mmal-vchiq.c. This
dependency was removed in:
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
flush operations")
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 -
1 fi
Remove the asm/cacheflush.h header include from mmal-vchiq.c. This
dependency was removed in:
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
flush operations")
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 -
1 fi
Remove the TODO item to remove manual cache flushing from bulk_receive.
This was previously done in this commit:
(7e8dbdea) staging: bcm2835-camera: Remove explicit cache flush
operations
Also remove the unnecessary asm/cacheflush.h header.
Signed-off-by: Aymen Qader
---
v2: Make commit
This patch removes the TODO item to remove manual cache flushing from b
ulk_receieve - this was done in 7e8dbea. Also remove the unnecessary
asm/cacheflush.h header.
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/bcm2835-camera/TODO | 6 --
drivers/staging
This patch fixes the checkpatch.pl error:
ERROR: code indent should use tabs where possible
in the interface/vchi directory
Signed-off-by: Aymen Qader
---
.../vc04_services/interface/vchi/vchi.h | 116 +-
1 file changed, 58 insertions(+), 58 deletions(-)
diff --git a
This patch fixes the checkpatch.pl error:
ERROR: "foo * bar" should be "foo *bar"
in the interface/vchi directory
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --g
This patch fixes the checkpatch.pl error:
ERROR: space prohibited after/before that open/closed parenthesis
in the interface/vchi directory.
Signed-off-by: Aymen Qader
---
.../vc04_services/interface/vchi/vchi.h | 106 +-
.../vc04_services/interface/vchi/vchi_cfg.h
nclosed in parentheses
ERROR: "foo * bar" should be "foo* bar"
Aymen Qader (4):
staging: vc04_services: Fix "space prohibited"
staging: vc04_services: Use tabs instead of spaces
staging: vc04_services: Remove unused macros
staging: vc04_services: Remove
This patch removes the macros and structs associated with the
"vchi_msg_queuev_ex" function, which was previously removed in 49bec49.
Also fixes the checkpatch.pl errors:
ERROR: Macros with complex values should be enclosed in parentheses
ERROR: space required after that ','
This patch fixes the checkpatch.pl error:
ERROR: space prohibited after/before that open/closed parenthesis
in the interface/vchi directory.
Signed-off-by: Aymen Qader
---
.../vc04_services/interface/vchi/vchi.h | 106 +-
.../vc04_services/interface/vchi/vchi_cfg.h
This patch removes the macros and structs associated with the
"vchi_msg_queuev_ex" function, which was previously removed in 49bec49.
Also fixes the checkpatch.pl errors:
ERROR: Macros with complex values should be enclosed in parentheses
ERROR: space required after that ','
This patch fixes the checkpatch.pl error:
ERROR: code indent should use tabs where possible
in the interface/vchi directory
Signed-off-by: Aymen Qader
---
.../vc04_services/interface/vchi/vchi.h | 116 +-
1 file changed, 58 insertions(+), 58 deletions(-)
diff --git a
This patch fixes the checkpatch.pl error:
ERROR: "foo * bar" should be "foo *bar"
in the interface/vchi directory
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --g
nclosed in parentheses
ERROR: "foo * bar" should be "foo* bar"
Aymen Qader (4):
staging: vc04_services: Fix "space prohibited"
staging: vc04_services: Use tabs instead of spaces
staging: vc04_services: Remove unused macros
staging: vc04_services: Remove spaces
This patch fixes the checkpatch.pl error:
ERROR: "foo * bar" should be "foo* bar"
in the interface/vchi directory
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
This patch fixes the checkpatch.pl error:
ERROR: Macros with complex values should be enclosed in parentheses
in the interface/vchi directory
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
This patch fixes the checkpatch.pl error:
ERROR: space prohibited after/before that open/closed parenthesis
in the interface/vchi directory.
Signed-off-by: Aymen Qader
---
.../vc04_services/interface/vchi/vchi.h | 106 +-
.../vc04_services/interface/vchi/vchi_cfg.h
This patch fixes the checkpatch.pl error:
ERROR: space required after that ','
in the interface/vchi directory
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drive
nclosed in parentheses
ERROR: "foo * bar" should be "foo* bar"
Aymen Qader (5):
staging: vc04_services: Fix "space prohibited"
staging: vc04_services: Use tabs instead of spaces
staging: vc04_services: Add spaces after commas
staging: vc04_services: Surround
This patch fixes the checkpatch.pl error:
ERROR: code indent should use tabs where possible
in the interface/vchi directory
Signed-off-by: Aymen Qader
---
.../vc04_services/interface/vchi/vchi.h | 116 +-
1 file changed, 58 insertions(+), 58 deletions(-)
diff --git a
nclosed in parentheses
ERROR: Macros with complex values should be enclosed in parenthese
Aymen Qader (5):
staging: vc04_services: Fix "space prohibited"
staging: vc04_services: Use tabs instead of spaces
staging: vc04_services: Add spaces after commas
staging: vc04_services: Sur
This patch fixes the checkpatch.pl error:
ERROR: "foo * bar" should be "foo* bar"
in the interface/vchi directory
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
This patch fixes the checkpatch.pl error:
ERROR: code indent should use tabs where possible
in the interface/vchi directory
Signed-off-by: Aymen Qader
---
.../vc04_services/interface/vchi/vchi.h | 116 +-
1 file changed, 58 insertions(+), 58 deletions(-)
diff --git a
This patch fixes the checkpatch.pl error:
ERROR: space required after that ','
in the interface/vchi directory
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drive
This patch fixes the checkpatch.pl error:
ERROR: Macros with complex values should be enclosed in parentheses
in the interface/vchi directory
Signed-off-by: Aymen Qader
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
This patch fixes the checkpatch.pl error:
ERROR: space prohibited after/before that open/closed parenthesis
in the interface/vchi directory.
Signed-off-by: Aymen Qader
---
.../vc04_services/interface/vchi/vchi.h | 106 +-
.../vc04_services/interface/vchi/vchi_cfg.h
This patch corrects a typo (frambuffer->framebuffer) in the
sm750fb_fram(e)buffer_release and sm750fb_fram(e)buffer_alloc function
names.
Signed-off-by: Aymen Qader
---
drivers/staging/sm750fb/sm750.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/stag
43 matches
Mail list logo
