The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/adc/ad7816.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
quot;struct device object" is defined prefer pr_*macro() over printk().
This patch Replace printk having a log level with the appropriate output
format according to the order of preference.
Signed-off-by: Arushi Singhal
---
Changes in v3
*In version2 net_*macro_ratelimited was used which i
Replace printk having a log level with the appropriate
net_*macro_ratelimited.
It's better to use actual device name as a prefix in error messages.
Indentation is also changed, to fix the checkpatch issue if line is not
exceding 80 characters.
Signed-off-by: Arushi Singhal
---
changes
Replace "dont" with "don't".
"Dont" is not same as "Do not" or "Don't".
Signed-off-by: Arushi Singhal
---
changes in v2
*Commit log is rewrite in the imperative.
drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +-
drivers/staging
Replace printk having a log level with the appropriate
net_*macro_ratelimited.
It's better to use actual device name as a prefix in error messages.
Signed-off-by: Arushi Singhal
---
changes in v2
*In v1 printk was changed to pr_*macro(), which is used
in kernel instead of calling p
Replace printk having a log level with the appropriate
net_*macro_ratelimited.
It's better to use actual device name as a prefix in error messages.
Indentation is also changed, to fix the checkpatch issue if line is not
exceding 80 characters.
Signed-off-by: Arushi Singhal
---
.../rtl
Replace printk having a log level with the appropriate
net_*macro_ratelimited.
It's better to use actual device name as a prefix in error messages.
Indentation is also changed, to fix the checkpatch issue.
Signed-off-by: Arushi Singhal
---
changes in v2
*In previous version printk was ch
Replace "cant" with "can't".
"cant" is not same as "Can not" or "Can't".
Signed-off-by: Arushi Singhal
---
drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
This patch replace "be be" with "be".
Signed-off-by: Arushi Singhal
---
drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_pipe_public.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_pipe
Replace "dont" with "don't".
"Dont" is not same as "Do not" or "Don't".
Signed-off-by: Arushi Singhal
---
drivers/staging/media/atomisp/pci/atomisp2/mmu/isp_mmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Spellcheck the comments.
Remove the repeated, consecutive words with single word.
Arushi Singhal (3):
staging: media: Replace "be be" with "be"
staging: media: Replace "cant" with "can't"
staging: media: Replace "dont" with "
Replace "dont" with "don't".
"Dont" is not same as "Do not" or "Don't".
Signed-off-by: Arushi Singhal
---
drivers/staging/lustre/lustre/fld/fld_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/sta
This patch replace "to to" with "to".
Signed-off-by: Arushi Singhal
---
drivers/staging/lustre/lustre/include/cl_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/cl_object.h
b/drivers/staging/lustre/lustre
Spellcheck the comments.
Remove the repeated, consecutive words with single word.
Arushi Singhal (3):
staging: lustre: Replace "be be" with "be"
staging: lustre: Replace "to to" with "to"
staging: lustre: Replace "dont" with &q
This patch replace "be be" with "be".
Signed-off-by: Arushi Singhal
---
drivers/staging/lustre/lnet/libcfs/debug.c | 2 +-
drivers/staging/lustre/lustre/include/lprocfs_status.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stagin
"dont" is changed to "don't" in messages, "dont" is not correct
english.
Signed-off-by: Arushi Singhal
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +-
drivers/staging/comedi/drivers/das16.c | 2 +-
drivers/staging/comedi/drivers/das16m1.c |
Using pr_() is more concise than printk(KERN_).
Replace printks having a log level with the appropriate pr_*() macros.
Signed-off-by: Arushi Singhal
---
drivers/staging/ipx/af_ipx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ipx/af_ipx.c b/drivers
change is as follows:
@header@
@@
#include
@r1@
expression e;
@@
-memset(e,0x00,ETH_ALEN);
+eth_zero_addr(e);
@includeheader depends on r1 && !header@
@@
+ #include
#include <...>
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 ++-
d
Remove unnecessary semicolon found using semicolon.cocci Coccinelle
script.
Signed-off-by: Arushi Singhal
---
.../media/atomisp/pci/atomisp2/css2400/runtime/frame/src/frame.c| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/drivers/staging/media/atomisp/pci/atomisp2
Remove unnecessary semicolon using semicolon.cocci Coccinelle script.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
Remove non-essential semicolon after 'else' and 'switch' statements. Issue
found using semicolon.cocci Coccinelle script.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtlwifi/base.c | 6 +++---
drivers/staging/rtlwifi/phydm/phydm_rainfo.c | 1 -
2 files c
Replace a mix of tabs and spaces indentation by tabs only.
Fixed checkpatch warning "Statements should start on a tabstop".
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/drv_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stagi
Remove unnecessary parentheses around variables to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/recv_linux.c | 4 +-
drivers/staging/rtl8712/rtl8712_cmd.c | 8 ++--
drivers/staging/rtl8712/rtl8712_led.c | 70
Delete/Add tabs and spaces to align the code to fix the
checkpatch issue: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/mlme_linux.c | 2 +-
drivers/staging/rtl8712/os_intfs.c | 2 +-
2 files changed, 2 insertions(+), 2
Add spaces around arithmetic operator '+', to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_cmd.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stagi
Remove extra blank line(s) to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/os_intfs.c | 1 -
drivers/staging/rtl8712/rtl8712_bitdef.h | 1 -
drivers/staging/rtl8712
Add spaces around '|' to conform to the Linux
kernel coding style. Issue found using checkpatch.
CHECK: spaces preferred around that '|'.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h | 2 +-
drivers/staging/rtl8712/rtl8712_gp_bitdef.h
Fix issues found with checkpatch.pl to conform to the Linux
kernel coding style.
Changes in v2:
* From and Signed-off emails were not same in v1.
* Added detailed commit message
Arushi Singhal (6):
staging: rtl8712: Fixed 'tabstop' coding style warning
staging: rtl8712: match alig
From: Arushi Singhal
Remove extra blank line(s) that were causing checkpatch issues.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/os_intfs.c | 1 -
drivers/staging/rtl8712/rtl8712_bitdef.h | 1 -
drivers/staging/rtl8712/rtl8712_cmdctrl_regdef.h | 2
Remove unnecessary parentheses around variables to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/recv_linux.c | 4 +-
drivers/staging/rtl8712/rtl8712_cmd.c | 8 ++--
drivers/staging/rtl8712/rtl8712_led.c | 70
Fix issues found with checkpatch.pl for rtl8712 driver.
Arushi Singhal (4):
staging: rtl8712: Remove multiple blank line(s)
staging: rtl8712: Added spaces around '+'.
staging: rtl8712: Add spaces around '|'
staging: rtl8712: remove unnecessary parentheses
dri
From: Arushi Singhal
Add spaces around arithmetic operator '+', to fix the checkpatch
issue.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_cmd.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_cmd.h
b/drive
From: Arushi Singhal
Add spaces around '|' to fix the checkpatch issue.
CHECK: spaces preferred around that '|'.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h | 2 +-
drivers/staging/rtl8712/rtl8712_gp_bitdef.h | 2 +-
2 files c
This patch fixes the checks reported by checkpatch.pl for alignment
should match open parenthesis.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/mlme_linux.c | 2 +-
drivers/staging/rtl8712/os_intfs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
Replace a mix of tabs and spaces indentation by tabs only.
Fixed checkpatch warning "Statements should start on a tabstop" in
rtl8712 module.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/drv_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/mlme_linux.c| 4 ++--
drivers/staging/rtl8712/rtl8712_cmd.c | 2 +-
drivers/staging/rtl8712/rtl8712_efuse.c | 2 +-
3 files changed, 4 insert
The driver needs to insure atomicity during frequency
changes of bus and device. The iiodev->mlock as used
was not doing that. Replace it with the drivers existing
buffer lock and execute spi_write directly.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/meter/ade7759.c | 9 ++---
Remove the extra parenthesis remove the checkpatch issue.
Signed-off-by: Arushi Singhal
---
changes in v2
-done the changes according to the current tree
drivers/staging/iio/cdc/ad7746.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio
Remove the extra parenthesis remove the checkpatch issue.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/cdc/ad7746.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +-
d
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/media/omap4iss/iss_csi2.c| 2 +-
drivers/staging/media/omap4iss/iss_ipipe.c | 2 +-
drivers/staging
Use managed resource functions devm_request_irq instead of request_irq.
Remove corresponding calls to free_irq in the probe.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers
the devices global data.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/meter/ade7759.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/iio/meter/ade7759.c
b/drivers/staging/iio/meter/ade7759.c
index 0b65f1847510..514a4f6bb8f9 100644
--- a/driv
Simplify function returns by merging assignment and return.
Signed-off-by: Arushi Singhal
---
changes in v2
*correct the error.
drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 8 ++--
.../media/atomisp/pci/atomisp2/css2400/runtime/bufq/src/bufq.c | 10 --
2 files
Simplify function returns by merging assignment and return.
Signed-off-by: Arushi Singhal
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 8 ++--
.../media/atomisp/pci/atomisp2/css2400/runtime/bufq/src/bufq.c| 7 ++-
2 files changed, 4 insertions(+), 11
Simplify function returns by merging assignment and return.
Signed-off-by: Arushi Singhal
---
drivers/staging/greybus/loopback.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c
b/drivers/staging/greybus/loopback.c
index aaf29a5fac83
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v3
- change the subject.
- remove extra parenthesis.
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
d
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v2
-Remove unnecessary parenthesis.
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
drivers/staging
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v2
-Remove unnecessary parenthesis
drivers/staging/media/omap4iss/iss_csi2.c| 2 +-
drivers/staging/media/om
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v2
-remove the unnecessary parenthesis.
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
Remove the extra parenthesis remove the checkpatch issue.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/cdc/ad7746.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index
Remove the code which do not have any value.
Signed-off-by: Arushi Singhal
---
drivers/staging/lustre/lnet/lnet/net_fault.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c
b/drivers/staging/lustre/lnet/lnet/net_fault.c
index 18183cbb9859
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'.
Signed-off-by: Arushi Singhal
---
changes in v2
- change the commit subject
Delete tabs and add spaces to align the code to fix the
checkpatch issue: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
changes in v3
- make the commit message more clear.
drivers/staging/speakup/speakup_apollo.c | 2 +-
drivers/stagi
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
changes in v2
- change the commit message.
drivers/staging/speakup/speakup_apollo.c | 2 +-
drivers/staging/speakup/speakup_decext.c | 4 ++--
2 files changed, 3 insert
Moved the contents of the header(tsl2x7x.h) into the source file
tsl2x7x_core.c with the exception of the platform data struct which is
supposed to be used from somewhere else other than the driver.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/light/tsl2x7x.h | 57
Moved the contents of the header(ad7746.h) into the source file
ad7746.c with the exception of the platform data struct which is
supposed to be used from somewhere else other than the driver.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/cdc/ad7746.c | 5 +
drivers/staging/iio/cdc
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v2
-improve the code.
drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +-
drivers/staging/fbtft/fb_ili9163.c
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v2
-remove/correct the wrong code.
drivers/staging/iio/cdc/ad7150.c | 2 +-
drivers/staging/iio/cdc/ad7746.
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v2
- remove the unnecessary parenthesis.
- removethe wrong changes.
drivers/staging/lustre/lnet/klnds/s
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v2
- remove the unnecessary parenthesis.
drivers/staging/rts5208/rtsx_chip.c | 4 ++--
1 file changed, 2 insertions
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v2
-change the cc list
drivers/staging/iio/adc/ad7816.c | 2 +-
drivers/staging/iio/cdc/ad7150.c | 2 +-
d
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
.../staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 12 ++--
.../media/atomisp/pci/atomisp2/atomisp_compat_css20.c
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/media/omap4iss/iss_csi2.c| 2 +-
drivers/staging/media/omap4iss/iss_ipipe.c | 2 +-
drivers/staging
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +-
d
Replace a bit shift by a use of BIT in media driver.
Arushi Singhal (3):
staging: media: Replace a bit shift by a use of BIT.
staging: media: davinci_vpfe: Replace a bit shift by a use of BIT.
staging: media: omap4iss: Replace a bit shift by a use of BIT.
.../media/atomisp/pci/atomisp2
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/octeon/ethernet-tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/adc/ad7816.c | 2 +-
drivers/staging/iio/cdc/ad7150.c | 2 +-
drivers/staging/iio/cdc/ad7746.
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/s
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +-
drivers/staging/lustre/lnet/klnds/socklnd/sockln
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 4 ++--
drivers/staging/fbtft/fb_ili9163.c | 2 +-
drivers/staging/fbtft/fb_ili
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/rts5208/rtsx_chip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/r
This patch removes typedefs from enum and renames it from "typedef enum
_spolarity_t" to "enum spolarity" as per kernel coding standards."
Signed-off-by: Arushi Singhal
---
changes in v2
-change the subject and commit message of PATCH.
drivers/staging/sm750fb/ddk750_m
This patch removes typedefs from struct and renames it from "typedef
struct _mode_parameter_t" to "struct mode_parameter" as per kernel
coding standards."
Signed-off-by: Arushi Singhal
---
changes in v2
-change the subject and commit message of PATCH.
drivers/staging/
Typedefs are removed in sm750fb driver.
Arushi Singhal (2):
staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t"
staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"
drivers/staging/sm750fb/ddk750_mode.c | 8 +---
drivers/staging/s
The contents of ade7759.h are only used in ade7759.c.
Move the header contents to the implemtation file,
and delete the header file.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/meter/ade7759.c | 52 ++-
drivers/staging/iio/meter/ade7759.h | 54
ces global data.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/meter/ade7759.c | 4 ++--
drivers/staging/iio/meter/ade7759.h | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/meter/ade7759.c
b/drivers/staging/iio/meter/ade7759.c
index 944ee3401
Patchseries of IIO coding tasks
Arushi Singhal (2):
staging: ad7759: Replace mlock with driver private lock
staging: iio: ade7759: Move header content to implementation file
drivers/staging/iio/meter/ade7759.c | 56 +--
drivers/staging/iio/meter/ade7759.h
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 2 +-
drivers/staging/speakup/selection.c | 2 +-
drivers/staging/speakup/serialio.c | 2 +-
drivers/staging/speakup/speaku
Unnecessary parentheses are removed to improve readability.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/kobjects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/kobjects.c
b/drivers/staging/speakup/kobjects.c
index afb61e153592
Moved logical OR operator to previous line to fix the following
checkpatch issue:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_apollo.c | 2 +-
drivers/staging/speakup/speakup_decext.c | 4 ++--
2 files changed, 3 insertions
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/fakekey.c | 2 +-
Fixed the checkpatch.pl issues like:
CHECK: spaces preferred around that '&' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
CHECK: spaces preferred around that '-' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
etc.
Signed-
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/ma
This patch fixes the checks reported by checkpatch.pl
for braces {} should be used on all arms of this statement.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 35 +++-
drivers/staging/speakup/speakup_decext.c | 6 +++---
drivers
Moved logical operator to previous line to fix the following
checkpatch issue:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/selection.c | 2 +
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/stagi
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (11):
staging: speakup: Moved logical to previous line.
staging: speakup: Remove multiple assignments
staging: speakup: Simplify "NULL" comparisons
staging: speakup: fixes braces {}
This patch removes typedefs from enum and renames them as
per kernel coding standards.
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_mode.h | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.h
b/drivers/staging
This patch removes typedefs from structure and renames them as
per kernel coding standards.
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_mode.c | 8 +---
drivers/staging/sm750fb/ddk750_mode.h | 8 +++-
drivers/staging/sm750fb/sm750_hw.c| 2 +-
3 files changed, 9
Typedefs are removed in sm750fb driver.
Arushi Singhal (2):
staging: sm750fb: Remove typedefs from struct
staging: sm750fb: Remove typedefs from enum
drivers/staging/sm750fb/ddk750_mode.c | 8 +---
drivers/staging/sm750fb/ddk750_mode.h | 19 ---
drivers/staging/sm750fb
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_apollo.c | 2 +-
drivers/staging/speakup/speakup_decext.c | 4 ++--
2 files changed, 3 insertions
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 2 +-
drivers/staging/speakup/selection.c | 2 +-
drivers/staging/speakup/serialio.c | 2 +-
drivers/staging/speakup/speaku
Unnecessary parentheses are removed to improve readability.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/kobjects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/kobjects.c
b/drivers/staging/speakup/kobjects.c
index afb61e153592
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/fakekey.c | 2 +-
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (4):
staging: speakup: Removed Unnecessary parentheses.
staging: speakup: Simplify the NULL comparisons
staging: speakup: Match alignment with open parenthesis.
staging: speakup: Fix alignment
Fixed the checkpatch.pl issues like:
CHECK: spaces preferred around that '&' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
CHECK: spaces preferred around that '-' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
etc.
Signed-
1 - 100 of 311 matches
Mail list logo