Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-11-05 Thread Arun KS
On 2018-11-06 03:14, Andrew Morton wrote: On Mon, 05 Nov 2018 15:12:27 +0530 Arun KS wrote: On 2018-10-22 16:03, Arun KS wrote: > On 2018-10-19 13:37, Michal Hocko wrote: >> On Thu 18-10-18 19:18:25, Andrew Morton wrote: >> [...] >>> So this patch needs more work, yes

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-11-05 Thread Arun KS
On 2018-10-22 16:03, Arun KS wrote: On 2018-10-19 13:37, Michal Hocko wrote: On Thu 18-10-18 19:18:25, Andrew Morton wrote: [...] So this patch needs more work, yes? Yes, I've talked to Arun (he is offline until next week) offlist and he will play with this some more. Conv

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-22 Thread Arun KS
On 2018-10-19 13:37, Michal Hocko wrote: On Thu 18-10-18 19:18:25, Andrew Morton wrote: [...] So this patch needs more work, yes? Yes, I've talked to Arun (he is offline until next week) offlist and he will play with this some more. Converted totalhigh_pages, totalram_pages and zone->managed

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-10 Thread Arun KS
On 2018-10-10 23:03, Michal Hocko wrote: On Wed 10-10-18 22:26:41, Arun KS wrote: On 2018-10-10 21:00, Vlastimil Babka wrote: > On 10/5/18 10:10 AM, Arun KS wrote: > > When free pages are done with higher order, time spend on > > coalescing pages by buddy allocator can b

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-10 Thread Arun KS
On 2018-10-10 21:00, Vlastimil Babka wrote: On 10/5/18 10:10 AM, Arun KS wrote: When free pages are done with higher order, time spend on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from 50-60 ms to less

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-10 Thread Arun KS
On 2018-10-10 13:37, Oscar Salvador wrote: On Fri, Oct 05, 2018 at 01:40:05PM +0530, Arun KS wrote: When free pages are done with higher order, time spend on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-09 Thread Arun KS
On 2018-10-09 14:59, Michal Hocko wrote: On Fri 05-10-18 13:40:05, Arun KS wrote: When free pages are done with higher order, time spend on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from 50-60 ms to less

[PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-05 Thread Arun KS
online callback to align with the change. Signed-off-by: Arun KS --- Changes since v4: - As suggested by Michal Hocko, - Simplify logic in online_pages_block() by using get_order(). - Seperate out removal of prefetch from __free_pages_core(). Changes since v3: - Renamed _free_pages_boot_core

[PATCH v5 2/2] mm/page_alloc: remove software prefetching in __free_pages_core

2018-10-05 Thread Arun KS
They not only increase the code footprint, they actually make things slower rather than faster. Remove them as contemporary hardware doesn't need any hint. Suggested-by: Dan Williams Signed-off-by: Arun KS --- mm/page_alloc.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-)

Re: [PATCH v4] memory_hotplug: Free pages as higher order

2018-10-05 Thread Arun KS
On 2018-10-04 20:21, Michal Hocko wrote: On Wed 03-10-18 19:09:39, Arun KS wrote: [...] +static int online_pages_blocks(unsigned long start, unsigned long nr_pages) +{ + unsigned long end = start + nr_pages; + int order, ret, onlined_pages = 0; + + while (start <

[PATCH v4] memory_hotplug: Free pages as higher order

2018-10-03 Thread Arun KS
online callback to align with the change. Also remove prefetch from __free_pages_core(). Signed-off-by: Arun KS --- Changes since v3: - renamed _free_pages_boot_core -> __free_pages_core. - removed prefetch from __free_pages_core. - removed xen_online_page(). Changes since v2: - reuse code f

Re: [PATCH v3] memory_hotplug: Free pages as higher order

2018-09-27 Thread Arun KS
On 2018-09-27 12:41, Juergen Gross wrote: On 27/09/18 08:58, Arun KS wrote: When free pages are done with higher order, time spend on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from 50-60 ms to less than

Re: [PATCH v3] memory_hotplug: Free pages as higher order

2018-09-27 Thread Arun KS
On 2018-09-27 12:39, Oscar Salvador wrote: On Thu, Sep 27, 2018 at 12:28:50PM +0530, Arun KS wrote: + __free_pages_boot_core(page, order); Hi, I am not sure, but if we are going to use that function from the memory-hotplug code, we might want to rename that function to something more

[PATCH v3] memory_hotplug: Free pages as higher order

2018-09-27 Thread Arun KS
online callback to align with the change. Signed-off-by: Arun KS --- Changes since v2: reuse code from __free_pages_boot_core() Changes since v1: - Removed prefetch() Changes since RFC: - Rebase. - As suggested by Michal Hocko remove pages_per_block. - Modifed external providers of

Re: [PATCH v2] memory_hotplug: Free pages as higher order

2018-09-26 Thread Arun KS
On 2018-09-25 23:48, Michal Hocko wrote: On Tue 25-09-18 11:59:09, Vlastimil Babka wrote: [...] This seems like almost complete copy of __free_pages_boot_core(), could you do some code reuse instead? I think Michal Hocko also suggested that. Yes, please try to reuse as much code as possible

[PATCH v2] memory_hotplug: Free pages as higher order

2018-09-24 Thread Arun KS
online callback to align with the change. Signed-off-by: Arun KS --- Changes since v1: - Removed prefetch() Changes since RFC: - Rebase. - As suggested by Michal Hocko remove pages_per_block. - Modifed external providers of online_page_callback. v1: https://lore.kernel.org/patchwork/patch

Re: [PATCH] memory_hotplug: Free pages as higher order

2018-09-24 Thread Arun KS
On 2018-09-21 21:12, Dan Williams wrote: On Fri, Sep 21, 2018 at 2:40 AM Arun KS wrote: When free pages are done with higher order, time spend on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from 50-60 ms

[PATCH] memory_hotplug: Free pages as higher order

2018-09-21 Thread Arun KS
online callback to align with the change. Signed-off-by: Arun KS --- Changes since RFC: - Rebase. - As suggested by Michal Hocko remove pages_per_block. - Modifed external providers of online_page_callback. RFC: https://lore.kernel.org/patchwork/patch/984754/ --- drivers/hv/hv_balloon.c