Declare non-exported functions as static.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
b/drivers/staging/lustre/lustre
Include the header with declarations of variables that are shared between
several sources in ptlrpc module into the appropriate source files.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 2 ++
drivers/staging/lustre/lustre/ptlrpc/wiretest.c | 2 ++
2
This patch moves declarations of variables used in several files
across the ptlrpc module from source files to a local header.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c| 1 -
drivers/staging/lustre/lustre/ptlrpc/nrs.c | 1 -
drivers
Andreas Dilger for the review.
Anton Gerasimov (3):
staging: lustre: moved extern declarations to a header
staging: lustre: include header with local ptlrpc declarations
staging: lustre: make non-exported functions static
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c| 1 -
drivers
Declare non-exported functions in pack_generic.c as static.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
b/drivers/staging
Include the header with declaations of variables that are shared between
several sources in ptlrpc module into the appropriate source files.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 2 ++
drivers/staging/lustre/lustre/ptlrpc/wiretest.c | 2 ++
2 files
This patch adds declarations for variables used in several files
across the ptlrpc module to the local header.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/lustre/lustre/ptlrpc
This series of patches eliminates some sparse warnings concerning
static variables in lustre rtlrpc module where it seemed reasonable.
Symbols that are really local to a source file are made static and
declarations added to a header for symbols that are shared between
source files.
Anton
Declare non-exported functions in pack_generic.c as static.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
b/drivers/staging
Include the header with declaations of variables that are shared between
several sources in ptlrpc module into the appropriate source files.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 2 ++
drivers/staging/lustre/lustre/ptlrpc/wiretest.c | 2 ++
2 files
This patch adds declarations for variables used in several files
across the ptlrpc module to the local header.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/lustre/lustre/ptlrpc
This series of patches eliminates some sparse warnings concerning
static variables in lustre rtlrpc module where it seemed reasonable.
Symbols that are really local to a source file are made static and
declarations added to a header for symbols that are shared between
source files.
Anton
Typo in a comment to register write corrected.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fb_ili9320.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_ili9320.c
b/drivers/staging/fbtft/fb_ili9320.c
index 0301bd5..ef4fa6b 100644
--- a
Split long function declarations, function calls, comments etc.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fb_ra8875.c| 13
drivers/staging/fbtft/fb_tls8204.c | 11 +++---
drivers/staging/fbtft/fbtft_device.c | 3 ++-
drivers/staging/fbtft/flexfb.c
Eliminated code duplication when searching for a display.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fbtft_device.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
index e5aa533
Indentation with spaces fixed.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fb_tinylcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_tinylcd.c
b/drivers/staging/fbtft/fb_tinylcd.c
index c0b1a33..8ab177f 100644
--- a/drivers/staging
Thanks for your reviews!
Changes were rearranged in a more reasonable way.
Anton Gerasimov (10):
staging: fbtft: split long strings
staging: fbtft: put spaces around assignment operators
staging: fbtft: replace spaces with tabs
staging: fbtft: make module descriptions greppable
staging
Put spaces around assignment operators for readability.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/flexfb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
index 5c813fc..3c76774 100644
--- a
Added spaces after commas in initialization sequences and removed
unnecessary line continuations.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/flexfb.c | 116 -
1 file changed, 58 insertions(+), 58 deletions(-)
diff --git a/drivers/staging
Removed unnecessary line continuations in several lines.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fbtft_device.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft
Split module description strings are merged for searchability.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fbtft_device.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
index
The patch removes spaces before tabs so that checkpatch.pl is content.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fbtft_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
Placed comments to register writes before the function calls to
eliminate long strings and make code more readable.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fb_ili9320.c | 118 +++--
1 file changed, 88 insertions(+), 30 deletions(-)
diff --git a
Added spaces after commas in initialization sequences.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/flexfb.c | 116 -
1 file changed, 58 insertions(+), 58 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft
Placed comments to register writes before the function call to
eliminate long strings and make code more readable.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fb_ili9320.c | 118 +++--
1 file changed, 88 insertions(+), 30 deletions(-)
diff --git a
Split several long lines into shorter ones to fit in 80 characters.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fb_ra8875.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ra8875.c
b/drivers/staging/fbtft/fb_ra8875.c
index
Eliminated code duplication when searching for a display.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fbtft_device.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
index e5aa533
Removed unnecessary line continuations in several lines.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fbtft_device.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft
The patch removes spaces before tabs so that checkpatch.pl is content.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fbtft_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
Indentation with spaces fixed.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fb_tinylcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_tinylcd.c
b/drivers/staging/fbtft/fb_tinylcd.c
index c0b1a33..8ab177f 100644
--- a/drivers/staging
Comments are rearranged for readability, one long function call is
split into several lines.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fb_tls8204.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fb_tls8204.c
b/drivers
Split module description strings are merged for searchability.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fbtft_device.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
index
Broken long initialization into two lines for readability.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fbtft_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
index c19d34d
Several style fixes for fbtft drivers.
Had to split some drivers so the numeration differs from that of PATCH v1
Anton Gerasimov (11):
staging: fbtft: split long function calls in flexfb.c
staging: fbtft: style fix on fb_tls8204.c
staging: fbtft: style fix on fb_tinylcd.c
staging: fbtft
The patch splits long function calls and declarations into several shorter
lines.
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/flexfb.c | 45 +-
1 file changed, 31 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fb_ili9320.c | 118 +++--
1 file changed, 88 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ili9320.c
b/drivers/staging/fbtft/fb_ili9320.c
index 3a02edd..0301bd5 100644
--- a/drivers
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fb_ra8875.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ra8875.c
b/drivers/staging/fbtft/fb_ra8875.c
index 2c4d4dc..54bc566 100644
--- a/drivers/staging/fbtft/fb_ra8875.c
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fbtft_device.c | 54 +---
1 file changed, 25 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
index df6cd77..211d504 100644
--- a
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fb_tinylcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_tinylcd.c
b/drivers/staging/fbtft/fb_tinylcd.c
index c0b1a33..8ab177f 100644
--- a/drivers/staging/fbtft/fb_tinylcd.c
+++ b/drivers
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/flexfb.c | 281 ++---
1 file changed, 209 insertions(+), 72 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
index ca39fe9..82c96fc 100644
--- a/drivers/staging
Signed-off-by: Anton Gerasimov
---
drivers/staging/fbtft/fb_tls8204.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fb_tls8204.c
b/drivers/staging/fbtft/fb_tls8204.c
index 5ea73b5..3253a25 100644
--- a/drivers/staging/fbtft/fb_tls8204.c
Several style patches (mostly breaking long lines and deleting line
continuations).
Anton Gerasimov (6):
staging: fbtft: style fix on flexfb.c
staging: fbtft: style fix on fb_tls8204.c
staging: fbtft: style fix on fb_tinylcd.c
staging: fbtft: style fix on fbtft_device.c
staging: fbtft
42 matches
Mail list logo