Re: [PATCH] Staging: rtl8192u: fix sparse warnings in r8192U_core.c

On Thu, Aug 07, 2014 at 10:10:47AM +0530, A Raghavendra Rao wrote: > Signed-off-by: A Raghavendra Rao This looks very similar to what I submitted on July 31st. At this time Greg had additional comments which led to a quite different patchset (though its review is not completed yet), you may find

[PATCH 2/6] staging: rtl8192u: remove define always set USE_ONE_PIPE

Also remove the code previously under #ifndef USE_ONE_PIPE. Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/rtl8192u/Makefile | 1 - drivers/staging/rtl8192u/r8192U_core.c | 19 --- 2 files changed, 20 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 6/6] staging: rtl8192u: remove misc. unused defines

Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/rtl8192u/r8192U_core.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 0f59605..4f3fa35 100644 --- a/drivers/staging

[PATCH 4/6] staging: rtl8192u: remove unused define USB_RX_AGGREGATION_SUPPORT

Also remove related unreachable code. Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/rtl8192u/Makefile | 1 - drivers/staging/rtl8192u/r8192U_core.c | 174 +++-- 2 files changed, 11 insertions(+), 164 deletions(-) diff --git a/drivers/staging

[PATCH 3/6] staging: rtl8192u: remove unused define USB_TX_DRIVER_AGGREGATION_ENABLE

Also remove the unreachable code. Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/rtl8192u/Makefile | 1 - drivers/staging/rtl8192u/r8192U_core.c | 250 + 2 files changed, 4 insertions(+), 247 deletions(-) diff --git a/drivers/staging

[PATCH 5/6] staging: rtl8192u: remove unused define LOOP_TEST

Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/rtl8192u/r8192U_core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index bd15651..0f59605 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c

[PATCH 1/6] staging: rtl8192u: remove unused define DEBUG_EPROM

Also remove the code now unreachable. Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/rtl8192u/r8192U_core.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 7640386..ccf00f7

Re: [PATCH 1/1] staging: rtl8192u: remove unselectable options DEBUG_*, USE_ONE_PIPE, USB_RX_AGGREGATION_SUPPORT, USB_TX_DRIVER_AGGREGATION_ENABLE

On Fri, Aug 01, 2014 at 08:54:07AM -0700, Greg KH wrote: > On Tue, Jun 24, 2014 at 03:52:05PM +0200, Antoine Schweitzer-Chaput wrote: > > The code which was only reachable using these options is also removed. > > > > Signed-off-by: Antoine Schweitzer-Chaput > > --- &g

[PATCH 1/1] staging: rtl8192u: remove unselectable options DEBUG_*, USE_ONE_PIPE, USB_RX_AGGREGATION_SUPPORT, USB_TX_DRIVER_AGGREGATION_ENABLE

The code which was only reachable using these options is also removed. Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/rtl8192u/Makefile | 3 - drivers/staging/rtl8192u/r8192U_core.c | 482 ++--- 2 files changed, 16 insertions(+), 469 deletions

Re: [PATCH 2/2] staging: rlt8192u: conditional compilation in r8192U_core.c

On Fri, Aug 01, 2014 at 12:59:43AM -0700, Greg KH wrote: > > /* this is only for debug */ > > +#ifdef DEBUG_EPROM > > how can this ever be set? If no one sets it, just remove the code > entirely please. I guess it's supposed to be set manually in the code (there's a large list around l.60). >

Re: [PATCH 1/1] staging: rtl8192u: mark some functions as static.

On Wed, Jul 30, 2014 at 05:06:41PM -0700, Greg Kroah-Hartman wrote: > On Mon, Jul 28, 2014 at 05:52:46PM +0200, Antoine Schweitzer-Chaput wrote: > > Some functions defined in r8192U_core.c and only used locally are marked as > > static. > > This fixes some warn

[PATCH 2/2] staging: rlt8192u: conditional compilation in r8192U_core.c

: Antoine Schweitzer-Chaput --- drivers/staging/rtl8192u/r8192U_core.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 4536a87..b6718c0 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c

[PATCH 1/2] staging: rlt8192u: mark some functions as static

Some functions defined in r8192U_core.c and only used locally are marked as static. This fixes some warnings issues by sparse. Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/rtl8192u/r8192U_core.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 1/1] staging: rtl8192u: mark some functions as static.

Some functions defined in r8192U_core.c and only used locally are marked as static. This fixes some warnings issued by sparse. Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/rtl8192u/r8192U_core.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a

[PATCH] Staging: imx-drm: Fix some lines over 80 characters

Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 6 -- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c b/drivers/staging/imx-drm/ipu-v3

[PATCH 1/1] Fix some lines over 80 characters in imx-drm staging driver

>From 73eb48f2b376c56f0a354ea0e6c2c71972aaffae Mon Sep 17 00:00:00 2001 From: Antoine Schweitzer-Chaput Date: Wed, 16 Apr 2014 09:59:26 +0200 Subject: [PATCH 1/1] Fix some lines over 80 characters in imx-drm staging driver Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/imx-