[PATCH staging] rtl8188eu : BIT() macro cleanup

Use the BIT(x) macro directly instead using multiple BITX defines. Signed-off-by: Anish Bhatt --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 48 +-- drivers/staging/rtl8188eu/hal/bb_cfg.c | 2 +- drivers/staging/rtl8188eu/hal/odm.c| 24 +- drivers

[PATCH staging] rtl8192u: BIT() macro cleanup

Use the BIT(x) macro directly instead using multiple BITX defines. Signed-off-by: Anish Bhatt --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 10 +- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 49 ++-- drivers/staging/rtl8192u/r8192U.h| 95

[PATCH staging v2 2/2] wilc1000 : Use BIT() macro where possible

Replace (1 << x) by BIT(x) as recommended by checkpatch.pl Signed-off-by: Anish Bhatt --- drivers/staging/wilc1000/host_interface.c | 4 +- drivers/staging/wilc1000/host_interface.h | 38 +++ drivers/staging/wilc1000/linux_wlan_common.h | 8 ++-- drivers/staging/wi

[PATCH staging v2 0/2] wilc1000 code cleanups

Patchset removes extraneous macro defines and cleans some code as recommended by checkpatch.pl v2 : Do not change code formatting when removing comment delimiters Anish Bhatt (2): wilc1000 : Remove leftover comment delimiters wilc1000 : Use BIT() macro where possible drivers/staging

[PATCH staging v2 1/2] wilc1000 : Remove leftover comment delimiters

Remove leftover comment delimiters that were only partially removed in a previous cleanup. Fixes : c3ca63728ad8 ("staging: wilc1000: remove useless comment") Signed-off-by: Anish Bhatt --- drivers/staging/wilc1000/wilc_wlan.c | 13 ++--- 1 file changed, 6 insertions(+), 7

Re: [PATCH staging 2/3] wilc1000 : Remove leftover comment delimiters

On Mon, Sep 28, 2015 at 5:42 PM, Greg KH wrote: > On Fri, Sep 25, 2015 at 12:45:16AM -0700, Anish Bhatt wrote: >> Remove leftover comment delimiters that were only partially removed >> in a previous cleanup. > > You also changed code formatting, which isn't ok to do i

Re: [PATCH staging 3/3] wilc1000 : Use BIT() macro where possible

On Fri, Sep 25, 2015 at 10:47 PM, Dan Carpenter wrote: > On Fri, Sep 25, 2015 at 09:14:29AM -0700, Anish Bhatt wrote: >> On Fri, Sep 25, 2015 at 3:50 AM, Dan Carpenter >> wrote: >> > On Fri, Sep 25, 2015 at 12:45:17AM -0700, Anish Bhatt wrote: >> >>

Re: [PATCH staging 3/3] wilc1000 : Use BIT() macro where possible

On Fri, Sep 25, 2015 at 3:50 AM, Dan Carpenter wrote: > On Fri, Sep 25, 2015 at 12:45:17AM -0700, Anish Bhatt wrote: >> @@ -1672,11 +1673,11 @@ static int wilc_wlan_stop(void) >> } >> >> } while (timeout); >> - reg = ((1 << 0) | (

[PATCH staging 2/3] wilc1000 : Remove leftover comment delimiters

Remove leftover comment delimiters that were only partially removed in a previous cleanup. Fixes : c3ca63728ad8 ("staging: wilc1000: remove useless comment") Signed-off-by: Anish Bhatt --- drivers/staging/wilc1000/wilc_wlan.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[PATCH staging 0/3] wilc1000 code cleanups

Patchset removes extraneous macro defines and cleans some code as recommended by checkpatch.pl Anish Bhatt (3): wilc1000 : Remove unused macro definitions wilc1000 : Remove leftover comment delimiters wilc1000 : Use BIT() macro where possible drivers/staging/wilc1000/host_interface.c

[PATCH staging 3/3] wilc1000 : Use BIT() macro where possible

Replace (1 << x) by BIT(x) as recommended by checkpatch.pl Signed-off-by: Anish Bhatt --- drivers/staging/wilc1000/host_interface.c | 4 +- drivers/staging/wilc1000/host_interface.h | 38 +++ drivers/staging/wilc1000/linux_wlan_common.h | 8 ++-- drivers/staging/wi

[PATCH staging 1/3] wilc1000 : Remove unused macro definitions

Remove all unused TCP_*_MASK macro definitions Signed-off-by: Anish Bhatt --- drivers/staging/wilc1000/wilc_wlan.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index 0a930ec..bf7e900 100644 --- a/drivers

[PATCH v3][RESEND] staging/rtl8188eu : Remove duplicated BIT() definitions

The BIT() macro is already defined in bitops.h, remove duplicate definitions. Users of BIT() macro are expecting unsigned int/u32, so add typecasts where this creates a build warning. Signed-off-by: Anish Bhatt --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 7 +-- drivers/staging

Re: [PATCH v3 3/4] staging/rtl8188eu : Remove duplicated BIT() definitions

On Fri, Sep 11, 2015 at 7:42 PM, Greg KH wrote: > On Wed, Sep 09, 2015 at 03:57:09PM -0700, Anish Bhatt wrote: >> The BIT() macro is already defined in bitops.h, remove duplicate >> definitions. Users of BIT() macro are expecting unsigned int/u32, so >> add typecasts where

[PATCH v3 4/4] staging/rtl8712 : Remove duplicated BIT() definitions

The BIT() macro is already defined in bitops.h, remove duplicate definitions. Signed-off-by: Anish Bhatt --- drivers/staging/rtl8712/osdep_service.h | 4 drivers/staging/rtl8712/wifi.h | 5 - 2 files changed, 9 deletions(-) diff --git a/drivers/staging/rtl8712/osdep_service.h

[PATCH v3 2/4] staging/rtl8712 : Remove unused macro definitions.

WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN are unused, duplicate or unnecessary, remove. Signed-off-by: Anish Bhatt --- drivers/staging/rtl8712/wifi.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging/rtl8712/wifi.h index 17f5131

[PATCH v3 3/4] staging/rtl8188eu : Remove duplicated BIT() definitions

The BIT() macro is already defined in bitops.h, remove duplicate definitions. Users of BIT() macro are expecting unsigned int/u32, so add typecasts where this creates a build warning. Signed-off-by: Anish Bhatt --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 7 +-- drivers/staging

[PATCH v3 1/4] staging/rtl8188eu : Remove unused macro definitions.

WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN are unused, duplicate or unnecessary, remove. Signed-off-by: Anish Bhatt --- drivers/staging/rtl8188eu/include/wifi.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu

[PATCH v3 0/4] Minor fixes for rtl8188eu/rtl8712

atch Anish Bhatt (4): staging/rtl8188eu : Remove unused macro definitions. staging/rtl8712 : Remove unused macro definitions. staging/rtl8188eu : Remove duplicated BIT() definitions staging/rtl8712 : Remove duplicated BIT() definitions drivers/staging/rtl8188eu/core/rtw_mlme_ext.c

[PATCH v2 5/5] staging/wilc100 : Use BIT() macro where possible

Replace (1 << x) by BIT(x) as recommended by checkpatch.pl. Fix any resultant build warnings. Signed-off-by: Anish Bhatt --- drivers/staging/wilc1000/wilc_wlan.c | 72 ++-- 1 file changed, 35 insertions(+), 37 deletions(-) diff --git a/drivers/staging/wi

[PATCH v2 3/5] staging/rtl* Remove unused macro definitions.

WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN are unused, duplicate or unnecessary, remove. Signed-off-by: Anish Bhatt --- drivers/staging/rtl8188eu/include/wifi.h | 5 - drivers/staging/rtl8712/wifi.h | 4 2 files changed, 9 deletions(-) diff --git a/drivers/staging

[PATCH v2 1/5] staging/wlan-ng : Prefer ether_addr* functions over mem*

Replace memcmp/memcpy(... ETH_ALEN) with ether_addr_copy()/ ether_addr_equal_unaligned() Signed-off-by: Anish Bhatt --- drivers/staging/wlan-ng/p80211conv.c | 22 +++--- drivers/staging/wlan-ng/p80211netdev.c | 2 +- drivers/staging/wlan-ng/prism2sta.c| 16

[PATCH v2 4/5] staging/rtl* Remove duplicated BIT() definitions

The BIT() macro is already defined in bitops.h, remove duplicate definitions. Fix any resultant build or checkpatch warnings. Signed-off-by: Anish Bhatt --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 7 +-- drivers/staging/rtl8188eu/core/rtw_wlan_util.c| 6 -- drivers

[PATCH v2 0/5] Minor fixes for wlan-ng/rtl/wilc100 drivers

Patchset covers checkpatch recommendations and code cleanup of multiple duplicate or unncessary cpp defines. v2 : Rebase on top for staging-testing instead of master Silence build warnings Anish Bhatt (5): staging/wlan-ng : Prefer ether_addr* functions over mem* staging/wlan-ng

[PATCH v2 2/5] staging/wlan-ng : Remove duplicated defines from p80211

ETH_ALEN/ETH_HLEN can be used instead of WLAN_ETHADDR_LEN & WLAN_ETHHDR_LEN, replace directly or use eth_addr* functions where applicable. Signed-off-by: Anish Bhatt --- drivers/staging/wlan-ng/p80211conv.c | 50 ++-- drivers/staging/wlan-ng/p80211conv.h

[PATCH 5/5] staging/wilc100 : Use BIT() macro where possible

Replace (1 << x) by BIT(x) as recommended by checkpatch.pl Signed-off-by: Anish Bhatt --- drivers/staging/wilc1000/wilc_wlan.c | 64 +--- 1 file changed, 31 insertions(+), 33 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/s

[PATCH 3/5] staging/rtl* Remove unused macro definitions.

WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN are unused, duplicate or unnecessary, remove. Signed-off-by: Anish Bhatt --- drivers/staging/rtl8188eu/include/wifi.h | 5 - drivers/staging/rtl8712/wifi.h | 4 2 files changed, 9 deletions(-) diff --git a/drivers/staging

[PATCH 2/5] staging/wlan-ng : Remove duplicated defines from p80211

ETH_ALEN/ETH_HLEN can be used instead of WLAN_ETHADDR_LEN & WLAN_ETHHDR_LEN, replace directly or use eth_addr* functions where applicable. Signed-off-by: Anish Bhatt --- drivers/staging/wlan-ng/p80211conv.c | 50 ++-- drivers/staging/wlan-ng/p80211conv.h

[PATCH 1/5] staging/wlan-ng : Prefer ether_addr* functions over mem*

Replace memcmp/memcpy(... ETH_ALEN) with ether_addr_copy()/ ether_addr_equal_unaligned() Signed-off-by: Anish Bhatt --- drivers/staging/wlan-ng/p80211conv.c | 22 +++--- drivers/staging/wlan-ng/p80211netdev.c | 2 +- drivers/staging/wlan-ng/prism2sta.c| 16

[PATCH 4/5] staging/rtl* Remove duplicated BIT() definitions

The BIT() macro is already defined in bitops.h, remove duplicate definitions. Signed-off-by: Anish Bhatt --- drivers/staging/rtl8188eu/include/rtl8188e_spec.h | 4 drivers/staging/rtl8188eu/include/wifi.h | 7 --- drivers/staging/rtl8712/osdep_service.h | 4

[PATCH 0/5] Minor fixes for wlan-ng/rtl/wilc100 drivers

Patchset covers checkpatch recommendations and code cleanup of multiple duplicate or unncessary cpp defines. Anish Bhatt (5): staging/wlan-ng : Prefer ether_addr* functions over mem* staging/wlan-ng : Remove duplicated defines from p80211 staging/rtl* Remove unused macro definitions

[PATCH v2 5/5] staging/fbtft : Add missing whitespace around operators

Add blank spaces around operators where recommended by checkpatch.pl Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_hx8340bn.c | 2 +- drivers/staging/fbtft/fb_hx8347d.c | 2 +- drivers/staging/fbtft/fb_ili9163.c | 4 ++-- drivers/staging/fbtft/fb_ili9320.c | 4 ++-- drivers

[PATCH v2 3/5] staging/fbtft : Remove unicode characters

Remove stray unicode quotes around name Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c index bfe01f0..1eba1a0 100644 --- a

[PATCH v2 4/5] staging/fbtft : Fix multiple/missing blank line issues

Remove or add blank lines as recommended by checkpatch.pl Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_agm1264k-fl.c | 3 +-- drivers/staging/fbtft/fb_bd663474.c| 1 + drivers/staging/fbtft/fb_hx8340bn.c| 4 +--- drivers/staging/fbtft/fb_hx8347d.c | 3 +-- drivers/staging

[PATCH v2 2/5] staging/fbtft : Remove repeated set_addr_win debug messages

fbtft_par_dbg(DEBUG_SET_ADDR_WIN.. ) is repeated in every set_addr_win() handler, this could be replicated by using the kernel function tracer instead. Signed-off-by: Anish Bhatt Suggested-by: Greg KH --- drivers/staging/fbtft/fb_agm1264k-fl.c | 4 drivers/staging/fbtft/fb_bd663474.c

[PATCH v2 0/5] staging/fbtft checkpatch and other fixes

fixes into one patch per pattern. * Add missing changelog text for BIT() macro patch. * FSF address patch sent out as individual patch. * Refactor into one patch per type of fix. Anish Bhatt (5): staging/fbtft : Use BIT() macro when possible staging/fbtft : Remove repeated set_addr_win debug

[PATCH v2 1/5] staging/fbtft : Use BIT() macro when possible

Based on checkpatch.pl recommendations, (1 << x) is replaced by BIT(x) Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_hx8340bn.c | 6 +++--- drivers/staging/fbtft/fb_hx8353d.c | 6 +++--- drivers/staging/fbtft/fb_s6d02a1.c | 6 +++--- drivers/staging/fbtft/fb_st7735r.c | 6 +++

[PATCH v3] staging/fbtft : Remove FSF mailing address

checkpatch.pl recommends that this is no longer required. Also replaces ASCII-art copyright notice with simple text Signed-off-by: Anish Bhatt --- v2 : Fix encoding issues accidentally introduced in git send-email v3 : Move patch versioning so that it wont show in changelog, cross fingers

[PATCH v2] staging/fbtft : Remove FSF mailing address

checkpatch.pl recommends that this is no longer required. Also replaces ASCII-art copyright notice with simple text v2: Fix encoding issues accidentally introduced in git send-email Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_bd663474.c | 4 drivers/staging/fbtft

Re: [PATCH 2/4] staging/fbtft : Use macro for common fbtft addr win debug print

On Wed, Sep 2, 2015 at 6:12 PM, Greg KH wrote: > On Wed, Sep 02, 2015 at 04:29:34PM -0700, Anish Bhatt wrote: >> Same fbtft_par_dbg(DEBUG_SET_ADDR_WIN..) debug print is repeated in >> every set_addr_win handler, repalce with a macro. > > Ick. > >> static void set_

Re: [PATCH 3/4] staging:fbtft : Fix whitespace issues

On Wed, Sep 2, 2015 at 6:12 PM, Greg KH wrote: > On Wed, Sep 02, 2015 at 04:29:35PM -0700, Anish Bhatt wrote: >> * Add missing spaces after and before operators >> * Add blank lines where recommended by checkpatch.pl >> * Remove extra blank lines where recommended by check

Re: [PATCH 1/4] staging/fbtft : Remove FSF mailing address

On Wed, Sep 2, 2015 at 6:13 PM, Greg KH wrote: > On Wed, Sep 02, 2015 at 04:29:33PM -0700, Anish Bhatt wrote: >> checkpatch.pl recommends that this is no longer required. >> Also replaces ASCII-art copyright notice with simple text >> >> Signed-off-by: Anish Bhatt

[PATCH 3/4] staging:fbtft : Fix whitespace issues

* Add missing spaces after and before operators * Add blank lines where recommended by checkpatch.pl * Remove extra blank lines where recommended by checkpatch.pl Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_agm1264k-fl.c | 5 ++--- drivers/staging/fbtft/fb_bd663474.c| 1

[PATCH 4/4] staging/fbtft : Use BIT() macro when possible

Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_hx8340bn.c | 6 +++--- drivers/staging/fbtft/fb_hx8353d.c | 6 +++--- drivers/staging/fbtft/fb_s6d02a1.c | 6 +++--- drivers/staging/fbtft/fb_st7735r.c | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH 2/4] staging/fbtft : Use macro for common fbtft addr win debug print

Same fbtft_par_dbg(DEBUG_SET_ADDR_WIN..) debug print is repeated in every set_addr_win handler, repalce with a macro. Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_bd663474.c | 4 ++-- drivers/staging/fbtft/fb_hx8347d.c | 3 +-- drivers/staging/fbtft/fb_hx8353d.c | 3

[PATCH 1/4] staging/fbtft : Remove FSF mailing address

checkpatch.pl recommends that this is no longer required. Also replaces ASCII-art copyright notice with simple text Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_bd663474.c | 4 drivers/staging/fbtft/fb_hx8340bn.c | 4 drivers/staging/fbtft/fb_hx8347d.c | 4

[PATCH 0/4] staging/fbtft checkpatch and other fixes

* Remove FSF mailing address * Remove stray unicode characters * Fix a bunch of whitespace issues * Use BIT() macros where recommended * Simplify addr_win debug prints Anish Bhatt (4): staging/fbtft : Remove FSF mailing address from GPL comments staging/fbtft : Use macro for common fbtft addr

[PATCH][RESEND] staging/wlan-ng : Partial checkpatch cleanups

ssary parentheses * CHECK : Comparison to NULL/!NULL Resent because osuosl bounced the first patch. Signed-off-by: Anish Bhatt --- drivers/staging/wlan-ng/cfg80211.c | 67 +--- drivers/staging/wlan-ng/hfa384x_usb.c | 53 +- drivers/staging/wlan-ng/p80211conv.c