Re: [PATCH v5 2/2] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-16 Thread Andrew Morton
On Tue, 16 Jun 2020 11:43:11 -0400 Waiman Long wrote: > As said by Linus: > > A symmetric naming is only helpful if it implies symmetries in use. > Otherwise it's actively misleading. > > In "kzalloc()", the z is meaningful and an important part of what the > caller wants. > > In "kz

Re: [PATCH v2 0/8] mm/kdump: allow to exclude pages that are logically offline

2019-02-28 Thread Andrew Morton
On Wed, 27 Feb 2019 13:32:14 +0800 Dave Young wrote: > This series have been in -next for some days, could we get this in > mainline? It's been in -next for two months? > Andrew, do you have plan about them, maybe next release? They're all reviewed except for "xen/balloon: mark inflated pages

Re: [PATCH V4] binder: ipc namespace support for android binder

2018-11-15 Thread Andrew Morton
, it's mainly an android patch so I suggest this be taken via the android tree. Acked-by: Andrew Morton ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V2] binder: ipc namespace support for android binder

2018-11-07 Thread Andrew Morton
On Wed, 7 Nov 2018 01:48:12 + chouryzhou(周威) wrote: > > > --- a/ipc/namespace.c > > > +++ b/ipc/namespace.c > > > @@ -56,6 +56,9 @@ static struct ipc_namespace *create_ipc_ns(struct > > user_namespace *user_ns, > > > ns->ucounts = ucounts; > > > > > > err = mq_init_ns(ns); > >

Re: [PATCH V2] binder: ipc namespace support for android binder

2018-11-06 Thread Andrew Morton
On Mon, 29 Oct 2018 06:18:11 + chouryzhou(周威) wrote: > We are working for running android in container, but we found that binder is > not isolated by ipc namespace. Since binder is a form of IPC and therefore > should > be tied to ipc namespace. With this patch, we can run more than one a

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-11-05 Thread Andrew Morton
On Mon, 05 Nov 2018 15:12:27 +0530 Arun KS wrote: > On 2018-10-22 16:03, Arun KS wrote: > > On 2018-10-19 13:37, Michal Hocko wrote: > >> On Thu 18-10-18 19:18:25, Andrew Morton wrote: > >> [...] > >>> So this patch needs more work, yes? > >> &g

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-18 Thread Andrew Morton
On Thu, 11 Oct 2018 09:55:03 +0200 Michal Hocko wrote: > > > > > This is now not called anymore, although the xen/hv variants still do > > > > > it. The function seems empty these days, maybe remove it as a followup > > > > > cleanup? > > > > > > > > > > > - __online_page_increment_counters(pag

Re: [PATCH v7 4/4] kexec_file: Load kernel at top of system RAM if required

2018-07-19 Thread Andrew Morton
On Thu, 19 Jul 2018 23:17:53 +0800 Baoquan He wrote: > Hi Andrew, > > On 07/18/18 at 03:33pm, Andrew Morton wrote: > > On Wed, 18 Jul 2018 10:49:44 +0800 Baoquan He wrote: > > > > > For kexec_file loading, if kexec_buf.top_down is 'true', the memory w

Re: [PATCH v7 4/4] kexec_file: Load kernel at top of system RAM if required

2018-07-18 Thread Andrew Morton
On Wed, 18 Jul 2018 10:49:44 +0800 Baoquan He wrote: > For kexec_file loading, if kexec_buf.top_down is 'true', the memory which > is used to load kernel/initrd/purgatory is supposed to be allocated from > top to down. This is what we have been doing all along in the old kexec > loading interface

Re: simplify procfs code for seq_file instances

2018-04-24 Thread Andrew Morton
On Tue, 24 Apr 2018 16:23:04 +0200 Christoph Hellwig wrote: > On Thu, Apr 19, 2018 at 09:57:50PM +0300, Alexey Dobriyan wrote: > > > git://git.infradead.org/users/hch/misc.git proc_create > > > > > > I want to ask if it is time to start using poorman function overloading > > with _b_c_e().

Re: [RFC patch] checkpatch: test identifier lengths

2018-02-16 Thread Andrew Morton
On Fri, 16 Feb 2018 09:13:27 -0800 Joe Perches wrote: > On Fri, 2018-02-16 at 15:55 +0300, Dan Carpenter wrote: > > On Fri, Feb 16, 2018 at 05:06:34PM +0530, Yash Omer wrote: > > > This patch fix line should not end with open parenthesis found by > > > checkpatch.plscript. > > > > > > Signed-of

Re: [PATCH v2] android: binder: Drop lru lock in isolate callback

2017-09-14 Thread Andrew Morton
e going away. The mmdrop_async stuff should be moved into fork.c (and maybe made static) as well. It's pointless having this stuff global and inlined, especially mmdrop_async_fn(). Something like the below, not yet tested... From: Andrew Morton Subject: include/linux/sched/mm.h: un

Re: [PATCH RESEND 0/3] memory_hotplug: hyperv: fix deadlock between memory adding and onlining

2015-02-12 Thread Andrew Morton
On Thu, 12 Feb 2015 23:43:17 +0100 "Rafael J. Wysocki" wrote: > On Thursday, February 12, 2015 10:10:30 PM KY Srinivasan wrote: > > [cut] yay! > > > > > > > > > > > > This issue was first discovered by Andy Whitcroft: > > > > > > https://lkml.org/lkml/2014/3/14/451 > > > > > > I had sent patc

Re: [PATCH 1/3] driver core: export lock_device_hotplug/unlock_device_hotplug

2015-02-11 Thread Andrew Morton
On Wed, 11 Feb 2015 16:44:20 +0100 Vitaly Kuznetsov wrote: > add_memory() is supposed to be run with device_hotplug_lock grabbed, otherwise > it can race with e.g. device_online(). Allow external modules (hv_balloon for > now) to lock device hotplug. > > ... > > --- a/drivers/base/core.c > +++ b

Re: [PATCH v3 00/11] lib: introduce string_escape_mem and %*pE specifier

2014-08-28 Thread Andrew Morton
On Thu, 28 Aug 2014 23:58:45 +0300 Andy Shevchenko wrote: > On Thu, Aug 28, 2014 at 10:08 PM, Andrew Morton > wrote: > > On Thu, 28 Aug 2014 14:33:30 -0400 "John W. Linville" > > wrote: > > > >> On Wed, Aug 20, 2014 at 12:42:41PM +0300, Andy Shevc

Re: [PATCH v3 00/11] lib: introduce string_escape_mem and %*pE specifier

2014-08-28 Thread Andrew Morton
On Thu, 28 Aug 2014 14:33:30 -0400 "John W. Linville" wrote: > On Wed, Aug 20, 2014 at 12:42:41PM +0300, Andy Shevchenko wrote: > > The introduced function is a kind of opposite to string_unescape. We have > > several users of such functionality each of them created custom > > implementation. >

Re: [PATCH 2/6] lib / string_helpers: introduce string_escape_mem()

2014-07-02 Thread Andrew Morton
On Wed, 2 Jul 2014 16:20:25 +0300 Andy Shevchenko wrote: > This is almost the opposite function to string_unescape(). Nevertheless it > handles \0 and could be used for any byte buffer. > > The documentation is supplied together with the function prototype. > > The test cases covers most of t

Re: [PATCH 1/6] lib / string_helpers: clean up test suite

2014-07-02 Thread Andrew Morton
On Wed, 2 Jul 2014 16:20:24 +0300 Andy Shevchenko wrote: > This patch prepares test suite for a following update. It introduces > test_string_check_buf() helper which checks the result and dumps an error. > > ... > > --- a/lib/test-string_helpers.c > +++ b/lib/test-string_helpers.c > @@ -10,6

Re: [PATCH] list: Fix order of arguments for hlist_add_after(_rcu)

2014-06-06 Thread Andrew Morton
On Fri, 6 Jun 2014 10:22:51 -0700 "Paul E. McKenney" wrote: > On Fri, Jun 06, 2014 at 03:56:52PM +, David Laight wrote: > > From: Behalf Of Ken Helias > > > All other add functions for lists have the new item as first argument and > > > the > > > position where it is added as second argumen

Re: [PATCH] checkpatch: Improve missing blank line after declarations test

2014-05-05 Thread Andrew Morton
On Mon, 05 May 2014 15:35:43 -0700 Joe Perches wrote: > > @@ -67,6 +68,7 @@ long vfs_truncate(struct path *path, lof > > { > > struct inode *inode; > > long error; > > + wobble(); > > > > inode = path->dentry->d_inode; > > Patch content can be a bit odd when lines are > both add

Re: [PATCH] checkpatch: Improve missing blank line after declarations test

2014-05-05 Thread Andrew Morton
On Mon, 05 May 2014 13:12:16 -0700 Joe Perches wrote: > A couple more modifications to the declarations tests. > > o Declarations can also be bitfields so exclude things with a colon > o Make sure the current and previous lines are indented the same > to avoid matching some macro where a struc

Re: [PATCH v5 3/3] memstick: Add realtek USB memstick host driver

2014-04-01 Thread Andrew Morton
On Tue, 1 Apr 2014 11:20:32 +0800 Roger wrote: > On 03/25/2014 06:44 PM, rogera...@realtek.com wrote: > > From: Roger Tseng > > > > Realtek USB memstick host driver provides memstick host support based on the > > Realtek USB card reader MFD driver. > > > > Signed-off-by: Roger Tseng > > --- > >

Re: [RFC] quiet checkpatch style recommendation about no spaces around bitfield :

2014-03-31 Thread Andrew Morton
On Mon, 31 Mar 2014 08:31:38 -0700 Joe Perches wrote: > > > @@ -143,13 +143,13 @@ union cvmx_usbcx_gahbcfg { > > >* * 1'b1: Unmask the interrupt assertion to the application. > > >*/ > > > struct cvmx_usbcx_gahbcfg_s { > > > - uint32_t reserved_9_31 : 23; > > > - u

Re: [PATCH v4 3/3] memstick: Add realtek USB memstick host driver

2014-03-20 Thread Andrew Morton
On Thu, 20 Mar 2014 16:38:03 +0800 Roger wrote: > On 02/12/2014 06:00 PM, rogera...@realtek.com wrote: > > From: Roger Tseng > > > > Realtek USB memstick host driver provides memstick host support based on the > > Realtek USB card reader MFD driver. > > > > Signed-off-by: Roger Tseng > Andrew,

Re: [PATCH v4 3/3] memstick: Add realtek USB memstick host driver

2014-03-20 Thread Andrew Morton
On Wed, 12 Feb 2014 18:00:38 +0800 wrote: > From: Roger Tseng > > Realtek USB memstick host driver provides memstick host support based on the > Realtek USB card reader MFD driver. > > ... > > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include

Re: [PATCH] checkpatch: net and drivers/net: Warn on missing blank line after variable declaration

2014-03-06 Thread Andrew Morton
On Thu, 06 Mar 2014 15:42:30 -0800 Joe Perches wrote: > On Thu, 2014-03-06 at 15:35 -0800, Andrew Morton wrote: > > On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches wrote: > > > Networking prefers this style, so warn when it's not used. > > > void foo(

Re: [PATCH] checkpatch: net and drivers/net: Warn on missing blank line after variable declaration

2014-03-06 Thread Andrew Morton
On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches wrote: > Networking prefers this style, so warn when it's not used. > > Networking uses: > > void foo(int bar) > { > int baz; > > code... > } > > not > > void foo(int bar) > { > int baz; > code... > } > > There are a lim

Re: [PATCH] memstick: rtsx: fix ms card data transfer bug

2013-11-06 Thread Andrew Morton
On Wed, 6 Nov 2013 09:14:59 +0800 micky wrote: > On 11/06/2013 05:10 AM, Andrew Morton wrote: > > On Wed, 30 Oct 2013 14:40:16 +0800 wrote: > > > >> unlike mspro card, ms card use normal read/write mode for DMA > >> data transfer. > > What a

Re: [PATCH] memstick: rtsx: fix ms card data transfer bug

2013-11-05 Thread Andrew Morton
On Wed, 30 Oct 2013 14:40:16 +0800 wrote: > unlike mspro card, ms card use normal read/write mode for DMA > data transfer. What are the user-visible effects of this bug? Please always include this information when fixing bugs so that others can decide whether they (or their customers) need the