[PATCH v3] staging: comedi: ni_pcidio: make defines uppercase

2019-01-10 Thread Alexander Schroth
According to the Linux coding guidelines, defines should be written in uppercase. This patch converts all define-statements in the ni_pcidio.c file to uppercase, thus matching the coding style of the kernel. Signed-off-by: Alexander Schroth Signed-off-by: Marco Ammon --- v2: After feedback

Re: [PATCH 2/2] comedi/ni_pcidio: make all defines uppercase

2018-12-17 Thread Alexander Schroth
We agree that preserving the reverse-engineered knowledge is more important than reducing code size. In turn, we have modified the patch to keep these defines and converted them to uppercase as well. Also, we agree that further abbreviating would be a bad idea.

[PATCH v2] comedi/ni_pcidio: make all defines uppercase

2018-12-17 Thread Alexander Schroth
According to the Linux coding guidelines, defines should be written in uppercase. This patch converts all define-statements in the ni_pcidio.c file to uppercase, thus matching the coding style of the kernel. Signed-off-by: Alexander Schroth Signed-off-by: Marco Ammon --- drivers/staging/comedi

[PATCH 1/2] comedi/ni_pcidio: remove unused defines

2018-12-11 Thread Alexander Schroth
Define-statements, which are not used within the file, are being removed as they add clutter to the code. Because the file is not being included from anywhere else, this has no negative side-effects. Signed-off-by: Alexander Schroth Signed-off-by: Marco Ammon --- drivers/staging/comedi/drivers

[PATCH 2/2] comedi/ni_pcidio: make all defines uppercase

2018-12-11 Thread Alexander Schroth
According to the Linux coding guidelines, defines should be written in uppercase. This patch converts all define-statements in the ni_pcidio.c file to uppercase, thus matching the coding style of the kernel. Signed-off-by: Alexander Schroth Signed-off-by: Marco Ammon --- drivers/staging/comedi

[no subject]

2018-12-11 Thread Alexander Schroth
This patch series improves the conformance of comedi/drivers/ni_pcidio.c to the Linux coding guidelines. It focuses on the usage of #define and is based on the next-20181207 tag. Signed-off-by: Alexander Schroth Signed-off-by: Marco Ammon ___ devel