Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Alexander Kapshuk
s##0) ^ rk[4 * i + 1]; > \ > d##2 = TE0(s##2) ^ TE1(s##3) ^ TE2(s##0) ^ TE3(s##1) ^ rk[4 * i + 2]; > \ > d##3 = TE0(s##3) ^ TE1(s##0) ^ TE2(s##1) ^ TE3(s##2) ^ rk[4 * i + 3]; > \ > } while (0) > > On Tue, Mar 14, 2017 at 5:02 PM, Alexander Kapshuk > wr

Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Alexander Kapshuk
On Tue, Mar 14, 2017 at 1:26 PM, Pushkar Jambhlekar wrote: > Description: > There should not be ';' after do ... while(0) in macro defination > > Signed-off-by: Pushkar Jambhlekar > --- > drivers/staging/rtl8188eu/core/rtw_security.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations

2017-03-04 Thread Alexander Kapshuk
Use a single string literal as the fmt argument passed to dev_err() instead of multiple string literals split with an embedded backslash character. Signed-off-by: Alexander Kapshuk --- drivers/staging/fbtft/fb_ssd1331.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations.

2017-02-28 Thread Alexander Kapshuk
On Tue, Feb 28, 2017 at 10:34 PM, Joe Perches wrote: > On Tue, 2017-02-28 at 21:52 +0200, Alexander Kapshuk wrote: >> Use a single fmt string with appropriate verbs as conversion specifiers, >> followed by the original string literals and the integer argument >> instead of

[PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations.

2017-02-28 Thread Alexander Kapshuk
/fbtft/fb_ssd1331.c. Signed-off-by: Alexander Kapshuk --- drivers/staging/fbtft/fb_ssd1331.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c index 26f24e3..6d03041 100644 --- a/drivers/staging