Re: [PATCHv6 3/5] Staging: most: hdm-usb/hdm_usb.c. Fix "missing static keyword" warnings

2015-08-07 Thread AdrianRemonda
On Thu, Aug 06, 2015 at 11:57:28PM +0200, Christian Gromm wrote: > On Thu, 6 Aug 2015 19:34:58 +0200 > Adrian Remonda wrote: > > > This is a patch to the most/hdm-usb/hdm_usb.c file. It > > makes several local functions and structures static to prevent global > > visibility. > > > > v6: fixed al

Re: [PATCHv3 0/6] Staging: most: several warnings fix reported by sparse

2015-08-03 Thread AdrianRemonda
On Mon, Aug 03, 2015 at 11:30:18AM +0300, Dan Carpenter wrote: > The subjects still are not unique. Greg said this earlier. > > If you want just do it in two patches. > > [patch 1] add static > [patch 2] use NULL instead of zero > > regards, > dan carpenter > Yes, sorry. I totally messed it u

Re: [PATCH 4/4] Staging: lustre: sparse lock warning fix

2015-05-21 Thread AdrianRemonda
On Tue, May 19, 2015 at 12:21:15AM +0300, Dan Carpenter wrote: > On Mon, May 18, 2015 at 08:34:51PM +0200, Adrian Remonda wrote: > > Fixed sparse warning: context imbalance in 'nrs_resource_put_safe' - > > 'different lock contexts for basic block' by releasing the lock on each > > iteration of the

Re: [PATCH] Staging: comedi: Removed expression that has no effect

2015-05-14 Thread AdrianRemonda
On Tue, May 12, 2015 at 02:19:01PM -0700, Greg Kroah-Hartman wrote: > On Tue, May 12, 2015 at 11:03:52PM +0200, Adrian Remonda wrote: > > This patch remove a register from an '|' expression. > > It is wrong since after in the code, the variable ai_trig gets > > written back to that register. > >

Re: Question regarding sparse warning in staging/lustre

2015-02-09 Thread AdrianRemonda
On Mon, Feb 09, 2015 at 07:40:23AM +0800, Greg Kroah-Hartman wrote: > On Sun, Feb 08, 2015 at 10:27:23PM +0100, Adrian Remonda wrote: > > Hello, > > > > I'm cleaning the drivers/staging/lustre driver. > > I have got the next warning from sparse: > > > > drivers/staging/lustre/lnet/selftest//conct

Re: [PATCH] Staging: rtl8188eu: Lines over 80 characters fixed.

2014-08-07 Thread AdrianRemonda
On Mon, Aug 04, 2014 at 03:52:17PM -0700, Joe Perches wrote: > On Tue, 2014-08-05 at 00:45 +0200, Adrian Remonda wrote: > > This is a patch to the hal/rtl8188eu_recv.c file that fixes up a "line > > over 80 characters" warning found by the checkpatch.pl tool. > [] > > diff --git a/drivers/staging/r

[PATCH] Staging: android: Missing a blank line after declarations in sw_sync.c This is a patch to the sw_sync.c file that fixes up a missing a blank warning found by the checkpatch.pl tool

2014-07-28 Thread adrianremonda
From: Adrian Remonda Signed-off-by: Adrian Remonda --- drivers/staging/android/sw_sync.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index a76db3ff87cb..863d4b17387a 100644 --- a/drivers/staging/android/sw_sync