Re: [PATCH 1/2] staging: octeon: delete driver

On Tue, Dec 10, 2019 at 12:15:15PM -0800, Guenter Roeck wrote: > On Tue, Dec 10, 2019 at 09:46:59PM +0200, Aaro Koskinen wrote: > > On Tue, Dec 10, 2019 at 01:01:20PM +0100, Greg Kroah-Hartman wrote: > > > I have no idea :( > > > > It's stated in the TODO fil

Re: [PATCH 2/2] staging: octeon-usb: delete the octeon usb host controller driver

On Tue, Dec 10, 2019 at 09:19:57PM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 10, 2019 at 09:31:54PM +0200, Aaro Koskinen wrote: > > Hi, > > > > On Tue, Dec 10, 2019 at 10:15:09AM +0100, Greg Kroah-Hartman wrote: > > > This driver was merged back in 2013 and

Re: [PATCH 1/2] staging: octeon: delete driver

On Tue, Dec 10, 2019 at 01:01:20PM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 10, 2019 at 12:40:54PM +0100, Sandro Volery wrote: > > Doesn't octeon have drivers out of staging already? > > What is this module for? > > I have no idea :( It's stated in the TODO file you are deleting (visible in

Re: [PATCH 2/2] staging: octeon-usb: delete the octeon usb host controller driver

Hi, On Tue, Dec 10, 2019 at 10:15:09AM +0100, Greg Kroah-Hartman wrote: > This driver was merged back in 2013 and shows no progress toward every > being merged into the "correct" part of the kernel. Do you mean all the patches since 2013 were "no progress"? Thanks. > The code doesn't even build

Re: [Outreachy kernel] [PATCH v2 0/5] Remove typedef declarations in staging: octeon

Hi, On Sat, Oct 12, 2019 at 08:35:19PM +0200, Julia Lawall wrote: > On Sat, 12 Oct 2019, Wambui Karuga wrote: > > This patchset removes the addition of new typedefs data types in octeon, > > along with replacing the previous uses with the new declaration format. > > > > v2 of the series removes th

Re: [PATCH] staging: octeon: Fix incorrect type in assignment

Hi, On Thu, Oct 10, 2019 at 07:38:15AM +0300, Wambui Karuga wrote: > Fix the following warning generated by sparse in > drivers/staging/octeon/ethernet-tx.c: > > drivers/staging/octeon/ethernet-tx.c:563:50: warning: incorrect type in > assignment (different base types) > drivers/staging/octeon/e

Re: [PATCH] staging: octeon: Remove typedef declaration

Hi, On Tue, Oct 08, 2019 at 07:09:43AM +0300, Wambui Karuga wrote: > Fixes checkpatch.pl warning: do not add new typedefs in > drivers/staging/octeon/octeon-stubs.h:41 > > Signed-off-by: Wambui Karuga > --- > drivers/staging/octeon/octeon-stubs.h | 6 +++--- > 1 file changed, 3 insertions(+), 3

TODO advice for octeon-usb?

Hi, I'm looking for input what should be done next to get drivers/staging/octeon-usb out of staging. Thousands of checkpatch errors/warnings have been fixed (starting point was ), also the size of the driver has shrunken considerably.

Re: [PATCH] staging: xgifb: delete the driver

Hi, On Fri, Jan 18, 2019 at 12:20:28PM +0100, Daniel Vetter wrote: > On Fri, Jan 18, 2019 at 11:08:28AM +0100, Greg Kroah-Hartman wrote: > > There has not been any real work done on cleaning this driver up and > > getting it out of the staging tree in years. Also, no new fb drivers > > are being

[PATCH 1/2] staging: refer to TODO in Kconfig help text

Refer to TODO file instead of driver_name.README that does not seem to be used. Signed-off-by: Aaro Koskinen --- drivers/staging/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index 62951e836cbc..35aa09ed3972

[PATCH 2/2] staging: octeon-ethernet: add TODO

Add missing TODO to describe the plan to get this driver out of staging. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/TODO | 9 + 1 file changed, 9 insertions(+) create mode 100644 drivers/staging/octeon/TODO diff --git a/drivers/staging/octeon/TODO b/drivers/staging/octeon

Re: [PATCH] staging: octeon-ethernet: fix incorrect PHY mode

Hi, On Tue, Mar 26, 2019 at 10:01:50AM +0100, Andrew Lunn wrote: > Humm, that is unique, as far as i know. Every other MAC driver uses > of_get_phy_mode() to get the value out of device tree. The proprietary > delay values can then be used to fine tune the basic delay setting > read from DT. Prob

[PATCH] staging: octeon-ethernet: fix incorrect PHY mode

rrect mode. Tested on EdgeRouter Lite (RGMII_RXID, at803x PHY) and D-Link DSR-500N (RGMII, broadcom PHY). Fixes: 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-mdio.c | 2 +- drivers/stagi

Re: [PATCH] staging: octeon-usb octeon-hcd: Fix several typos.

Hi, On Sat, Mar 09, 2019 at 03:18:27PM -0300, Laura Lazzati wrote: > I found that the comments had several typos such as "aenable", "internaly" > and some others. > I fixed them all. > > Signed-off-by: Laura Lazzati I spotted one more typo that could be fixed as well: > @@ -1797,7 +1797,7 @@

[PATCH] staging: octeon: fix broken phylib usage

quot;) Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c index 2848fa71a33d..d6248eecf123 100644 --- a/drivers/staging/octeon/e

[PATCH] staging: octeon-ethernet: delete redundant include

cvmx-smix-defs.h is not needed by this driver. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-mdio.c | 1 - drivers/staging/octeon/ethernet.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet

[PATCH] staging: octeon-usb: use a helper function to set the DMA mask

Use a helper function to set the DMA mask. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 9c766f5b812f

Re: [PATCH v4 1/1] Staging: octeon-usb: Using defined error codes and applying coding style

Hi, On Sun, Jul 29, 2018 at 05:33:38PM +0300, Georgios Tsotsos wrote: > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c > b/drivers/staging/octeon-usb/octeon-hcd.c > index 3f44ac260eff..edf87d1b3609 100644 > --- a/drivers/staging/octeon-usb/octeon-hcd.c > +++ b/drivers/staging/octeon-usb/oct

Re: [PATCH v3 2/2] Staging: octeon-usb: Changes macro CVMX_WAIT_FOR_FIELD32 to function call.

Hi, On Sun, Jul 29, 2018 at 02:40:35PM +0300, Georgios Tsotsos wrote: > +/** > + * Loop through register until txfflsh or rxfflsh become zero. > + * > + * @usb: USB block > + * @address: 64bit address to read > + * @timeout_usec: Timeout > + * @fflsh_type:Indicates fflsh type,

Re: [PATCH] staging: octeon-usb: use __delay() instead of cvmx_wait()

Hi, On Fri, Nov 17, 2017 at 11:45:06AM -0600, Steven J. Hill wrote: > On 11/17/2017 04:06 AM, James Hogan wrote: > > On Fri, Nov 17, 2017 at 09:50:10AM +0200, Aaro Koskinen wrote: > >> Commit edf188bee1d9 ("MIPS: Octeon: Remove usage of cvmx_wait() > >> every

[PATCH] staging: octeon-usb: use __delay() instead of cvmx_wait()

Commit edf188bee1d9 ("MIPS: Octeon: Remove usage of cvmx_wait() everywhere.") deleted cvmx_wait() but forgot to update OCTEON USB staging driver. Fix that to allow driver build. Fixes: edf188bee1d9 ("MIPS: Octeon: Remove usage of cvmx_wait() everywhere.") Signed-o

[PATCH] staging: octeon: stop using cvmx_helper_link_autoconf()

Stop using cvmx_helper_link_autoconf(). We want to remove it in the future, as it duplicates link state information into platform code for no reason. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rgmii.c | 5 - drivers/staging/octeon/ethernet.c | 6 -- 2 files

Re: [PATCH v2 00/11] staging: octeon: multi rx group (queue) support

Hi, On Wed, Aug 31, 2016 at 07:09:13PM -0700, Ed Swierk wrote: > On 8/31/16 13:57, Aaro Koskinen wrote: > > This series implements multiple RX group support that should improve > > the networking performance on multi-core OCTEONs. Basically we register > > IRQ and NAPI for ea

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

Hi, On Wed, Aug 31, 2016 at 09:20:07AM -0700, Ed Swierk wrote: > I'm not using CONFIG_NET_POLL_CONTROLLER either; the problem is in the > normal cvm_oct_napi_poll() path. > > Here's my workaround: [...] > -static int cvm_oct_poll(struct oct_rx_group *rx_group, int budget) > +static int cvm_oct_

[PATCH v2 10/11] staging: octeon: set up pknd for all interfaces

RX path uses pknd to find the correct device, and we maintain 1:1 port to pknd mapping. However, this is only set for XAUI interfaces (in the arch code). But it should be set for all interface types. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet.c | 2 ++ 1 file changed, 2

[PATCH v2 11/11] staging: octeon: prevent poll during rx init

Prevent poll before the RX init has been completed. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 4f32fa3..ce1e2a3 100644 --- a

[PATCH v2 05/11] staging: octeon: create a struct for rx group specific data

Create a struct for RX group specific data. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 140e8af

[PATCH v2 09/11] staging: octeon: enable taking multiple rx groups into use

Enable taking multiple RX groups into use. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet.c | 49 +-- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index

[PATCH v2 00/11] staging: octeon: multi rx group (queue) support

failure with CONFIG_NET_POLL_CONSOLE. - Disable the extended group tag mask bits on CN68XX. - Set up PKND for all interfaces. - Don't allow poll before RX init is completed. v1: http://marc.info/?t=14725829975&r=1&

[PATCH v2 07/11] staging: octeon: move group number into rx group data

Move group number into RX group data. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 776003c

[PATCH v2 06/11] staging: octeon: move irq into rx group specific data

Move IRQ number into RX group specific data. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 65f6013

[PATCH v2 08/11] staging: octeon: support enabling multiple rx groups

Support enabling multiple RX groups. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 126 ++- drivers/staging/octeon/ethernet.c| 6 +- drivers/staging/octeon/octeon-ethernet.h | 2 +- 3 files changed, 81 insertions(+), 53

[PATCH v2 01/11] staging: octeon: disable rx interrupts in oct_rx_shutdown

Disable RX interrupts in oct_rx_shutdown(). This way we don't need to expose the RX IRQ numbers outside the RX module. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 9 + drivers/staging/octeon/ethernet.c| 9 - 2 files changed, 9 insertions(

[PATCH v2 04/11] staging: octeon: move common poll code into a separate function

Move common poll code into a separate function. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c

[PATCH v2 03/11] staging: octeon: pass the NAPI instance reference to irq handler

Pass the NAPI instance reference to the interrupt handler. This is preparation for having multiple NAPI instances. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/octeon/ethernet

[PATCH v2 02/11] staging: octeon: use passed interrupt number in the handler

Use passed interrupt number in the handler, so we can avoid using the global variable. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

Hi, On Tue, Aug 30, 2016 at 06:12:17PM -0700, Ed Swierk wrote: > On Tue, Aug 30, 2016 at 11:47 AM, Aaro Koskinen wrote: > > This series implements multiple RX group support that should improve > > the networking performance on multi-core OCTEONs. Basically we register > >

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

Hi, On Tue, Aug 30, 2016 at 06:12:17PM -0700, Ed Swierk wrote: > On Tue, Aug 30, 2016 at 11:47 AM, Aaro Koskinen wrote: > > This series implements multiple RX group support that should improve > > the networking performance on multi-core OCTEONs. Basically we register > >

[PATCH 6/9] staging: octeon: move irq into rx group specific data

Move IRQ number into RX group specific data. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 65f6013

[PATCH 5/9] staging: octeon: create a struct for rx group specific data

Create a struct for RX group specific data. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 140e8af

[PATCH 8/9] staging: octeon: support enabling multiple rx groups

Support enabling multiple RX groups. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 126 ++- drivers/staging/octeon/ethernet.c| 6 +- drivers/staging/octeon/octeon-ethernet.h | 2 +- 3 files changed, 81 insertions(+), 53

[PATCH 1/9] staging: octeon: disable rx interrupts in oct_rx_shutdown

Disable RX interrupts in oct_rx_shutdown(). This way we don't need to expose the RX IRQ numbers outside the RX module. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 9 + drivers/staging/octeon/ethernet.c| 9 - 2 files changed, 9 insertions(

[PATCH 9/9] staging: octeon: enable taking multiple rx groups into use

Enable taking multiple RX groups into use. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet.c | 42 +-- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index

[PATCH 4/9] staging: octeon: move common poll code into a separate function

Move common poll code into a separate function. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c

[PATCH 3/9] staging: octeon: pass the NAPI instance reference to irq handler

Pass the NAPI instance reference to the interrupt handler. This is preparation for having multiple NAPI instances. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/octeon/ethernet

[PATCH 2/9] staging: octeon: use passed interrupt number in the handler

Use passed interrupt number in the handler, so we can avoid using the global variable. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon

[PATCH 7/9] staging: octeon: move group number into rx group data

Move group number into RX group data. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 776003c

[PATCH 0/9] staging: octeon: multi rx group (queue) support

forwarding test using two flows and 16 RX groups distributed between two cores - the routing throughput is roughly doubled. A. Aaro Koskinen (9): staging: octeon: disable rx interrupts in oct_rx_shutdown staging: octeon: use passed interrupt number in the handler staging: octeon: pass the NAPI

[PATCH] staging: octeon: configure rx-delay/tx-delay

Configure rx-delay/tx-delay when available. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index 2eb9731..073a1e3 100644

Re: Improving OCTEON II 10G Ethernet performance

Hi, On Thu, Aug 25, 2016 at 01:11:45PM -0700, David Daney wrote: > On 08/25/2016 11:22 AM, Aaro Koskinen wrote: > >On Thu, Aug 25, 2016 at 09:50:15AM -0700, David Daney wrote: > >>Ideally we would configure the packet classifiers on the RX side to create > >>multiple R

Re: Improving OCTEON II 10G Ethernet performance

Hi, On Thu, Aug 25, 2016 at 09:50:15AM -0700, David Daney wrote: > Ideally we would configure the packet classifiers on the RX side to create > multiple RX queues based on a hash of the TCP 5-tuple, and handle each queue > with a single NAPI instance. That should result in better performance whil

Re: Improving OCTEON II 10G Ethernet performance

Hi, On Wed, Aug 24, 2016 at 06:29:49PM -0700, Ed Swierk wrote: > I'm trying to migrate from the Octeon SDK to a vanilla Linux 4.4 > kernel for a Cavium OCTEON II (CN6880) board running in 64-bit > little-endian mode. So far I've gotten most of the hardware features I > need working, including XAUI

Re: [RFC] [PATCH 0/3] media: an attempt to refresh omap1_camera driver

Hi, On Fri, Jun 17, 2016 at 09:04:52AM +0200, Hans Verkuil wrote: > Out of curiosity: is supporting the Amstrad Delta something you do as a hobby > or are there other reasons? Out of curiousity, why should this matter? A. ___ devel mailing list de...@l

[PATCH RESEND 3/3] staging: octeon: delete redundant log message

There will be a separate banner message after pow0 is set up (or an error message if it failed). Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index

[PATCH RESEND 2/3] staging: octeon: check for pow0 before calling interface helper

Check for pow0 port first before calling the interface helper. This avoids the following error log when setting up pow0 interface: cvmx_helper_get_interface_num: Illegal IPD port number Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-util.h | 7 --- 1 file changed

[PATCH RESEND 1/3] staging: octeon: validate interface before calling INDEX

Some helper functions call INDEX before checking if the interface is valid. Since pow0 is not a real interface, we get the following errors: cvmx_helper_get_interface_index_num: Illegal IPD port number Fix by using INDEX only when needed with real interfaces. Signed-off-by: Aaro

[PATCH 2/3] staging: octeon: check for pow0 before calling interface helper

Check for pow0 port first before calling the interface helper. This avoids the following error log when setting up pow0 interface: cvmx_helper_get_interface_num: Illegal IPD port number Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-util.h | 7 --- 1 file changed

[PATCH 3/3] staging: octeon: delete redundant log message

There will be a separate banner message after pow0 is set up (or an error message if it failed). Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index

[PATCH 1/3] staging: octeon: validate interface before calling INDEX

Some helper functions call INDEX before checking if the interface is valid. Since pow0 is not a real interface, we get the following errors: cvmx_helper_get_interface_index_num: Illegal IPD port number Fix by using INDEX only when needed with real interfaces. Signed-off-by: Aaro

[PATCH 07/16] staging: octeon-usb: rename cvmx_usb_perform_complete to cvmx_usb_complete

Rename cvmx_usb_perform_complete to cvmx_usb_complete. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 89 - 1 file changed, 42 insertions(+), 47 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging

[PATCH 12/16] staging: octeon-usb: move interrupt transfer handling into separate function

Move bulk transfer handling into a separate function to avoid deep indentation. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 74 + 1 file changed, 28 insertions(+), 46 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon

[PATCH 14/16] staging: octeon-usb: move next pipe selection into a separate function

Move next pipe selection into a separate function to avoid deep nesting. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 49 +++-- 1 file changed, 28 insertions(+), 21 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b

[PATCH 16/16] staging: octeon-usb: update TODO

Update TODO. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/TODO | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/octeon-usb/TODO b/drivers/staging/octeon-usb/TODO index cc58a7e..2b29acc 100644 --- a/drivers/staging/octeon-usb/TODO +++ b

[PATCH 02/16] staging: octeon-usb: align split lines to match open parenthesis

Align split lines to match open parenthesis. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 170 +++- 1 file changed, 81 insertions(+), 89 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb

[PATCH 03/16] staging: octeon-usb: eliminate redundant parameter from find_ready_pipe

current_frame always equals usb->frame_number. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hc

[PATCH 05/16] staging: octeon-usb: simplify if statement

Simplify if statement to avoid deep nesting. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb

[PATCH 13/16] staging: octeon-usb: move isoc transfer handling into separate function

Move isochronous transfer handling into a separate function to avoid deep indentation. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 106 1 file changed, 53 insertions(+), 53 deletions(-) diff --git a/drivers/staging/octeon-usb

[PATCH 06/16] staging: octeon-usb: rename cvmx_usb_complete to cvmx_usb_status

Rename cvmx_usb_complete to cvmx_usb_status. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 105 1 file changed, 52 insertions(+), 53 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb

[PATCH 15/16] staging: octeon-usb: avoid an overlong line

Avoid an overlong line. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 298fcaa..17442b3 100644 --- a/drivers

[PATCH 09/16] staging: octeon-usb: fold cvmx_usb_state into octeon_hcd

Fold cvmx_usb_state into octeon_hcd. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 255 +++- 1 file changed, 118 insertions(+), 137 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon

[PATCH 11/16] staging: octeon-usb: move bulk transfer handling into separate function

Move bulk transfer handling into a separate function to avoid deep indentation. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 38 + 1 file changed, 38 insertions(+) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers

[PATCH 04/16] staging: octeon-usb: pass transfer type to find_ready_pipe

Since we always search the same list, we can just pass the transfer type. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon

[PATCH 08/16] staging: octeon-usb: rename STATUS_SUCCESS to STATUS_OK

Rename STATUS_SUCCESS to STATUS_OK. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c

[PATCH 10/16] staging: octeon-usb: move control transfer handling into separate function

Move control transfer handling into a separate function to avoid deep indentation. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 174 1 file changed, 88 insertions(+), 86 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon

[PATCH 01/16] staging: octeon-usb: use preferred style for NULL comparison

Use preferred coding style for NULL comparison. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 1ec8906

[PATCH v2] staging: octeon: drop atomic usage from rx counters

We have only one NAPI poll running at a time, so virtual port rx counters can be updated normally. Update of rx_dropped can still race with the gathering of statistics, but full accuracy is not required there. Signed-off-by: Aaro Koskinen --- Replaces this patch: http://marc.info/?t

Re: [PATCH] staging: octeon: use atomic_long_t

Hi, On Fri, Feb 19, 2016 at 10:17:54AM -0800, Greg Kroah-Hartman wrote: > On Fri, Feb 19, 2016 at 10:08:07AM -0800, David Daney wrote: > > On 02/18/2016 03:45 PM, Greg Kroah-Hartman wrote: > > >On Fri, Feb 19, 2016 at 12:20:45AM +0200, Aaro Koskinen wrote: > > >>Use

[PATCH] staging: octeon: use atomic_long_t

Use atomic_long_t, so that we can avoid some 32 vs. 64-bit ifdeffery. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 24 ++-- drivers/staging/octeon/ethernet.c| 9 ++--- 2 files changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers

[PATCH 4/7] staging: octeon-usb: clean up includes

Clean up includes. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 010b861..3165849

[PATCH 1/7] staging: octeon-usb: delete redundant blank lines

Delete redundant blank lines. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index eaf6ded..91fce2c 100644 --- a

[PATCH 7/7] staging: octeon-usb: make driver name to match the file name

Make driver name to match the file name. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 68e42fe..1ec8906 100644

[PATCH 6/7] staging: octeon-usb: add spaces around operator

Add spaces around operator to improve readability. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb

[PATCH 2/7] staging: octeon-usb: add missing braces

Some if branches are missing braces as required by coding style. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon

[PATCH 5/7] staging: octeon-usb: switch to use kernel types

Switch to use kernel types: uint64_t -> u64 uint32_t -> u32 uint16_t -> u16 uint8_t -> u8 int8_t -> s8 Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 75 +++-- drivers/staging/octeon-usb/oct

[PATCH 3/7] staging: octeon-usb: delete space after cast

Delete space after cast. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 2872653..010b861 100644 --- a

[PATCH] staging: octeon-usb: support official bindings

Support official DT bindings alongside with the deprecated ones. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb

[PATCH] staging: octeon: support fixed-link phys

Support fixed-link PHYs. This allows to remove some of the board-specific link cvmx_helper code in the future. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-mdio.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers

[PATCH] staging: octeon: refactor rgmii 10 mbps preamble error checking

h software preamble removal" logs when interfaces are being bringed up. It also avoids some corner-case crashes when the in-band interrupt triggers while the interface is being taken down. Tested on EdgeRouter Lite & D-Link DSR-1000N. Signed-off-by: Aaro Koskinen --- drivers/staging/oct

[PATCH 2/3] staging: octeon-ethernet: drop poll_now parameter from cvm_oct_common_open

Drop redundant poll_now parameter from cvm_oct_common_open. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rgmii.c | 2 +- drivers/staging/octeon/ethernet-sgmii.c | 2 +- drivers/staging/octeon/ethernet-xaui.c | 2 +- drivers/staging/octeon/ethernet.c| 5

[PATCH 1/3] staging: octeon-ethernet: rgmii: poll link status on open

Get the initial link status already on open instead of postponing it to the periodic poll task. This unifies the behaviour with other interfaces types. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rgmii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 3/3] staging: octeon-ethernet: move cvm_oct_xaui_open()

cvm_oct_xaui_open() is trivial and does not need a dedicated file. Move it to the main file. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/Makefile | 2 -- drivers/staging/octeon/ethernet-xaui.c | 31 --- drivers/staging/octeon/ethernet.c

Re: [PATCH] staging: octeon: fixed few coding style warnings

Hi, On Wed, Oct 14, 2015 at 07:36:37PM +0530, Sakshi Bansal wrote: > Fixed allignment issues and line over 80 characters You are also doing many other things which are not mention in the commit log. > /* > - printk_ratelimited("Port %d

[PATCH 1/2] staging: octeon-ethernet: xaui: don't register poll function in init

Link status poll function is already controlled by open/stop functions, so we don't need to do it on init. This eliminates a redundant xaui link status notification when the module is loaded. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-xaui.c | 4 1 file chang

[PATCH 2/2] staging: octeon-ethernet: xaui: use common init

Use common init. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-xaui.c | 7 --- drivers/staging/octeon/ethernet.c| 2 +- drivers/staging/octeon/octeon-ethernet.h | 1 - 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/octeon/ethernet

Re: [PATCH 00/14] MIPS/staging: OCTEON: enable ethernet/xaui on CN68XX

Hi, On Thu, Aug 13, 2015 at 12:16:43PM -0700, David Daney wrote: > On 08/13/2015 06:21 AM, Aaro Koskinen wrote: > >Currently mainline Linux is unusable on OCTEON II CN68XX SOCs due to > >issues in Ethernet driver initialization. Some boards are hanging during > >init, and al

[PATCH 11/14] MIPS: OCTEON: initialize CN68XX PKO

From: Janne Huttunen CN68XX requires a different PKO configuration. This patch provides just enough setup to get the XAUI interfaces on CN6880 working with default parameters. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/cvmx-pko.c | 149

[PATCH 06/14] MIPS: OCTEON: add definitions for setting up SSO

From: Janne Huttunen Some Octeon II models have SSO instead of POW and use a different register for setting the interrupt thresholds. Add the necessary definitions for configuring the interrupts also on those models. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- arch/mips

[PATCH 14/14] MIPS/staging: OCTEON: use common helpers for determining interface and port

: Janne Huttunen Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-util.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/octeon/ethernet-util.h b/drivers/staging/octeon/ethernet-util.h index 1ba789a..45f024b 100644 --- a

[PATCH 02/14] MIPS: OCTEON: support additional interfaces on CN68XX

From: Janne Huttunen CN68XX has 9 interfaces. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/cvmx-helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper.c b/arch/mips/cavium-octeon

[PATCH 00/14] MIPS/staging: OCTEON: enable ethernet/xaui on CN68XX

. This patch set provides a minimal support to get octeon-ethernet going on CN68XX. Tested on top of 4.2-rc6 with Cavium EBB6800 and Kontron S1901 boards by sending traffic over XAUI interface with busybox. A. Aaro Koskinen (2): MIPS/staging: OCTEON: properly enable/disable SSO WQE interrupts MIPS

  1   2   3   4   >