Re: [PATCH v6 4/5] drm/bridge: anx7625: add HDCP support

2021-04-01 Thread Xin Ji
On Mon, Mar 29, 2021 at 02:02:08PM -0400, Sean Paul wrote: > On Mon, Mar 29, 2021 at 6:27 AM Xin Ji wrote: > > > > On Thu, Mar 25, 2021 at 02:19:23PM -0400, Sean Paul wrote: > > > On Fri, Mar 19, 2021 at 2:35 AM Xin Ji wrote: > > > > > > > > Add HDCP feature, enable HDCP function through chip int

[PATCH v8 13/13] arm64: dts: imx8mq: Add node to G2 hardware

2021-04-01 Thread Benjamin Gaignard
Split VPU node in two: one for G1 and one for G2 since they are different hardware blocks. Add syscon for hardware control block. Remove reg-names property that is useless. Each VPU node only need one interrupt. Change G2 assigned clock to match to the specifications. In the both nodes all the cloc

[PATCH v8 11/13] media: hantro: Introduce G2/HEVC decoder

2021-04-01 Thread Benjamin Gaignard
Implement all the logic to get G2 hardware decoding HEVC frames. It support up level 5.1 HEVC stream. It doesn't support yet 10 bits formats or scaling feature. Add HANTRO HEVC dedicated control to skip some bits at the beginning of the slice header. That is very specific to this hardware so can't

[PATCH v8 12/13] media: hantro: IMX8M: add variant for G2/HEVC codec

2021-04-01 Thread Benjamin Gaignard
Add variant to IMX8M to enable G2/HEVC codec. Define the capabilities for the hardware up to 3840x2160. G2 doesn't have postprocessor, use the same clocks and got it own interruption. Signed-off-by: Benjamin Gaignard Reviewed-by: Philipp Zabel Reviewed-by: Ezequiel Garcia --- version 8: - Add

[PATCH v8 10/13] media: hantro: handle V4L2_PIX_FMT_HEVC_SLICE control

2021-04-01 Thread Benjamin Gaignard
Make sure that V4L2_PIX_FMT_HEVC_SLICE is correctly handle by v4l2 of the driver. Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia --- version 8: - Add Ezequiel review tag drivers/staging/media/hantro/hantro_v4l2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/stagi

[PATCH v8 09/13] media: uapi: Add a control for HANTRO driver

2021-04-01 Thread Benjamin Gaignard
The HEVC HANTRO driver needs to know the number of bits to skip at the beginning of the slice header. That is a hardware specific requirement so create a dedicated control that this purpose. Signed-off-by: Benjamin Gaignard --- version 5: - Be even more verbose in control documentation. - Do no

[PATCH v8 08/13] media: hantro: Only use postproc when post processed formats are defined

2021-04-01 Thread Benjamin Gaignard
If the variant doesn't offert postprocessed formats make sure it will be ok. Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia --- version 8: - add Ezequiel review tag drivers/staging/media/hantro/hantro.h | 8 ++-- drivers/staging/media/hantro/hantro_postproc.c | 14

[PATCH v8 07/13] media: hantro: Define HEVC codec profiles and supported features

2021-04-01 Thread Benjamin Gaignard
Define which HEVC profiles (up to level 5.1) and features (no scaling, no 10 bits) are supported by the driver. Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia --- version 8: - add Ezequiel review tag drivers/staging/media/hantro/hantro.h | 3 ++ drivers/staging/media/hantr

[PATCH v8 06/13] media: hantro: change hantro_codec_ops run prototype to return errors

2021-04-01 Thread Benjamin Gaignard
Change hantro_codec_ops run prototype from 'void' to 'int'. This allow to cancel the job if an error occur while configuring the hardware. Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia --- version 8: - add Ezequiel review tag version 5: - forward hantro_h264_dec_prepare_run()

[PATCH v8 05/13] media: hevc: Add decode params control

2021-04-01 Thread Benjamin Gaignard
Add decode params control and it associated structure to regroup all the information that are needed to decode a reference frame as it is describe in ITU-T Rec. H.265 section "8.3.2 Decoding process for reference picture set". Adapt Cedrus driver to these changes. Signed-off-by: Benjamin Gaignard

[PATCH v8 03/13] media: hantro: Use syscon instead of 'ctrl' register

2021-04-01 Thread Benjamin Gaignard
In order to be able to share the control hardware block between VPUs use a syscon instead a ioremap it in the driver. To keep the compatibility with older DT if 'nxp,imx8mq-vpu-ctrl' phandle is not found look at 'ctrl' reg-name. With the method it becomes useless to provide a list of register names

[PATCH v8 04/13] media: hevc: Add fields and flags for hevc PPS

2021-04-01 Thread Benjamin Gaignard
Add fields and flags as they are defined in 7.4.3.3.1 "General picture parameter set RBSP semantics of the H.265 ITU specification. Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia --- version 8: - add Ezequiel review tag .../userspace-api/media/v4l/ext-ctrls-codec.rst| 14 ++

[PATCH v8 02/13] dt-bindings: media: nxp, imx8mq-vpu: Update the bindings for G2 support

2021-04-01 Thread Benjamin Gaignard
Introducing G2 hevc video decoder lead to modify the bindings to allow to get one node per VPUs. VPUs share one hardware control block which is provided as a phandle on an syscon. Each node got now one reg and one interrupt. Add a compatible for G2 hardware block: nxp,imx8mq-vpu-g2. To be compatib

[PATCH v8 01/13] dt-bindings: mfd: Add 'nxp, imx8mq-vpu-ctrl' to syscon list

2021-04-01 Thread Benjamin Gaignard
Add 'nxp,imx8mq-vpu-ctrl' in the list of possible syscon. It will used to access to the VPU control registers. Signed-off-by: Benjamin Gaignard Acked-by: Rob Herring Acked-by: Lee Jones --- version 8: - Add Lee ack version 7: - Add Rob ack Documentation/devicetree/bindings/mfd/syscon.yaml

[PATCH v8 00/13] Add HANTRO G2/HEVC decoder support for IMX8MQ

2021-04-01 Thread Benjamin Gaignard
The IMX8MQ got two VPUs but until now only G1 has been enabled. This series aim to add the second VPU (aka G2) and provide basic HEVC decoding support. To be able to decode HEVC it is needed to add/update some of the structures in the uapi. In addition of them one HANTRO dedicated control is requ

Re: Re: Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 08:28:02PM +0800, Yongji Xie wrote: > On Thu, Apr 1, 2021 at 7:33 PM Greg KH wrote: > > > > On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote: > > > On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote: > > > > > > > > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie

Re: [PATCH v6 5/5] drm/bridge: anx7625: add HDMI audio function

2021-04-01 Thread Robert Foss
Hey Xin, This patch looks good to me. Reviewed-by: Robert Foss On Fri, 19 Mar 2021 at 07:35, Xin Ji wrote: > > Add audio HDMI codec function support, enable it through device true flag > "analogix,audio-enable". > > Reported-by: kernel test robot > Signed-off-by: Xin Ji > --- > drivers/gpu/

Re: [PATCH v6 3/5] drm/bridge: anx7625: add MIPI DPI input feature support

2021-04-01 Thread Robert Foss
Hey Xin, This patch looks good to me, feel free to add my r-b. Reviewed-by: Robert Foss On Fri, 19 Mar 2021 at 07:34, Xin Ji wrote: > > Add MIPI rx DPI input support. > > Reported-by: kernel test robot > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 245 +

Re: Re: Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Yongji Xie
On Thu, Apr 1, 2021 at 7:33 PM Greg KH wrote: > > On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote: > > On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote: > > > > > > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote: > > > > On Thu, Apr 1, 2021 at 5:54 PM Greg KH > > > > wrote: >

Re: Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote: > On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote: > > > > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote: > > > On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote: > > > > > > > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji

Re: Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Yongji Xie
On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote: > > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote: > > On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote: > > > > > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote: > > > > Use receive_fd() to receive file from another process ins

Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Yongji Xie
On Thu, Apr 1, 2021 at 6:40 PM Christian Brauner wrote: > > On Thu, Apr 01, 2021 at 11:54:45AM +0200, Greg KH wrote: > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote: > > > Use receive_fd() to receive file from another process instead of > > > combination of get_unused_fd_flags() and

Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote: > On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote: > > > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote: > > > Use receive_fd() to receive file from another process instead of > > > combination of get_unused_fd_flags() and fd_i

Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Christian Brauner
On Thu, Apr 01, 2021 at 11:54:45AM +0200, Greg KH wrote: > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote: > > Use receive_fd() to receive file from another process instead of > > combination of get_unused_fd_flags() and fd_install(). This simplifies > > the logic and also makes sure we

Re: Re: [PATCH 1/2] file: Export receive_fd() to modules

2021-04-01 Thread Yongji Xie
On Thu, Apr 1, 2021 at 5:52 PM Greg KH wrote: > > On Thu, Apr 01, 2021 at 05:09:31PM +0800, Xie Yongji wrote: > > Export receive_fd() so that some modules can use > > it to pass file descriptor across processes without > > missing any security stuffs. > > > > Signed-off-by: Xie Yongji > > --- > >

Re: [PATCH 0/2] Export receive_fd() to modules and do some cleanups

2021-04-01 Thread Christian Brauner
On Thu, Apr 01, 2021 at 05:09:30PM +0800, Xie Yongji wrote: > This series starts from Christian's comments on the series[1]. > We'd like to export receive_fd() which can not only be used by > our module in the series[1] but also allow further cleanups > like patch 2 does. > > Now this series is ba

Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Yongji Xie
On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote: > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote: > > Use receive_fd() to receive file from another process instead of > > combination of get_unused_fd_flags() and fd_install(). This simplifies > > the logic and also makes sure we don't m

Re: Re: [PATCH 0/2] Export receive_fd() to modules and do some cleanups

2021-04-01 Thread Yongji Xie
On Thu, Apr 1, 2021 at 5:53 PM Greg KH wrote: > > On Thu, Apr 01, 2021 at 05:09:30PM +0800, Xie Yongji wrote: > > This series starts from Christian's comments on the series[1]. > > We'd like to export receive_fd() which can not only be used by > > our module in the series[1] but also allow further

Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote: > Use receive_fd() to receive file from another process instead of > combination of get_unused_fd_flags() and fd_install(). This simplifies > the logic and also makes sure we don't miss any security stuff. But no logic is simplified here,

Re: [PATCH 0/2] Export receive_fd() to modules and do some cleanups

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 05:09:30PM +0800, Xie Yongji wrote: > This series starts from Christian's comments on the series[1]. > We'd like to export receive_fd() which can not only be used by > our module in the series[1] but also allow further cleanups > like patch 2 does. But binder can not be a m

Re: [PATCH 1/2] file: Export receive_fd() to modules

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 05:09:31PM +0800, Xie Yongji wrote: > Export receive_fd() so that some modules can use > it to pass file descriptor across processes without > missing any security stuffs. > > Signed-off-by: Xie Yongji > --- > fs/file.c| 6 ++ > include/linux/file.h | 7 ++

[PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Xie Yongji
Use receive_fd() to receive file from another process instead of combination of get_unused_fd_flags() and fd_install(). This simplifies the logic and also makes sure we don't miss any security stuff. Signed-off-by: Xie Yongji --- drivers/android/binder.c | 4 ++-- 1 file changed, 2 insertions(+)

[PATCH 1/2] file: Export receive_fd() to modules

2021-04-01 Thread Xie Yongji
Export receive_fd() so that some modules can use it to pass file descriptor across processes without missing any security stuffs. Signed-off-by: Xie Yongji --- fs/file.c| 6 ++ include/linux/file.h | 7 +++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/fs/fil

[PATCH 0/2] Export receive_fd() to modules and do some cleanups

2021-04-01 Thread Xie Yongji
This series starts from Christian's comments on the series[1]. We'd like to export receive_fd() which can not only be used by our module in the series[1] but also allow further cleanups like patch 2 does. Now this series is based on Christoph's patch[2]. [1] https://lore.kernel.org/linux-fsdevel