On Wed, Feb 17, 2021 at 8:07 AM Selvakumar Elangovan
wrote:>
> Removed an unnecessary blank line before closing brace reported by
> checkpatch.pl
>
> Signed-off-by: Selvakumar Elangovan
> ---
> drivers/staging/mt7621-pci/pci-mt7621.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Sergio Pa
Removed an unnecessary blank line before closing brace reported by
checkpatch.pl
Signed-off-by: Selvakumar Elangovan
---
drivers/staging/mt7621-pci/pci-mt7621.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
b/drivers/staging/mt7621-pci/pci-mt7621.c
i
Hi Selvakumar,
On Wed, Feb 17, 2021 at 7:53 AM Selvakumar Elangovan
wrote:
>
> Removed an unecessary blank line before closing brace reported by
> checkpatch.pl
Typo:
s/unecessary/unnecessary/g
>
> Signed-off-by: Selvakumar Elangovan
> ---
> drivers/staging/mt7621-pci/pci-mt7621.c | 1 -
> 1
Removed an unecessary blank line before closing brace reported by
checkpatch.pl
Signed-off-by: Selvakumar Elangovan
---
drivers/staging/mt7621-pci/pci-mt7621.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
b/drivers/staging/mt7621-pci/pci-mt7621.c
in
On Tue, Feb 16, 2021 at 10:59:51PM -0500, Sean Behan wrote:
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c
> b/drivers/staging/emxx_udc/emxx_udc.c
> index 3536c03ff523..741147a4f0fe 100644
> --- a/drivers/st
---
drivers/staging/emxx_udc/emxx_udc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index 3536c03ff523..741147a4f0fe 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -38,7
-ought-to-be
|-- x86_64-randconfig-a001-20210216
| `--
drivers-net-wireless-broadcom-b43legacy-debugfs.c:error:void-value-not-ignored-as-it-ought-to-be
`-- xtensa-allyesconfig
`--
drivers-net-wireless-broadcom-b43legacy-debugfs.c:error:void-value-not-ignored-as-it-ought-to-be
elapsed time
On Tue, Feb 16, 2021 at 12:24:38PM +0300, Dan Carpenter wrote:
> Looks good.
>
> Reviewed-by: Dan Carpenter
>
> regards,
> dan carpenter
>
Thank you Dan.
Regards,
Phil
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverp
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
debugfs_remove_return_value
head: 5187c2360ee1d023078e4302dad32fda1e895772
commit: 72f2bf74b31aae983fb200aa7e84a05943bf27fc [2/8] debugfs: remove return
value of debugfs_create_bool()
config: i386-allyesconfig (attac
On 2/16/21 9:48 AM, Kumar Kartikeya Dwivedi wrote:
On Tue, Feb 16, 2021 at 08:24:59PM IST, Alex Elder wrote:
This is a good change. But while you're at it, I would
appreciate if you would convert a few spots to use
sizeof(dest) rather than a fixed constant. I will
point them out below.
If thi
On Tue, Feb 16, 2021 at 08:24:59PM IST, Alex Elder wrote:
> This is a good change. But while you're at it, I would
> appreciate if you would convert a few spots to use
> sizeof(dest) rather than a fixed constant. I will
> point them out below.
>
> If this is the *only* request for a change on yo
On Tue, Feb 16, 2021 at 08:40:58PM +0530, Selvakumar Elangovan wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Selvakumar Elangovan
> ---
> drivers/staging/ks7010/ks_hostif.h | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/stag
On 2/12/21 4:50 PM, Manikantan Ravichandran wrote:
checkpatch warning fix for string split across lines
Signed-off-by: Manikantan Ravichandran
I think what you're doing here *looks* reasonable. But
the GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF symbol is
a (string) numeric value that is associa
Fixed a coding style issue.
Signed-off-by: Selvakumar Elangovan
---
drivers/staging/ks7010/ks_hostif.h | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_hostif.h
index 39138191a556..c62a4
On 1/31/21 11:28 AM, Kumar Kartikeya Dwivedi wrote:
strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
and there is no functional difference when the caller expects truncation
(when not checking the return value). strscpy is relatively better as it
also avoids scanning the w
On dinsdag 16 februari 2021 01:12:12 CET Diederik de Haas wrote:
> On maandag 8 februari 2021 13:22:56 CET Stefan Wahren wrote:
> > Currently i cannot see any of the fixes by Phil
> > Elwell in linux-stable. Maybe they won't apply and needs to be backport
> > manually.
> >
> > Just for reference h
On 31.01.21 22:58:27, Kumar Kartikeya Dwivedi wrote:
> strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
> and there is no functional difference when the caller expects truncation
> (when not checking the return value). strscpy is relatively better as it
> also avoids scannin
Vendor listed for mediatek in kernel vendor file 'vendor-prefixes.yaml'
contains 'mediatek' as a valid vendor string. Some nodes in the device
tree are using an invalid vendor string vfor 'mtk' instead. Fix all of
them in dts file. Update also ralink mt7621 related code to properly
match new string
Clocks for SoC mt7621 have been properly integrated so there is
no need to declare fixed clocks at all in the device tree. Remove
all of them, add new device tree nodes for mt7621-clk and update
the rest of the nodes to use them.
Acked-by: Greg Kroah-Hartman
Signed-off-by: Sergio Paracuellos
---
Adding myself as maintainer for mt7621 clock driver.
Signed-off-by: Sergio Paracuellos
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 809a68af5efd..be5ada6b4309 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11288,6 +11288,12 @@ L: l
This patchset ports CPU clock detection for MT7621 from OpenWrt
and adds a complete clock plan for the mt7621 SOC.
The documentation for this SOC only talks about two registers
regarding to the clocks:
* SYSC_REG_CPLL_CLKCFG0 - provides some information about boostrapped
refclock. PLL and dividers
The documentation for this SOC only talks about two
registers regarding to the clocks:
* SYSC_REG_CPLL_CLKCFG0 - provides some information about
boostrapped refclock. PLL and dividers used for CPU and some
sort of BUS.
* SYSC_REG_CPLL_CLKCFG1 - a banch of gates to enable/disable
clocks for all or s
Adds device tree binding documentation for clocks in the
MT7621 SOC.
Signed-off-by: Sergio Paracuellos
---
.../bindings/clock/mediatek,mt7621-clk.yaml | 66 +++
1 file changed, 66 insertions(+)
create mode 100644
Documentation/devicetree/bindings/clock/mediatek,mt7621-clk.yam
Adds dt binding header for 'mediatek,mt7621-clk' clocks.
Acked-by: Rob Herring
Signed-off-by: Sergio Paracuellos
---
include/dt-bindings/clock/mt7621-clk.h | 41 ++
1 file changed, 41 insertions(+)
create mode 100644 include/dt-bindings/clock/mt7621-clk.h
diff --git a/
On Tue, Feb 16, 2021 at 12:28:01PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 16, 2021 at 07:13:53PM +0800, Du Cheng wrote:
> > fix macro gb_loopback_stats_attrs by wrapping its multi-line definition
> > inside a do {} while(0) block, in compliance to scripts/checkpatch.pl.
> >
> > Signed-off-
In hi6421-spmi-pmic.c, there are some warnings and Check:
"WARNING: please, no space before tabs" in lines 51,52,53 and 69.
"CHECK: Alignment should match open parenthesis" in lines 180 and 238.
Signed-off-by: Alaa Emad
---
Changes in v2:
- Make the commit message more clearer.
---
drivers/st
On Tue, Feb 16, 2021 at 07:13:53PM +0800, Du Cheng wrote:
> fix macro gb_loopback_stats_attrs by wrapping its multi-line definition
> inside a do {} while(0) block, in compliance to scripts/checkpatch.pl.
>
> Signed-off-by: Du Cheng
> ---
> changes v2:
> * relign backslashes with tabstop=8
> * im
On Tue, Feb 16, 2021 at 07:13:53PM +0800, Du Cheng wrote:
> fix macro gb_loopback_stats_attrs by wrapping its multi-line definition
> inside a do {} while(0) block, in compliance to scripts/checkpatch.pl.
>
> Signed-off-by: Du Cheng
> ---
> changes v2:
> * relign backslashes with tabstop=8
> * im
fix macro gb_loopback_stats_attrs by wrapping its multi-line definition
inside a do {} while(0) block, in compliance to scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
changes v2:
* relign backslashes with tabstop=8
* improve description and subject
changes v1:
* fix coding style of the macro
use __func__ macro instead of literal function name in RT_TRACE() in
* phy_set_rf8256_bandwidth()
* phy_rf8256_config_para_file()
remove unnecessary return at the end of phy_set_rf8256_ofdm_tx_power()
these coding style issues are flagged as warnings by scripts/checkpatch.pl.
Signed-off-by: D
fix the closing of a one-line block comment,
marked incorrect by scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
changes v5:
- improve description
changes v4:
- move "changes" after triple-tiret
changes v3:
- add SUBSYSTEM in subject line
- add explanation to past version of this patch
chan
On Tue, Feb 16, 2021 at 05:40:12PM +0800, Du Cheng wrote:
> align * in block comments on each line
That says _what_ you did, not _why_ you did it.
And "each line"? You only did this once.
> This series of patches is for Task 10 of the Eudyptula Challenge
This isn't a "series" of patches, it is
align * in block comments on each line
This series of patches is for Task 10 of the Eudyptula Challenge
Signed-off-by: Du Cheng
---
changes v4:
- move "changes" after triple-tiret
changes v3:
- add SUBSYSTEM in subject line
- add explanation to past version of this patch
changes v2:
- move clo
On Tue, Feb 16, 2021 at 10:20:22AM +0100, Heiner Kallweit wrote:
> On 16.02.2021 09:53, Du Cheng wrote:
> > align * in block comments on each line
> >
> > changes v3:
> > - add SUBSYSTEM in subject line
> > - add explanation to past version of this patch
> >
> > changes v2:
> > - move closing of
Looks good.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Feb 16, 2021 at 04:53:26PM +0800, Du Cheng wrote:
> align * in block comments on each line
>
> changes v3:
> - add SUBSYSTEM in subject line
> - add explanation to past version of this patch
>
> changes v2:
> - move closing of comment to the same line
>
> changes v1:
> - align * in block
On 16.02.2021 09:53, Du Cheng wrote:
> align * in block comments on each line
>
> changes v3:
> - add SUBSYSTEM in subject line
> - add explanation to past version of this patch
>
> changes v2:
> - move closing of comment to the same line
>
> changes v1:
> - align * in block comments
>
> Signed
align * in block comments on each line
changes v3:
- add SUBSYSTEM in subject line
- add explanation to past version of this patch
changes v2:
- move closing of comment to the same line
changes v1:
- align * in block comments
Signed-off-by: Du Cheng
---
drivers/staging/qlge/qlge_main.c | 3 +-
38 matches
Mail list logo
