Re: [PATCH v2] staging: wimax/i2400m: fix pointer declaration style

On Sat, 2021-01-30 at 23:14 +0530, Anirudh Rayabharam wrote: > Fix a couple of pointer declarations where the pointer qualifier '*' > is not attached to the variable name. This fixes the checkpatch > error: "foo * bar" should be "foo *bar". This driver is in staging to get deleted unless somebody

[PATCH v2] staging: wimax/i2400m: fix pointer declaration style

Fix a couple of pointer declarations where the pointer qualifier '*' is not attached to the variable name. This fixes the checkpatch error: "foo * bar" should be "foo *bar". Signed-off-by: Anirudh Rayabharam --- v2: Minor corrections in the commit message. --- drivers/staging/wimax/i2400m/rx.c |

Re: [PATCH] media: allegro-dvt: Use __packed sentence

Hi, > > Spelling check please? > > And _why_ are you making this change, what does this do "better" than > the original? > Actually, I'm really new here, and this is my first patch. I run the checkpatch.pl, and give me that recommendation. I would like to look the David comments. Thanks! eama

[PATCH] staging: wimax/i2400m: fix pointer declaration style

Fix a couple of pointer declarataions where the pointer qualifier '*' is not attached to the variable. This fixes the checkpatch error: "'foo * bar' should be 'foo *bar'". Signed-off-by: Anirudh Rayabharam --- drivers/staging/wimax/i2400m/rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

Re: [PATCH] staging: android: ashmen.c: fixed a coding style issue with struct

On Sat, Jan 30, 2021 at 06:04:18PM +0530, Ahana Datta wrote: > Hi, > I am sorry this was my first time. I followed instructions given here : > https://www.youtube.com/watch?v=LLBrBBImJt4 Note, that is a 10 year old talk :) > and recompiled the driver that I had changed. Are you sure? Touch the

Re: [PATCH] staging: android: ashmen.c: fixed a coding style issue with struct

On Sat, Jan 30, 2021 at 04:36:30PM +0530, Ahana Datta wrote: > Fixed warning "struct file_operations should normally be const" > > Signed-off-by: Ahana Datta > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android

[PATCH] staging: android: ashmen.c: fixed a coding style issue with struct

Fixed warning "struct file_operations should normally be const" Signed-off-by: Ahana Datta --- drivers/staging/android/ashmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index d66a64e42273..e675b7850044

Re: [PATCH] media: allegro-dvt: Use __packed sentence

On Fri, Jan 29, 2021 at 05:01:54PM -0300, Emmanuel Arias wrote: > Fix coding style using __packed sentece instead of Spelling check please? And _why_ are you making this change, what does this do "better" than the original? thanks, greg k-h ___ devel