Re: [PATCH] staging: greybus: fix stack size warning with UBSAN

2021-01-03 Thread Dan Carpenter
On Sun, Jan 03, 2021 at 11:35:32PM +0100, Arnd Bergmann wrote: > @@ -1050,78 +1088,28 @@ static int gbaudio_tplg_create_widget(struct > gbaudio_module_info *module, > strlcpy(temp_name, w->name, NAME_SIZE); > snprintf(w->name, NAME_SIZE, "GB %d %s", module->dev_id, temp_name); > > +

Re: [PATCH] staging: greybus: fix stack size warning with UBSAN

2021-01-03 Thread Alex Elder
On 1/3/21 4:35 PM, Arnd Bergmann wrote: From: Arnd Bergmann clang warns about excessive stack usage in this driver when UBSAN is enabled: drivers/staging/greybus/audio_topology.c:977:12: error: stack frame size of 1836 bytes in function 'gbaudio_tplg_create_widget' [-Werror,-Wframe-larger-th

[PATCH] staging: greybus: fix stack size warning with UBSAN

2021-01-03 Thread Arnd Bergmann
From: Arnd Bergmann clang warns about excessive stack usage in this driver when UBSAN is enabled: drivers/staging/greybus/audio_topology.c:977:12: error: stack frame size of 1836 bytes in function 'gbaudio_tplg_create_widget' [-Werror,-Wframe-larger-than=] Rework this code to no longer use co

[PATCH] staging: rtl819x: select CONFIG_CRC32

2021-01-03 Thread Arnd Bergmann
From: Arnd Bergmann Without crc32 support, the drivers fail to link: ERROR: modpost: "crc32_le" [drivers/staging/rtl8192e/rtllib_crypt_wep.ko] undefined! ERROR: modpost: "crc32_le" [drivers/staging/rtl8192e/rtllib_crypt_tkip.ko] undefined! ERROR: modpost: "crc32_le" [drivers/staging/rtl8192u/r