[PATCH] staging/rtl8723bs: replace "foo * bar" with "foo *bar"

2020-10-22 Thread Elena Afanasova
Correct the coding style error reported by checkpatch.pl. Signed-off-by: Elena Afanasova --- drivers/staging/rtl8723bs/include/rtw_mlme.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging/rtl8723bs/include/rtw_mlme

Re: [PATCH v2 10/10] pwm: Add Raspberry Pi Firmware based PWM bus

2020-10-22 Thread Andy Shevchenko
On Thu, Oct 22, 2020 at 9:05 PM Nicolas Saenz Julienne wrote: > > Adds support to control the PWM bus available in official Raspberry Pi > PoE HAT. Only RPi's co-processor has access to it, so commands have to > be sent through RPi's firmware mailbox interface. > drivers/pwm/pwm-raspberrypi.c |

Re: [PATCH v2 01/10] firmware: raspberrypi: Introduce rpi_firmware_put()

2020-10-22 Thread Andy Shevchenko
On Thu, Oct 22, 2020 at 9:06 PM Nicolas Saenz Julienne wrote: > > When unbinding the firmware device we need to make sure it has no > consumers left. Otherwise we'd leave them with a firmware handle > pointing at freed memory. > > Keep a reference count of all consumers and make sure they all fini

[PATCH v2 07/10] input: raspberrypi-ts: Release firmware handle when not needed

2020-10-22 Thread Nicolas Saenz Julienne
After passing the DMA buffer address through the firmware interface, release the firmware handle, we won't need it anymore. Signed-off-by: Nicolas Saenz Julienne --- drivers/input/touchscreen/raspberrypi-ts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/touchscreen/raspberry

[PATCH v2 00/10] Raspberry Pi PoE HAT fan support

2020-10-22 Thread Nicolas Saenz Julienne
The aim of this series is to add support to the fan found on RPi's PoE HAT. Some commentary on the design can be found below. But the imporant part to the people CC'd here not involved with PWM is that, in order to achieve this properly, we also have to fix the firmware interface the driver uses to

[PATCH v2 02/10] clk: bcm: rpi: Release firmware handle on unbind

2020-10-22 Thread Nicolas Saenz Julienne
Upon unbinding the clock device make sure we release RPi's firmware interface. Signed-off-by: Nicolas Saenz Julienne --- drivers/clk/bcm/clk-raspberrypi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index f89b9cfc4309

[PATCH v2 03/10] gpio: raspberrypi-exp: Release firmware handle on unbind

2020-10-22 Thread Nicolas Saenz Julienne
Upon unbinding the device make sure we release RPi's firmware interface. Signed-off-by: Nicolas Saenz Julienne --- drivers/gpio/gpio-raspberrypi-exp.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-raspberrypi-exp.c b/drivers/gpio/gpio-raspb

[PATCH v2 06/10] staging: vchiq: Release firmware handle on unbind

2020-10-22 Thread Nicolas Saenz Julienne
Upon unbinding the device make sure we release RPi's firmware interface. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b

[PATCH v2 04/10] reset: raspberrypi: Release firmware handle on unbind

2020-10-22 Thread Nicolas Saenz Julienne
Upon unbinding the device make sure we release RPi's firmware interface. Signed-off-by: Nicolas Saenz Julienne --- drivers/reset/reset-raspberrypi.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/reset/reset-raspberrypi.c b/drivers/reset/reset-raspberr

[PATCH v2 10/10] pwm: Add Raspberry Pi Firmware based PWM bus

2020-10-22 Thread Nicolas Saenz Julienne
Adds support to control the PWM bus available in official Raspberry Pi PoE HAT. Only RPi's co-processor has access to it, so commands have to be sent through RPi's firmware mailbox interface. Signed-off-by: Nicolas Saenz Julienne --- Changes since v1: - Use default pwm bindings and get rid of

[PATCH v2 08/10] dt-bindings: pwm: Add binding for RPi firmware PWM bus

2020-10-22 Thread Nicolas Saenz Julienne
The PWM bus controlling the fan in RPi's official PoE hat can only be controlled by the board's co-processor. Signed-off-by: Nicolas Saenz Julienne --- Changes since v1: - Update bindings to use 2 #pwm-cells .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 20 +++ .../pwm/raspb

[PATCH v2 09/10] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support

2020-10-22 Thread Nicolas Saenz Julienne
This is an example on how to enable the fan on top of RPi's official PoE hat. Signed-off-by: Nicolas Saenz Julienne --- Changes since v1: - Update patch to use 2 pwm cells arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 54 +++ 1 file changed, 54 insertions(+) diff --git a/a

[PATCH v2 05/10] soc: bcm: raspberrypi-power: Release firmware handle on unbind

2020-10-22 Thread Nicolas Saenz Julienne
Upon unbinding the device make sure we release RPi's firmware interface. Signed-off-by: Nicolas Saenz Julienne --- drivers/soc/bcm/raspberrypi-power.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c i

[PATCH v2 01/10] firmware: raspberrypi: Introduce rpi_firmware_put()

2020-10-22 Thread Nicolas Saenz Julienne
When unbinding the firmware device we need to make sure it has no consumers left. Otherwise we'd leave them with a firmware handle pointing at freed memory. Keep a reference count of all consumers and make sure they all finished unbinding before we do. Suggested-by: Uwe Kleine-König Signed-off-b

Re: [Outreachy kernel] [PATCH] staging/wlan-ng: Fix line alignment

2020-10-22 Thread Julia Lawall
On Thu, 22 Oct 2020, izabela.bakoll...@gmail.com wrote: > From: Izabela Bakollari > > Fix code alignment. Issue reported by checkpatch.pl Try to find something other than "Fix" to describe what you have done. What kind of change have you made and why is it a good idea? > > Signed-off-by: Izab

Re: [Outreachy kernel] [PATCH] staging/wlan-ng: Fix line that exceeds 100 columns

2020-10-22 Thread Julia Lawall
On Thu, 22 Oct 2020, izabela.bakoll...@gmail.com wrote: > From: Izabela Bakollari > > Rearrange comment that exceeds 100 columns length. Issue reported > by checkpatch.pl > > Signed-off-by: Izabela Bakollari > --- > drivers/staging/wlan-ng/cfg80211.c | 3 ++- > 1 file changed, 2 insertions(+

[PATCH] staging/wlan-ng: Fix line alignment

2020-10-22 Thread izabela . bakollari
From: Izabela Bakollari Fix code alignment. Issue reported by checkpatch.pl Signed-off-by: Izabela Bakollari --- drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mg

[PATCH] staging/wlan-ng: Fix line that exceeds 100 columns

2020-10-22 Thread izabela . bakollari
From: Izabela Bakollari Rearrange comment that exceeds 100 columns length. Issue reported by checkpatch.pl Signed-off-by: Izabela Bakollari --- drivers/staging/wlan-ng/cfg80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers

[PATCH] staging/rtl8192u/ieee80211: remove debugging line

2020-10-22 Thread Elena Afanasova
Remove unnecessary debug line from rtl8192u_dot11d_init(). Signed-off-by: Elena Afanasova --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.c b/drivers/staging/rtl8192u/ieee80211/dot11d.c index f972edcd

Re: [Outreachy kernel] Clean up query: greybus/audio_manager_module.c

2020-10-22 Thread Deepak R Varma
On Thu, Oct 22, 2020 at 07:29:31AM +0200, Greg KH wrote: > On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote: > > Hello, > > I am reviewing the file: drivers/staging/greybus/audio_manager_module.c > > and have found that there are several gb_audio_module_*_show functions > > that accep