On Thu, Sep 03, 2020 at 07:24:51PM +0100, Alex Dewar wrote:
> +
> + ret = atomisp_register_i2c_module(&flash->sd, NULL, LED_FLASH);
> + if (!ret)
> + return 0;
Ugh!!! This is a a special case of the "success handling instead of
failure handling" anti-pattern where the last con
This patch was generated, and sent by a script I was working on (and
apparently, still am), that would run sparse,
detect unused variables and eliminate them. However, upon manual
inspection, it became clear
to me that these functions are in fact necessary. I'm sorry this
mistake happened. Kindly i
A few unused variables that were defined were found and removed.
Signed-off-by: Anant Thazhemadam
---
drivers/staging/comedi/drivers/dt2814.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2814.c
b/drivers/staging/comedi/drivers/dt2814.c
index bcf4d5444faf
CONGRATULATION!!!
Reference to the 1,320th Euro-Millions draw that took place on Friday 15th May
2020 at 21:00 CEST (20:00 BST) through the Euro-Millions draw system were your
E-mail address emerged among lucky winners with the drawn winning numbers:
Lucky numbers 11-23-32-34-39 Star Number 1-
On Wed, Sep 2, 2020 at 8:52 PM Nathan Chancellor
wrote:
>
> On Wed, Sep 02, 2020 at 05:36:29PM -0700, Florian Fainelli wrote:
> >
> >
> > On 9/2/2020 3:38 PM, Nathan Chancellor wrote:
> > [snip]
> > > > Hello Nathan,
> > > >
> > > > Can you tell me how much memory your RPI has and if all of it is
The function lm3554_remove() checks for the return code for
lm3554_gpio_uninit() even though this is on the exit path and exits the
function, leaving the variable flash unfreed. Print a warning instead
and free flash unconditionally.
Signed-off-by: Alex Dewar
---
.../staging/media/atomisp/i2c/at
We don't really need to know that the LED pin reset successfully.
Signed-off-by: Alex Dewar
---
drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-lm3554.c
b/drivers/staging/media/atomisp/i2c/atomisp-lm
The error path for lm3554_probe() contains a number of bugs, including:
* resource leaks
* jumping to error labels out of sequence
* not setting the return value appropriately
Fix it up and give the labels more memorable names.
This issue has existed since the code was originally contributed i
> You're right. I wonder if there is really any need for the
> lm3554_gpio_uninit() function at all? It's basically the same as
> lm3554_gpio_init() except for the order of function calls. Probably
> we could just rename lm3554_gpio_init() to something like
> lm3554_gpio_set_default() and use it
Dear Beloved
Life is gradually passing away from me as a result of my present medical
condition and my personal doctor confided in me yesterday that I have only but
few more weeks to live.
In view of this setback, I want to donate my estate for humanitarian
assistance, since this has always be
Dear Beloved
Life is gradually passing away from me as a result of my present medical
condition and my personal doctor confided in me yesterday that I have only but
few more weeks to live.
In view of this setback, I want to donate my estate for humanitarian
assistance, since this has always be
On Thu, Sep 03, 2020 at 04:48:41PM +0100, Alex Dewar wrote:
> Good point about the timer!
>
> > >
> > > - err = lm3554_gpio_init(client);
> > > - if (err) {
> > > + ret = lm3554_gpio_init(client);
> > > + if (ret) {
> > > dev_err(&client->dev, "gpio request/direction_output fail");
> >
Hi Mauro,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[cannot apply to staging/staging-testing linus/master v5.9-rc3 next-20200903]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to
FYI, I've moved it off for-next and into its own dma-ranges branch
for now until we sort out the regressions. I still hope to bring it
back soon.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo
Good point about the timer!
> >
> > - err = lm3554_gpio_init(client);
> > - if (err) {
> > + ret = lm3554_gpio_init(client);
> > + if (ret) {
> > dev_err(&client->dev, "gpio request/direction_output fail");
> > - goto fail2;
> > + goto err_cleanup_entity;
Em Thu, 3 Sep 2020 17:07:24 +0300
Andy Shevchenko escreveu:
> On Thu, Sep 03, 2020 at 03:57:32PM +0200, Mauro Carvalho Chehab wrote:
> > There are some warnings reported by gcc:
> > drivers/staging/media/atomisp//pci/atomisp_compat_css20.c:164:2:
> > warning: function ‘atomisp_css2_dbg_print
On Thu, Sep 03, 2020 at 03:57:32PM +0200, Mauro Carvalho Chehab wrote:
> There are some warnings reported by gcc:
> drivers/staging/media/atomisp//pci/atomisp_compat_css20.c:164:2:
> warning: function ‘atomisp_css2_dbg_print’ might be a candidate for
> ‘gnu_printf’ format attribute [-Wsugge
Hello dear how are you doing? I am Ms. Melvida, am 56 years old from France.I
have a proposal to share with you please kindly get back to me for details via
my email {melvidabullo...@gmail.com}.
thank you as i await your response.
Best Regards,
Melvida.
Email:melvdabullo...@gmail.com
___
There are several vars declared and set but unused:
drivers/staging/media/atomisp//pci/sh_css_param_shading.c:239:4:
warning: variable ‘padded_width’ set but not used [-Wunused-but-set-variable]
drivers/staging/media/atomisp//pci/sh_css.c:1366:24: warning: variable
‘stream’ set b
Gcc reports that input_formatter_alignment is not used:
In file included from
./drivers/staging/media/atomisp//pci/hive_isp_css_include/input_formatter.h:34,
from
drivers/staging/media/atomisp//pci/runtime/debug/src/ia_css_debug.c:55:
./drivers/staging/m
As warned by gcc:
drivers/staging/media/atomisp//pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c:237:31:
warning: variable ‘isp_data_ptr’ set but not used [-Wunused-but-set-variable]
ia_css_vf_configure() logic has an error var that detects troubles
when setting the kernel for downscaling. Th
There are some warnings reported by gcc:
drivers/staging/media/atomisp//pci/atomisp_compat_css20.c:164:2:
warning: function ‘atomisp_css2_dbg_print’ might be a candidate for
‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
drivers/staging/media/atomisp//pci/atomisp_compa
The linux-media policy is to have zero warnings with W=1. However, when
I started using a Jenkins instance at https://builder.linuxtv.org to automate
such tests, I didn't notice that a bug at the scripts were just ignoring
warnings.
Now that this is fixed, we need to get rid of the warnings that g
The code that used to check for ISP2400/2401 version were
using the revision number in order to decide wheather
version should be used. With the new version, the code
doesn't need to check anymore for ISP version.
Fixes: ca133c395f2f ("media: atomisp: improve device detection code")
Signed-off-by:
On Wed, Sep 02, 2020 at 07:41:50PM +0100, Alex Dewar wrote:
> The error path for lm3554_probe() contains a number of bugs, including:
> * resource leaks
> * jumping to error labels out of sequence
> * not setting the return value appropriately
>
> Fix it up and give the labels more memorable na
On Wed, Sep 02, 2020 at 05:58:52PM +0100, Colin King wrote:
> From: Colin Ian King
>
> In the case where the call to lm3554_platform_data_func returns an
> error there is a memory leak on the error return path of object
> flash. Fix this by adding an error return path that will free
> flash and
Em Wed, 2 Sep 2020 21:15:31 +0300
Andy Shevchenko escreveu:
> On Wed, Sep 2, 2020 at 8:02 PM Colin King wrote:
> >
> > From: Colin Ian King
> >
> > In the case where the call to lm3554_platform_data_func returns an
> > error there is a memory leak on the error return path of object
> > flash.
27 matches
Mail list logo
