On 26/06/2020 02:17, Dmitry Osipenko wrote:
> 24.06.2020 18:23, Dmitry Osipenko пишет:
>> 24.06.2020 18:16, Hans Verkuil пишет:
>>> On 24/06/2020 17:08, Dmitry Osipenko wrote:
Hello,
This small series addresses a Runtime PM issue that was discovered during
of Tegra VI driver rev
writes:
> From: Ajay Singh
>
> WILC1000 is an IEEE 802.11 b/g/n IoT link controller module. The
> WILC1000 connects to Microchip AVR/SMART MCUs, SMART MPUs, and other
> processors with minimal resource requirements with a simple
> SPI/SDIO-to-Wi-Fi interface.
>
> WILC1000 driver has been part of
Hi,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on wireless-drivers-next/master
wireless-drivers/master v5.8-rc2 next-20200625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when
Greg KH writes:
> On Wed, Jun 24, 2020 at 12:49:24PM +0300, Kalle Valo wrote:
>> Greg KH writes:
>>
>> > On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote:
>> >> writes:
>> >>
>> >> > From: Ajay Singh
>> >> >
>> >> > This patch series is to review and move wilc1000 driver out of sta
On Thu, Jun 25, 2020 at 10:17:23PM -0400, B K Karthik wrote:
> soc_camera.c:
>
> fixing ERROR: Macros with complex values must be enclused within parentheses.
>
> Signed-off-by: B K Karthik
> ---
> drivers/staging/media/soc_camera/soc_camera.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deleti
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
branch HEAD: 92cd1b5d65f5c67147c7da39a3c2ad7e6ff81027 staging: ion: fix common
struct sg_table related issues
elapsed time: 725m
configs tested: 120
configs skipped: 5
The following configs have b
Hi Karthik,
Thank you for the patch.
On Thu, Jun 25, 2020 at 10:17:23PM -0400, B K Karthik wrote:
> soc_camera.c:
>
> fixing ERROR: Macros with complex values must be enclused within parentheses.
>
> Signed-off-by: B K Karthik
> ---
> drivers/staging/media/soc_camera/soc_camera.c | 3 +--
> 1
soc_camera.c:
fixing ERROR: Macros with complex values must be enclused within parentheses.
Signed-off-by: B K Karthik
---
drivers/staging/media/soc_camera/soc_camera.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/soc_camera/soc_camera.c
b/drivers
24.06.2020 18:23, Dmitry Osipenko пишет:
> 24.06.2020 18:16, Hans Verkuil пишет:
>> On 24/06/2020 17:08, Dmitry Osipenko wrote:
>>> Hello,
>>>
>>> This small series addresses a Runtime PM issue that was discovered during
>>> of Tegra VI driver reviewing by balancing RPM usage count on RPM resume
>>
On Fri, 2020-06-26 at 05:57 +0800, Coiby Xu wrote:
> Remove unnecessary elses after return or break.
unrelated trivia:
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
[]
> @@ -1391,12 +1391,11 @@ static void ql_dump_cam_entries(struct ql_adapter
> *qdev)
>
On Thu, Jun 25, 2020 at 08:25:10PM +0300, Dan Carpenter wrote:
The subject isn't right (no subsystem prefix) and we need a commit
message.
regards,
dan carpenter
Thank you for pointing out the exact problems!
--
Best regards,
Coiby
___
devel mailing
Remove trailing "*/" in block comments.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_main.c | 3 ++-
drivers/staging/qlge/qlge_mpi.c | 10 ++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
inde
Remove unnecessary elses after return or break.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_dbg.c | 23 ++-
drivers/staging/qlge/qlge_main.c | 8
drivers/staging/qlge/qlge_mpi.c | 4 ++--
3 files changed, 16 insertions(+), 19 deletions(-)
diff --git a/
These two patches fix two coding style problems for all files under
drivers/staging/qlge as reported by checkpatch.pl,
- trailing */ in block comment
- unnecessary else after return or break
Coiby Xu (2):
fix trailing */ in block comment
fix else after return or break
drivers/staging
The subject isn't right (no subsystem prefix) and we need a commit
message.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Jun 25, 2020 at 11:36:13PM +0800, Coiby Xu wrote:
> Signed-off-by: Coiby Xu
> ---
> drivers/staging/qlge/qlge_main.c | 3 ++-
> drivers/staging/qlge/qlge_mpi.c | 10 ++
> 2 files changed, 8 insertions(+), 5 deletions(-)
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartm
On Thu, Jun 25, 2020 at 11:36:14PM +0800, Coiby Xu wrote:
> Signed-off-by: Coiby Xu
> ---
> drivers/staging/qlge/qlge_dbg.c | 23 ++-
> drivers/staging/qlge/qlge_main.c | 8
> drivers/staging/qlge/qlge_mpi.c | 4 ++--
> 3 files changed, 16 insertions(+), 19 deleti
On Thu, Jun 25, 2020 at 11:35:17AM -0400, B K Karthik wrote:
> staging: media: soc_camera: soc_camera.c: Clearing coding-style problem
> "Macros with complex values should be enclosed in parentheses" in line 241 by
> adding parentheses.
> staging: media: soc_camera: soc_camera.c: Clearing coding-s
From: Ajay Singh
WILC1000 is an IEEE 802.11 b/g/n IoT link controller module. The
WILC1000 connects to Microchip AVR/SMART MCUs, SMART MPUs, and other
processors with minimal resource requirements with a simple
SPI/SDIO-to-Wi-Fi interface.
WILC1000 driver has been part of staging for few years.
staging: media: soc_camera: soc_camera.c: Clearing coding-style problem
"Macros with complex values should be enclosed in parentheses" in line 241 by
adding parentheses.
staging: media: soc_camera: soc_camera.c: Clearing coding-style problem
"Alignment should match open parenthesis" by adding tab
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_main.c | 3 ++-
drivers/staging/qlge/qlge_mpi.c | 10 ++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 1650de13842f..aaecf2b0f9a1 100644
--- a
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_dbg.c | 23 ++-
drivers/staging/qlge/qlge_main.c | 8
drivers/staging/qlge/qlge_mpi.c | 4 ++--
3 files changed, 16 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging
These two patches fix two coding style problems for all files under
drivers/staging/qlge as reported by checkpatch.pl,
- trailing */ in block comment
- unnecessary else after return or break
Coiby Xu (2):
fix trailing */ in block comment
fix else after return or break
drivers/staging
On Tue, Jun 23, 2020 at 06:41:46PM +0200, Nicolas Saenz Julienne wrote:
> vchi acts as a mid layer between vchiq and its kernel services, while
> arguably providing little to no benefit: half of the functions exposed
> are a 1:1 copy of vchiq's, and the rest provide some functionality which
> can b
On Wed, Jun 24, 2020 at 08:20:35PM +0200, Garrit Franke wrote:
> Signed-off-by: Garrit Franke
>
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq
On Thu, Jun 25, 2020 at 09:50:51AM -0400, B K Karthik wrote:
> Signed-off-by: B K Karthik
> ---
> drivers/staging/nvec/nvec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 360ec0407740..16afbe1dfdeb
Signed-off-by: B K Karthik
---
drivers/staging/nvec/nvec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec0407740..16afbe1dfdeb 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
On Thu, Jun 25, 2020 at 09:25:13AM -0400, Brooke Basile wrote:
> Fixing checkpatch WARNING: Symbolic permissions 'S_IRUGO' are not preferred.
> Consider using octal permissions '0444'.
>
> Signed-off-by: Brooke Basile
> ---
> drivers/staging/gasket/gasket_sysfs.h | 2 +-
> 1 file changed, 1 ins
Fixing checkpatch WARNING: Symbolic permissions 'S_IRUGO' are not preferred.
Consider using octal permissions '0444'.
Signed-off-by: Brooke Basile
---
drivers/staging/gasket/gasket_sysfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.h
On Thu, Jun 25, 2020 at 11:32:37AM +0200, Garrit Franke wrote:
> Cleans up some bitshifts by using the BIT macro.
>
> Signed-off-by: Garrit Franke
Looks good.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdrive
Cleans up some bitshifts by using the BIT macro.
Signed-off-by: Garrit Franke
---
.../interface/vchiq_arm/vchiq_core.c | 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
b/drivers/stag
On Wed, Jun 24, 2020 at 08:20:34PM +0200, Garrit Franke wrote:
> This should prevent possible overflowing bits by using the BIT macro in
> vchiq_core
>
There are no "overflowing bits". Fold both patches together.
regards,
dan carpenter
___
devel mail
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/Makefile
> b/drivers/staging/vc04_services/vchiq-mmal/Makefile
> index f8164c33aec3..b2a830f48acc 100644
> --- a/drivers/staging/vc04_services/vchiq-mmal/Makefile
> +++ b/drivers/staging/vc04_services/vchiq-mmal/Makefile
> @@ -5,4 +5,5 @@ obj-
33 matches
Mail list logo
