Le 14/04/2020 à 00:28, Waiman Long a écrit :
Since kfree_sensitive() will do an implicit memzero_explicit(), there
is no need to call memzero_explicit() before it. Eliminate those
memzero_explicit() and simplify the call sites. For better correctness,
the setting of keylen is also moved down af
generic-64bit_defconfig
x86_64 randconfig-a001-20200413
x86_64 randconfig-a002-20200413
x86_64 randconfig-a003-20200413
i386 randconfig-a001-20200413
i386 randconfig-a002-20200413
i386 randconfig-a003-20200413
Since kfree_sensitive() will do an implicit memzero_explicit(), there
is no need to call memzero_explicit() before it. Eliminate those
memzero_explicit() and simplify the call sites. For better correctness,
the setting of keylen is also moved down after the key pointer check.
Signed-off-by: Waiman
Correct a spelling mistake discovered by checkpatch.
attatch -> attach
Signed-off-by: Michael Straube
---
drivers/staging/rtl8712/usb_halinit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/usb_halinit.c
b/drivers/staging/rtl8712/usb_halinit.c
index
On 4/13/20 5:31 PM, Joe Perches wrote:
> On Mon, 2020-04-13 at 17:15 -0400, Waiman Long wrote:
>> Since kfree_sensitive() will do an implicit memzero_explicit(), there
>> is no need to call memzero_explicit() before it. Eliminate those
>> memzero_explicit() and simplify the call sites.
> 2 bits of
On Mon, 2020-04-13 at 17:15 -0400, Waiman Long wrote:
> Since kfree_sensitive() will do an implicit memzero_explicit(), there
> is no need to call memzero_explicit() before it. Eliminate those
> memzero_explicit() and simplify the call sites.
2 bits of trivia:
> diff --git a/drivers/crypto/allwin
As said by Linus:
A symmetric naming is only helpful if it implies symmetries in use.
Otherwise it's actively misleading.
In "kzalloc()", the z is meaningful and an important part of what the
caller wants.
In "kzfree()", the z is actively detrimental, because maybe in the
future we r
Since kfree_sensitive() will do an implicit memzero_explicit(), there
is no need to call memzero_explicit() before it. Eliminate those
memzero_explicit() and simplify the call sites.
Signed-off-by: Waiman Long
---
.../crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 15 +++
.../crypto/
This patchset makes a global rename of the kzfree() to kfree_sensitive()
to highlight the fact buffer clearing is only needed if the data objects
contain sensitive information like encrpytion key. The fact that kzfree()
uses memset() to do the clearing isn't totally safe either as compiler
may comp
-64bit_defconfig
parisc allyesconfig
x86_64 randconfig-a001-20200413
x86_64 randconfig-a002-20200413
x86_64 randconfig-a003-20200413
i386 randconfig-a001-20200413
i386 randconfig-a002-20200413
i386
Rename 'FWDL_ChkSum_rpt' to 'FWDL_CHKSUM_RPT' as defines are normaly
named all upper case. Also clears a camel case checkpatch warning.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/fw.c| 4 ++--
drivers/staging/rtl8188eu/include/rtl8188e_spec.h | 2 +-
2 files
Make const char array 'fw_name' static. Clears a checkpatch warning
and reduces object file size by 17 bytes (gcc 9.3.1 x86_64).
WARNING: const array should probably be static const
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 d
This series clears the last remaining checkpatch issues in the file
hal/fw.c.
Michael Straube (3):
staging: rtl8188eu: rename define to upper case
staging: rtl8188eu: cleanup long line in fw.c
staging: rtl8188eu: make const char array static
drivers/staging/rtl8188eu/hal/fw.c
Add line break to avoid line length over 80 characters.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/fw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging/rtl8188eu/hal/fw.c
index dbf7883f9ed7..432e6be
Make function arguments alignment match open parenthesis.
Found using checkpatch.pl.
Signed-off-by: R Veera Kumar
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2
Make function arguments alignment match open parenthesis.
Found using checkpatch.pl.
Signed-off-by: R Veera Kumar
---
drivers/staging/sm750fb/sm750.h| 23 +--
drivers/staging/sm750fb/sm750_hw.c | 2 +-
2 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/driv
64r6el_defconfig
mips allnoconfig
mips 32r2_defconfig
mips allmodconfig
pariscgeneric-64bit_defconfig
parisc allyesconfig
i386 randconfig-a002-20200413
x86_64
Variable 'n' in 'mt7621_pcie_init_virtual_bridges' function
can be directly initialized when it is declared instead of
doing it before using it first.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
Definition 'PCIE_P2P_MAX' is '3'. The value here is not a MAXimum.
It is a count or a number. It is how many masks there are.
The masks are numbered 0, 1, 2 so the maximum is 2. Hence rename
variable into 'PCIE_P2P_CNT' which is a more accurate name.
Suggested-by: NeilBrown
Signed-off-by: Sergio
Add a comment explaining a bit what is going on in this function.
It would be helfulp for other people for a better understanding
of the code.
Suggested-by: NeilBrown
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 5 +
1 file changed, 5 insertions(+)
diff -
On Mon, 2020-04-13 at 14:50 +0200, Greg KH wrote:
> On Mon, Apr 13, 2020 at 03:01:28AM +, Camylla Goncalves Cantanheide wrote:
> > Changes of the local variable value and
> > modification in the seletive repetition structure.
[]
> > diff --git a/drivers/staging/rtl8192u/r8192U_core.c
> > b/dri
allmodconfig
parisc allyesconfig
x86_64 randconfig-a001-20200413
x86_64 randconfig-a002-20200413
x86_64 randconfig-a003-20200413
i386 randconfig-a001-20200413
i386 randconfig-a002-20200413
i386
On Mon, Apr 13, 2020 at 04:32:58PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 13, 2020 at 04:25:17PM +0200, Oscar Carter wrote:
> > On Mon, Apr 13, 2020 at 02:56:16PM +0200, Greg Kroah-Hartman wrote:
> > > On Sat, Apr 11, 2020 at 02:26:09PM +0200, Oscar Carter wrote:
> > > > Create a constant a
On Mon, Apr 13, 2020 at 04:29:07PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 13, 2020 at 04:13:15PM +0200, Oscar Carter wrote:
> > On Mon, Apr 13, 2020 at 02:56:33PM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Apr 07, 2020 at 06:39:14PM +0200, Oscar Carter wrote:
> > > > Use the define RATE
On Mon, Apr 13, 2020 at 04:25:17PM +0200, Oscar Carter wrote:
> On Mon, Apr 13, 2020 at 02:56:16PM +0200, Greg Kroah-Hartman wrote:
> > On Sat, Apr 11, 2020 at 02:26:09PM +0200, Oscar Carter wrote:
> > > Create a constant array with the values of the "phy->signal" for every
> > > rate. Remove all "
On Mon, Apr 13, 2020 at 04:13:15PM +0200, Oscar Carter wrote:
> On Mon, Apr 13, 2020 at 02:56:33PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Apr 07, 2020 at 06:39:14PM +0200, Oscar Carter wrote:
> > > Use the define RATE_11M present in the file "device.h" instead of the
> > > magic number 3. So
On Mon, Apr 13, 2020 at 02:56:16PM +0200, Greg Kroah-Hartman wrote:
> On Sat, Apr 11, 2020 at 02:26:09PM +0200, Oscar Carter wrote:
> > Create a constant array with the values of the "phy->signal" for every
> > rate. Remove all "phy->signal" assignments inside the switch statement
> > and replace t
On Mon, Apr 13, 2020 at 02:56:33PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 07, 2020 at 06:39:14PM +0200, Oscar Carter wrote:
> > Use the define RATE_11M present in the file "device.h" instead of the
> > magic number 3. So the code is more clear.
> >
> > Reviewed-by: Dan Carpenter
> > Signed
Use a formula to calculate the return value of the vnt_rf_addpower
function instead of the "if" statement with literal values for every
case.
Signed-off-by: Oscar Carter
---
What is the better approach for this function ? Leave it as is or use
a formula although it is less clear.
I prefer the fo
On Mon, Apr 13, 2020 at 12:19:31PM +0200, Oscar Carter wrote:
> Use the error code returned by the vnt_control_out function as the
> returned value of the vnt_rf_write_embedded function instead of a
> boolean value.
>
> Then, fix all vnt_rf_write_embedded calls removing the "and" operations
> and
On Sun, Apr 12, 2020 at 11:33:11AM +0200, Oscar Carter wrote:
> Use the BIT() macro instead of the bit left shift operator. So the code
> is more clear.
>
> It's safe to remove the casting to u16 type because the value obtained
> never exceeds 16 bits. So the casting is unnecessary.
>
> Signed-of
On Tue, Apr 07, 2020 at 06:39:14PM +0200, Oscar Carter wrote:
> Use the define RATE_11M present in the file "device.h" instead of the
> magic number 3. So the code is more clear.
>
> Reviewed-by: Dan Carpenter
> Signed-off-by: Oscar Carter
> ---
> drivers/staging/vt6656/baseband.c | 3 ++-
> 1
On Sat, Apr 11, 2020 at 02:26:09PM +0200, Oscar Carter wrote:
> Create a constant array with the values of the "phy->signal" for every
> rate. Remove all "phy->signal" assignments inside the switch statement
> and replace these with a single reading from the new vnt_phy_signal
> array.
>
> The con
On Sun, Apr 12, 2020 at 04:25:08PM +0200, carlosteniswarr...@gmail.com wrote:
> Fixed two checkpatch warnings.
>
> Signed-off-by: Carlos Guerrero Alvarez
> ---
> drivers/staging/comedi/drivers/jr3_pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging
On Mon, Apr 13, 2020 at 10:05:55AM +0200, carlosteniswarr...@gmail.com wrote:
> Fixed a coding style issue caused by some declarations that weren't separated.
>
> Signed-off-by: Carlos Guerrero Alvarez
Your From: line in your email client does not match with this :(
> ---
> drivers/staging/com
On Mon, Apr 13, 2020 at 03:01:29AM +, Camylla Goncalves Cantanheide wrote:
> Renames the local variables of the setKey
> function, making them explicit.
Why do this?
>
> Signed-off-by: Camylla Goncalves Cantanheide
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 48 +--
On Mon, Apr 13, 2020 at 03:01:28AM +, Camylla Goncalves Cantanheide wrote:
> Changes of the local variable value and
> modification in the seletive repetition structure.
>
> Signed-off-by: Camylla Goncalves Cantanheide
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 52 -
Use the error code returned by the vnt_control_out function as the
returned value of the vnt_rf_write_embedded function instead of a
boolean value.
Then, fix all vnt_rf_write_embedded calls removing the "and" operations
and replace with a direct assignment to the ret variable and add a check
condi
Fixed a coding style issue caused by some declarations that weren't separated.
Signed-off-by: Carlos Guerrero Alvarez
---
drivers/staging/comedi/drivers/das08.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi/drivers/das08.c
Hi greg：
On 2020/4/12 15:46, Greg KH wrote:
On Sat, Apr 11, 2020 at 10:51:51PM +0800, Tang Bin wrote:
Fix missing braces compilation warning in the ARM
compiler environment:
drivers/android/binderfs.c: In function 'binderfs_fill_super':
drivers/android/binderfs.c:650:9: warning: missi
On Sat, Apr 11, 2020 at 10:51:51PM +0800, Tang Bin wrote:
> Fix missing braces compilation warning in the ARM
> compiler environment:
> drivers/android/binderfs.c: In function 'binderfs_fill_super':
> drivers/android/binderfs.c:650:9: warning: missing braces around
> initializer [-Wmissing
41 matches
Mail list logo
