[PATCH] Staging: comedi: dt2815: remove set but not used variable 'hi'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn: drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable 'hi' set but not used [-Wunused-but-set-variable] commit d6a929b7608a ("Staging: comedi: add dt2815 driver") involv

[PATCH] Staging: rtl8192e: remove set but not used variable 'tmpRegC'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c: In function rtl92e_start_adapter: drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:693:15: warning: variable ‘tmpRegC’ set but not used [-Wunused-but-set-variable] commit 94a799425eee ("rtl8192e: Split

[PATCH] staging: rtl8192u: Remove some set but not used variables

Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8192u/r8192U_core.c: In function rtl8192_hard_data_xmit: drivers/staging/rtl8192u/r8192U_core.c:905:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/staging/rtl8192u/r8192U_core.c: In function rtl8192

[staging:staging-testing] BUILD SUCCESS e7b6875944e61bec586ede80b95727cd55381e1e

generic-32bit_defconfig parisc allyesconfig x86_64 randconfig-a003-20200405 i386 randconfig-a002-20200405 x86_64 randconfig-a002-20200405 x86_64 randconfig-a001-20200405 i386 randconfi

Re: [kbuild-all] Re: [staging:staging-testing 41/41] drivers/staging/vt6655/baseband.c:1711:15: warning: The scope of the variable 'preamble' can be reduced. [variableScope]

On 4/5/2020 9:07 PM, Greg Kroah-Hartman wrote: On Sun, Apr 05, 2020 at 08:43:40PM +0800, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: e7b6875944e61bec586ede80b95727cd55381e1e commit: e7b6875944e61bec586ede80b95727

Re: [staging:staging-testing 41/41] drivers/staging/vt6655/baseband.c:1711:15: warning: The scope of the variable 'preamble' can be reduced. [variableScope]

On Sun, Apr 05, 2020 at 08:43:40PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: e7b6875944e61bec586ede80b95727cd55381e1e > commit: e7b6875944e61bec586ede80b95727cd55381e1e [41/41] Staging: vt6655: > Replac

[PATCH] staging: gdm724x: remove redundant assignment to pointer 'w'

From: Colin Ian King The pointer 'w' is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/staging/gdm724x/gdm_lte.c

[staging:staging-testing 41/41] drivers/staging/vt6655/baseband.c:1711:15: warning: The scope of the variable 'preamble' can be reduced. [variableScope]

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: e7b6875944e61bec586ede80b95727cd55381e1e commit: e7b6875944e61bec586ede80b95727cd55381e1e [41/41] Staging: vt6655: Replace camel case variable names. If you fix the issue, kindly add following tag

[PATCH 2/2] staging: rtl8188eu: remove unnecessary variable

The variable 'bStopBlinking' is used in if tests immediately after its value is set. Use the conditions for setting 'bStopBlinking' diretly in the subsequent if tests and remove the variable. Slightly reduces object file size by 16 bytes (gcc 9.2.1 x86_64). Signed-off-by: Michael Straube --- dri

[PATCH 1/2] staging: rtl8188eu: remove unnecessary asignment

Remove unnecessary asignment in SwLedBlink1(). The code path with the asignment 'pLed->BlinkTimes = 0' is only executed when 'pLed->BlinkTimes' is already zero and the value is not changed between the test 'if (pLed->BlinkTimes == 0)' and the asignment. Signed-off-by: Michael Straube --- drivers

Re: [PATCH 3/3] staging: iio: ad5933: use iio_device_attach_kfifo_buffer() helper

On Wed, 1 Apr 2020 15:59:36 +0300 Alexandru Ardelean wrote: > This driver calls iio_kfifo_allocate() vs devm_iio_kfifo_allocate(). But > the conversion is still simpler here, and cleans-up/reduces some error > paths. > > Signed-off-by: Alexandru Ardelean This mixes devm managed stuff an unmana

Re: [PATCH 1/3] iio: kfifo: add iio_device_attach_kfifo_buffer() helper

On Wed, 1 Apr 2020 15:59:34 +0300 Alexandru Ardelean wrote: > This change adds the iio_device_attach_kfifo_buffer() helper/short-hand, > which groups the simple routine of allocating a kfifo buffers via > devm_iio_kfifo_allocate() and calling iio_device_attach_buffer(). > > The mode_flags parame

Re: [PATCH 2/3] iio: make use of iio_device_attach_kfifo_buffer() where straightforward

On Wed, 1 Apr 2020 15:59:35 +0300 Alexandru Ardelean wrote: > All drivers that already call devm_iio_kfifo_allocate() & > iio_device_attach_buffer() are simple to convert to > iio_device_attach_kfifo_buffer() in a single go/patch/. > > This change does that. > > For drivers max30100 & max30102