Re: [PATCH v3 0/5] staging: mt7621-pci: re-do reset boot process

2020-03-12 Thread Sergio Paracuellos
Hi again Greg, On Fri, Mar 13, 2020 at 6:45 AM Sergio Paracuellos wrote: > > Hi Greg, > > On Fri, Mar 13, 2020 at 4:51 AM Greg Ungerer wrote: > [snip] > > > > I applied the patches to the staging git tree for testing. > > I have seen a couple of different problems on boot up: > > > > ... > > rt2

Re: [PATCH v3 0/5] staging: mt7621-pci: re-do reset boot process

2020-03-12 Thread Sergio Paracuellos
Hi Greg, On Fri, Mar 13, 2020 at 4:51 AM Greg Ungerer wrote: [snip] > > I applied the patches to the staging git tree for testing. > I have seen a couple of different problems on boot up: > > ... > rt2880-pinmux pinctrl: pcie is already enabled > mt7621-pci 1e14.pcie: Error applying setting,

Re: [PATCH v3 0/5] staging: mt7621-pci: re-do reset boot process

2020-03-12 Thread Greg Ungerer
Hi Sergio, On 12/3/20 7:00 pm, Sergio Paracuellos wrote: Some time ago Greg Ungerer reported some random hangs using the staging mt7621-pci driver: See: * http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2019-June/134947.html Try to fix that is the main motivation of this pat

Re: [PATCH] staging: exfat: fixed coding style warning

2020-03-12 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I incl

Re: [PATCH] staging: exfat: fixed coding style warning

2020-03-12 Thread Greg KH
On Thu, Mar 12, 2020 at 10:01:27PM +, Miguel Faggioni wrote: > Inverted comparison order on r8192U_wx.c:752 to place constant on the > right side. > > Signed-off-by: Miguel Faggioni > --- > drivers/staging/rtl8192u/r8192U_wx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The subj

[PATCH] staging: exfat: fixed coding style warning

2020-03-12 Thread Miguel Faggioni
Inverted comparison order on r8192U_wx.c:752 to place constant on the right side. Signed-off-by: Miguel Faggioni --- drivers/staging/rtl8192u/r8192U_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx

Hello Friend,, 03/12/2020..

2020-03-12 Thread Hello
Good day, My name is Reem E. Hashimy, the Emirates Minister of State and Managing Director of the United Arab Emirates (Dubai) World Expo 2020 Committee. I am writing you to manage my funds I received as financial gratification from various foreign companies I assisted to receive participation

[PATCH 1/2] staging: bcm2835-camera: Drop unused ignore_errors flag

2020-03-12 Thread Stefan Wahren
The struct bm2835_mmal_v4l2_ctrl contains an ignore_errors flag which was always set to false. So drop the unused flag. Signed-off-by: Stefan Wahren --- .../vc04_services/bcm2835-camera/controls.c| 34 +- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/d

[PATCH 2/2] staging: bcm2835-camera: Use designators to init V4L2 controls

2020-03-12 Thread Stefan Wahren
The initializer lists for the V4L2 controls are hard to read. So improve this by using designators. Signed-off-by: Stefan Wahren --- .../vc04_services/bcm2835-camera/controls.c| 424 ++--- 1 file changed, 277 insertions(+), 147 deletions(-) diff --git a/drivers/staging/v

[PATCH 0/2] staging: bcm2835-camera: Improve bm2835_mmal_v4l2_ctrl

2020-03-12 Thread Stefan Wahren
These 2 patches improves the V4L2 controls in the bcm2835 camera driver. Stefan Wahren (2): staging: bcm2835-camera: Drop unused ignore_errors flag staging: bcm2835-camera: Use designators to init V4L2 controls .../vc04_services/bcm2835-camera/controls.c| 458 + 1

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: sdio_halinit: Remove unnecessary conditions

2020-03-12 Thread Joe Perches
On Thu, 2020-03-12 at 03:58 +0530, Shreeya Patel wrote: > Hey Joe, > > On March 11, 2020 10:56:29 PM GMT+05:30, Joe Perches wrote: > > On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote: > > > Remove if and else conditions since both are leading to the > > > initialization of "valueDMATimeout

[staging:staging-testing] BUILD SUCCESS c15e7f072288bc6d19bbab065a8b60ca096529bf

2020-03-12 Thread kbuild test robot
randconfig-a003-20200311 i386 randconfig-a001-20200311 i386 randconfig-a002-20200311 i386 randconfig-a003-20200311 x86_64 randconfig-a001-20200312 x86_64 randconfig-a002-20200312 x86_64 randconfig

[staging:staging-linus] BUILD SUCCESS ac42c12dd752d315a7027dcb50421dbbd1af53bd

2020-03-12 Thread kbuild test robot
allmodconfig mips allyesconfig mips fuloong2e_defconfig mips malta_kvm_defconfig pariscallnoconfig i386 randconfig-a003-20200312 i386 randconfig-a001-20200312 x86_64

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions

2020-03-12 Thread Lakshmi Ramasubramanian
On 3/12/2020 3:49 AM, Julia Lawall wrote: Thanks for your input Julia and Stefano. That's my general preference as well, but I can't find any point in the "Describe your changes" section of submitting-patches.rst actually defining the order. I wouldn't imply that from the sequence the steps are

Re: [PATCH] staging: greybus: Use scnprintf() for avoiding potential buffer overflow

2020-03-12 Thread Johan Hovold
On Thu, Mar 12, 2020 at 05:51:11PM +0300, Dan Carpenter wrote: > On Wed, Mar 11, 2020 at 10:58:14AM +0100, Johan Hovold wrote: > > On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote: > > > Since snprintf() returns the would-be-output size instead of the > > > actual output size, the succe

Re: [PATCH] staging: greybus: Use scnprintf() for avoiding potential buffer overflow

2020-03-12 Thread Dan Carpenter
On Wed, Mar 11, 2020 at 10:58:14AM +0100, Johan Hovold wrote: > On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote: > > Since snprintf() returns the would-be-output size instead of the > > actual output size, the succeeding calls may go beyond the given > > buffer limit. Fix it by replac

Re: [PATCH 3/5] staging: wfx: make warning about pending frame less scary

2020-03-12 Thread Dan Carpenter
On Tue, Mar 10, 2020 at 11:13:54AM +0100, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Removing station while some traffic is in progress may happen. > You're doing this in every commit where you start the commit message in the subject and then just keep writing. Take a look at your patc

Consulta Marzo 2020

2020-03-12 Thread info14
Buenos días Os informamos que se encuentra abierto el plazo de inscripción para la presente Convocatoria de Cursos Bonificables para empleados (Marzo 2020) Todos los cursos son totalmente Bonificables con cargo al Crédito de Formación 2020 que disponen las empresas. Deseáis que os mandemos

Re: [PATCH 2/5] staging: wfx: fix lines ending with a comma instead of a semicolon

2020-03-12 Thread Dan Carpenter
On Tue, Mar 10, 2020 at 11:13:53AM +0100, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Obviously introduced by mistake. > I have a Smatch check for when people use a comma instead of semi-colon, but I have never published it because it seems totally harmless. I can't think of a reason wh

[PATCH 3/3] staging: greybus: loopback_test: fix potential path truncations

2020-03-12 Thread Johan Hovold
Newer GCC warns about possible truncations of two generated path names as we're concatenating the configurable sysfs and debugfs path prefixes with a filename and placing the results in buffers of the same size as the maximum length of the prefixes. snprintf(d->name, MAX_STR_LEN, "gb_loopb

[PATCH 2/3] staging: greybus: loopback_test: fix potential path truncation

2020-03-12 Thread Johan Hovold
Newer GCC warns about a possible truncation of a generated sysfs path name as we're concatenating a directory path with a file name and placing the result in a buffer that is half the size of the maximum length of the directory path (which is user controlled). loopback_test.c: In function 'open_po

[PATCH 1/3] staging: greybus: loopback_test: fix poll-mask build breakage

2020-03-12 Thread Johan Hovold
A scripted conversion from userland POLL* to kernel EPOLL* constants mistakingly replaced the poll flags in the loopback_test tool, which therefore no longer builds. Fixes: a9a08845e9ac ("vfs: do bulk POLL* -> EPOLL* replacement") Cc: stable # 4.16 Signed-off-by: Johan Hovold --- drivers/st

[PATCH 0/3] staging: greybus: loopback_test: fix build breakage

2020-03-12 Thread Johan Hovold
The loopback_test tool hasn't received much love lately. In fact, it has failed to build for the past two years after a scripted EPOLL* conversion. Newer GCC also started warning for potential string truncation of generated path names; the last two patches addresses that. Johan Johan Hovold (3)

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions

2020-03-12 Thread Julia Lawall
On Thu, 12 Mar 2020, Stefano Brivio wrote: > Hi Lakshmi, > > On Wed, 11 Mar 2020 19:42:06 -0700 > Lakshmi Ramasubramanian wrote: > > > On 3/11/2020 6:58 AM, Shreeya Patel wrote: > > > > > Remove unnecessary if and else conditions since both are leading to the > > > initialization of "phtpriv->

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions

2020-03-12 Thread Stefano Brivio
Hi Lakshmi, On Wed, 11 Mar 2020 19:42:06 -0700 Lakshmi Ramasubramanian wrote: > On 3/11/2020 6:58 AM, Shreeya Patel wrote: > > > Remove unnecessary if and else conditions since both are leading to the > > initialization of "phtpriv->ampdu_enable" with the same value. > > > > Signed-off-by: Shr

[PATCH] staging: rtl8188eu: Add device id for MERCUSYS MW150US v2

2020-03-12 Thread Michael Straube
This device was added to the stand-alone driver on github. Add it to the staging driver as well. Link: https://github.com/lwfinger/rtl8188eu/commit/2141f244c3e7 Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/driv

[PATCH v3 4/5] staging: mt7621-pci: bindings: update doc accordly to last changes

2020-03-12 Thread Sergio Paracuellos
Properly update bindings documentation with added 'reset-gpios' property. Delete also 'perst-gpio' which is not being used anymore. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/

[PATCH v3 3/5] staging: mt7621-dts: make use of 'reset-gpios' property for pci

2020-03-12 Thread Sergio Paracuellos
Properly set pins for group pcie as 'gpio' function and declare gpio's in the pci node to make reset stuff properly functional. Delete no more needed general reset and previous pers gpio which is now being used in 'reset-gpios' property. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt76

[PATCH v3 5/5] staging: mt7621-pci: release gpios after pci initialization

2020-03-12 Thread Sergio Paracuellos
R3G's LEDs fail to initialize because one of them uses GPIO8 Hence, release the GPIO resources after PCIe initialization and properly release also in driver error path. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 23 ++- 1 file changed, 18

[PATCH v3 2/5] staging: mt7621-pci: change value for 'PERST_DELAY_US'

2020-03-12 Thread Sergio Paracuellos
Value of 'PERST_DELAY_US' is too high and it is ok just to set up to 100 us. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci

[PATCH v3 1/5] staging: mt7621-pci: use gpios for properly reset

2020-03-12 Thread Sergio Paracuellos
Original driver code was using three gpio's for reset asserts and deasserts the pcis. Instead of using that a general reset control with a perst gpio was introduced and it seems it is partially working but sometimes there are some unexpected hangs on boot. This commit make use of the three original

[PATCH v3 0/5] staging: mt7621-pci: re-do reset boot process

2020-03-12 Thread Sergio Paracuellos
Some time ago Greg Ungerer reported some random hangs using the staging mt7621-pci driver: See: * http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2019-June/134947.html Try to fix that is the main motivation of this patch series. Also in openwrt there is a driver for mt7621-p