Re: [PATCH] staging: vt6656: Use BIT_ULL() macro instead of bit shift operation

On Sat, Mar 07, 2020 at 11:49:29AM +0100, Oscar Carter wrote: > Replace the bit left shift operation with the BIT_ULL() macro and remove > the unnecessary "and" operation against the bit_nr variable. > > Signed-off-by: Oscar Carter > --- > drivers/staging/vt6656/main_usb.c | 4 ++-- > 1 file cha

Re: [ashmem] possible deadlock in shmem_fallocate (4)

ashmem is calling shmem_fallocate() during memory reclaim, which can deadlock on inode_lock(). +Cc maintainers of drivers/staging/android/ashmem.c. On Thu, Dec 26, 2019 at 01:25:09PM -0800, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:46cf053e Linux 5.5-rc

[PATCH] staging: vt6656: Use BIT_ULL() macro instead of bit shift operation

Replace the bit left shift operation with the BIT_ULL() macro and remove the unnecessary "and" operation against the bit_nr variable. Signed-off-by: Oscar Carter --- drivers/staging/vt6656/main_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/m

[PATCH v2 2/3] staging: wilc1000: modified 'clock-names' and 'compatible' property

From: Ajay Singh Modified the 'clock-names' property by removing '_clk' from its name and remove '_spi/sdio' from 'compatible' string. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/sdio.c | 4 ++-- drivers/staging/wilc1000/spi.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-

[PATCH v2 1/3] staging: wilc1000: use 'interrupts' property instead of 'irq-gpio'

From: Ajay Singh Make use of 'interrupts' property instead of using gpio for handling the interrupt as suggested in [1]. [1]. https://lore.kernel.org/linux-wireless/20200303015558.GA6876@bogus Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/netdev.c | 24 drive

[PATCH v2 3/3] staging: wilc1000: updated DT binding documentation

From: Ajay Singh Merged the DT binding documentation of SDIO and SPI into a single file. Removed documentation for some of the properties which are not required and handled review comments received in [1] & [2]. [1]. https://lore.kernel.org/linux-wireless/20200303020230.GA15543@bogus [2]. https:

[PATCH v2 0/3] staging: wilc1000: handle DT binding documentation comments

From: Ajay Singh This patch series contains changes to handle DT binding documentation related review comments. The changes were suggested during the full driver review [1] & [2]. First submitting these patches to staging and later will include them as part of the full driver review patch series.

Re: [PATCH 1/2] staging: wilc1000: use 'interrupts' property instead of 'irq-gpio'

Hi Rob, On 06/03/20 9:05 pm, Rob Herring wrote: > > On Fri, Mar 6, 2020 at 8:44 AM wrote: >> >> From: Ajay Singh >> >> Make use of 'interrupts' property instead of using gpio for handling >> the interrupt as suggested in [1]. >> >> [1]. https://lore.kernel.org/linux-wireless/20200303015558.GA68

Re: [PATCH] staging: vt6656: Declare a few variables as __read_mostly

On Sun, Mar 01, 2020 at 04:09:13PM +0100, Greg Kroah-Hartman wrote: > On Sun, Mar 01, 2020 at 02:17:01PM +0100, Oscar Carter wrote: > > On Sun, Mar 01, 2020 at 01:25:14PM +0100, Greg Kroah-Hartman wrote: > > > On Sun, Mar 01, 2020 at 12:26:20PM +0100, Oscar Carter wrote: > > > > These include modul