Re: [PATCH v2] staging: android: ashmem: Disallow ashmem memory from being remapped

On Mon, Jan 27, 2020 at 03:56:16PM -0800, Todd Kjos wrote: > From: Suren Baghdasaryan > > When ashmem file is mmapped, the resulting vma->vm_file points to the > backing shmem file with the generic fops that do not check ashmem > permissions like fops of ashmem do. If an mremap is done on the ash

Re: [PATCH 2/4] media: hantro: Use standard luma quantization table

Hi Andrzej, On Mon, 2020-01-27 at 15:30 +0100, Andrzej Pietrasiewicz wrote: > The table is actually different in the document than in this file, so align > this file with the document. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/staging/media/hantro/hantro_jpeg.c | 16 -

Re: [PATCH 1/4] media: hantro: Read be32 words starting at every fourth byte

On Mon, 2020-01-27 at 15:30 +0100, Andrzej Pietrasiewicz wrote: > Since (luma/chroma)_qtable is an array of unsigned char, indexing it > returns consecutive byte locations, but we are supposed to read the arrays > in four-byte words. Consequently, we should be pointing > get_unaligned_be32() at con

Re: [PATCH 0/4] Hantro VPU JPEG encoder fixes

Hi Andrzej, Thanks a lot for the fixes! On Mon, 2020-01-27 at 15:30 +0100, Andrzej Pietrasiewicz wrote: > This series addresses quality issues in encoded JPEG images. > > The first patch actually restores the intention of the original submission > of this driver: due to a typo the helper variabl

Re: [greybus-dev] [PATCH] staging: greybus: bootrom: fix uninitialized variables

On 1/25/20 6:14 AM, SAURAV GIREPUNJE wrote: > On 25/01/20 11:00 +0100, Johan Hovold wrote: >> On Sat, Jan 25, 2020 at 02:14:03PM +0530, Saurav Girepunje wrote: >>> fix uninitialized variables issue found using static code analysis tool >> >> Which tool is that? >> >>> (error) Uninitialized variable

[PATCH 4/4] media: hantro: Write quantization table registers in increasing addresses order

Luma and chroma qtables need to be written into two 16-register blocks, each table consisting of 64 bytes total. The blocks are contiguous and start at offset 0 for luma and at offset 0x40 for chroma. The seemingly innocent optimization of writing the two blocks using one loop causes side effects

[PATCH 2/4] media: hantro: Use standard luma quantization table

The table is actually different in the document than in this file, so align this file with the document. Signed-off-by: Andrzej Pietrasiewicz --- drivers/staging/media/hantro/hantro_jpeg.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media/

[PATCH 0/4] Hantro VPU JPEG encoder fixes

This series addresses quality issues in encoded JPEG images. The first patch actually restores the intention of the original submission of this driver: due to a typo the helper variables were unused and then have been removed in some cleanup done by Mauro. The second patch aligns the driver's lum

[PATCH 3/4] media: hantro: Write the quantization tables in proper order

The quantization tables as defined in the file (luma_q_table, chroma_q_table) are in fact in linear order. The JPEG file header, which is not generated by the hardware, but must be programatically created with the CPU, expects the table in zigzag order. On the other hand, the hardware doesn't expec

[PATCH 1/4] media: hantro: Read be32 words starting at every fourth byte

Since (luma/chroma)_qtable is an array of unsigned char, indexing it returns consecutive byte locations, but we are supposed to read the arrays in four-byte words. Consequently, we should be pointing get_unaligned_be32() at consecutive word locations instead. Signed-off-by: Andrzej Pietrasiewicz

Re: [PATCH] staging: rtl8723bs: fix copy of overlapping memory

HI, On 26-01-2020 23:05, Colin King wrote: From: Colin Ian King Currently the rtw_sprintf prints the contents of thread_name onto thread_name and this can lead to a potential copy of a string over itself. Avoid this by printing the literal string RTWHALXT instread of the contents of thread_nam

Re: [PATCH 10/22] staging: exfat: Rename variable "SecSize" to "sec_size"

On Mon, Jan 27, 2020 at 03:43:31PM +0530, Pragat Pandya wrote: > Change all the occurrences of "SecSize" to "sec_size" in exfat. > > Signed-off-by: Pragat Pandya > --- > drivers/staging/exfat/exfat.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/exfat/

Re: [PATCH 07/22] staging: exfat: Rename variable "MilliSecond" to "milli_second"

On Mon, Jan 27, 2020 at 02:55:31PM +0300, Dan Carpenter wrote: > On Mon, Jan 27, 2020 at 03:43:28PM +0530, Pragat Pandya wrote: > > Change all the occurrences of "MilliSecond" to "milli_second" in exfat. > > > > Signed-off-by: Pragat Pandya > > --- > > drivers/staging/exfat/exfat.h | 2 +-

Re: [PATCH 10/22] staging: exfat: Rename variable "SecSize" to "sec_size"

On Mon, Jan 27, 2020 at 03:43:31PM +0530, Pragat Pandya wrote: > Change all the occurrences of "SecSize" to "sec_size" in exfat. > > Signed-off-by: Pragat Pandya > --- > drivers/staging/exfat/exfat.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/exfat/

Re: [PATCH 09/22] staging: exfat: Rename variable "Size" to "size"

On Mon, Jan 27, 2020 at 03:43:30PM +0530, Pragat Pandya wrote: > Change all the occurences of "Size" to "size" in exfat. > > Signed-off-by: Pragat Pandya > --- > drivers/staging/exfat/exfat.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/exfat/exfat.h

Re: [PATCH 07/22] staging: exfat: Rename variable "MilliSecond" to "milli_second"

On Mon, Jan 27, 2020 at 03:43:28PM +0530, Pragat Pandya wrote: > Change all the occurrences of "MilliSecond" to "milli_second" in exfat. > > Signed-off-by: Pragat Pandya > --- > drivers/staging/exfat/exfat.h | 2 +- > drivers/staging/exfat/exfat_super.c | 16 > 2 files ch

Re: [PATCH 00/22] staging: exfat: Fix checkpatch warning: …

> This patchset renames following twenty-two variables declared in exfat.h Would a subject like “staging: exfat: Renaming of some identifiers” be more appropriate (than an incomplete one) for this cover letter? Regards, Markus ___ devel mailing list de.

Re: [PATCH 06/22] staging: vc04_services: get rid of vchiq_platform_use_suspend_timer()

On Fri, 2020-01-24 at 15:46 +0100, Nicolas Saenz Julienne wrote: > @@ -3059,7 +2986,6 @@ vchiq_check_service(struct vchiq_service *service) > arm_state->videocore_use_count, > suspend_state_names[arm_state->vc_suspend_state + >

Re: [PATCH 02/22] staging: exfat: Rename variable "Month" to "month"

> Change all the occurrences of "Month" to "month" in exfat. I hope that the final commit will not contain a misplaced quotation character in the subject. Regards, Markus ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverpr

Re: [PATCH 02/22] staging: exfat: Rename variable "Month" to "month"

> Change all the occurrences of "Month" to "month" in exfat. I hope that the final commit will not contain a misplaced quotation character in the subject. Regards, Markus ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverpr

[PATCH 19/22] staging: exfat: Rename variabel "NumSubdirs" to "num_subdirs"

Change all the occurreces of "NumSubdirs" to "num_subdirs" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/d

[PATCH 12/22] staging: exfat: Rename variable "ClusterSize" to "cluster_size"

Change all the occurrences of "ClusterSize" to "cluster_size" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/driv

[PATCH 18/22] staging: exfat: Rename variable "Attr" to "attr"

Change all the occurrences of "Attr" to "attr" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 24 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/exfat/exfat.h

[PATCH 13/22] staging: exfat: Rename variable "NumClusters" to "num_clusters"

Change all the occurreces of "NumClusters" to "num_clusters" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b

[PATCH 14/22] staging: exfat: Rename variable "FreeClusters" to "free_clusters"

Change all the occurrences of "FreeClusters" to "free_clusters" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/

[PATCH 20/22] staging: exfat: Rename variabel "CreateTimestamp" to "create_timestamp"

Change all the occurreces of "CreateTimestamp" to "create_timestamp" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 46 ++--- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/dr

[PATCH 15/22] staging: exfat: Rename variable "UsedClusters" to "used_clusters"

Change all the occurrences of "UsedClusters" to "used_clusters" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/

[PATCH 22/22] staging: exfat: Rename variable "AccessTimestamp" to "access_timestamp"

Change all the occurrences of "AccessTimestamp" to "access_timestamp" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/exfat/

[PATCH 21/22] staging: exfat: Rename variable "ModifyTimestamp" to "modify_timestamp"

Change all the occurrences of "ModifyTimestamp" to "modify_timestamp" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 46 ++--- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/d

[PATCH 16/22] staging: exfat: Rename variable "Name" to "name"

Change all the occurrences of "Name" to "name" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/sta

[PATCH 17/22] staging: exfat: Rename variable "ShortName" to "short_name"

Change all the occurrences of "ShortName" to "short_name" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/

[PATCH 01/22] staging: exfat: Rename variable "Year" to "year"

Change all the occurrences of "Year" to "year" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/d

[PATCH 11/22] staging: exfat: Rename variable "FatType" to "fat_type"

Change all the occurrences of "FatType" to "fat_type" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/stagin

[PATCH 10/22] staging: exfat: Rename variable "SecSize" to "sec_size"

Change all the occurrences of "SecSize" to "sec_size" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index a228350acdb4..58292495bb57 100644

[PATCH 06/22] staging: exfat: Rename variable "Second" to "second"

Change all the occurrences of "Second" to "second" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/exfat/exfat.h

[PATCH 09/22] staging: exfat: Rename variable "Size" to "size"

Change all the occurences of "Size" to "size" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index 52f314d50b91..a228350acdb4 100644 --- a/d

[PATCH 00/22] staging: exfat: Fix checkpatch warning: Avoid

This patchset renames following twenty-two variables declared in exfat.h Fix checkpatch warning: Avoid CamelCase. -Year->year -Month->month -Day->day -Hour->hour -Minute->minute -Second->second -MilliSecond->milli_secnod -Offset->offset -Size->size -SecSize->sec_size -FatType->fat_type

[PATCH 08/22] staging: exfat: Rename variable "Offset" to "offset"

Change all the occurrences of "Offset" to "offset" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index 5c207d715f44..52f314d50b91 100644 --

[PATCH 07/22] staging: exfat: Rename variable "MilliSecond" to "milli_second"

Change all the occurrences of "MilliSecond" to "milli_second" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 16 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/exfat/ex

[PATCH 05/22] staging: exfat: Rename variable "Minute" to "minute"

Change all the occurrences of "Minute" to "minute" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/exfat/exfat.h

[PATCH 02/22] staging: exfat: Rename variable "Month" to "mont"h

Change all the occurrences of "Month" to "month" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b

[PATCH 03/22] staging: exfat: Rename variable "Day" to "day"

Change all the occurrences of "Day" to "day" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/dri

[PATCH 04/22] staging: exfat: Rename variable "Hour" to "hour"

Change all the occurrences of "Hour" to "hour" in exfat. Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/d

Re: [PATCH 1/2] staging: wilc1000: return zero on success and non-zero on function failure

Hi Dan, On 27/01/20 1:07 pm, Dan Carpenter wrote: > > Looks good. > > Reviewed-by: Dan Carpenter > > On Thu, Jan 23, 2020 at 12:50:47PM +, ajay.kat...@microchip.com wrote: >> @@ -384,19 +378,18 @@ static int wilc_sdio_write_reg(struct wilc *wilc, u32 >> addr, u32 data) >> cm

Re: [PATCH] staging: bcm2835-audio: fix warning of no space is necessary

On Sun, Jan 26, 2020 at 07:37:58PM +0200, Valery Ivanov wrote: > This patch fixes "No space is necessary after a cast". > Issue found by checkpatch.pl > > Signed-off-by: Valery Ivanov > --- > drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [PATCH] staging: rtl8723bs: core: fix condition with no effect

On Sat, Jan 25, 2020 at 07:04:38PM +0530, Saurav Girepunje wrote: > fix warning reorted by coccicheck > WARNING: possible condition with no effect (if == else) > > Signed-off-by: Saurav Girepunje This one looks good. The difference between this one and the last one, is that this stuff looks lik

Re: [PATCH] staging: comedi: drivers: fix condition with no effect

On Sat, Jan 25, 2020 at 06:45:35PM +0530, Saurav Girepunje wrote: > fix warning reorted by coccicheck > WARNING: possible condition with no effect (if == else) > > Signed-off-by: Saurav Girepunje > --- > drivers/staging/comedi/drivers/das1800.c | 6 -- > 1 file changed, 6 deletions(-) > > d

Re: [RESEND PATCH] staging: exfat: Fix alignment warnings

It looks like you sent this on Jan 11 and it was applied already. Why are you resending? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: greybus: bootrom: fix uninitialized variables

On Sat, Jan 25, 2020 at 02:14:03PM +0530, Saurav Girepunje wrote: > fix uninitialized variables issue found using static code analysis tool > > (error) Uninitialized variable: offset > (error) Uninitialized variable: size > These are false positives as Johan said. Don't change the code just to