Re: staging: Add MA USB Host driver

2020-01-20 Thread Dan Carpenter
This code is not terrible. It would have helped a lot if you had run it through checkpatch --strict. This driver initializes most local variables to zero which disables GCC's uninitialized error variable checking and generally makes the code harder to understand. Try to remove this as much as yo

Proposal / Partnership

2020-01-20 Thread sn
I am a banker, I have some amount of funds that I want to move out of the country. I need a good partner someone I can trust. It is risk free and legal. Reply to this email: chiuting...@gmail.com CHIU TING. Proposal / Partnership ___ devel mailing li

[PATCH 2/4] iio: imu: adis: Refactor adis_initial_startup

2020-01-20 Thread Alexandru Ardelean
From: Nuno Sá All the ADIS devices perform, at the beginning, a self test to make sure the device is in a sane state. Furthermore, some drivers also do a call to `adis_reset()` before the test which is also a good practice. This patch unifies all those operation so that, there's no need for code

[PATCH 4/4] iio: adis16460: Make use of __adis_initial_startup

2020-01-20 Thread Alexandru Ardelean
From: Nuno Sá All of the actions done in `adis16460_initial_setup()` are now done in `__adis_initial_startup()` so, there's no need for code duplication. Signed-off-by: Nuno Sá Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis16460.c | 37 ++--- 1 file

[PATCH 3/4] iio: adis16480: Make use of __adis_initial_startup

2020-01-20 Thread Alexandru Ardelean
From: Nuno Sá All actions done in `adis16480_initial_setup()` are now done in `__adis_initial_startup()` so, there's no need for code duplication. Furthermore, the call to `adis16480_initial_setup()` is done before any device configuration since the device will be reset if not already (via rst pi

[PATCH 1/4] iio: imu: adis: Add self_test_reg variable

2020-01-20 Thread Alexandru Ardelean
From: Nuno Sá This patch adds a dedicated self_test_reg variable. This is also a step to let new drivers make use of `adis_initial_startup()`. Some devices use MSG_CTRL reg to request a self_test command while others use the GLOB_CMD register. Signed-off-by: Nuno Sá Signed-off-by: Alexandru Ard

Re: [PATCH v2] media: staging: rkisp1: The rkisp1 should be depended on CONFIG_OF

2020-01-20 Thread Mauro Carvalho Chehab
Em Tue, 14 Jan 2020 10:17:20 +0800 Zhang Xiaoxu escreveu: > If 'CONFIG_VIDEO_ROCKCHIP_ISP1' configured but no 'CONFIG_OF', the > default configuration maybe: > # CONFIG_OF is not set > CONFIG_PHY_ROCKCHIP_DPHY_RX0=y > CONFIG_VIDEO_ROCKCHIP_ISP1=y > > This will cause the following compilati