Re: [PATCH] media: staging: rkisp1: Fix undefined reference to `phy_mipi_dphy_get_default_config' in rkisp1_mipi_csi2_start

2020-01-13 Thread Helen Koike
On 1/13/20 11:53 PM, zhangxiaoxu (A) wrote: > > > 在 2020/1/14 1:34, Helen Koike 写道: >> Hi Zhang, >> >> Thank you for the patch. >> >> On 1/13/20 1:48 AM, Zhang Xiaoxu wrote: >>> If 'GENERIC_PHY_MIPI_DPHY' not configured, there is an error: >>> >>> drivers/staging/media/rkisp1/rkisp1-isp.o: >>>

[PATCH v2] media: staging: rkisp1: The rkisp1 should be depended on CONFIG_OF

2020-01-13 Thread Zhang Xiaoxu
If 'CONFIG_VIDEO_ROCKCHIP_ISP1' configured but no 'CONFIG_OF', the default configuration maybe: # CONFIG_OF is not set CONFIG_PHY_ROCKCHIP_DPHY_RX0=y CONFIG_VIDEO_ROCKCHIP_ISP1=y This will cause the following compilation errors: drivers/staging/media/rkisp1/rkisp1-isp.o: In function

Re: [PATCH] media: staging: rkisp1: Fix undefined reference to `phy_mipi_dphy_get_default_config' in rkisp1_mipi_csi2_start

2020-01-13 Thread zhangxiaoxu (A)
在 2020/1/14 1:34, Helen Koike 写道: Hi Zhang, Thank you for the patch. On 1/13/20 1:48 AM, Zhang Xiaoxu wrote: If 'GENERIC_PHY_MIPI_DPHY' not configured, there is an error: drivers/staging/media/rkisp1/rkisp1-isp.o: In function `rkisp1_mipi_csi2_start.isra.5': rkisp1-isp.c:(.text+0x12

Re: [PATCH 7/8] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM)

2020-01-13 Thread Rob Herring
On Mon, 13 Jan 2020 15:15:50 +0100, Alex Riesen wrote: > As the driver has some support for the audio interface of the device, > the bindings file should mention it. > > Signed-off-by: Alexander Riesen > --- > .../devicetree/bindings/media/i2c/adv748x.txt | 13 - > 1 file chang

[PATCH] staging: rtl8188eu: remove unused parameters from rtw_check_network_type

2020-01-13 Thread Michael Straube
Parameters 'ratelen' and 'channel' of function rtw_check_network_type are unused, remove them. Reduces object file size by 62 bytes. textdata bss dec hex filename 398525 128964688 416109 6596d drivers/staging/rtl8188eu/r8188eu.o 398463 128964688 416047 6592f dri

Re: [PATCH] media: staging: rkisp1: Fix undefined reference to `phy_mipi_dphy_get_default_config' in rkisp1_mipi_csi2_start

2020-01-13 Thread Helen Koike
Hi Zhang, Thank you for the patch. On 1/13/20 1:48 AM, Zhang Xiaoxu wrote: > If 'GENERIC_PHY_MIPI_DPHY' not configured, there is an error: > > drivers/staging/media/rkisp1/rkisp1-isp.o: > In function `rkisp1_mipi_csi2_start.isra.5': > rkisp1-isp.c:(.text+0x1238): > undefined referenc

Re: [PATCH v2 3/4] dt-bindings: iio: adc: Migrate AD7606 documentation to yaml

2020-01-13 Thread Rob Herring
On Wed, Aug 7, 2019 at 8:32 AM Beniamin Bia wrote: > > The documentation for ad7606 was migrated to yaml. > > Signed-off-by: Beniamin Bia > --- > Changes in v2: > -old txt file was deleted > > .../bindings/iio/adc/adi,ad7606.txt | 66 - > .../bindings/iio/adc/adi,ad7606.yaml

[PATCH 0/8] media: i2c: adv748x: add support for HDMI audio

2020-01-13 Thread Alex Riesen
This adds minimal support for controlling the audio output I2S port available on ADV7481 and ADV7482 HDMI decoder devices by ADI. The port carries audio signal from the decoded HDMI stream. An ADV7482 on the Renesas Salvator-X ES1.1 was used during development of this code. Alex Riesen (8): med

[PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-01-13 Thread Alex Riesen
Not sure if all variants of the Salvator board have the HDMI decoder chip (the ADV7482) connected to the SSI4 on R-Car SoC, as it is on Salvator-X ES1, so the the ADV7482 endpoint and connection definitions are placed in the board file. I do assume though that all Salvator variants have the CLK_C

[PATCH 0/8] media: i2c: adv748x: add support for HDMI audio

2020-01-13 Thread Alex Riesen
This adds minimal support for controlling the audio output I2S port available on ADV7481 and ADV7482 HDMI decoder devices by ADI. The port carries audio signal from the decoded HDMI stream. An ADV7482 on the Renesas Salvator-X ES1.1 was used during development of this code. Alex Riesen (8): med

[PATCH 3/8] media: adv748x: add log_status ioctl

2020-01-13 Thread Alex Riesen
The logged information provides insights about cable connection and the state of the HDMI decoder. It is very useful when debugging hardware problems in environments without easy access to the connectors. Signed-off-by: Alexander Riesen --- drivers/media/i2c/adv748x/adv748x-hdmi.c | 173

[PATCH 1/8] media: adv748x: add a device-specific wrapper for register block read

2020-01-13 Thread Alex Riesen
Some of the devices I2C-accessible registers (for instance, cs_data for stereo channel information or tmds_params for TMDS channel information) located in adjacent cells. According to manufacturers information, these registers can be read using block transactions. Signed-off-by: Alexander Riesen

[PATCH 2/8] media: adv748x: add audio mute control and output selection ioctls

2020-01-13 Thread Alex Riesen
This change implements audio-related V4L2 ioctls for the HDMI subdevice. The master audio clock is configured for 256fs, as supported by the only device available at the moment. For the same reason, the TDM slot is formatted using left justification of its bits. Signed-off-by: Alexander Riesen -

[PATCH 6/8] media: adv748x: reduce amount of code for bitwise modification of device registers

2020-01-13 Thread Alex Riesen
The regmap provides corresponding routine (regmap_update_bits) already wrapped for this device earlier. Signed-off-by: Alexander Riesen --- drivers/media/i2c/adv748x/adv748x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/adv748x/adv748x.h b/drivers

[PATCH 4/8] media: adv748x: reserve space for the audio (I2S) port in the driver structures

2020-01-13 Thread Alex Riesen
This allows use of the port in the device tree files. Signed-off-by: Alexander Riesen --- drivers/media/i2c/adv748x/adv748x.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/adv748x/adv748x.h b/drivers/media/i2c/adv748x/adv748x.h index fdda6982e437..5db06

[PATCH 5/8] media: adv748x: add an ASoC DAI definition to the driver

2020-01-13 Thread Alex Riesen
The definition is used to publish hardware constraints and can be used to implement in-demand device configuration. Signed-off-by: Alexander Riesen --- drivers/media/i2c/adv748x/adv748x-core.c | 33 1 file changed, 33 insertions(+) diff --git a/drivers/media/i2c/adv748x

[PATCH 7/8] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM)

2020-01-13 Thread Alex Riesen
As the driver has some support for the audio interface of the device, the bindings file should mention it. Signed-off-by: Alexander Riesen --- .../devicetree/bindings/media/i2c/adv748x.txt | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/Documentation/devic