From: William Johnson.

2020-01-03 Thread William Johnson
Hello, Thank you for lending me your timeand as you may wish to know,I am the accounts updating officer with a leading bank here in London United Kingdom and the transaction is about an abandoned fund with us here hence I have perfected every arrangement to pull the funds totalling the sum of

From: William Johnson.

2020-01-03 Thread William Johnson
Hello, Thank you for lending me your timeand as you may wish to know,I am the accounts updating officer with a leading bank here in London United Kingdom and the transaction is about an abandoned fund with us here hence I have perfected every arrangement to pull the funds totalling the sum of

Re: [PATCH] Fixing coding style. Signed-off-by: amritapat...@gmail.com

2020-01-03 Thread Dan Carpenter
On Thu, Jan 02, 2020 at 12:16:53PM +0100, Greg KH wrote: > On Thu, Jan 02, 2020 at 12:59:29PM +0530, Amrita Patole wrote: > > From: Amrita Patole > > > > --- > > drivers/staging/qlge/qlge_mpi.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/qlge

Re: [PATCH][next] staging: wfx: check for memory allocation failures from wfx_alloc_hif

2020-01-03 Thread Dan Carpenter
On Sat, Dec 21, 2019 at 12:15:43AM +, Colin King wrote: > From: Colin Ian King > > Currently calls to wfx_alloc_hif are not checking for a null return > when a memory allocation fails and this leads to null pointer > dereferencing issues. Fix this by adding null pointer checks and > returnin

Re: [PATCH 4/5] staging: vt6656: remove bool from vnt_radio_power_on ret

2020-01-03 Thread Dan Carpenter
On Fri, Dec 20, 2019 at 09:15:33PM +, Malcolm Priestley wrote: > The driver uses logical only error checking a bool true would flag error. > This commit message is too vague. This is a bugfix and needs to go to stable. Add a Fixes tag. Here is a suggested wording: The caller expects this

Re: [PATCH 3/5] staging: vt6656: limit reg output to block size

2020-01-03 Thread Dan Carpenter
On Fri, Dec 20, 2019 at 09:15:24PM +, Malcolm Priestley wrote: > vnt_control_out appears to fail when BBREG is greater than 64 writes. > > Create new function that will relay an array in no larger than > the indicated block size. > > It appears that this command has always failed but was igno

Re: [PATCH 2/5] staging: vt6656: correct return of vnt_init_registers.

2020-01-03 Thread Dan Carpenter
On Fri, Dec 20, 2019 at 09:15:09PM +, Malcolm Priestley wrote: > The driver standard error returns remove bool false conditions. > > Cc: stable # v5.3+ > Signed-off-by: Malcolm Priestley Fixes: 07ba60a15843 ("staging: vt6656: clean-up registers initialization error path") The other part o

Re: [PATCH 25/55] staging: wfx: fix name of struct hif_req_start_scan_alt

2020-01-03 Thread Jérôme Pouiller
On Friday 3 January 2020 10:27:44 CET Dan Carpenter wrote: > On Mon, Dec 16, 2019 at 05:03:46PM +, Jérôme Pouiller wrote: > > From: Jérôme Pouiller > > > > The original name did not make any sense. > > > > Signed-off-by: Jérôme Pouiller > > --- > > drivers/staging/wfx/hif_api_cmd.h | 2 +- >

Re: [PATCH 1/5] staging: vt6656: Fix non zero logical return of, usb_control_msg

2020-01-03 Thread Dan Carpenter
On Fri, Dec 20, 2019 at 09:14:59PM +, Malcolm Priestley wrote: > Starting with commit 59608cb1de1856 > ("staging: vt6656: clean function's error path in usbpipe.c") > the usb control functions have returned errors throughout driver > with only logical variable checking. Use the Fixes tag for t

Re: [PATCH 13/55] staging: wfx: avoid double warning when no more tx policy are available

2020-01-03 Thread Jérôme Pouiller
On Friday 3 January 2020 10:21:16 CET Dan Carpenter wrote: > On Mon, Dec 16, 2019 at 05:03:40PM +, Jérôme Pouiller wrote: > > From: Jérôme Pouiller > > > > Currently, number of available tx retry policies is checked two times. > > Only one is sufficient. > > > > Signed-off-by: Jérôme Pouiller

Re: [PATCH] staging: exfat: add STAGING prefix to config names

2020-01-03 Thread Greg KH
On Fri, Jan 03, 2020 at 12:08:10PM +0200, Amir Goldstein wrote: > On Fri, Jan 3, 2020 at 3:17 AM Namjae Jeon wrote: > > > > Add STAGING prefix to config names to avoid collsion with fs/exfat config. > > > > Signed-off-by: Namjae Jeon > > --- > > drivers/staging/Makefile | 2 +- > >

Re: [PATCH] staging: exfat: add STAGING prefix to config names

2020-01-03 Thread Amir Goldstein
On Fri, Jan 3, 2020 at 3:17 AM Namjae Jeon wrote: > > Add STAGING prefix to config names to avoid collsion with fs/exfat config. > > Signed-off-by: Namjae Jeon > --- > drivers/staging/Makefile | 2 +- > drivers/staging/exfat/Kconfig| 26 +++ > drivers/staging/exf

Re: [PATCH 5/5] staging: vt6656: set usb_set_intfdata on driver fail.

2020-01-03 Thread Greg Kroah-Hartman
On Fri, Jan 03, 2020 at 11:01:59AM +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 20, 2019 at 09:15:59PM +, Malcolm Priestley wrote: > > intfdata will contain stale pointer when the device is detached after > > failed initialization when referenced in vt6656_disconnect > > > > Provide driver a

Re: [PATCH 5/5] staging: vt6656: set usb_set_intfdata on driver fail.

2020-01-03 Thread Greg Kroah-Hartman
On Fri, Dec 20, 2019 at 09:15:59PM +, Malcolm Priestley wrote: > intfdata will contain stale pointer when the device is detached after > failed initialization when referenced in vt6656_disconnect > > Provide driver access to it here and NULL it. > > Cc: stable > Signed-off-by: Malcolm Priest

Re: [PATCH v2] Staging: most: core: Fix SPDX License Identifier style issue

2020-01-03 Thread Greg KH
On Fri, Dec 27, 2019 at 03:41:55AM -0500, Matthew Hanzelik wrote: > Fixed a style issue with the SPDX License Identifier style. > > Signed-off-by: Matthew Hanzelik > --- > Changes in v2: > - Fix trailing space in patch diff > > drivers/staging/most/core.h | 2 +- > 1 file changed, 1 insertion

Re: [PATCH 25/55] staging: wfx: fix name of struct hif_req_start_scan_alt

2020-01-03 Thread Dan Carpenter
On Mon, Dec 16, 2019 at 05:03:46PM +, Jérôme Pouiller wrote: > From: Jérôme Pouiller > > The original name did not make any sense. > > Signed-off-by: Jérôme Pouiller > --- > drivers/staging/wfx/hif_api_cmd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/

Re: [PATCH 13/55] staging: wfx: avoid double warning when no more tx policy are available

2020-01-03 Thread Dan Carpenter
On Mon, Dec 16, 2019 at 05:03:40PM +, Jérôme Pouiller wrote: > From: Jérôme Pouiller > > Currently, number of available tx retry policies is checked two times. > Only one is sufficient. > > Signed-off-by: Jérôme Pouiller > --- > drivers/staging/wfx/data_tx.c | 3 ++- > 1 file changed, 2 in

Re: [PATCH] staging: kpc2000: replace assertion with recovery code

2020-01-03 Thread Dan Carpenter
On Sun, Dec 15, 2019 at 07:28:14PM +0100, Greg Kroah-Hartman wrote: > On Sun, Dec 15, 2019 at 12:12:37PM -0600, Aditya Pakki wrote: > > In kpc_dma_transfer, if either priv or ldev is NULL, crashing the > > process is excessive and is not needed. Instead of asserting, by > > passing the error upstre