Re: [PATCH] staging: rtl8192e: rtllib_module: Fix memory leak in alloc_rtllib

Hi Johan, On Sun, Dec 15, 2019 at 7:23 AM Johan Hovold wrote: > > On Sat, Dec 14, 2019 at 05:05:58PM -0600, Navid Emamdoost wrote: > > In the implementation of alloc_rtllib() the allocated dev is leaked in > > case of ieee->pHTInfo allocation failure. Release via free_netdev(dev). > > > > Fixes:

[PATCH v1 0/3] Tegra GPIO: Minor code clean up

Hello, I was investigating why CPU hangs during of GPIO driver suspend and in the end it turned out that it is a Broadcom WiFi driver problem because it keeps OOB wake-interrupt enabled while WLAN interface is DOWN and this may cause a bit weird CPU hang on writing to INT_ENB register during of GP

[PATCH v1 1/3] gpio: tegra: Use generic readl_relaxed/writel_relaxed accessors

There is no point in using old-style raw accessors, the generic accessors do the same thing and also take into account CPU endianness. Tegra SoCs do not support big-endian mode in the upstream kernel, but let's switch away from the outdated things anyway, just to keep code up-to-date. Signed-off-b

[PATCH v1 3/3] gpio: tegra: Use NOIRQ phase for suspend/resume

All GPIO interrupts are disabled during of the NOIRQ suspend/resume phase, thus there is no need to manually disable the interrupts. This patch doesn't fix any problem, this is just a minor clean-up. Signed-off-by: Dmitry Osipenko --- drivers/gpio/gpio-tegra.c | 10 ++ 1 file changed, 2

[PATCH v1 2/3] gpio: tegra: Properly handle irq_set_irq_wake() error

Technically upstream interrupt controller may fail changing of GPIO's bank wake-state and in this case the GPIO's wake-state shouldn't be changed. Signed-off-by: Dmitry Osipenko --- drivers/gpio/gpio-tegra.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/g

Re: [PATCH] staging: kpc2000: replace assertion with recovery code

On Sun, Dec 15, 2019 at 12:12:37PM -0600, Aditya Pakki wrote: > In kpc_dma_transfer, if either priv or ldev is NULL, crashing the > process is excessive and is not needed. Instead of asserting, by > passing the error upstream, the error can be handled. > > Signed-off-by: Aditya Pakki > --- > dri

[PATCH] staging: kpc2000: replace assertion with recovery code

In kpc_dma_transfer, if either priv or ldev is NULL, crashing the process is excessive and is not needed. Instead of asserting, by passing the error upstream, the error can be handled. Signed-off-by: Aditya Pakki --- drivers/staging/kpc2000/kpc_dma/fileops.c | 6 -- 1 file changed, 4 inserti

[PATCH v1 0/3] Tegra VDE: Minor code clean up

Hello, This small series just makes a minor clean up of the driver's code, addressing COMPILE_TEST build problem that was reported sometime ago. Dmitry Osipenko (3): media: staging: tegra-vde: Select IOVA unconditionally in Kconfig media: staging: tegra-vde: Sort headers alphabetically medi

[PATCH v1 2/3] media: staging: tegra-vde: Sort headers alphabetically

Keep the alphabetical order for consistency. Signed-off-by: Dmitry Osipenko --- drivers/staging/media/tegra-vde/vde.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/tegra-vde/vde.h b/drivers/staging/media/tegra-vde/vde.h index d369f1466bc7..5561291b0c8

[PATCH v1 3/3] media: staging: tegra-vde: Use __maybe_unused attribute instead of ifdef

Replace #ifdef with __maybe_unused attribute just to keep code cleaner a tad. Signed-off-by: Dmitry Osipenko --- drivers/staging/media/tegra-vde/vde.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/tegra-vde/vde.c b/drivers/staging/media/tegra-vd

[PATCH v1 1/3] media: staging: tegra-vde: Select IOVA unconditionally in Kconfig

There were several reports of building failures due to IOVA being selected inconsistently by different drivers. All drivers that are using IOVA API should select it unconditionally in order to avoid the compilation problems, tegra-vde is one of those drivers. Link: https://patchwork.kernel.org/pat

Re: [PATCH] staging: comedi: drivers: Fix memory leak in gsc_hpdi_auto_attach

> In the implementation of gsc_hpdi_auto_attach(), the allocated dma > description is leaks in case of alignment error, … Please avoid a typo in this change message. … +++ b/drivers/staging/comedi/drivers/gsc_hpdi.c … > @@ -660,6 +661,15 @@ static int gsc_hpdi_auto_attach(struct comedi_device >

Re: [PATCH] staging: rtl8192e: rtllib_module: Fix memory leak in alloc_rtllib

On Sat, Dec 14, 2019 at 05:05:58PM -0600, Navid Emamdoost wrote: > In the implementation of alloc_rtllib() the allocated dev is leaked in > case of ieee->pHTInfo allocation failure. Release via free_netdev(dev). > > Fixes: 6869a11bff1d ("Staging: rtl8192e: Use !x instead of x == NULL") This is no

Re: [PATCH v6 2/2] dt-bindings: iio: accel: add binding documentation for ADIS16240

On Fri, 13 Dec 2019 13:10:36 -0600 Rob Herring wrote: > On Sat, 7 Dec 2019 01:53:39 -0300, Rodrigo Carvalho wrote: > > This patch add device tree binding documentation for ADIS16240. > > > > Signed-off-by: Rodrigo Carvalho > > --- > > V6: > > - Update SPDX license identifier > > > > .../bi