On Tue, Nov 12, 2019 at 09:50:34PM -0500, Valdis Kletnieks wrote:
> syzbot took a nosedive because it runs with panic_on_warn set. And
> it's quite correct, it shouldn't have been a WARN in the first place.
> Other locations just use a pr_info(), so do that here too.
>
> Signed-off-by: Valdis Klet
On Tue, Nov 12, 2019 at 03:12:53PM -0800, Linus Torvalds wrote:
> On Tue, Nov 12, 2019 at 2:54 PM Greg Kroah-Hartman
> wrote:
> >
> > Christoph, this is what you mean, right? If so, I'll send this to Linus
> > later this week, or he can grab it right from this patch :)
>
> No.
>
> I was unhappy
On Tue, Nov 12, 2019 at 06:29:55PM -0500, Marcelo Diop-Gonzalez wrote:
> On Tue, Nov 12, 2019 at 6:09 PM Greg KH wrote:
> >
> > On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote:
> > > This allows the removal of the struct rpi_firmware* member
> > > from struct vchiq_drvdata.
>
syzbot took a nosedive because it runs with panic_on_warn set. And
it's quite correct, it shouldn't have been a WARN in the first place.
Other locations just use a pr_info(), so do that here too.
Signed-off-by: Valdis Kletnieks
Reported-by: syzbot+787bcbef9b5fec619...@syzkaller.appspotmail.com
Fi
It should depends on ETHERNET, otherwise building fails:
drivers/staging/hp/hp100.o: In function `hp100_pci_remove':
hp100.c:(.text+0x165): undefined reference to `unregister_netdev'
hp100.c:(.text+0x214): undefined reference to `free_netdev'
Fixes: 52340b82cf1a ("hp100: Move 100BaseVG AnyLAN dri
On Tue, Nov 12, 2019 at 6:09 PM Greg KH wrote:
>
> On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote:
> > This allows the removal of the struct rpi_firmware* member
> > from struct vchiq_drvdata.
> >
> > Signed-off-by: Marcelo Diop-Gonzalez
> > ---
> > .../interface/vchiq_arm
On Tue, Nov 12, 2019 at 2:54 PM Greg Kroah-Hartman
wrote:
>
> Christoph, this is what you mean, right? If so, I'll send this to Linus
> later this week, or he can grab it right from this patch :)
No.
I was unhappy about a staging driver being added in rc7, but I went
"whatever, it's Greg's garb
On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote:
> This allows the removal of the struct rpi_firmware* member
> from struct vchiq_drvdata.
>
> Signed-off-by: Marcelo Diop-Gonzalez
> ---
> .../interface/vchiq_arm/vchiq_2835_arm.c | 14 +-
> .../vc04_ser
When Christoph said this code was "good enough to go in now" I thought
he ment to put it in drivers/staging/ for now, when in fact he ment to
put it into the "real" part of the kernel instead.
So move the code to the "real" part of the kernel as it's good enough.
Reported-by: Christoph Hellwig
C
Updating with the current laundry list of things that need attention.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/TODO | 70 --
1 file changed, 59 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/exfat/TODO b/drivers/staging/exfat/TOD
Global functions called 'buf*' are a linkage editor disaster waiting to
happen. Rename our buf_* functions to exfat_buf_*
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 18 +++---
drivers/staging/exfat/exfat_cache.c | 22 +++
drivers/staging/exfat/exfat_core.c |
Rename all the FAT_* functions to exfat_fat_*.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 12 +-
drivers/staging/exfat/exfat_cache.c | 26 +++---
drivers/staging/exfat/exfat_core.c | 34 ++---
drivers/staging/exfat/e
In this patch, we straighten out most of the cases where the
code was testing 'p_fs->vol_type == EXFAT' and '!= EXFAT'
There's still some ?: ops and a few places where the code
is doing checks for '.' and '..' that require looking at,
but those are future patches
Signed-off-by: Valdis Kletnieks
Remove the top-level mount functionality, to make this driver handle
only exfat file systems.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/Kconfig | 9 --
drivers/staging/exfat/exfat.h | 2 -
drivers/staging/exfat/exfat_core.c | 193
dri
These functions are only used in the local file, make them static
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 6 --
drivers/staging/exfat/exfat_core.c | 8
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/dr
Everything referenced in the struct fs_func exfat_fs_func is located
in that same .c file. Make them static and remove from exfat.h
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 32 ---
drivers/staging/exfat/exfat_core.c | 42 +++---
Move a few more things so we can make them static and clear exfat.h out.
At this point, pretty much everything that can be static is static.
(Note: FAT_sync(), buf_sync(), and sync_alloc_bitmap() aren't called
anyplace, but aren't static because (a) that will toss an error and
(b) they probably *sh
The code simplification from the previous patch rendered a few more
routines unreferenced, so heave them over the side as well.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 19 ---
drivers/staging/exfat/exfat_core.c | 137
drivers/staging/exfat/e
Rename all the bdev_* to exfat_bdev_*
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h| 10 +-
drivers/staging/exfat/exfat_blkdev.c | 10 +-
drivers/staging/exfat/exfat_core.c | 8
drivers/staging/exfat/exfat_super.c | 16
4
Relocating these functions to before first use lets us make them static
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 4 --
drivers/staging/exfat/exfat_core.c | 78 +++---
2 files changed, 39 insertions(+), 43 deletions(-)
diff --git a/drivers
Some more functions that can be moved and made static
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 3 -
drivers/staging/exfat/exfat_core.c | 182 ++---
2 files changed, 91 insertions(+), 94 deletions(-)
diff --git a/drivers/staging/exfat/exf
The first 4 patches iteratively remove more and more of the
FAT/VFAT code.
The second 8 patches make a lot of functions static, and
renames many of the rest to avoid namespace pollution.
Valdis Kletnieks (12):
staging: exfat: Remove FAT/VFAT mount support, part 1
staging: exfat: Remove FAT/VF
Remove no longer referenced FAT/VFAT routines.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 44 --
drivers/staging/exfat/exfat_core.c | 619 -
2 files changed, 663 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/
On Tue, Nov 12, 2019 at 05:37:57PM +, Jonathan Cameron wrote:
> On Tue, 12 Nov 2019 17:35:50 +0200
> Beniamin Bia wrote:
>
> > From: Michael Hennerich
> >
> > ADM1177 is a Hot Swap Controller and Digital Power Monitor with
> > Soft Start Pin.
> >
> > Datasheet:
> > Link:
> > https://www.a
On Tue, 12 Nov 2019 17:35:50 +0200
Beniamin Bia wrote:
> From: Michael Hennerich
>
> ADM1177 is a Hot Swap Controller and Digital Power Monitor with
> Soft Start Pin.
>
> Datasheet:
> Link:
> https://www.analog.com/media/en/technical-documentation/data-sheets/ADM1177.pdf
>
> Signed-off-by: M
CONTACT WALMART TRANSFER To pick up $5000 sent to you this morning
Attn Dear Beneficiary.
Happy to inform you,I have deposited your payment funds
$10.500,000MillionUS DollarsWith Walmart international money
transfers.
Receive the Money with Walmart | MoneyGram service.
Walmart partners with Money
Add Beniamin Bia and Michael Hennerich as a maintainer for ADM1177 ADC.
Signed-off-by: Beniamin Bia
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0fca3b055985..41a34d7a802c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -962,6 +962,15
Documentation for ADM1177 was added.
Signed-off-by: Beniamin Bia
---
.../bindings/iio/adc/adi,adm1177.yaml | 60 +++
1 file changed, 60 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,adm1177.yaml
diff --git a/Documentation/devicetree/bind
From: Michael Hennerich
ADM1177 is a Hot Swap Controller and Digital Power Monitor with
Soft Start Pin.
Datasheet:
Link:
https://www.analog.com/media/en/technical-documentation/data-sheets/ADM1177.pdf
Signed-off-by: Michael Hennerich
Co-developed-by: Beniamin Bia
Signed-off-by: Beniamin Bia
This patch adds a comment to the start_mutex and fifo_lock fields of
the most_channel structure definition.
Signed-off-by: Christian Gromm
---
drivers/staging/most/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/co
On Tuesday 12 November 2019 00:16:59 CET Al Viro wrote:
[...]
> More fun:
> int hif_read_mib(struct wfx_dev *wdev, int vif_id, u16 mib_id, void *val,
> size_t val_len)
> {
> int ret;
> struct hif_msg *hif;
> int buf_len = sizeof(struct hif_cnf_read_mib) + val_len;
>
Hello Al,
Thank you for your extensive review.
On Monday 11 November 2019 21:28:52 CET Al Viro wrote:
> On Mon, Nov 11, 2019 at 01:51:33PM +, Jules Irenge wrote:
> >
> > > NAK. force-cast (and it's not a gcc extension, BTW - it's sparse) is
> > > basically
> > > "I know better; the code is
32 matches
Mail list logo
