Re: [PATCH v1 03/10] KVM: Prepare kvm_is_reserved_pfn() for PG_reserved changes

2019-11-04 Thread Dan Williams
On Thu, Oct 24, 2019 at 5:11 AM David Hildenbrand wrote: > > Right now, ZONE_DEVICE memory is always set PG_reserved. We want to > change that. > > KVM has this weird use case that you can map anything from /dev/mem > into the guest. pfn_valid() is not a reliable check whether the memmap > was ini

Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody

2019-11-04 Thread Chao Yu
On 2019/11/4 9:45, Valdis Kletnieks wrote: > There's currently 6 filesystems that have the same #define. Move it > into errno.h so it's defined in just one place. > > Signed-off-by: Valdis Kletnieks > Acked-by: Darrick J. Wong > Reviewed-by: Jan Kara > Acked-by: Theodore Ts'o > fs/erofs/inte

Re: [PATCH v1 02/10] KVM: x86/mmu: Prepare kvm_is_mmio_pfn() for PG_reserved changes

2019-11-04 Thread Dan Williams
On Thu, Oct 24, 2019 at 5:10 AM David Hildenbrand wrote: > > Right now, ZONE_DEVICE memory is always set PG_reserved. We want to > change that. > > KVM has this weird use case that you can map anything from /dev/mem > into the guest. pfn_valid() is not a reliable check whether the memmap > was ini

Re: [PATCH v1 01/10] mm/memory_hotplug: Don't allow to online/offline memory blocks with holes

2019-11-04 Thread Dan Williams
On Thu, Oct 24, 2019 at 5:10 AM David Hildenbrand wrote: > > Our onlining/offlining code is unnecessarily complicated. Only memory > blocks added during boot can have holes (a range that is not > IORESOURCE_SYSTEM_RAM). Hotplugged memory never has holes (e.g., see > add_memory_resource()). All boo

Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody

2019-11-04 Thread Valdis Klētnieks
On Mon, 04 Nov 2019 16:33:06 -0800, Christoph Hellwig said: > On Sun, Nov 03, 2019 at 08:45:06PM -0500, Valdis Kletnieks wrote: > > There's currently 6 filesystems that have the same #define. Move it > > into errno.h so it's defined in just one place. > > And 4 out of 6 also define EFSBADCRC, so pl

Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody

2019-11-04 Thread Christoph Hellwig
On Sun, Nov 03, 2019 at 08:45:06PM -0500, Valdis Kletnieks wrote: > There's currently 6 filesystems that have the same #define. Move it > into errno.h so it's defined in just one place. And 4 out of 6 also define EFSBADCRC, so please lift that as well. _

Re: [PATCH v1 09/10] mm/memory_hotplug: Don't mark pages PG_reserved when initializing the memmap

2019-11-04 Thread Boris Ostrovsky
On 10/24/19 8:09 AM, David Hildenbrand wrote: > diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c > index 4f2e78a5e4db..af69f057913a 100644 > --- a/drivers/xen/balloon.c > +++ b/drivers/xen/balloon.c > @@ -374,6 +374,13 @@ static void xen_online_page(struct page *page, unsigned > int orde

Re: [PATCH v2] staging: comedi: rewrite macro function with GNU extension typeof

2019-11-04 Thread Greg KH
On Mon, Nov 04, 2019 at 05:03:04PM +, Ian Abbott wrote: > On 04/11/2019 16:33, Jules Irenge wrote: > > Rewrite macro function with the GNU extension typeof > > to remove a possible side-effects of MACRO argument reuse "x". > > - Problem could rise if arguments have different types > > and dif

Re: [PATCH v1] staging: intel-dpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

2019-11-04 Thread David Miller
From: Greg KH Date: Mon, 4 Nov 2019 13:20:09 +0100 > Why is this being submitted to staging? What is wrong with the "real" > part of the kernel for this? Agreed, this makes no sense at all. ___ devel mailing list de...@linuxdriverproject.org http://dr

Re: [PATCH] staging: rts5208: rewrite macro with GNU extension __auto_type

2019-11-04 Thread Joe Perches
On Mon, 2019-11-04 at 17:51 +0100, Greg KH wrote: > On Mon, Nov 04, 2019 at 04:44:00PM +, Jules Irenge wrote: > > Rewrite macro function with GNU extension __auto_type > > to remove issue detected by checkpatch tool. > > CHECK: MACRO argument reuse - possible side-effects? [] > > diff --git a/d

Re: [PATCH v2] staging: comedi: rewrite macro function with GNU extension typeof

2019-11-04 Thread Ian Abbott
On 04/11/2019 16:33, Jules Irenge wrote: Rewrite macro function with the GNU extension typeof to remove a possible side-effects of MACRO argument reuse "x". - Problem could rise if arguments have different types and different use though. Signed-off-by: Jules Irenge --- v1 - had no full commit

Re: [PATCH 2/3] media: cedrus: Fix H264 4k support

2019-11-04 Thread Jernej Škrabec
Dne ponedeljek, 04. november 2019 ob 11:13:19 CET je Paul Kocialkowski napisal(a): > Hi, > > On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote: > > H264 decoder needs additional or bigger buffers in order to decode 4k > > videos. > > Thanks for the fixup, we hadn't looked into those bits at all duri

Re: [PATCH] staging: rts5208: rewrite macro with GNU extension __auto_type

2019-11-04 Thread Greg KH
On Mon, Nov 04, 2019 at 04:44:00PM +, Jules Irenge wrote: > Rewrite macro function with GNU extension __auto_type > to remove issue detected by checkpatch tool. > CHECK: MACRO argument reuse - possible side-effects? > > Signed-off-by: Jules Irenge > --- > drivers/staging/rts5208/rtsx_chip.h

Re: [PATCH v2] staging: comedi: rewrite macro function with GNU extension typeof

2019-11-04 Thread Greg KH
On Mon, Nov 04, 2019 at 04:33:31PM +, Jules Irenge wrote: > Rewrite macro function with the GNU extension typeof > to remove a possible side-effects of MACRO argument reuse "x". > - Problem could rise if arguments have different types > and different use though. You can not just get away with

[PATCH] staging: rts5208: rewrite macro with GNU extension __auto_type

2019-11-04 Thread Jules Irenge
Rewrite macro function with GNU extension __auto_type to remove issue detected by checkpatch tool. CHECK: MACRO argument reuse - possible side-effects? Signed-off-by: Jules Irenge --- drivers/staging/rts5208/rtsx_chip.h | 92 + 1 file changed, 55 insertions(+), 37 del

Re: [PATCH v1] staging: intel-dpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

2019-11-04 Thread Andrew Lunn
On Mon, Nov 04, 2019 at 01:20:09PM +0100, Greg KH wrote: > On Mon, Nov 04, 2019 at 07:22:20PM +0800, Jack Ping CHNG wrote: > > This driver enables the Intel's LGM SoC GSWIP block. > > GSWIP is a core module tailored for L2/L3/L4+ data plane and QoS functions. > > It allows CPUs and other accelerato

Re: [PATCH 1/3] media: cedrus: Properly signal size in mode register

2019-11-04 Thread Jernej Škrabec
Dne ponedeljek, 04. november 2019 ob 11:02:28 CET je Paul Kocialkowski napisal(a): > Hi Jernej, > > On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote: > > Mode register also holds information if video width is bigger than 2048 > > and if it is equal to 4096. > > > > Rework cedrus_engine_enable() to

[PATCH v2] staging: comedi: rewrite macro function with GNU extension typeof

2019-11-04 Thread Jules Irenge
Rewrite macro function with the GNU extension typeof to remove a possible side-effects of MACRO argument reuse "x". - Problem could rise if arguments have different types and different use though. Signed-off-by: Jules Irenge --- v1 - had no full commit log message, with changes not intended to b

Investment opportunity

2019-11-04 Thread Peter Wong
Greetings, Find attached email very confidential. reply for more details Thanks. Peter Wong This email was sent by the shareware version of Postman Professional. ___ devel mailing list de...@linu

Re: [PATCH v1] staging: intel-dpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

2019-11-04 Thread Greg KH
On Mon, Nov 04, 2019 at 07:22:20PM +0800, Jack Ping CHNG wrote: > This driver enables the Intel's LGM SoC GSWIP block. > GSWIP is a core module tailored for L2/L3/L4+ data plane and QoS functions. > It allows CPUs and other accelerators connected to the SoC datapath > to enqueue and dequeue packets

Re: [PATCH v2] staging: wfx: Fix a memory leak in 'wfx_upload_beacon'

2019-11-04 Thread Dan Carpenter
On Mon, Nov 04, 2019 at 10:42:43AM +, Jerome Pouiller wrote: > On Saturday 2 November 2019 16:59:45 CET Christophe JAILLET wrote: > > The current code is a no-op, because all it can do is 'dev_kfree_skb(NULL)' > > Remove the test before 'dev_kfree_skb()' > > > > Signed-off-by: Christophe JAILL

Re: [PATCH v2 07/10] staging: exfat: Clean up return codes - FFS_SUCCESS

2019-11-04 Thread Dan Carpenter
On Mon, Nov 04, 2019 at 05:53:55AM -0500, Valdis Klētnieks wrote: > On Mon, 04 Nov 2019 13:04:14 +0300, Dan Carpenter said: > > On Sun, Nov 03, 2019 at 08:45:03PM -0500, Valdis Kletnieks wrote: > > > - if (sector_read(sb, sec, &bp->buf_bh, 1) != FFS_SUCCESS) { > > > + if (sector_read(sb, sec, &bp->

Re: [PATCH v2 07/10] staging: exfat: Clean up return codes - FFS_SUCCESS

2019-11-04 Thread Valdis Klētnieks
On Mon, 04 Nov 2019 13:04:14 +0300, Dan Carpenter said: > On Sun, Nov 03, 2019 at 08:45:03PM -0500, Valdis Kletnieks wrote: > > - if (sector_read(sb, sec, &bp->buf_bh, 1) != FFS_SUCCESS) { > > + if (sector_read(sb, sec, &bp->buf_bh, 1) != 0) { > > It's better to just remove the "!= 0" double ne

Re: [PATCH v2] staging: wfx: Fix a memory leak in 'wfx_upload_beacon'

2019-11-04 Thread Jerome Pouiller
On Saturday 2 November 2019 16:59:45 CET Christophe JAILLET wrote: > The current code is a no-op, because all it can do is 'dev_kfree_skb(NULL)' > Remove the test before 'dev_kfree_skb()' > > Signed-off-by: Christophe JAILLET > --- > V2: remove the 'if(...)', 'dev_kfree_skb()' can handle NULL. >

Re: [PATCH 3/3] media: cedrus: Increase maximum supported size

2019-11-04 Thread Paul Kocialkowski
Hi, On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote: > There are few variations of 4k resolutions. The biggest one is > 4096x2304 which is also supported by HW. It has also nice property that > both width and size are divisible by maximum HEVC CTB size, which is 64. > > Signed-off-by: Jernej Skrabe

Re: [PATCH 2/3] media: cedrus: Fix H264 4k support

2019-11-04 Thread Paul Kocialkowski
Hi, On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote: > H264 decoder needs additional or bigger buffers in order to decode 4k > videos. Thanks for the fixup, we hadn't looked into those bits at all during initial bringup of H.264! See a few minor comments below. > Signed-off-by: Jernej Skrabec >

Re: [PATCH v2 07/10] staging: exfat: Clean up return codes - FFS_SUCCESS

2019-11-04 Thread Dan Carpenter
On Sun, Nov 03, 2019 at 08:45:03PM -0500, Valdis Kletnieks wrote: > diff --git a/drivers/staging/exfat/exfat_cache.c > b/drivers/staging/exfat/exfat_cache.c > index 467b93630d86..28a67f8139ea 100644 > --- a/drivers/staging/exfat/exfat_cache.c > +++ b/drivers/staging/exfat/exfat_cache.c > @@ -462,7

Re: [PATCH 1/3] media: cedrus: Properly signal size in mode register

2019-11-04 Thread Paul Kocialkowski
Hi Jernej, On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote: > Mode register also holds information if video width is bigger than 2048 > and if it is equal to 4096. > > Rework cedrus_engine_enable() to properly signal this properties. Thanks for the patch, looks good to me! Acked-by: Paul Kocialko

[driver-core:debugfs_cleanup 46/47] drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c:237:48: error: 'root' undeclared; did you mean 'ror8'?

2019-11-04 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup head: ef50c0149ff6aa510790d31eb3ffd5a0d2249727 commit: e166ed14a34253629572f1f31e1389c1d606c342 [46/47] media: c8sectpfe: no need to check return value of debugfs_create functions config: ia64-allmodc