On 10/16/19 6:29 PM, gbittencourt wrote:
> Hi Randy,
>
> On 10/16/19 10:25 PM, Randy Dunlap wrote:
>> Hi,
>>
>> On 10/16/19 6:18 PM, Gabriela Bittencourt wrote:
>>> Cluster comments that describes parameters of functions and create one
>>> single comment before the function in kernel doc format.
>
Hi Randy,
On 10/16/19 10:25 PM, Randy Dunlap wrote:
Hi,
On 10/16/19 6:18 PM, Gabriela Bittencourt wrote:
Cluster comments that describes parameters of functions and create one
single comment before the function in kernel doc format.
Good plan.
How did you test this patch?
I haven't test it.
Hi,
On 10/16/19 6:18 PM, Gabriela Bittencourt wrote:
> Cluster comments that describes parameters of functions and create one
> single comment before the function in kernel doc format.
Good plan.
How did you test this patch?
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/sm750f
Cluster comments that describes parameters of functions and create one
single comment before the function in kernel doc format.
Signed-off-by: Gabriela Bittencourt
---
drivers/staging/sm750fb/sm750_accel.c | 65 +++
1 file changed, 37 insertions(+), 28 deletions(-)
diff
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
device_h_splitup
head: 965681d8272ce30aa68375c25c4c797731e18dd3
commit: 965681d8272ce30aa68375c25c4c797731e18dd3 [11/11] device.h: move
dev_printk()-like functions to device_printk.h
config: powerpc-mpc512x_defconfig
On Wed, 16 Oct 2019 16:33:17 -0400, Sasha Levin said:
> It looks like the reason this wasn't made public along with the exFAT
> spec is that TexFAT is pretty much dead - it's old, there are no users
> we are aware of, and digging it out of it's grave to make it public is
> actually quite the heada
On Wed, Oct 16, 2019 at 4:50 AM YueHaibing wrote:
>
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing
> ---
> drivers/staging/fieldbus/anybuss/arcx-anybus.c | 8 ++--
> 1 file changed, 2 insertions(+), 6 deletio
On Wed, Oct 16, 2019 at 06:03:49PM +0200, Pali Rohár wrote:
On Wednesday 16 October 2019 10:31:13 Sasha Levin wrote:
On Wed, Oct 16, 2019 at 04:03:53PM +0200, Pali Rohár wrote:
> On Friday 30 August 2019 09:56:47 Pali Rohár wrote:
> > On Thursday 29 August 2019 19:35:06 Sasha Levin wrote:
> > >
On Wed, 16 Oct 2019, Julia Lawall wrote:
> > #ifndef VCHI_BULK_GRANULARITY
> > # if __VCCOREVER__ >= 0x0400
> > -# define VCHI_BULK_GRANULARITY 32 // Allows for the need to do cache
> > cleans
> > +# define VCHI_BULK_GRANULARITY 32 // Allows for the need of cache cleans
> > #
On Wed, Oct 16, 2019 at 06:32:31PM +0200, Pali Rohár wrote:
> On Wednesday 16 October 2019 09:22:11 Greg Kroah-Hartman wrote:
> > On Wed, Oct 16, 2019 at 06:03:49PM +0200, Pali Rohár wrote:
> > > > Can I assume you will be implementing TexFAT support once the spec is
> > > > available?
> > >
> > >
On Wednesday 16 October 2019 09:22:11 Greg Kroah-Hartman wrote:
> On Wed, Oct 16, 2019 at 06:03:49PM +0200, Pali Rohár wrote:
> > > Can I assume you will be implementing TexFAT support once the spec is
> > > available?
> >
> > I cannot promise that I would implement something which I do not know
>
On Wed, Oct 16, 2019 at 06:03:49PM +0200, Pali Rohár wrote:
> > Can I assume you will be implementing TexFAT support once the spec is
> > available?
>
> I cannot promise that I would implement something which I do not know
> how is working... It depends on how complicated TexFAT is and also how
>
On Wed, Oct 16, 2019 at 06:03:49PM +0200, Pali Rohár wrote:
On Wednesday 16 October 2019 10:31:13 Sasha Levin wrote:
On Wed, Oct 16, 2019 at 04:03:53PM +0200, Pali Rohár wrote:
> On Friday 30 August 2019 09:56:47 Pali Rohár wrote:
> > On Thursday 29 August 2019 19:35:06 Sasha Levin wrote:
> > >
On Wed, 16 Oct 2019 10:31:13 -0400, Sasha Levin said:
> On Wed, Oct 16, 2019 at 04:03:53PM +0200, Pali Roh�r wrote:
> >Now one month passed, so do you have some information when missing parts
> >of documentation like TexFAT would be released to public?
>
> Sure, I'll see if I can get an approval t
On Wednesday 16 October 2019 10:31:13 Sasha Levin wrote:
> On Wed, Oct 16, 2019 at 04:03:53PM +0200, Pali Rohár wrote:
> > On Friday 30 August 2019 09:56:47 Pali Rohár wrote:
> > > On Thursday 29 August 2019 19:35:06 Sasha Levin wrote:
> > > > With regards to missing specs/docs/whatever - our main
On Wed Oct 16, 2019 at 5:01 PM Jann Horn wrote:
> binder_mmap() tries to prevent the creation of overly big binder mappings
> by silently truncating the size of the VMA to 4MiB. However, this violates
> the API contract of mmap(). If userspace attempts to create a large binder
> VMA, and later atte
On Wed Oct 16, 2019 at 5:01 PM Jann Horn wrote:
> SZ_1K has been defined in include/linux/sizes.h since v3.6. Get rid of the
> duplicate definition.
>
> Signed-off-by: Jann Horn
Acked-by: Christian Brauner
___
devel mailing list
de...@linuxdriverproje
On Wed, Oct 16, 2019 at 10:25:40PM +0800, Chuhong Yuan wrote:
> ad9834_probe misses a check for devm_clk_get and may cause problems.
> Add a check like what ad9832 does to fix it.
>
> Signed-off-by: Chuhong Yuan
Looks good.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
On Wed, Oct 16, 2019 at 07:37:53PM +0530, Aliasgar Surti wrote:
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -507,19 +507,9 @@ int rtw_cmd_thread(void *context)
>
> cmd_process_time = jiffies_to_msecs(jiffies - cmd_start_time
On Wed, Oct 16, 2019 at 12:49:25AM -0700, Chandra Annamaneni wrote:
> Resolved: "CHECK: Alignment should match open parenthesis" from checkpatch
>
I think you accidentally copied the wrong commit message. This one
and the next are the same. This description doesn't match the patch.
regards,
da
On Wed, Oct 16, 2019 at 04:03:53PM +0200, Pali Rohár wrote:
On Friday 30 August 2019 09:56:47 Pali Rohár wrote:
On Thursday 29 August 2019 19:35:06 Sasha Levin wrote:
> With regards to missing specs/docs/whatever - our main concern with this
> release was that we want full interoperability, whic
ad9834_probe misses a check for devm_clk_get and may cause problems.
Add a check like what ad9832 does to fix it.
Signed-off-by: Chuhong Yuan
---
drivers/staging/iio/frequency/ad9834.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/iio/frequency/ad9834.c
b/drivers/stagi
From: Aliasgar Surti
There is use of if..elseif..else condition which has same logic
in all three blocks.
Removed if..else block and placed log message instead that.
Signed-off-by: Aliasgar Surti
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 16 +++-
1 file changed, 3 insertions(+
On Friday 30 August 2019 09:56:47 Pali Rohár wrote:
> On Thursday 29 August 2019 19:35:06 Sasha Levin wrote:
> > With regards to missing specs/docs/whatever - our main concern with this
> > release was that we want full interoperability, which is why the spec
> > was made public as-is without modif
On Mon, Oct 14, 2019 at 06:00:14PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas
>
> Some of the power management ops use this style:
>
> struct device_driver *drv = dev->driver;
> if (drv && drv->pm && drv->pm->prepare(dev))
> drv->pm->prepare(dev);
>
> while others use this:
>
>
Hi Marco,
On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote:
> Hi Chuhong,
>
> On 19-10-15 21:59, Chuhong Yuan wrote:
>> devm_regulator_get may return an error but mipi_csis_phy_init misses
>> a check for it.
>> This may lead to problems when regulator_set_voltage uses the unchecked
>> pointer.
>> Th
On 10/16/19 12:34 AM, Jules Irenge wrote:
> Fix "alignment should mactch open parenthesis" check.
> Issue detected by checkpatch tool
>
> Signed-off-by: Jules Irenge
> ---
> drivers/staging/media/meson/vdec/codec_mpeg12.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/
Hello YueHaibing,
Thank you for the patch.
The same fix has already been submitted a week ago, and I have sent a
pull request today that includes it. I'm afraid I thus can't take this
patch. The good news is that the change was good :-)
On Wed, Oct 16, 2019 at 04:51:36PM +0800, YueHaibing wrote:
Hello Hariprasad,
Thank you for the patch.
As the patch only touches the omap4iss driver, you could have made the
subject line a bit more specific, for instance "staging: media:
omap4iss: Use devm_platform_ioremap_resource". No big deal though.
On Tue, Oct 08, 2019 at 12:25:51PM +0530,
haripras
Hi Chuhong,
On 19-10-15 21:59, Chuhong Yuan wrote:
> devm_regulator_get may return an error but mipi_csis_phy_init misses
> a check for it.
> This may lead to problems when regulator_set_voltage uses the unchecked
> pointer.
> This patch adds a check for devm_regulator_get to avoid potential risk.
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing
---
drivers/staging/ralink-gdma/ralink-gdma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c
b/drivers/sta
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing
---
drivers/staging/netlogic/xlr_net.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/netlogic/xlr_net.c
b/drivers/staging/netlogic/x
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c
b/drivers/staging/m
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing
---
drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
b/d
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing
---
drivers/staging/media/omap4iss/iss.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss.c
b/drivers/staging/med
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing
---
drivers/staging/fieldbus/anybuss/arcx-anybus.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fieldbus/anybuss/arcx-anybus.c
Resolved: "CHECK: Alignment should match open parenthesis" from checkpatch
Signed-off-by: Chandra Annamaneni
---
Previous versions of these patches were not split into different
patches, did not have different patch numbers and did not have the
keyword staging.
drivers/staging/kpc2000/kpc2000_s
Resolved: "CHECK: Alignment should match open parenthesis" from checkpatch
Signed-off-by: Chandra Annamaneni
---
Previous versions of these patches were not split into different
patches, did not have different patch numbers and did not have the
keyword staging.
drivers/staging/kpc2000/kpc2000_s
Resolved: CHECK: Unnecessary parentheses around table[i]
Signed-off-by: Chandra Annamaneni
---
Previous versions of these patches were not split into different
patches, did not have different patch numbers and did not have the
keyword staging.
drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
1 fil
Resolved: "CHECK: Please use a blank line after.." from checkpatch.pl
Signed-off-by: Chandra Annamaneni
---
Previous versions of these patches were not split into different
patches, did not have different patch numbers and did not have the
keyword staging.
drivers/staging/kpc2000/kpc2000_spi.c
On Fri, Oct 11, 2019 at 08:32:19AM +0200, Greg KH wrote:
> On Thu, Oct 10, 2019 at 10:51:51PM -0700, Chandra Annamaneni wrote:
> > Resoved: "WARNING: line over 80 characters" from checkpatch.pl
>
> Please put "staging:" in your subject line, makes it easier to sort and
> handle. It should look so
41 matches
Mail list logo
