From: Hariprasad Kelam
fix below issue reported by coccicheck
drivers/staging//media/omap4iss/iss.c:915:1-15: WARNING: Use
devm_platform_ioremap_resource for iss -> regs [ res ]
Signed-off-by: Hariprasad Kelam
---
drivers/staging/media/omap4iss/iss.c | 6 +-
1 file changed, 1 insertion(+),
From: Hariprasad Kelam
fix below issue reported by coccicheck
drivers/staging//emxx_udc/emxx_udc.c:3092:1-10: WARNING: Use
devm_platform_ioremap_resource for mmio_base
Signed-off-by: Hariprasad Kelam
---
drivers/staging/emxx_udc/emxx_udc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(
From: Hariprasad Kelam
fix below issue reported by coccicheck
drivers/staging//ralink-gdma/ralink-gdma.c:822:1-5: WARNING: Use
devm_platform_ioremap_resource for base
Signed-off-by: Hariprasad Kelam
---
drivers/staging/ralink-gdma/ralink-gdma.c | 4 +---
1 file changed, 1 insertion(+), 3 delet
From: Hariprasad Kelam
fix below issue reported by coccicheck
drivers/staging//netlogic/xlr_net.c:980:2-17: WARNING: Use
devm_platform_ioremap_resource for priv -> base_addr
Signed-off-by: Hariprasad Kelam
---
drivers/staging/netlogic/xlr_net.c | 3 +--
1 file changed, 1 insertion(+), 2 deleti
From: Hariprasad Kelam
fix below issue reported by coccicheck
rivers/staging//mt7621-dma/mtk-hsdma.c:671:1-5: WARNING: Use
devm_platform_ioremap_resource for base
Signed-off-by: Hariprasad Kelam
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
From: Hariprasad Kelam
fix below issue reported by coccicheck
drivers/staging//media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Use
devm_platform_ioremap_resource for state -> regs
Signed-off-by: Hariprasad Kelam
---
drivers/staging/media/imx/imx7-mipi-csis.c | 4 +---
1 file changed, 1 insertion
On Mon, Oct 07, 2019 at 06:15:23PM +0200, Thomas Meyer wrote:
> Dan Carpenter writes:
>
> > On Sun, Oct 06, 2019 at 04:07:45PM +0200, Thomas Meyer wrote:
> >> Use lib/crc32 instead of another implementation.
> >>
> >> Signed-off-by: Thomas Meyer
> >
> > I always get annoyed whenever anyone asks
On Mon, Oct 07, 2019 at 09:52:48PM +0100, Jules Irenge wrote:
> Add comment to spinlock declaration to fix warning issued by checkpatch.pl
> "CHECK: spinlock_t definition without comment".
>
> Signed-off-by: Jules Irenge
> ---
> drivers/staging/rtl8712/drv_types.h | 2 +-
> 1 file changed, 1 ins
From: Hariprasad Kelam
fix below issues reported by coccicheck
drivers/staging//fieldbus/anybuss/arcx-anybus.c:135:1-5: WARNING: Use
devm_platform_ioremap_resource for base
drivers/staging//fieldbus/anybuss/arcx-anybus.c:248:1-14: WARNING: Use
devm_platform_ioremap_resource for cd -> cpld_base
S
On Tue, Oct 08, 2019 at 09:06:11AM +0300, Dan Carpenter wrote:
> On Tue, Oct 08, 2019 at 01:38:58PM +0800, zhengbin wrote:
> > diff --git a/drivers/staging/sm750fb/ddk750_mode.c
> > b/drivers/staging/sm750fb/ddk750_mode.c
> > index 9722692..e0230f4 100644
> > --- a/drivers/staging/sm750fb/ddk750_m
On Tue, Oct 08, 2019 at 01:38:58PM +0800, zhengbin wrote:
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c
> b/drivers/staging/sm750fb/ddk750_mode.c
> index 9722692..e0230f4 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -209,12 +209,11
On Tue, Oct 08, 2019 at 01:38:57PM +0800, zhengbin wrote:
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
> b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
> index c6f9cf1..8a94c5b 100644
> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
>
On Mon, 7 Oct 2019, Nachammai Karuppiah wrote:
> Remove NULL comparison. Issue found using checkpatch.pl
This introduces compiler warnings, which you should try very hard not to
do.
julia
>
> Signed-off-by: Nachammai Karuppiah
>
> ---
>
> Changes in V2
>- Remove all NULL comparisons in
From: Hariprasad Kelam
Fix below issue reported by coccicheck
drivers/staging//clocking-wizard/clk-xlnx-clock-wizard.c:147:1-15:
WARNING: Use devm_platform_ioremap_resource for clk_wzrd -> base
Signed-off-by: Hariprasad Kelam
---
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 4 +---
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/sm750fb/ddk750_mode.c: In function ddk750_setModeTiming:
drivers/staging/sm750fb/ddk750_mode.c:212:15: warning: variable
uiActualPixelClk set but not used [-Wunused-but-set-variable]
It is not used since commit 81dee67e215b ("staging
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/sm750fb/ddk750_chip.c: In function set_chip_clock:
drivers/staging/sm750fb/ddk750_chip.c:59:15: warning: variable actual_mx_clk
set but not used [-Wunused-but-set-variable]
It is not used since commit f0977109a577 ("staging:
sm750fb:
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt3000.c: In function dt3k_ai_insn_read:
drivers/staging/comedi/drivers/dt3000.c:511:27: warning: variable aref set but
not used [-Wunused-but-set-variable]
It is not used since commit 2e310235ca8f ("staging:
comedi: d
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn:
drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable hi set but not
used [-Wunused-but-set-variable]
It is not used since commit d6a929b7608a ("Staging:
comedi: add dt2
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c: In function
audio_vchi_callback:
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c:99:6: warning:
variable status set but not used [-Wunused-but-set-variable]
It is not used sin
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt2814.c: In function dt2814_interrupt:
drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable data set but
not used [-Wunused-but-set-variable]
It is not used since commit 7806012e97ed ("staging:
comedi: ref
zhengbin (6):
staging: bcm2835-audio: Remove set but not used variable 'status'
staging: sm750fb: Remove set but not used variable 'uiActualPixelClk'
staging: sm750fb: Remove set but not used variable 'actual_mx_clk'
staging: comedi: Remove set but not used variable 'data'
staging: comedi
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-next
head: e772cd8c9c9cd3d08715800aabaf50b771b395d9
commit: 4f8b7fabb15df3658564a98971fc67029be1815d [50/93] staging: wfx: allow to
send commands to chip
If you fix the issue, kindly add following tag
Reported-b
Fixes checkpatch.pl warning: do not add new typedefs in
drivers/staging/octeon/octeon-stubs.h:41
Signed-off-by: Wambui Karuga
---
drivers/staging/octeon/octeon-stubs.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/octeon/octeon-stubs.h
b/drivers/stagi
When building for a non-Cavium MIPS system with COMPILE_TEST=y, the
Octeon ethernet driver hits a number of issues due to use of macros
provided only for CONFIG_CAVIUM_OCTEON_SOC=y configurations. For
example:
drivers/staging/octeon/ethernet-rx.c:190:6: error:
'CONFIG_CAVIUM_OCTEON_CVMSEG_SI
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/rtl8723bs/core/rtw_xmit.c: In function update_attrib:
drivers/staging/rtl8723bs/core/rtw_xmit.c:680:7: warning: variable i set but
not used [-Wunused-but-set-variable]
It is not used since commit 554c0a3abf21 ("staging:
Add rtl8723bs
Remove NULL comparison. Issue found using checkpatch.pl
Signed-off-by: Nachammai Karuppiah
---
Changes in V2
- Remove all NULL comparisons in vc04_services/interface directory.
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 4 ++--
.../vc04_services/interface/vchiq_arm/vchiq_arm.
Thank you for letting us know about the issue Jann. I will work on a
fix and send out the same for review once ready.
Regards,
Hridya
On Mon, Oct 7, 2019 at 2:04 PM Todd Kjos wrote:
>
> +Hridya Valsaraju
>
>
> On Mon, Oct 7, 2019 at 1:50 PM Jann Horn wrote:
> >
> > Hi!
> >
> > There is a use-a
On Mon, Oct 07, 2019 at 10:49:57PM +0200, Jann Horn wrote:
> Hi!
>
> There is a use-after-free read in print_binder_transaction_log_entry()
> on ANDROID_BINDERFS kernels because
> print_binder_transaction_log_entry() prints the char* e->context_name
> as string, and if the transaction occurred on
+Hridya Valsaraju
On Mon, Oct 7, 2019 at 1:50 PM Jann Horn wrote:
>
> Hi!
>
> There is a use-after-free read in print_binder_transaction_log_entry()
> on ANDROID_BINDERFS kernels because
> print_binder_transaction_log_entry() prints the char* e->context_name
> as string, and if the transaction o
On Mon, 7 Oct 2019, Jules Irenge wrote:
> Add comment to spinlock declaration to fix warning issued by checkpatch.pl
> "CHECK: spinlock_t definition without comment".
Since it is not apparent from the shown code, it would be helpful to
describe what evidence you used to choose this comment.
t
Add comment to spinlock declaration to fix warning issued by checkpatch.pl
"CHECK: spinlock_t definition without comment".
Signed-off-by: Jules Irenge
---
drivers/staging/rtl8712/drv_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/drv_types.h
Hi!
There is a use-after-free read in print_binder_transaction_log_entry()
on ANDROID_BINDERFS kernels because
print_binder_transaction_log_entry() prints the char* e->context_name
as string, and if the transaction occurred on a binder device from
binderfs, e->context_name belongs to the binder de
Dne ponedeljek, 07. oktober 2019 ob 12:44:24 CEST je Hans Verkuil napisal(a):
> Hi Jernej,
>
> On 9/29/19 10:00 PM, Jernej Skrabec wrote:
> > This series adds support for decoding multi-slice H264 frames along with
> > support for V4L2_DEC_CMD_FLUSH and V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF.
> >
> >
> -Original Message-
> From: Bjorn Helgaas
> Sent: Monday, October 7, 2019 6:24 AM
> To: Dexuan Cui
> Cc: lorenzo.pieral...@arm.com; linux-...@vger.kernel.org; Michael Kelley
> ; linux-hyp...@vger.kernel.org;
> linux-ker...@vger.kernel.org; driverdev-devel@linuxdriverproject.org; Sasha
>
Fix typo s/mechansim/mechanism/
Signed-off-by: Antonio Borneo
---
drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
index 6e4a1fcb8790..d5793e4614
Dan Carpenter writes:
> On Sun, Oct 06, 2019 at 04:07:45PM +0200, Thomas Meyer wrote:
>> Use lib/crc32 instead of another implementation.
>>
>> Signed-off-by: Thomas Meyer
>
> I always get annoyed whenever anyone asks if people have tested their
> patches, but have you tested this?
no annoynen
On Sun, Oct 06, 2019 at 09:39:02PM -0300, Gabriela Bittencourt wrote:
> Cleans up checks of "Alignment should match open parenthesis"
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rtl8712/rtl8712_led.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dr
On Sun, Oct 06, 2019 at 04:07:45PM +0200, Thomas Meyer wrote:
> Use lib/crc32 instead of another implementation.
>
> Signed-off-by: Thomas Meyer
I always get annoyed whenever anyone asks if people have tested their
patches, but have you tested this? It's hard for me to review it
because I don't
On Sun, Oct 06, 2019 at 05:09:55PM +0800, zhengbin wrote:
> @@ -689,7 +688,7 @@ static s32 update_attrib(struct adapter *padapter, _pkt
> *pkt, struct pkt_attrib
> DBG_COUNTER(padapter->tx_logs.core_tx_upd_attrib);
>
> _rtw_open_pktfile(pkt, &pktfile);
> - i = _rtw_pktfile_read(&p
On Wed, Aug 14, 2019 at 01:06:55AM +, Dexuan Cui wrote:
>
> In pci_legacy_suspend_late(), the device state is moved to PCI_UNKNOWN.
>
> In pci_pm_thaw_noirq(), the state is supposed to be moved back to PCI_D0,
> but the current code misses the pci_legacy_resume_early() path, so the
> state re
Hi Jernej,
On 9/29/19 10:00 PM, Jernej Skrabec wrote:
> This series adds support for decoding multi-slice H264 frames along with
> support for V4L2_DEC_CMD_FLUSH and V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF.
>
> Code was tested by modified ffmpeg, which can be found here:
> https://github.com/jernejsk/
On Sun, Oct 06, 2019 at 05:09:55PM +0800, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/rtl8723bs/core/rtw_xmit.c: In function update_attrib:
> drivers/staging/rtl8723bs/core/rtw_xmit.c:680:7: warning: variable i set but
> not used [-Wunused-but-set-variable
On Sun, Oct 06, 2019 at 07:20:15PM -0300, Gabriela Bittencourt wrote:
> Cleans up checks of: "Alignment should match open parenthesis"
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rtl8712/osdep_service.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You sent 2 diffe
On Sun, Oct 06, 2019 at 04:10:20PM -0300, Gabriela Bittencourt wrote:
> Cleans up CHECKs of "Alignment should match open parenthesis"
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/vt6656/rxtx.c | 63 +++
> 1 file changed, 41 insertions(+), 22 del
On Sun, Oct 06, 2019 at 05:34:20PM -0300, Gabriela Bittencourt wrote:
> Cleans up warnings of "Block comments should align the * on each line"
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rtl8712/recv_linux.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> dif
On Sun, Oct 06, 2019 at 04:58:54PM -0300, Gabriela Bittencourt wrote:
> Cleans up checks of "don't use multiple blank line"
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/vt6656/main_usb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c
On 10/7/19 10:32 AM, Hans Verkuil wrote:
> On 10/7/19 8:02 AM, Jernej Škrabec wrote:
>> Dne petek, 04. oktober 2019 ob 11:21:12 CEST je Hans Verkuil napisal(a):
>>> On 9/29/19 10:00 PM, Jernej Skrabec wrote:
These helpers are used by stateless codecs when they support multiple
slices per
On Mon, Oct 07, 2019 at 08:36:22AM +, Jerome Pouiller wrote:
> On Friday 4 October 2019 12:48:32 CEST kbuild test robot wrote:
> [...]
> > >> drivers/staging/wfx/main.c:47:14-21: ERROR: PTR_ERR applied after
> > >> initialization to constant on line 42
> >
> > vim +47 drivers/staging/wfx/main
On Friday 4 October 2019 12:48:32 CEST kbuild test robot wrote:
[...]
> >> drivers/staging/wfx/main.c:47:14-21: ERROR: PTR_ERR applied after
> >> initialization to constant on line 42
>
> vim +47 drivers/staging/wfx/main.c
>
> 30
> 31 struct gpio_desc *wfx_get_gpio(struct device *dev, i
On 10/7/19 8:02 AM, Jernej Škrabec wrote:
> Dne petek, 04. oktober 2019 ob 11:21:12 CEST je Hans Verkuil napisal(a):
>> On 9/29/19 10:00 PM, Jernej Skrabec wrote:
>>> These helpers are used by stateless codecs when they support multiple
>>> slices per frame and hold capture buffer flag is set. It's
On Fri, Oct 4, 2019 at 4:57 PM Krzysztof Kozlowski wrote:
> Adjust indentation from spaces to tab (+optional two spaces) as in
> coding style with command like:
> $ sed -e 's/^/\t/' -i */Kconfig
>
> Signed-off-by: Krzysztof Kozlowski
> arch/m68k/Kconfig.bus | 2 +-
51 matches
Mail list logo
