attention de...@linuxdriverproject.org,

Dear de...@linuxdriverproject.org, THIS IS FOR YOUR ATTENTION. I wish to notify you that you are the beneficiary to the total sum of $10,600,000.00 Million (Ten Million Six Hundred Thousand United States Dollars). This is the sum deposited by my late client with the bank months before his

[PATCH] staging: rtl8723bs: Variable rf_type in function rtw_cfg80211_init_wiphy() could be uninitialized

In function rtw_cfg80211_init_wiphy(), local variable "rf_type" could be uninitialized if function rtw_hal_get_hwreg() fails to initialize it. However, this value is used in function rtw_cfg80211_init_ht_capab() and used to decide the value writing to ht_cap, which is potentially unsafe. Signed-of

[PATCH RESEND v3 00/26] Add definition for the number of standard PCI BARs

Code that iterates over all standard PCI BARs typically uses PCI_STD_RESOURCE_END, but this is error-prone because it requires "i <= PCI_STD_RESOURCE_END" rather than something like "i < PCI_STD_NUM_BARS". We could add such a definition and use it the same way PCI_SRIOV_NUM_BARS is used. The patchs

[PATCH] staging: rtl8188eu: fix null dereference when kzalloc fails

If kzalloc() returns NULL, the error path doesn't stop the flow of control from entering rtw_hal_read_chip_version() which dereferences the null pointer. Fix this by adding a 'goto' to the error path to more gracefully handle the issue and avoid proceeding with initialization steps that we're no lo

Re: [PATCH] staging: rtl8192u: fix multiple memory leaks on error path

> In rtl8192_tx on error handling path allocated urbs and also skb should > be released. Can this change description be improved? How do you think about to add the tag “Fixes” here? > @@ -1588,7 +1590,12 @@ short rtl8192_tx(struct net_device *dev, struct > sk_buff *skb) > RT_TRACE(COMP_

Re: [PATCH] staging: vt6656: clean up an indentation issue

On Fri, Sep 27, 2019 at 10:24:00AM +0100, Colin King wrote: > From: Colin Ian King > > There is a block of code that is indented incorrectly, add in the > missing tabs. > > Signed-off-by: Colin Ian King > --- > drivers/staging/vt6656/main_usb.c | 8 > 1 file changed, 4 insertions(+),

Re: [PATCH v2] staging: rtl8188eu: remove dead code/vestigial do..while loop

Looks good. Thanks! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8188eu: fix HighestRate check in odm_ARFBRefresh_8188E()

Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.3.1, v5.2.17, v4.19.75, v4.14.146, v4.9.194, v4.4.194. v5.3.1: Build OK! v5.2.1

Re: [PATCH v3 0/4] Add binder state and statistics to binderfs

On Tue, Sep 03, 2019 at 09:16:51AM -0700, Hridya Valsaraju wrote: > Currently, the only way to access binder state and > statistics is through debugfs. We need a way to > access the same even when debugfs is not mounted. > These patches add a mount option to make this > information available in bin

[PATCH v2 11/17] staging: qlge: Factor out duplicated expression

Given that (u16) 65536 == 0, that expression can be replaced by a simple cast. Signed-off-by: Benjamin Poirier --- drivers/staging/qlge/qlge.h | 5 + drivers/staging/qlge/qlge_main.c | 18 ++ 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/stagi

[PATCH v2 05/17] staging: qlge: Remove bq_desc.maplen

The size of the mapping is known statically in all cases, there's no need to save it at runtime. Remove this member. Signed-off-by: Benjamin Poirier Acked-by: Manish Chopra --- drivers/staging/qlge/qlge.h | 1 - drivers/staging/qlge/qlge_main.c | 43 +++- 2 fil

[PATCH v2 16/17] staging: qlge: Refill rx buffers up to multiple of 16

Reading the {s,l}bq_prod_idx registers on a running device, it appears that the adapter will only use buffers up to prod_idx & 0xfff0. The driver currently uses fixed-size guard zones (16 for sbq, 32 for lbq - don't know why this difference). After the previous patch, this approach no longer guaran

[PATCH v2 12/17] staging: qlge: Remove qlge_bq.len & size

Given the way the driver currently works, these values are always known at compile time. Signed-off-by: Benjamin Poirier --- drivers/staging/qlge/qlge.h | 17 +--- drivers/staging/qlge/qlge_dbg.c | 4 -- drivers/staging/qlge/qlge_main.c | 75 3 files c

[PATCH v2 08/17] staging: qlge: Deduplicate rx buffer queue management

The qlge driver (and device) uses two kinds of buffers for reception, so-called "small buffers" and "large buffers". The two are arranged in rings, the sbq and lbq. These two share similar data structures and code. Factor out data structures into a common struct qlge_bq, make required adjustments

[PATCH v2 13/17] staging: qlge: Remove useless memset

This just repeats what the other memset a few lines above did. Signed-off-by: Benjamin Poirier --- drivers/staging/qlge/qlge_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index ef33db118aa1..8da596922582 100644 --- a

[PATCH v2 15/17] staging: qlge: Update buffer queue prod index despite oom

Currently, if we repeatedly fail to allocate all of the buffers from the desired batching budget, we will never update the prod_idx register. Restructure code to always update prod_idx if new buffers could be allocated. This eliminates the current two stage process (clean_idx -> prod_idx) and some

[PATCH v2 02/17] staging: qlge: Remove irq_cnt

qlge uses an irq enable/disable refcounting scheme that is: * poorly implemented Uses a spin_lock to protect accesses to the irq_cnt atomic variable. * buggy Breaks when there is not a 1:1 sequence of irq - napi_poll, such as when using SO_BUSY_POLL. * unnecessary

[PATCH v2 17/17] staging: qlge: Refill empty buffer queues from wq

When operating at mtu 9000, qlge does order-1 allocations for rx buffers in atomic context. This is especially unreliable when free memory is low or fragmented. Add an approach similar to commit 3161e453e496 ("virtio: net refill on out-of-memory") to qlge so that the device doesn't lock up if there

[PATCH v2 14/17] staging: qlge: Replace memset with assignment

Instead of clearing the structure wholesale, it is sufficient to initialize the skb member which is used to manage sbq instances. lbq instances are managed according to curr_idx and clean_idx. Signed-off-by: Benjamin Poirier --- drivers/staging/qlge/qlge_main.c | 3 +-- 1 file changed, 1 inserti

[PATCH v2 03/17] staging: qlge: Remove page_chunk.last_flag

As already done in ql_get_curr_lchunk(), this member can be replaced by a simple test. Signed-off-by: Benjamin Poirier Acked-by: Manish Chopra --- drivers/staging/qlge/qlge.h | 1 - drivers/staging/qlge/qlge_main.c | 13 + 2 files changed, 5 insertions(+), 9 deletions(-) diff

[PATCH v2 09/17] staging: qlge: Fix dma_sync_single calls

Using the unmap addr elsewhere than unmap calls is a misuse of the dma api. In prevision of this fix, qlge kept two copies of the dma address around ;) Fixes: c4e84bde1d59 ("qlge: New Qlogic 10Gb Ethernet Driver.") Fixes: 7c734359d350 ("qlge: Size RX buffers based on MTU.") Fixes: 2c9a266afefe ("q

[PATCH v2 04/17] staging: qlge: Deduplicate lbq_buf_size

lbq_buf_size is duplicated to every rx_ring structure whereas lbq_buf_order is present once in the ql_adapter structure. All rings use the same buf size, keep only one copy of it. Also factor out the calculation of lbq_buf_size instead of having two copies. Signed-off-by: Benjamin Poirier Acked-b

[PATCH v2 07/17] staging: qlge: Remove useless dma synchronization calls

This is unneeded for two reasons: 1) the cpu does not write data for the device in the mapping 2) calls like ..._sync_..._for_device(..., ..._FROMDEVICE) are nonsensical, see commit 3f0fb4e85b38 ("Documentation/DMA-API-HOWTO.txt: fix misleading example") Signed-off-by: Benjamin Poirier ---

[PATCH v2 01/17] staging: qlge: Fix irq masking in INTx mode

Tracing the driver operation reveals that the INTR_EN_EN bit (per-queue interrupt control) does not immediately prevent rx completion interrupts when the device is operating in INTx mode. This leads to interrupts being raised while napi is scheduled/running. Those interrupts are ignored by qlge_isr

[PATCH v2 06/17] staging: qlge: Remove rx_ring.sbq_buf_size

Tx completion rings have sbq_buf_size = 0 but there's no case where the code actually tests on that value. We can remove sbq_buf_size and use a constant instead. Signed-off-by: Benjamin Poirier Reviewed-by: Willem de Bruijn --- drivers/staging/qlge/qlge.h | 1 - drivers/staging/qlge/qlge_

[PATCH v2 10/17] staging: qlge: Remove rx_ring.type

This field is redundant, the type can be determined from the index, cq_id. Signed-off-by: Benjamin Poirier --- drivers/staging/qlge/qlge.h | 10 -- drivers/staging/qlge/qlge_dbg.c | 16 drivers/staging/qlge/qlge_main.c | 31 +++ 3 files

[PATCH v2 0/17] staging: qlge: Fix rx stall in case of allocation failures

qlge refills rx buffers from napi context. In case of allocation failure, allocation will be retried the next time napi runs. If a receive queue runs out of free buffers (possibly after subsequent allocation failures), it drops all traffic, no longer raises interrupts and napi is no longer schedule

[PATCH] staging: vt6656: clean up an indentation issue

From: Colin Ian King There is a block of code that is indented incorrectly, add in the missing tabs. Signed-off-by: Colin Ian King --- drivers/staging/vt6656/main_usb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/stag