[PATCH] Staging: octeon: Avoid several usecases of strcpy

2019-09-10 Thread Sandro Volery
strcpy was used multiple times in strcpy to write into dev->name. I replaced them with strscpy. Signed-off-by: Sandro Volery --- drivers/staging/octeon/ethernet.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/sta

[PATCH] Staging: exfat: Avoid use of strcpy

2019-09-10 Thread Sandro Volery
Replaced strcpy with strscpy in exfat_core.c. Signed-off-by: Sandro Volery --- drivers/staging/exfat/exfat_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c index da8c58149c35..c71b145e8a24 100644 -

[PATCH v2] staging: android: ion: Replace strncpy() for stracpy()

2019-09-10 Thread Adam Zerella
Using strncpy() does not always terminate the destination string. stracpy() is a alternative function that does, by using this new function we will no longer need to insert a null separator. Signed-off-by: Adam Zerella --- v2: Remove unnecessary MAX_HEAP_NAME param from stracpy() --- drivers/st

Re: [PATCH] staging: rtl8712: Replace snprintf with scnprintf

2019-09-10 Thread Rohit Sarkar
Resending as I made a typo in Larry's email id. On Wed, Sep 11, 2019 at 12:19:31AM +0530, Rohit Sarkar wrote: > When the number of bytes to be printed exceeds the limit snprintf > returns the number of bytes that would have been printed (if there was > no truncation). This might cause issues, henc

[PATCH] staging: rtl8712: Replace snprintf with scnprintf

2019-09-10 Thread Rohit Sarkar
When the number of bytes to be printed exceeds the limit snprintf returns the number of bytes that would have been printed (if there was no truncation). This might cause issues, hence use scnprintf which returns the actual number of bytes printed to buffer always. Signed-off-by: Rohit Sarkar ---

[PATCH] staging: rtl8192u: ieee80211: Replace snprintf with scnprintf

2019-09-10 Thread Rohit Sarkar
When the number of bytes to be printed exceeds the limit snprintf returns the number of bytes that would have been printed (if there was no truncation). This might cause issues, hence use scnprintf which returns the actual number of bytes printed to buffer always. Signed-off-by: Rohit Sarkar ---

Re: staging: exfat: issue with FFS_MEDIAERR error return assignment

2019-09-10 Thread Valdis Klētnieks
On Tue, 10 Sep 2019 16:09:35 +0300, Dan Carpenter said: > On Tue, Sep 10, 2019 at 01:58:35PM +0100, Colin Ian King wrote: > > On 10/09/2019 13:44, Dan Carpenter wrote: > > > On Fri, Aug 30, 2019 at 07:38:00PM +0100, Colin Ian King wrote: > > >> Hi, > > >> > > >> Static analysis on exfat with Coveri

Re: staging: exfat: issue with FFS_MEDIAERR error return assignment

2019-09-10 Thread Dan Carpenter
On Tue, Sep 10, 2019 at 01:58:35PM +0100, Colin Ian King wrote: > On 10/09/2019 13:44, Dan Carpenter wrote: > > On Fri, Aug 30, 2019 at 07:38:00PM +0100, Colin Ian King wrote: > >> Hi, > >> > >> Static analysis on exfat with Coverity has picked up an assignment of > >> FFS_MEDIAERR that gets over-w

Re: staging: exfat: issue with FFS_MEDIAERR error return assignment

2019-09-10 Thread Colin Ian King
On 10/09/2019 13:44, Dan Carpenter wrote: > On Fri, Aug 30, 2019 at 07:38:00PM +0100, Colin Ian King wrote: >> Hi, >> >> Static analysis on exfat with Coverity has picked up an assignment of >> FFS_MEDIAERR that gets over-written: >> >> >> 1750if (is_dir) { >> 1751if ((fid->

Re: staging: exfat: issue with FFS_MEDIAERR error return assignment

2019-09-10 Thread Dan Carpenter
On Fri, Aug 30, 2019 at 07:38:00PM +0100, Colin Ian King wrote: > Hi, > > Static analysis on exfat with Coverity has picked up an assignment of > FFS_MEDIAERR that gets over-written: > > > 1750if (is_dir) { > 1751if ((fid->dir.dir == p_fs->root_dir) && > 1752

Re: [PATCH v3] Staging: gasket: Use temporaries to reduce line length.

2019-09-10 Thread Dan Carpenter
Looks good. Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: r8188eu: replace rtw_malloc() with it's definition

2019-09-10 Thread Dan Carpenter
On Sun, Sep 08, 2019 at 12:00:26PM +0300, Ivan Safonov wrote: > rtw_malloc prevents the use of kmemdup/kzalloc and others. > > Signed-off-by: Ivan Safonov > --- > drivers/staging/rtl8188eu/core/rtw_ap.c| 4 ++-- > drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- > .../staging/rtl

Re: [PATCH] staging: android: ion: Replace strncpy() for stracpy()

2019-09-10 Thread Dan Carpenter
On Sun, Sep 08, 2019 at 02:34:50PM +1000, Adam Zerella wrote: > Using strncpy() does not always terminate the destination string. > stracpy() is a alternative function that does, by using this new > function we will no longer need to insert a null separator. > > Signed-off-by: Adam Zerella > ---

Re: [PATCH] Staging: wlan-ng: parenthesis at end of line fix

2019-09-10 Thread Dan Carpenter
On Sat, Sep 07, 2019 at 10:57:20PM +0200, Sandro Volery wrote: > Fixed open parenthesis at the end of the line on line 327. > > Signed-off-by: Sandro Volery > --- > drivers/staging/wlan-ng/cfg80211.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/wlan

Re: [PATCH v2 1/2] staging: rtl8192u: Add or remove spaces to fix style issues

2019-09-10 Thread Dan Carpenter
On Sun, Sep 08, 2019 at 12:58:39PM +0530, Sumera Priyadarsini wrote: > Hi, I am extremely sorry for a late response to this. I was caught up > with some laptop issues. I will send a separate patch making the > change right away. There is not need to apologize at all. I'm not signing your paycheck

Re: [PATCH v2] Staging: gasket: Use temporaries to reduce line length.

2019-09-10 Thread Dan Carpenter
On Tue, Sep 10, 2019 at 07:11:26AM +0200, Sandro Volery LKML wrote: > Wow... I checked, compiled and still sent the wrong thing again. I'm > gonna have to give this up soon if i can't get it right. > The mistake was using gasket_page_table_num_simple_entries() instead of gasket_page_table_num_ent

Toto je moje poslední vɑrování Driverdev Devel!

2019-09-10 Thread Aʼnonymní Hʌcker
POSLEDNÍ VAROVÁNÍ driverdev-devel@linuxdriverproject.org! Máte konečnou příležitost zachránit svůj společenský život - já si srandu !! Dávám vám posledních 72 hodin, abych provedl platbu, než pošlu vίdeo s vaší ʍasturbací všem svým přátelům a spolupracovníkům. Naposledy jste navštívili Ƿornogra

Re: [PATCH] media: imx7-mipi-csis: make array 'registers' static const, makes object smaller

2019-09-10 Thread Rui Miguel Silva
Hi Colin, Thanks for the patch. On Fri 06 Sep 2019 at 16:08, Colin King wrote: > From: Colin Ian King > > Don't populate the array 'registers' on the stack but instead make it > static const. Makes the object code smaller by 10 bytes. > > > Before: >text data bss dec hex

Re: [PATCH] FBTFT: fb_agm1264k: usleep_range is preferred over udelay

2019-09-10 Thread Geert Uytterhoeven
Hi Sreeram, On Tue, Sep 10, 2019 at 2:25 AM Sreeram Veluthakkal wrote: > On Mon, Sep 09, 2019 at 10:56:25AM +0100, Greg KH wrote: > > On Sun, Sep 08, 2019 at 08:26:05PM -0500, Sreeram Veluthakkal wrote: > > > This patch fixes the issue: > > > FILE: drivers/staging/fbtft/fb_agm1264k-fl.c:88: > > >

[PATCH 1/2] staging: wilc1000: remove unused interrupt status handling code

2019-09-10 Thread Ajay.Kathat
From: Ajay Singh Remove interrupt handling for unused interrupt status(PLL update and Sleep). The firmware only initiates the interrupt for the data transfer to host and rest are not used anymore. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 26 -

[PATCH 2/2] staging: wilc1000: avoid twice IRQ handler execution for each single interrupt

2019-09-10 Thread Ajay.Kathat
From: Ajay Singh The IRQ handler(isr_bh_routine()) was called twice for each interrupt from firmware. The data was read completely during the first call and the second call was doing nothing. Now changed the IRQ flag from ‘level’ to ‘edge’ trigger i.e IRQF_TRIGGER_LOW to IRQF_TRIGGER_FALLING to a