[PATCH v3] Staging: gasket: Use temporaries to reduce line length.

2019-09-09 Thread Sandro Volery
Using temporaries for gasket_page_table entries to remove scnprintf() statements and reduce line length, as suggested by Joe Perches. Thanks! Signed-off-by: Sandro Volery --- v3: Fixed faulty copy/paste of function v2: Attempt to fix v1: Original patch drivers/staging/gasket/apex_driver.c | 20

Re: [PATCH v2] Staging: gasket: Use temporaries to reduce line length.

2019-09-09 Thread Sandro Volery LKML
Wow... I checked, compiled and still sent the wrong thing again. I'm gonna have to give this up soon if i can't get it right. Sandro V > On 10 Sep 2019, at 07:06, Sandro Volery wrote: > > Using temporaries for gasket_page_table entries to remove scnprintf() > statements and reduce line length

[PATCH v2] Staging: gasket: Use temporaries to reduce line length.

2019-09-09 Thread Sandro Volery
Using temporaries for gasket_page_table entries to remove scnprintf() statements and reduce line length, as suggested by Joe Perches. Thanks! Signed-off-by: Sandro Volery --- drivers/staging/gasket/apex_driver.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --

Re: [PATCH] Staging: gasket: Use temporaries to reduce line length.

2019-09-09 Thread Sandro Volery
> On 10 Sep 2019, at 00:30, Joe Perches wrote: > > On Mon, 2019-09-09 at 22:28 +0200, Sandro Volery wrote: >> Using temporaries for gasket_page_table entries to remove scnprintf() >> statements and reduce line length, as suggested by Joe Perches. Thanks! > > nak. Slow down. You broke the co

Re: [PATCH] Staging: gasket: Use temporaries to reduce line length.

2019-09-09 Thread Joe Perches
On Mon, 2019-09-09 at 22:28 +0200, Sandro Volery wrote: > Using temporaries for gasket_page_table entries to remove scnprintf() > statements and reduce line length, as suggested by Joe Perches. Thanks! nak. Slow down. You broke the code. Please be _way_ more careful and verify for yourself the

[PATCH] Staging: gasket: Use temporaries to reduce line length.

2019-09-09 Thread Sandro Volery
Using temporaries for gasket_page_table entries to remove scnprintf() statements and reduce line length, as suggested by Joe Perches. Thanks! Signed-off-by: Sandro Volery --- drivers/staging/gasket/apex_driver.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --

Re: [PATCH] staging: nvec: make use of devm_platform_ioremap_resource

2019-09-09 Thread Marc Dietrich
Hi Hariprased, On Sun, 8 Sep 2019, hariprasad@MISSING_DOMAIN wrote: ^^ something is wrong with your git mail config... From: Hariprasad Kelam fix below issue reported by coccicheck drivers/staging//nvec/nvec.c:794:1-5: WARNING: Use devm_platform_io

Re: [PATCH v2] staging: greybus: loopback_test: Adding missing brackets into if..else block

2019-09-09 Thread Greg KH
On Mon, Sep 09, 2019 at 02:32:44PM +, Julio Faracco wrote: > Inside a block of if..else conditional, else structure does not contain > brackets. This is not following regular policies of kernel coding style. > All parts of this conditional blocks should respect brackets inclusion. > This commit

[PATCH v2] staging: greybus: loopback_test: Adding missing brackets into if..else block

2019-09-09 Thread Julio Faracco
Inside a block of if..else conditional, else structure does not contain brackets. This is not following regular policies of kernel coding style. All parts of this conditional blocks should respect brackets inclusion. This commit removes some blank spaces that are not following brackets policies too

[PATCH v2 2/2] staging: wilc1000: look for rtc_clk clock

2019-09-09 Thread Eugen.Hristev
From: Eugen Hristev If rtc_clk is provided from DT, use it and enable it. This is optional. The signal may be hardcoded and no need to be requested, but if DT provides it, use it. Signed-off-by: Eugen Hristev Acked-by: Ajay Singh --- Changes in v2: - rebased on staging-next drivers/staging/

[PATCH v2 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property

2019-09-09 Thread Eugen.Hristev
From: Eugen Hristev Add bindings for optional rtc clock pin. Signed-off-by: Eugen Hristev Acked-by: Ajay Singh --- Changes in v2: - none drivers/staging/wilc1000/microchip,wilc1000,sdio.txt | 8 +++- drivers/staging/wilc1000/microchip,wilc1000,spi.txt | 8 2 files changed, 15

Re: [PATCH] FBTFT: fb_agm1264k: usleep_range is preferred over udelay

2019-09-09 Thread Sreeram Veluthakkal
On Mon, Sep 09, 2019 at 10:56:25AM +0100, Greg KH wrote: > On Sun, Sep 08, 2019 at 08:26:05PM -0500, Sreeram Veluthakkal wrote: > > This patch fixes the issue: > > FILE: drivers/staging/fbtft/fb_agm1264k-fl.c:88: > > CHECK: usleep_range is preferred over udelay; see > > Documentation/timers/timers

Re: [PATCH] FBTFT: fb_agm1264k: usleep_range is preferred over udelay

2019-09-09 Thread Greg KH
On Sun, Sep 08, 2019 at 08:26:05PM -0500, Sreeram Veluthakkal wrote: > This patch fixes the issue: > FILE: drivers/staging/fbtft/fb_agm1264k-fl.c:88: > CHECK: usleep_range is preferred over udelay; see > Documentation/timers/timers-howto.rst > + udelay(20); > > Signed-off-by: Sreeram Veluth