Re: [greybus-dev] [PATCH 9/9] staging: greybus: move es2 to drivers/greybus/

2019-08-25 Thread Viresh Kumar
On 25-08-19, 07:54, Greg Kroah-Hartman wrote: > The es2 Greybus host controller has long been stable, so move it out of > drivers/staging/ to drivers/greybus/ > > Cc: Johan Hovold > Cc: Alex Elder > Cc: greybus-...@lists.linaro.org > Cc: linux-ker...@vger.kernel.org > Signed-off-by: Greg Kroah-H

Re: [greybus-dev] [PATCH 8/9] staging: greybus: move the greybus core to drivers/greybus

2019-08-25 Thread Viresh Kumar
On 25-08-19, 07:54, Greg Kroah-Hartman wrote: > The Greybus core code has been stable for a long time, and has been > shipping for many years in millions of phones. With the advent of a > recent Google Summer of Code project, and a number of new devices in the > works from various companies, it is

Re: [greybus-dev] [PATCH 4/9] staging: greybus: manifest: Fix up some alignment checkpatch issues

2019-08-25 Thread Viresh Kumar
On 25-08-19, 07:54, Greg Kroah-Hartman wrote: > Some function prototypes do not match the expected alignment formatting > so fix that up so that checkpatch is happy. > > Cc: Johan Hovold > Cc: Alex Elder > Cc: greybus-...@lists.linaro.org > Cc: de...@driverdev.osuosl.org > Signed-off-by: Greg Kr

Re: [greybus-dev] [PATCH 5/9] staging: greybus: log: Fix up some alignment checkpatch issues

2019-08-25 Thread Viresh Kumar
On 25-08-19, 07:54, Greg Kroah-Hartman wrote: > Some function prototypes do not match the expected alignment formatting > so fix that up so that checkpatch is happy. > > Cc: David Lin > Cc: Johan Hovold > Cc: Alex Elder > Cc: greybus-...@lists.linaro.org > Cc: de...@driverdev.osuosl.org > Signe

Re: [greybus-dev] [PATCH 6/9] staging: greybus: loopback: Fix up some alignment checkpatch issues

2019-08-25 Thread Viresh Kumar
On 25-08-19, 07:54, Greg Kroah-Hartman wrote: > Some function prototypes do not match the expected alignment formatting > so fix that up so that checkpatch is happy. > > Cc: "Bryan O'Donoghue" > Cc: Johan Hovold > Cc: Alex Elder > Cc: greybus-...@lists.linaro.org > Cc: de...@driverdev.osuosl.or

Re: [PATCH 7/9] staging: greybus: move core include files to include/linux/greybus/

2019-08-25 Thread Viresh Kumar
On 25-08-19, 07:54, Greg Kroah-Hartman wrote: > With the goal of moving the core of the greybus code out of staging, the > include files need to be moved to include/linux/greybus.h and > include/linux/greybus/ > > Cc: Vaibhav Hiremath > Cc: Johan Hovold > Cc: Alex Elder > Cc: Vaibhav Agarwal >

Re: [PATCH 2/9] staging: greybus: remove license "boilerplate"

2019-08-25 Thread Viresh Kumar
On 25-08-19, 07:54, Greg Kroah-Hartman wrote: > When the greybus drivers were converted to SPDX identifiers for the > license text, some license boilerplate was not removed. Clean this up > by removing this unneeded text now. > > Cc: Johan Hovold > Cc: Alex Elder > Cc: Vaibhav Agarwal > Cc: Ma

Re: [PATCH 1/9] staging: greybus: fix up SPDX comment in .h files

2019-08-25 Thread Viresh Kumar
On 25-08-19, 07:54, Greg Kroah-Hartman wrote: > When these files originally got an SPDX tag, I used // instead of /* */ > for the .h files. Fix this up to use // properly. > > Cc: Viresh Kumar > Cc: Johan Hovold > Cc: Alex Elder > Cc: greybus-...@lists.linaro.org > Cc: de...@driverdev.osuosl.o

Re: [greybus-dev] [PATCH 3/9] staging: greybus: hd: Fix up some alignment checkpatch issues

2019-08-25 Thread Viresh Kumar
On 25-08-19, 07:54, Greg Kroah-Hartman wrote: > Some function prototypes do not match the expected alignment formatting > so fix that up so that checkpatch is happy. > > Cc: Johan Hovold > Cc: Alex Elder > Cc: greybus-...@lists.linaro.org > Cc: de...@driverdev.osuosl.org > Signed-off-by: Greg Kr

[PATCH] staging: rtl8712: wifi: checkpatch style fix

2019-08-25 Thread Taihsiang Ho (tai271828)
Remove multiple blank lines. Signed-off-by: Taihsiang Ho (tai271828) --- drivers/staging/rtl8712/wifi.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging/rtl8712/wifi.h index 1a5b966a167e..be731f1a2209 100644 --- a/drivers/staging/rtl8712

Re: [PATCH] staging: rtl8192u: Fix spacing style issues

2019-08-25 Thread Greg KH
On Mon, Aug 26, 2019 at 01:08:35AM +0530, Sumera Priyadarsini wrote: > This patch fixes the file r8190_rtl8256.c to avoid the following > checkpatch.pl warnings: > CHECK: spaces preferred around that '<<' (ctx:VxV) > CHECK: spaces preferred around that '-' (ctx:VxV) > CHECK: Blank

Save a soul.

2019-08-25 Thread Mrs J. Zhang
Good day brothers and sisters in the Lord, I greet you in the name of our lord Jesus christ and my mother Mary.My name is Mrs. Julia Zhang, the wife of late Mr Moses Zhang. I have suffered maltreatment and untold hardship in the hands of my late husband's family, since the death of my husband w

Save a soul.

2019-08-25 Thread Mrs J. Zhang
Good day brothers and sisters in the Lord, I greet you in the name of our lord Jesus christ and my mother Mary.My name is Mrs. Julia Zhang, the wife of late Mr Moses Zhang. I have suffered maltreatment and untold hardship in the hands of my late husband's family, since the death of my husband w

[PATCH] r8188eu: use skb_put_data instead of skb_put/memcpy pair

2019-08-25 Thread Ivan Safonov
skb_put_data is shorter and clear. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c| 6 +- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 3 +-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/d

[PATCH] staging: rtl8192u: Fix spacing style issues

2019-08-25 Thread Sumera Priyadarsini
This patch fixes the file r8190_rtl8256.c to avoid the following checkpatch.pl warnings: CHECK: spaces preferred around that '<<' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: Blank lines aren't necessary before a close brace '}' CHECK: Please us

[PATCH] staging: most-core: Fix checkpatch warnings

2019-08-25 Thread Peikan Tsai
Hi, This patch solves the following checkpatch.pl's messages in drivers/staging/most/core.c. WARNING: line over 80 characters + return snprintf(buf, PAGE_SIZE, "%s", ch_data_type[i].name); CHECK: Please use a blank line after function/struct/union/enum declarations +} +/*

Re: [PATCH v3 4/4] dt-bindings: iio: adc: Add AD7606B ADC documentation

2019-08-25 Thread Jonathan Cameron
On Wed, 21 Aug 2019 17:16:56 +0300 Beniamin Bia wrote: > Documentation for AD7606B Analog to Digital Converter and software > mode was added. > > Signed-off-by: Beniamin Bia Tweaked as per Peter's comment and added Rob's Reviewed-by from v2 Seems everyone decided to review this one just as you

Re: [PATCH v3 3/4] dt-bindings: iio: adc: Migrate AD7606 documentation to yaml

2019-08-25 Thread Jonathan Cameron
On Wed, 21 Aug 2019 17:16:55 +0300 Beniamin Bia wrote: > The documentation for ad7606 was migrated to yaml. > > Signed-off-by: Beniamin Bia make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml 3 things needed fixing beyond the tweak Rob mentioned (a

Re: [PATCH v3 2/4] MAINTAINERS: Add Beniamin Bia for AD7606 driver

2019-08-25 Thread Jonathan Cameron
On Wed, 21 Aug 2019 17:16:54 +0300 Beniamin Bia wrote: > Add Beniamin Bia as maintainer for AD7606 driver. > > Signed-off-by: Beniamin Bia Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to probably ignore it. Thanks, Jonathan > --- > Changes in v3: > -

Re: [PATCH v3 1/4] iio: adc: ad7606: Add support for AD7606B ADC

2019-08-25 Thread Jonathan Cameron
On Wed, 21 Aug 2019 17:16:53 +0300 Beniamin Bia wrote: > From: Stefan Popa > > The AD7606B is a 16-bit ADC that supports simultaneous sampling of 8 > channels. It is pin compatible to AD7606, but adds extra modes by > writing to the register map. > > The AD7606B can be configured to work in so

[staging:greybus_move 249/251] include/linux/greybus/greybus_protocols.h:45:2: error: unknown type name '__le16'

2019-08-25 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/staging.git greybus_move head: b85c1b86639e4f70f388c24ec4a3c5d56a50bf3c commit: 739afccd8b20e98bc7ed311a1b31a01da10cb07f [249/251] staging: greybus: move core include files to include/linux/greybus/ config: x86_64-allmodco

Re: [PATCH] staging: rtl8192u: Fix indentation

2019-08-25 Thread Greg Kroah-Hartman
On Thu, Aug 22, 2019 at 10:52:28AM -0700, Stephen Brennan wrote: > Checkpatch reports WARNING:SUSPECT_CODE_INDENT in several places. Fix > this by aligning code properly with tabs. > > Signed-off-by: Stephen Brennan > --- > .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 +- > .../staging/rt