Re: [HELP REQUESTED from the community] Was: Staging status of speakup

2019-08-21 Thread Gregory Nowak
On Wed, Aug 21, 2019 at 09:39:25AM -0700, Okash Khawaja wrote: > Hi Greg N, > > Would like to send this as a patch as Greg K-H suggested? If not, I > can do that with your email in Authored-by: tag? > > Thanks, > Okash Hi Okash and all, feel free to submit the patch with my email in the Authored

Re: Added Realtek rtl8192u driver to staging - static analysis report.

2019-08-21 Thread stephen
> > Either way, it's not clear to me and I think the code needs cleaning > > up. > > Any ideas? > > 10+ year old code, yeah!!! > > Just guess, who knows, no one seems to care :( I'm at least interested in helping with cleaning the code and learning about the driver, maybe fixing up logical err

Re: Added Realtek rtl8192u driver to staging - static analysis report.

2019-08-21 Thread Greg Kroah-Hartman
On Wed, Aug 21, 2019 at 07:18:39PM +0100, Colin Ian King wrote: > Hi, > > Static analysis of linux-next picked up an issue with the following commit: > > commit 8fc8598e61f6f384f3eaf1d9b09500c12af47b37 > Author: Jerry Chuang > Date: Tue Nov 3 07:17:11 2009 -0200 > > Staging: Added Realtek

Re: [PATCH v2 4/4] dt-bindings: iio: adc: Add AD7606B ADC documentation

2019-08-21 Thread Rob Herring
On Wed, 7 Aug 2019 16:31:37 +0300, Beniamin Bia wrote: > Documentation for AD7606B Analog to Digital Converter and software > mode was added. > > Signed-off-by: Beniamin Bia > --- > Changes in v2: > -nothing changed > > Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 4 +++- > 1 fil

Re: [PATCH v2 3/4] dt-bindings: iio: adc: Migrate AD7606 documentation to yaml

2019-08-21 Thread Rob Herring
On Wed, Aug 07, 2019 at 04:31:36PM +0300, Beniamin Bia wrote: > The documentation for ad7606 was migrated to yaml. > > Signed-off-by: Beniamin Bia > --- > Changes in v2: > -old txt file was deleted > > .../bindings/iio/adc/adi,ad7606.txt | 66 - > .../bindings/iio/adc/adi,ad7

Re: [PATCH 2/2] staging/erofs: Balanced braces around a few conditional statements.

2019-08-21 Thread Caitlyn Finn
On Wed, Aug 21, 2019 at 11:52 AM Gao Xiang wrote: > > Hi Tobin, > > On Wed, Aug 21, 2019 at 08:13:35AM -0700, Tobin C. Harding wrote: > > On Wed, Aug 21, 2019 at 10:31:22AM +0800, Gao Xiang wrote: > > > On Tue, Aug 20, 2019 at 07:26:46PM -0700, Joe Perches wrote: > > > > On Tue, 2019-08-20 at 20:1

re: Added Realtek rtl8192u driver to staging - static analysis report.

2019-08-21 Thread Colin Ian King
Hi, Static analysis of linux-next picked up an issue with the following commit: commit 8fc8598e61f6f384f3eaf1d9b09500c12af47b37 Author: Jerry Chuang Date: Tue Nov 3 07:17:11 2009 -0200 Staging: Added Realtek rtl8192u driver to staging In drivers/staging/rtl8192u/ieee80211/ieee80211_softm

[PATCH] staging: rtl8723bs: os_dep: Drop condition with no effect

2019-08-21 Thread Saurav Girepunje
As the "else if" and "else" branch body are identical the condition has no effect. So drop the "else if" condition. Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux

[PATCH] staging: rt;8723bs: os_dep: Drop condition with no effect

2019-08-21 Thread Saurav Girepunje
As the "else if" and "else" branch body are identical the condition has no effect. So drop the "else if" condition. Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux

[PATCH] staging: rtl8723bs: hal: Drop condition with no effect

2019-08-21 Thread Saurav Girepunje
As the "else if" and "else" branch body are identical the condition has no effect. So drop the else if condition. Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/ha

[PATCH] staging: rtl8723bs: os_dep: Remove unused declarations

2019-08-21 Thread hariprasad
From: Hariprasad Kelam Remove unused Macro declarations Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 -- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c| 3 --- drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 5 - 3 files changed, 10 dele

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

2019-08-21 Thread Okash Khawaja
On Thu, Jul 25, 2019 at 3:49 AM John Covici wrote: > > I think the program is genmap, I have it in my init sequence, but I > am not sure it does anything at this point. > > On Thu, 25 Jul 2019 00:04:07 -0400, > Chris Brannon wrote: > > > > Gregory Nowak writes: > > > > > keymap > > > I believe t

Re: [PATCH 2/2] staging/erofs: Balanced braces around a few conditional statements.

2019-08-21 Thread Gao Xiang
Hi Tobin, On Wed, Aug 21, 2019 at 08:13:35AM -0700, Tobin C. Harding wrote: > On Wed, Aug 21, 2019 at 10:31:22AM +0800, Gao Xiang wrote: > > On Tue, Aug 20, 2019 at 07:26:46PM -0700, Joe Perches wrote: > > > On Tue, 2019-08-20 at 20:18 -0400, Caitlyn wrote: > > > > Balanced braces to fix some chec

Re: [PATCH 2/2] staging/erofs: Balanced braces around a few conditional statements.

2019-08-21 Thread Tobin C. Harding
On Wed, Aug 21, 2019 at 10:31:22AM +0800, Gao Xiang wrote: > On Tue, Aug 20, 2019 at 07:26:46PM -0700, Joe Perches wrote: > > On Tue, 2019-08-20 at 20:18 -0400, Caitlyn wrote: > > > Balanced braces to fix some checkpath warnings in inode.c and > > > unzip_vle.c > > [] > > > diff --git a/drivers/sta

Re: [PATCH] staging: vt6656: Delete an unnecessary check before the macro call “dev_kfree_skb”

2019-08-21 Thread Quentin Deslandes
On Wed, Aug 21, 2019 at 02:07:56PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 21 Aug 2019 13:56:35 +0200 > > The dev_kfree_skb() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccin

Re: [PATCH 1/2] comedi: remove camelcase

2019-08-21 Thread Tobin C. Harding
On Wed, Aug 21, 2019 at 02:26:18AM -0700, Greg KH wrote: > On Tue, Aug 20, 2019 at 09:12:51PM -0700, Edmund Huber wrote: > > My apologies. Is it possible that you are replying to a different thread > > than intended? I don't think I have an email addressed to me from the > > patchbot. > > I got a

[PATCH v2 2/3] staging: rtl8192u: fix macro alignment in ieee80211

2019-08-21 Thread Stephen Brennan
Several macros display unaligned, due to mixes of tabs and spaces. These can be fixed by making spacing consistent, do this. Signed-off-by: Stephen Brennan --- .../staging/rtl8192u/ieee80211/ieee80211.h| 35 ++- .../staging/rtl8192u/ieee80211/rtl819x_HT.h | 8 ++--- 2 file

[PATCH v2 0/3] staging: rtl8192u: coding style fixes in ieee80211

2019-08-21 Thread Stephen Brennan
Addressed some spacing, brace placement, and macro alignment in this driver. I do not have the relevant hardware, but I verified that the drivers/staging/rtl8192u module built between each patch. This time I've included proper patch descriptions, my apologies for the previous series. Stephen Brenn

[PATCH v2 3/3] staging: rtl8192u: fix spacing in ieee80211

2019-08-21 Thread Stephen Brennan
Checkpatch emits several errors, warnings, and checks about spacing. Apply checkpatch's suggested spacing rules. Signed-off-by: Stephen Brennan --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 10 ++-- .../staging/rtl8192u/ieee80211/ieee80211.h| 4 +- .../rtl8192u/ieee80211/ieee80211_cry

[PATCH v2 1/3] staging: rtl8192u: fix OPEN_BRACE errors in ieee80211

2019-08-21 Thread Stephen Brennan
Checkpatch emits several errors regarding braces being on the incorrect line. These can be fixed by moving the brace, do this. In a few cases, some comments were moved to facilitate this. Signed-off-by: Stephen Brennan --- .../staging/rtl8192u/ieee80211/ieee80211.h| 3 +- .../staging/rtl81

Re: [PATCH v2 5/6] staging: erofs: detect potential multiref due to corrupted images

2019-08-21 Thread Chao Yu
On 2019-8-21 22:01, Gao Xiang wrote: > As reported by erofs-utils fuzzer, currently, multiref > (ondisk deduplication) hasn't been supported for now, > we should forbid it properly. > > Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support") > Cc: # 4.19+ > Signed-off-by: Gao

[PATCH v3 2/4] MAINTAINERS: Add Beniamin Bia for AD7606 driver

2019-08-21 Thread Beniamin Bia
Add Beniamin Bia as maintainer for AD7606 driver. Signed-off-by: Beniamin Bia --- Changes in v3: -nothing changed MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ad498428b38c..052d7a8591fb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -895,6 +895,

[PATCH v3 4/4] dt-bindings: iio: adc: Add AD7606B ADC documentation

2019-08-21 Thread Beniamin Bia
Documentation for AD7606B Analog to Digital Converter and software mode was added. Signed-off-by: Beniamin Bia --- Changes in v3: -nothing changed Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devic

[PATCH v3 3/4] dt-bindings: iio: adc: Migrate AD7606 documentation to yaml

2019-08-21 Thread Beniamin Bia
The documentation for ad7606 was migrated to yaml. Signed-off-by: Beniamin Bia --- Changes in v3: -nothing changed .../bindings/iio/adc/adi,ad7606.txt | 66 - .../bindings/iio/adc/adi,ad7606.yaml | 134 ++ MAINTAINERS

[PATCH v3 1/4] iio: adc: ad7606: Add support for AD7606B ADC

2019-08-21 Thread Beniamin Bia
From: Stefan Popa The AD7606B is a 16-bit ADC that supports simultaneous sampling of 8 channels. It is pin compatible to AD7606, but adds extra modes by writing to the register map. The AD7606B can be configured to work in software mode by setting all oversampling pins to high. This mode is sele

[PATCH v2 5/6] staging: erofs: detect potential multiref due to corrupted images

2019-08-21 Thread Gao Xiang
As reported by erofs-utils fuzzer, currently, multiref (ondisk deduplication) hasn't been supported for now, we should forbid it properly. Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support") Cc: # 4.19+ Signed-off-by: Gao Xiang --- changelog from v1: - change err = -EFS

[PATCH] staging/wlan-ng/hfa384x: Delete an unnecessary check before the macro call “dev_kfree_skb”

2019-08-21 Thread Markus Elfring
From: Markus Elfring Date: Wed, 21 Aug 2019 14:30:30 +0200 The dev_kfree_skb() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/wlan-ng/hf

[PATCH -next] staging: rtl8192e: remove set but not used variable 'data_len'

2019-08-21 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: In function ieee80211_ccmp_encrypt: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c:162:6: warning: variable data_len set but not used [-Wunused-but-set-variable] It is not used since commit 5ee5265674ce ("staging: rtl8192e: rtllib_crypt_

[PATCH -next] staging: rtl8192e: remove two set but not used variables

2019-08-21 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: In function '_rtl92e_dm_tx_power_tracking_callback_tssi': drivers/staging/rtl8192e/rtl8192e/rtl_dm.c:621:7: warning: variable 'bHighpowerstate' set but not used [-Wunused-but-set-variable] In function '_rtl92e_dm_rx_path_sel_byrssi': drivers/stagi

[PATCH -next] staging: rtl8192u: ieee80211: remove set but not used variable 'data_len'

2019-08-21 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c: In function ieee80211_ccmp_encrypt: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c:162:6: warning: variable data_len set but not used [-Wunused-but-set-variable] It is not used s

[PATCH] staging: vt6656: Delete an unnecessary check before the macro call “dev_kfree_skb”

2019-08-21 Thread Markus Elfring
From: Markus Elfring Date: Wed, 21 Aug 2019 13:56:35 +0200 The dev_kfree_skb() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/vt6656/mai

Re: [PATCH 1/2] comedi: remove camelcase

2019-08-21 Thread Greg KH
On Tue, Aug 20, 2019 at 09:12:51PM -0700, Edmund Huber wrote: > My apologies. Is it possible that you are replying to a different thread > than intended? I don't think I have an email addressed to me from the > patchbot. I got a bunch of patches from a lot of different people all at once (Tobin mu