[PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue

2019-08-16 Thread Matthew Hanzelik
Fixed an unnamed parameter style issue. Signed-off-by: Matthew Hanzelik --- drivers/staging/speakup/spk_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h index a2fc72c29894..afa64eb9afb4 100644 -

[PATCH] staging: gasket: Remove unnecessary line-breaks in function signatures

2019-08-16 Thread Sumera Priyadarsini
This patch fixes the function signatures for gasket_read_page_table_size, gasket_read_simple_page_table_size, gasket_partition_page_table, gasket_config_coherent_allocator to avoid the checkpatch.pl warning: CHECK: Lines should not end with a '(' Signed-off-by: Sumera Priyadarsini ---

Re: [RFC PATCH 11/15] drivers/acrn: add the support of handling emulated ioreq

2019-08-16 Thread Dan Carpenter
On Fri, Aug 16, 2019 at 10:25:52AM +0800, Zhao Yakui wrote: > +int acrn_ioreq_create_client(unsigned short vmid, > + ioreq_handler_t handler, > + void *client_priv, > + char *name) > +{ > + struct acrn_vm *vm; > + st

Re: [RFC PATCH 10/15] drivers/acrn: add interrupt injection support

2019-08-16 Thread Dan Carpenter
On Fri, Aug 16, 2019 at 10:25:51AM +0800, Zhao Yakui wrote: > + case IC_VM_INTR_MONITOR: { > + struct page *page; > + > + ret = get_user_pages_fast(ioctl_param, 1, 1, &page); > + if (unlikely(ret != 1) || !page) { ^^

Re: [RFC PATCH 09/15] drivers/acrn: add passthrough device support

2019-08-16 Thread Dan Carpenter
On Fri, Aug 16, 2019 at 10:25:50AM +0800, Zhao Yakui wrote: > + case IC_ASSIGN_PTDEV: { > + unsigned short bdf; > + > + if (copy_from_user(&bdf, (void *)ioctl_param, This casting is ugly and you also need a __user tag for Sparse. Do something like "void __user *p = ioc

Re: [RFC PATCH 08/15] drivers/acrn: add VM memory management for ACRN char device

2019-08-16 Thread Dan Carpenter
On Fri, Aug 16, 2019 at 10:25:49AM +0800, Zhao Yakui wrote: > +int hugepage_map_guest(struct acrn_vm *vm, struct vm_memmap *memmap) > +{ > + struct page *page = NULL, *regions_buf_pg = NULL; > + unsigned long len, guest_gpa, vma; > + struct vm_memory_region *region_array; > + struct

Re: [RFC PATCH 04/15] drivers/acrn: add the basic framework of acrn char device driver

2019-08-16 Thread Dan Carpenter
On Fri, Aug 16, 2019 at 10:25:45AM +0800, Zhao Yakui wrote: > +static > +int acrn_dev_open(struct inode *inodep, struct file *filep) > +{ > + pr_info("%s: opening device node\n", __func__); > + > + return 0; > +} > + > +static > +long acrn_dev_ioctl(struct file *filep, > + u

Re: [PATCH 0/2] Use ccm(aes) aead transform in staging drivers

2019-08-16 Thread Ard Biesheuvel
On Fri, 16 Aug 2019 at 10:00, Christina Quast wrote: > > Use ccm(aes) aead transform instead of invoking the AES block cipher > block by block. > Thanks! This eliminates another two users of the bare cipher API, which is not the right abstraction for drivers to use. Reviewed-by: Ard Biesheuvel

Re: [PATCH] staging: erofs: use common file type conversion

2019-08-16 Thread Chao Yu
On 2019/8/16 15:11, Gao Xiang wrote: > Deduplicate the EROFS file type conversion implementation and > remove EROFS_FT_* definitions since it's the same as defined > by POSIX, let's follow ext2 as Linus pointed out [1] > commit e10892189428 ("ext2: use common file type conversion"). > > [1] > htt

[PATCH] staging: erofs: use common file type conversion

2019-08-16 Thread Gao Xiang
Deduplicate the EROFS file type conversion implementation and remove EROFS_FT_* definitions since it's the same as defined by POSIX, let's follow ext2 as Linus pointed out [1] commit e10892189428 ("ext2: use common file type conversion"). [1] https://lore.kernel.org/r/CAHk-=wiUs+b=ivkm3mvooxgvk7c

[PATCH 1/2] staging: rtl8192u: ieee80211: ieee80211_crypt_ccmp.c: Use crypto API ccm(aes)

2019-08-16 Thread Christina Quast
Use ccm(aes) aead transform instead of invoking the AES block cipher block by block. Signed-off-by: Christina Quast --- drivers/staging/rtl8192u/Kconfig | 2 + .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 187 -- 2 files changed, 81 insertions(+), 108 deletions(

[PATCH 2/2] staging: rtl8192e: rtllib_crypt_ccmp.c: Use crypto API ccm(aes)

2019-08-16 Thread Christina Quast
Use ccm(aes) aead transform instead of invoking the AES block cipher block by block. Signed-off-by: Christina Quast --- drivers/staging/rtl8192e/Kconfig | 1 + drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 187 --- 2 files changed, 78 insertions(+), 110 deletions(-

Re: [RFC PATCH 04/15] drivers/acrn: add the basic framework of acrn char device driver

2019-08-16 Thread Greg KH
On Fri, Aug 16, 2019 at 10:25:45AM +0800, Zhao Yakui wrote: > ACRN hypervisor service module is the important middle layer that allows > the Linux kernel to communicate with the ACRN hypervisor. It includes > the management of virtualized CPU/memory/device/interrupt for other ACRN > guest. The user

[PATCH 0/2] Use ccm(aes) aead transform in staging drivers

2019-08-16 Thread Christina Quast
Use ccm(aes) aead transform instead of invoking the AES block cipher block by block. Christina Quast (2): staging: rtl8192u: ieee80211: ieee80211_crypt_ccmp.c: Use crypto API ccm(aes) staging: rtl8192e: rtllib_crypt_ccmp.c: Use crypto API ccm(aes) drivers/staging/rtl8192e/Kconfig

Re: [RFC PATCH 00/15] acrn: add the ACRN driver module

2019-08-16 Thread Greg KH
On Fri, Aug 16, 2019 at 08:39:25AM +0200, Borislav Petkov wrote: > On Fri, Aug 16, 2019 at 10:25:41AM +0800, Zhao Yakui wrote: > > The first three patches are the changes under x86/acrn, which adds the > > required APIs for the driver and reports the X2APIC caps. > > The remaining patches add the