Re: [PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

2019-07-19 Thread John Hubbard
On 7/19/19 1:02 PM, Bharath Vedartham wrote: > There have been issues with coordination of various subsystems using > get_user_pages. These issues are better described in [1]. > > An implementation of tracking get_user_pages is currently underway > The implementation requires the use put_user_page

RE: [PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

2019-07-19 Thread Matt Sickler
>From: Bharath Vedartham >Changes since v2 >- Added back PageResevered check as suggested by John Hubbard. > >The PageReserved check needs a closer look and is not worth messing >around with for now. > >Matt, Could you give any suggestions for testing this patch? Myself or someone else fr

Re: [PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

2019-07-19 Thread John Hubbard
On 7/19/19 1:59 PM, Matt Sickler wrote: >> From: Bharath Vedartham >> Changes since v2 >>- Added back PageResevered check as suggested by John Hubbard. >> >> The PageReserved check needs a closer look and is not worth messing >> around with for now. >> >> Matt, Could you give any suggestio

[PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

2019-07-19 Thread Bharath Vedartham
There have been issues with coordination of various subsystems using get_user_pages. These issues are better described in [1]. An implementation of tracking get_user_pages is currently underway The implementation requires the use put_user_page*() variants to release a reference rather than put_pag

Re: [PATCH] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-19 Thread Dan Carpenter
On Fri, Jul 19, 2019 at 05:01:33PM +0300, Dan Carpenter wrote: > On Fri, Jul 19, 2019 at 12:05:07PM +, ajay.kat...@microchip.com wrote: > > > > On 7/19/2019 5:16 PM, Chuhong Yuan wrote: > > > > > > 于2019年7月19日周五 下午7:34写道： > > >> > > >> On 7/19/2019 1:40 PM, Chuhong Yuan wrote: > > >>> > > >>

Re: [PATCH] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-19 Thread Dan Carpenter
On Fri, Jul 19, 2019 at 12:05:07PM +, ajay.kat...@microchip.com wrote: > > On 7/19/2019 5:16 PM, Chuhong Yuan wrote: > > > > 于2019年7月19日周五 下午7:34写道： > >> > >> On 7/19/2019 1:40 PM, Chuhong Yuan wrote: > >>> > >>> Merge the combo use of memcpy and le32_to_cpus. > >>> Use get_unaligned_le32 in

[driver-core:debugfs_cleanup 21/55] drivers/gpu/drm/i915/i915_debugfs.c:4444:6: error: conflicting types for 'i915_debugfs_register'

2019-07-19 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup head: 88ff756ea1e770a5a0dab006b06b969c4cda7a24 commit: 9ec380374a43c5e6fcf1c6c1a429379b208a7905 [21/55] drm: make .debugfs_init and drm_debugfs_create_files() return void config: x86_64-rhel

[PATCH v2] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-19 Thread Chuhong Yuan
Merge the combo use of memcpy and le32_to_cpus. Use get_unaligned_le32 instead. This simplifies the code. Signed-off-by: Chuhong Yuan --- Changes in v2: - Merge the two patches with the same subject line. drivers/staging/wilc1000/wilc_mon.c | 3 +-- drivers/staging/wilc1000/wi

Re: [PATCH] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-19 Thread Ajay.Kathat
On 7/19/2019 5:16 PM, Chuhong Yuan wrote: > > 于2019年7月19日周五 下午7:34写道： >> >> On 7/19/2019 1:40 PM, Chuhong Yuan wrote: >>> >>> Merge the combo use of memcpy and le32_to_cpus. >>> Use get_unaligned_le32 instead. >>> This simplifies the code. >>> >>> Signed-off-by: Chuhong Yuan >>> --- >>> driver

Re: [PATCH] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-19 Thread Chuhong Yuan
于2019年7月19日周五 下午7:34写道： > > On 7/19/2019 1:40 PM, Chuhong Yuan wrote: > > > > Merge the combo use of memcpy and le32_to_cpus. > > Use get_unaligned_le32 instead. > > This simplifies the code. > > > > Signed-off-by: Chuhong Yuan > > --- > > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +-

Re: [PATCH] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-19 Thread Ajay.Kathat
On 7/19/2019 1:40 PM, Chuhong Yuan wrote: > > Merge the combo use of memcpy and le32_to_cpus. > Use get_unaligned_le32 instead. > This simplifies the code. > > Signed-off-by: Chuhong Yuan > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +-- > 1 file changed, 1 insertion(+), 2 dele

Re: [OSSNA] Intro to kernel hacking tutorial

2019-07-19 Thread Dan Carpenter
On Fri, Jul 05, 2019 at 12:50:55PM +1000, Tobin C. Harding wrote: > Outcome will (hopefully) be a small patch set into drivers/staging/. > (Don't worry Greg only one group got to this stage last time, you > won't get flooded with patches :) We're good at reviewing floods of patches. Send away. I

[PATCH] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-19 Thread Chuhong Yuan
Merge the combo use of memcpy and le32_to_cpus. Use get_unaligned_le32 instead. This simplifies the code. Signed-off-by: Chuhong Yuan --- drivers/staging/wilc1000/wilc_mon.c | 3 +-- drivers/staging/wilc1000/wilc_wlan.c | 9 +++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git

[PATCH] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-19 Thread Chuhong Yuan
Merge the combo use of memcpy and le32_to_cpus. Use get_unaligned_le32 instead. This simplifies the code. Signed-off-by: Chuhong Yuan --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgo

[PATCH] staging: rtl8712: Merge memcpy + be16_to_cpus to get_unaligned_be16

2019-07-19 Thread Chuhong Yuan
Merge the combo of memcpy and be16_to_cpus. Use get_unaligned_be16 instead. This simplifies the code. Signed-off-by: Chuhong Yuan --- drivers/staging/rtl8712/rtl871x_recv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_recv.c b/drivers/sta