Re: [HELP REQUESTED from the community] Was: Staging status of speakup

2019-07-12 Thread Gregory Nowak
On Fri, Jul 12, 2019 at 11:23:19AM +0200, Samuel Thibault wrote: > Hello, > > To readers of the linux-speakup: could you help on this so we can get > Speakup in mainline? Neither Okash or I completely know what user > consequences the files in /sys/accessibility/speakup/ have, so could > people g

Re: [PATCH v5 0/3] [v4.9.y] coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping

2019-07-12 Thread Ajay Kaher
Greg, I hope you would like to include these patches in next release. In case any review comment please let me know. - Ajay On 01/07/19, 4:03 PM, "Ajay Kaher" wrote: > coredump: fix race condition between mmget_not_zero()/get_task_mm() > and core dumping > [PATCH v5 1/3]: > Backporting o

Re: [PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-12 Thread Andrzej Hajda
Hi Joe, On 10.07.2019 07:04, Joe Perches wrote: > These GENMASK uses are inverted argument order and the > actual masks produced are incorrect. Fix them. > > Add checkpatch tests to help avoid more misuses too. > > Joe Perches (12): > checkpatch: Add GENMASK tests > clocksource/drivers/npcm:

Re: [PATCH] staging: erofs: Remove function erofs_kill_sb()

2019-07-12 Thread Chao Yu
On 2019/7/12 15:12, Nishka Dasgupta wrote: > Remove function erofs_kill_sb as all it does is call kill_block_super. > Modify references to the former to point to the latter. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta Reviewed-by: Chao Yu Thanks, _

Re: Staging status of speakup

2019-07-12 Thread Okash Khawaja
On Fri, Jul 12, 2019 at 9:38 AM Greg Kroah-Hartman wrote: > > On Sun, Jul 07, 2019 at 08:57:10AM +0200, Greg Kroah-Hartman wrote: > > On Sat, Jul 06, 2019 at 08:08:57PM +0100, Okash Khawaja wrote: > > > On Fri, 15 Mar 2019 20:18:31 -0700 > > > Greg Kroah-Hartman wrote: > > > > > > > On Fri, Mar 1

[HELP REQUESTED from the community] Was: Staging status of speakup

2019-07-12 Thread Samuel Thibault
Hello, To readers of the linux-speakup: could you help on this so we can get Speakup in mainline? Neither Okash or I completely know what user consequences the files in /sys/accessibility/speakup/ have, so could people give brief explanations for each file (something like 3-6 lines of explanation

[PATCH] staging: android: ion: Remove unused rbtree for ion_buffer

2019-07-12 Thread Lecopzer Chen
ion_buffer_add() insert ion_buffer into rbtree every time creating an ion_buffer but never use it after ION reworking. Also, buffer_lock protects only rbtree operation, remove it together. Signed-off-by: Lecopzer Chen Cc: YJ Chiang Cc: Lecopzer Chen --- drivers/staging/android/ion/ion.c | 36 -

Re: Staging status of speakup

2019-07-12 Thread Greg Kroah-Hartman
On Sun, Jul 07, 2019 at 08:57:10AM +0200, Greg Kroah-Hartman wrote: > On Sat, Jul 06, 2019 at 08:08:57PM +0100, Okash Khawaja wrote: > > On Fri, 15 Mar 2019 20:18:31 -0700 > > Greg Kroah-Hartman wrote: > > > > > On Fri, Mar 15, 2019 at 01:01:27PM +, Okash Khawaja wrote: > > > > Hi, > > > > >

Re: [PATCH] staging: erofs: Remove function erofs_kill_sb()

2019-07-12 Thread Gao Xiang
On 2019/7/12 15:12, Nishka Dasgupta wrote: > Remove function erofs_kill_sb as all it does is call kill_block_super. > Modify references to the former to point to the latter. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta Reviewed-by: Gao Xiang Thanks, Gao Xiang __

[PATCH] staging: wilc1000: Replace function wilc_wlan_cfg_get_val()

2019-07-12 Thread Nishka Dasgupta
Include wilc_wlan_cfg.h in wilc_netdev.c to enable it to call functions in wilc_wlan_cfg.c. Remove function wilc_wlan_cfg_get_val as all it does is call wilc_wlan_cfg_get_wid_value in file wilc_wlan_cfg.c. Rename function wilc_wlan_cfg_get_wid_value to wilc_wlan_cfg_get_val to maintain compatibilit

[PATCH 8/8] staging: rtl8188eu: Replace function rtl88eu_phy_rf_config()

2019-07-12 Thread Nishka Dasgupta
Remove function rtl88eu_phy_rf_config as all it does is call rtl88e_phy_rf6052_config. Rename rtl88e_phy_rf6052_config to rtl88eu_phy_rf_config and change its type from static to non-static to maintain compatibility with call sites. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta ---

[PATCH 7/8] staging: rtl8188eu: Replace function rtl88e_phy_rf6052_config()

2019-07-12 Thread Nishka Dasgupta
Remove function rtl88e_phy_rf6052_config as all it does is call rf6052_conf_para. Rename rf6052_conf_para to rtl88e_phy_rf6052_config to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/hal/rf_cfg.c | 7 +-- 1 fi

[PATCH 5/8] staging: rtl8188eu: Remove function rtw_modular64()

2019-07-12 Thread Nishka Dasgupta
Remove function rtw_modular64 as all it does is call do_div. Replace call to rtw_modular64 with call to do_div. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 2 -- driv

[PATCH 3/8] staging: rtl8188eu: Replace function beacon_timing_control()

2019-07-12 Thread Nishka Dasgupta
Remove function beacon_timing_control as all it does is call rtw_hal_bcn_related_reg_setting. Rename rtw_hal_bcn_related_reg_setting to beacon_timing_control for compatibility with call sites. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/core/rtw_wlan

[PATCH 6/8] staging: rtl8188eu: Replace function rtw_alloc_network()

2019-07-12 Thread Nishka Dasgupta
Change external call site of _rtw_alloc_network to rtw_alloc_network. Remove function rtw_alloc_network as all it does is call _rtw_alloc_network. Rename _rtw_alloc_network to rtw_alloc_network to maintain compatibility with call sites. Keep its type as non-static (even though the old rtw_alloc_net

[PATCH 4/8] staging: rtl8188eu: Remove function rtw_os_indicate_scan_done()

2019-07-12 Thread Nishka Dasgupta
In function rtw_indicate_scan_done, replace call to rtw_os_indicate_scan_done with call to indicate_wx_scan_complete_event as all that rtw_os_indicate_scan_done does is call indicate_wx_scan_complete_event. Remove now-unused function rtw_os_indicate_scan_done. Issue found with Coccinelle. Signed-o

[PATCH 1/8] staging: rtl8188eu: core: Replace function Set_MSR()

2019-07-12 Thread Nishka Dasgupta
Change reference to Set_NETYPE0_MSR to Set_MSR. Replace the contents of Set_MSR with the contents of Set_NETYPE0_MSR as Set_MSR does nothing but call Set_NETYPE0_MSR. Delete Set_NETYPE0_MSR. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/core/rtw_mlme_e

[PATCH 2/8] staging: rtl8188eu: core: Remove function enable_rate_adaptive()

2019-07-12 Thread Nishka Dasgupta
Remove function enable_rate_adaptive as it does nothing except call Update_RA_Entry. Modify call site of enable_rate_adaptive to call Update_RA_Entry instead. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 7 +-- 1 file change

[PATCH] staging: erofs: Remove function erofs_kill_sb()

2019-07-12 Thread Nishka Dasgupta
Remove function erofs_kill_sb as all it does is call kill_block_super. Modify references to the former to point to the latter. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/erofs/super.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/d