Re: [PATCH 01/11] staging: rtl8723bs: core: Remove function eeprom_read_sz()

On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote: > Remove unused function eeprom_read_sz. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta This is great but you need to remove the declaration from the .h file as well. I noticed some of the other patches have thi

[PATCH 05/11] staging: rtl8723bs: core: Remove function enable_rate_adaptive()

Remove function enable_rate_adaptive as all it does is call Update_RA_Entry. Modify the single callsite of enable_rate_adaptive to call Update_RA_Entry directly instead. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 8 +--- 1

Re: [PATCH] binder: fix possible UAF when freeing buffer

On Wed, Jun 12, 2019 at 01:29:27PM -0700, Todd Kjos wrote: > There is a race between the binder driver cleaning > up a completed transaction via binder_free_transaction() > and a user calling binder_ioctl(BC_FREE_BUFFER) to > release a buffer. It doesn't matter which is first but > they need to be

[PATCH 03/11] staging: rtl8723bs: core: Remove eeprom_write16()

Remove unused function eeprom_write16. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_eeprom.c | 62 - 1 file changed, 62 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_eeprom.c b/drivers/staging/rtl8723bs/co

[PATCH 11/11] staging: rtl8723bs: Remove rtw_btcoex_Initialize()

Remove function rtw_btcoex_Initialize as the only thing it does is call hal_btcoex_Initialize. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 6 -- drivers/staging/rtl8723bs/include/rtw_btcoex.h

[PATCH 04/11] staging: rtl8723bs: core: Replace function Set_MSR()

Remove function Set_NETYPE0_MSR as it only has one line and it is only called by one other function, Set_MSR. Replace contents of Set_MSR with the contents of Set_NETYPE0_MSR as Set_MSR does nothing except call Set_NETYPE0_MSR. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- driv

[PATCH 02/11] staging: rtl8723bs: core: Remove function read_eeprom_content()

Remove unused function read_eeprom_content. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_eeprom.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_eeprom.c b/drivers/staging/rtl8723bs/core/rt

[PATCH 08/11] staging: rtl8723bs: Remove function rtw_set_scan_deny_timer_hdl()

Remove function rtw_set_scan_deny_timer_hdl as all it does is call rtw_clear_scan_deny. Modify call sites of rtw_set_scan_deny_timer_hdl to call rtw_clear_scan_deny instead. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 - d

[PATCH 06/11] staging: rtl8723bs: core: Remove wrapper functions

Remove function power_saving_wk_hdl as all it does is call rtw_ps_processor. Edit call sites accordingly. Remove function reset_securitypriv_hdl as all it does is call rtw_reset_securitypriv. Modify call sites accordingly. Remove function free_assoc_resources_hdl as all it does is call rtw_free_ass

[PATCH 07/11] staging: rtl8723bs: Replace function rtw_free_network_queue()

Remove function rtw_free_network_queue as all it does is call _rtw_free_network_queue. Rename _rtw_free_network_queue to rtw_free_network_queue to maintain compatibility with call sites. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_mlme.c

[PATCH 09/11] staging: rtl8723bs: Fix typo in function name

Change name of function hal_btcoex_Hanlder to hal_btcoex_Handler. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 2 +- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- drivers/staging/rtl8723bs/include/hal_btcoex.h | 2 +- 3 files changed, 3 insertions(

[PATCH 10/11] staging: rtl8723bs: hal: Replace function _InitQueuePriority()

Remove function _InitQueuePriority as all it does it call _InitNormalChipQueuePriority. Rename _InitNormalChipQueuePriority to _InitQueuePriority for compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 7 +--

[PATCH 01/11] staging: rtl8723bs: core: Remove function eeprom_read_sz()

Remove unused function eeprom_read_sz. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_eeprom.c | 47 - 1 file changed, 47 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_eeprom.c b/drivers/staging/rtl8723bs/co

[PATCH] binder: fix possible UAF when freeing buffer

There is a race between the binder driver cleaning up a completed transaction via binder_free_transaction() and a user calling binder_ioctl(BC_FREE_BUFFER) to release a buffer. It doesn't matter which is first but they need to be protected against running concurrently which can result in a UAF. Si

[ashmem] Re: WARNING in __vm_enough_memory

On Tue, Jan 16, 2018 at 06:20:37AM +0100, 'Dmitry Vyukov' via syzkaller-bugs wrote: > On Tue, Jan 16, 2018 at 12:58 AM, syzbot > wrote: > > Hello, > > > > syzkaller hit the following crash on > > 8418f88764046d0e8ca6a3c04a69a0e57189aa1e > > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux

Re: WARNING in binder_transaction_buffer_release

On Mon, May 20, 2019 at 07:18:06AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:72cf0b07 Merge tag 'sound-fix-5.2-rc1' of git://git.kernel.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=17c7d4bca0 > kernel

[PATCH][next] staging: media: meson: remove redundant initialization of mpeg12

From: Colin Ian King The pointer mpeg12 is being initialized however that value is never read and mpeg12 is being re-assigned almost immediately afterwards. Remove the redundant initialization. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/staging/media/meson/v

[PATCH v2 0/2] staging: kpc2000: minor fixes in kp2000_pcie_probe

These two patches fixes issues pointed out by Dan in a previous staging/kpc2000 patch thread: many comments in kp2000_pcie_probe just repeats the code and the current label names doesn't add any information and makes it hard to follow the code. Rename all labels and remove the comments that just r

[PATCH v2 1/2] staging: kpc2000: improve label names in kp2000_pcie_probe

Use self-explanatory label names instead of the generic numbered ones, to make it easier to follow and understand the code. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/d

[PATCH v2 2/2] staging: kpc2000: remove unnecessary comments in kp2000_pcie_probe

Much of the code comments in kp2000_pcie_probe just repeats the code and does not add any additional information. Delete them and make sure that comments still left in the function all use the same style. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 38

[driver-core:debugfs_cleanup 77/85] drivers/net/wireless/intel/iwlegacy/4965-rs.c:2779:49: sparse: sparse: incorrect type in assignment (different base types)

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup head: 38bfd17b38b31dfc13afabb1742a23d5741b16d2 commit: 2cd2d7ff48151c0a5326606dbc48a00df3a4d596 [77/85] debugfs: remove return value of debugfs_create_u8() reproduce: # apt-get install sparse

Re: [PATCH] x86/hyperv: Disable preemption while setting reenlightenment vector

On Tue, Jun 11, 2019 at 10:20:03PM +0100, Dmitry Safonov wrote: > KVM support may be compiled as dynamic module, which triggers the > following splat on modprobe: > > KVM: vmx: using Hyper-V Enlightened VMCS > BUG: using smp_processor_id() in preemptible [] code: modprobe/466 > caller i

Re: [PATCH] x86/hyperv: Disable preemption while setting reenlightenment vector

Peter Zijlstra writes: > On Tue, Jun 11, 2019 at 10:20:03PM +0100, Dmitry Safonov wrote: >> KVM support may be compiled as dynamic module, which triggers the >> following splat on modprobe: >> >> KVM: vmx: using Hyper-V Enlightened VMCS >> BUG: using smp_processor_id() in preemptible [

Re: [PATCH -next] media: meson: vdec: Add missing kthread.h

On Wed, Jun 12, 2019 at 12:05 PM YueHaibing wrote: > > Fix building error: > > drivers/staging/media/meson/vdec/vdec.c: In function vdec_recycle_thread: > drivers/staging/media/meson/vdec/vdec.c:59:10: error: implicit declaration > of function kthread_should_stop; > did you mean thread_saved_sp?

Re: [PATCH] x86/hyperv: Disable preemption while setting reenlightenment vector

Dmitry Safonov writes: > KVM support may be compiled as dynamic module, which triggers the > following splat on modprobe: > > KVM: vmx: using Hyper-V Enlightened VMCS > BUG: using smp_processor_id() in preemptible [] code: modprobe/466 > caller is debug_smp_processor_id+0x17/0x19 > CP

Re: [PATCH 2/2] staging: kpc2000: remove unnecessary comments in kp2000_pcie_probe

On 12/06, Greg KH wrote: > On Wed, Jun 12, 2019 at 10:39:36AM +0300, Dan Carpenter wrote: > > On Mon, Jun 10, 2019 at 10:05:35PM +0200, Simon Sandström wrote: > > > @@ -349,9 +340,7 @@ static int kp2000_pcie_probe(struct pci_dev *pdev, > > > goto err_remove_ida; > > > } > > > > > > -

[PATCH -next] media: meson: vdec: Add missing kthread.h

Fix building error: drivers/staging/media/meson/vdec/vdec.c: In function vdec_recycle_thread: drivers/staging/media/meson/vdec/vdec.c:59:10: error: implicit declaration of function kthread_should_stop; did you mean thread_saved_sp? [-Werror=implicit-function-declaration] Reported-by: Hulk Robot

[PATCH v2] media: imx7-media-csi: get csi upstream endpoint

When the upstream endpoint is neither a mux nor a CSI2 module, just get the source pad directly upstream from the CSI. Fixes: 05f634040c0d ("media: staging/imx7: add imx7 CSI subdev driver") Reported-by: Sebastien Szymanski Signed-off-by: Rui Miguel Silva --- v1->v2: Dan Carpenter: - s/in/is/

Re: [PATCH] media: imx7-media-csi: get csi upstream endpoint

Hi Dan, On Wed 12 Jun 2019 at 08:43, Dan Carpenter wrote: > On Tue, Jun 11, 2019 at 04:09:55PM +0100, Rui Miguel Silva wrote: >> When the upstream endpoint is neither a mux nor a CSI2 module, just get >> the source pad directly upstream from the CSI. >> >> Fixes: 05f634040c0d ("media: staging/imx7:

[driver-core:debugfs_cleanup 77/78] drivers/net/wireless/intel/iwlegacy/4965-rs.c:2779:42: error: void value not ignored as it ought to be

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup head: 0c2872ff925dd9b66e3f636d01221fb27859f3f3 commit: 2cd2d7ff48151c0a5326606dbc48a00df3a4d596 [77/78] debugfs: remove return value of debugfs_create_u8() config: sparc64-allmodconfig (attached as .c

[PATCH] staging: most: register net and video config subsystems with configFS

This patch makes the core components net and video register their config subsystems with configFS. It is needed to have the configuration interface of the modules exposed to user space. Signed-off-by: Christian Gromm --- drivers/staging/most/net/net.c | 12 +++- drivers/staging/most/

[driver-core:debugfs_cleanup 77/78] drivers/net//wireless/intel/iwlwifi/dvm/rs.c:3283:42: error: void value not ignored as it ought to be

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup head: 0c2872ff925dd9b66e3f636d01221fb27859f3f3 commit: 2cd2d7ff48151c0a5326606dbc48a00df3a4d596 [77/78] debugfs: remove return value of debugfs_create_u8() config: sparc64-allmodconfig (attached as .c

[PATCH RESEND] staging: kpc2000: removed DMA AIO implementation.

The existing implementation for doing DMA via asynchronous IO didn't work and there was no longer a use-case for it. Removed it. Fixed a few checkpatch warnings about too-long lines and extraneous braces in the process. Reported-by: Matt Sickler Signed-off-by: Jeremy Sowden --- I mucked up t

Re: [PATCH 2/2] staging: kpc2000: remove unnecessary comments in kp2000_pcie_probe

On Wed, Jun 12, 2019 at 10:39:36AM +0300, Dan Carpenter wrote: > On Mon, Jun 10, 2019 at 10:05:35PM +0200, Simon Sandström wrote: > > @@ -349,9 +340,7 @@ static int kp2000_pcie_probe(struct pci_dev *pdev, > > goto err_remove_ida; > > } > > > > - /* > > -* Step 4: Setup the R

Re: [PATCH 0/6] staging: kpc2000_dma: fixes for AIO file-ops.

On 2019-06-11, at 23:43:19 +, Matt Sickler wrote: > >-Original Message- > > From: Jeremy Sowden > > I've had a go at getting the DMA AIO working. It compiles, but I > > don't have access to the hardware, so I have done no more testing > > than that. > > Honestly, it'd probably be bett

Re: [PATCH] media: imx7-media-csi: get csi upstream endpoint

On Tue, Jun 11, 2019 at 04:09:55PM +0100, Rui Miguel Silva wrote: > When the upstream endpoint is neither a mux nor a CSI2 module, just get > the source pad directly upstream from the CSI. > > Fixes: 05f634040c0d ("media: staging/imx7: add imx7 CSI subdev driver") > Reported-by: Sebastien Szymansk

Re: [PATCH 2/2] staging: kpc2000: remove unnecessary comments in kp2000_pcie_probe

On Mon, Jun 10, 2019 at 10:05:35PM +0200, Simon Sandström wrote: > @@ -349,9 +340,7 @@ static int kp2000_pcie_probe(struct pci_dev *pdev, > goto err_remove_ida; > } > > - /* > - * Step 4: Setup the Register BAR > - */ > + // Setup the Register BAR Greg, are

Re: [PATCH 1/2] staging: kpc2000: improve label names in kp2000_pcie_probe

Thanks! Reviewed-by: Dan Carpenter Not related to your patch (IOW ignore if you want to) the error handling is slightly more complicated than required: drivers/staging/kpc2000/kpc2000/core.c 356 * Step 4: Setup the Register BAR 357 */ 358 reg_bar_phys_addr