On Mon, Jun 03, 2019 at 09:04:57PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 04, 2019 at 12:24:12AM +0530, Hariprasad Kelam wrote:
> > Knowing the fact that operator '|' is faster than '+'.
> > Its better we replace + with | in this case.
> >
> > Issue reported by coccicheck
> > drivers/stagi
Hi Greg,
On Wed, Jun 5, 2019 at 6:01 AM Greg Ungerer wrote:
>
> Hi Sergio,
>
> On 4/6/19 7:36 pm, Sergio Paracuellos wrote:
> > On Tue, Jun 4, 2019 at 9:14 AM Greg Ungerer wrote:
> >> On 4/6/19 3:06 pm, Sergio Paracuellos wrote:
> >>> On Tue, Jun 4, 2019 at 3:31 AM Greg Ungerer wrote:
> On
Hi Sergio,
On 4/6/19 7:36 pm, Sergio Paracuellos wrote:
On Tue, Jun 4, 2019 at 9:14 AM Greg Ungerer wrote:
On 4/6/19 3:06 pm, Sergio Paracuellos wrote:
On Tue, Jun 4, 2019 at 3:31 AM Greg Ungerer wrote:
On 4/6/19 5:59 am, Sergio Paracuellos wrote:
On Mon, Jun 3, 2019 at 2:32 PM Greg Ungere
The structure kp_spi_controller_state, defined in the kpc2000_spi
driver, contains a member named chip_select which is never used after
initialization. Therefore, it should be removed for simplicity's sake.
Signed-off-by: Geordan Neukum
---
drivers/staging/kpc2000/kpc2000_spi.c | 2 --
1 file ch
The kpc_spi driver unnecessarily casts from a (u64 __iomem *) to a (void
*) when invoking readq and writeq which both take a (void __iomem *) arg.
There is no need for this cast, and it actually harms us by discarding
the sparse cookie, __iomem. Make the driver stop performing this casting
operatio
The structure kp_spi_controller_state, defined in the kpc2000_spi
driver, contains a member named phys which is never used after
initialization. Therefore, it should be removed for simplicity's sake.
Signed-off-by: Geordan Neukum
---
drivers/staging/kpc2000/kpc2000_spi.c | 2 --
1 file changed,
The structure kp_spi_controller_state, defined in the kpc2000_spi
driver, contains a member named word_len which is never used after
initialization. Therefore, it should be removed for simplicity's sake.
Signed-off-by: Geordan Neukum
---
drivers/staging/kpc2000/kpc2000_spi.c | 3 ---
1 file chan
The kpc_spi driver stashes off an unsigned long representation of the
i/o mapping returned by devm_ioremap_nocache(). This is unnecessary, as
the only use of the unsigned long repr is to eventually be re-cast to
an (u64 __iomem *). Instead of casting the (void __iomem *) to an
(unsigned long) then
Primarily just a bunch of unused / unnecessarily used struct member
cleanup patches with the exception of one patch which removes an
unnecessary cast to a (void *) in a couple of functions.
Geordan Neukum (6):
staging: kpc2000: kpc_spi: remove unnecessary struct member phys
staging: kpc2000: k
The structure kpc_spi, defined in in the kpc2000_spi driver, contains
a member named pin_dir which is never used after initialization.
Therefore, it should be removed for simplicity's sake.
Signed-off-by: Geordan Neukum
---
drivers/staging/kpc2000/kpc2000_spi.c | 2 --
1 file changed, 2 deletion
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
platform_groups
head: d770d421e93c93ceb55d6486e5ddeb65f21ca920
commit: 84cc896d582fc145f9c01b76f533707857d32d08 [26/27] video: fbdev:
wm8505fb: convert platform driver to use dev_groups
config: arm-allyesconfig (atta
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
platform_groups
head: d770d421e93c93ceb55d6486e5ddeb65f21ca920
commit: 84cc896d582fc145f9c01b76f533707857d32d08 [26/27] video: fbdev:
wm8505fb: convert platform driver to use dev_groups
config: arm-multi_v7_defconfig
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
platform_groups
head: b3b12a24cfb8d0b56c0c320317e5bb02d947358c
commit: 3f8fb7c8cb8571eeb00d9849710b9a8f2050ec7c [28/29] video: fbdev: sm501fb:
convert platform driver to use dev_groups
config: xtensa-allyesconfig (at
Hi Greg,
Thanks for the traces.
On Tue, Jun 4, 2019 at 9:14 AM Greg Ungerer wrote:
>
> Hi Sergio,
>
> On 4/6/19 3:06 pm, Sergio Paracuellos wrote:
> > On Tue, Jun 4, 2019 at 3:31 AM Greg Ungerer wrote:
> >> On 4/6/19 5:59 am, Sergio Paracuellos wrote:
> >>> On Mon, Jun 3, 2019 at 2:32 PM Greg
Remove function rtw_free_network_nolock, as all it does is call
_rtw_free_network_nolock, and rename _rtw_free_network_nolock to
rtw_free_network_nolock.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
dif
Remove initialisation of return variable as it is never used.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drivers
Remove function r8712_free_network_queue, as it does nothing but call
_free_network queue; rename _free_network_queue to
r8712_free_network_queue to enable continued functionality; change the
type of r8712_free_network_queue (formerly _free_network_queue) from
static to non-static to match the type
Hi Sergio,
On 4/6/19 3:06 pm, Sergio Paracuellos wrote:
On Tue, Jun 4, 2019 at 3:31 AM Greg Ungerer wrote:
On 4/6/19 5:59 am, Sergio Paracuellos wrote:
On Mon, Jun 3, 2019 at 2:32 PM Greg Ungerer wrote:
On 3/6/19 3:34 pm, Sergio Paracuellos wrote:
On Mon, Jun 3, 2019 at 3:26 AM Greg Ungere
18 matches
Mail list logo
