Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

Hi Sergio, On 30/5/19 10:44 am, Greg Ungerer wrote: On 29/5/19 6:08 pm, Sergio Paracuellos wrote: [snip] I have added gpio consumer stuff and reorder a bit the code to be more similar to 4.20. I attach the patch. I have not try it to compile it, because my normal environment is in another comp

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

Hi Brett, On 30/5/19 12:44 am, Brett Neumeier wrote: On Wed, May 29, 2019 at 3:09 AM Sergio Paracuellos mailto:sergio.paracuel...@gmail.com>> wrote: I have added gpio consumer stuff and reorder a bit the code to be more similar to 4.20. I attach the patch. I have not try it to comp

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

Hi Sergio, On 29/5/19 6:08 pm, Sergio Paracuellos wrote: [snip] I have added gpio consumer stuff and reorder a bit the code to be more similar to 4.20. I attach the patch. I have not try it to compile it, because my normal environment is in another computer and I am in the middle of moving from

[PATCH 00/22] Some documentation fixes

Fix several warnings and broken links. This series was generated against linux-next, but was rebased to be applied at docs-next. It should apply cleanly on either tree. There's a git tree with all of them applied on the top of docs/docs-next at: https://git.linuxtv.org/mchehab/experimental.git/l

[PATCH] staging: kpc2000: replace bogus variable name in core.c

"struct kp2000_regs temp" has nothing to do with temperatures, so replace it with the more proper name "regs". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/stagin

Re: [PATCH 3/4] staging: kpc2000: add missing spaces in core.c

On Wed, May 29, 2019 at 05:54:19PM +0200, Simon Sandström wrote: > On Mon, May 27, 2019 at 10:31:59AM +0300, Dan Carpenter wrote: > > On Fri, May 24, 2019 at 01:08:01PM +0200, Simon Sandström wrote: > > > [..] > > > - ret = copy_to_user((void*)ioctl_param, (void*)&temp, > > > sizeof(temp))

Re: [PATCH 3/4] staging: kpc2000: add missing spaces in core.c

On Mon, May 27, 2019 at 10:31:59AM +0300, Dan Carpenter wrote: > On Fri, May 24, 2019 at 01:08:01PM +0200, Simon Sandström wrote: > > [..] > > - ret = copy_to_user((void*)ioctl_param, (void*)&temp, > > sizeof(temp)); > > + ret = copy_to_user((void *)ioctl_param, (void *)&temp,

[PATCH] staging: vt6655: Change return type of function and remove variable

As the function CARDbRadioPowerOff always returns true, and this value does not appear to be used anywhere, the return variable can be entirely removed and the function converted to type void. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/vt6655/card.c | 56

[PATCH] media: staging: allegro: cleanup two warnings

Sparse complains about two issues when building with i386 and COMPILE_TEST: drivers/staging/media/allegro-dvt/allegro-core.c:1849:36: warning: constant 0xUL is so big it is unsigned long long drivers/staging/media/allegro-dvt/allegro-core.c:865:24: error: incompat

[PATCH] staging: rtl8712: Remove initialisations

Remove initialisations of multiple variables as these initial values are never used. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_mp.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8712/rtl

[PATCH] staging: rtl8712: Remove return variable of different type

The local return variable ret may be replaced directly by its value, especially since its type (uint) is not the same as the function's return type (int). Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 4 ++-- 1 file changed, 2 ins

[PATCH] staging: rtl8712: Remove unnecessary variable in rtl8712_recv.c

Remove unnecessary variable last_evm in rtl8712_recv.c and use its value directly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_recv.c | 5 ++--- drivers/staging/rtl8712/rtl871x_cmd.c | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) di

[PATCH] staging: rts5208: Remove negations

Previously return variable fake_para was being negated before return. For simplification, fake_para can be changed to valid_para, which is returned without negation (corresponding values swapped accordingly). Further, the function names check_sd_current_prior and check_sd_speed_prior can be changed

[PATCH] staging: kpc2000: Change to use DIV_ROUND_UP

Use macro DIV_ROUND_UP instead of an equivalent sequence of operations. Signed-off-by: Nishka Dasgupta --- drivers/staging/kpc2000/kpc_dma/fileops.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc2000/kpc_dm

[PATCH] staging: octeon-usb: Remove return variable

Remove return variable result and return the value directly. Issue found using Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/octeon-usb/octeon-hcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/o

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

Hi Greg, On Wed, May 29, 2019 at 9:11 AM Greg Ungerer wrote: > > Hi Sergio, > > On 27/5/19 6:02 pm, Sergio Paracuellos wrote: > > On Mon, May 27, 2019 at 9:29 AM Greg Ungerer wrote: > >> On 27/5/19 4:35 pm, Sergio Paracuellos wrote: > >>> On Mon, May 27, 2019 at 6:37 AM Greg Ungerer wrote: > >>

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

Hi Sergio, On 27/5/19 6:02 pm, Sergio Paracuellos wrote: On Mon, May 27, 2019 at 9:29 AM Greg Ungerer wrote: On 27/5/19 4:35 pm, Sergio Paracuellos wrote: On Mon, May 27, 2019 at 6:37 AM Greg Ungerer wrote: On 24/5/19 3:35 pm, Sergio Paracuellos wrote: On Fri, May 24, 2019 at 2:35 AM Greg